HADOOP-15886. Fix findbugs warnings in RegistryDNS.java.
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/f747f5b0 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/f747f5b0 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/f747f5b0 Branch: refs/heads/HDDS-4 Commit: f747f5b06cb0da59c7c20b9f0e46d3eec9622eed Parents: 277a3d8 Author: Akira Ajisaka <aajis...@apache.org> Authored: Tue Oct 30 11:43:36 2018 +0900 Committer: Akira Ajisaka <aajis...@apache.org> Committed: Wed Oct 31 10:01:31 2018 +0900 ---------------------------------------------------------------------- .../dev-support/findbugs-exclude.xml | 33 ++++++++++++++++++++ hadoop-common-project/hadoop-registry/pom.xml | 10 ++++++ .../dev-support/findbugs-exclude.xml | 16 ---------- 3 files changed, 43 insertions(+), 16 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hadoop/blob/f747f5b0/hadoop-common-project/hadoop-registry/dev-support/findbugs-exclude.xml ---------------------------------------------------------------------- diff --git a/hadoop-common-project/hadoop-registry/dev-support/findbugs-exclude.xml b/hadoop-common-project/hadoop-registry/dev-support/findbugs-exclude.xml new file mode 100644 index 0000000..dc7b139 --- /dev/null +++ b/hadoop-common-project/hadoop-registry/dev-support/findbugs-exclude.xml @@ -0,0 +1,33 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<FindBugsFilter> + <Match> + <Class name="org.apache.hadoop.registry.server.dns.RegistryDNS" /> + <Method name="addNIOTCP" /> + <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" /> + </Match> + <Match> + <Class name="org.apache.hadoop.registry.server.dns.RegistryDNS" /> + <Method name="addNIOUDP" /> + <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" /> + </Match> + <Match> + <Class name="org.apache.hadoop.registry.server.dns.RegistryDNS" /> + <Method name="serveNIOTCP" /> + <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" /> + </Match> +</FindBugsFilter> http://git-wip-us.apache.org/repos/asf/hadoop/blob/f747f5b0/hadoop-common-project/hadoop-registry/pom.xml ---------------------------------------------------------------------- diff --git a/hadoop-common-project/hadoop-registry/pom.xml b/hadoop-common-project/hadoop-registry/pom.xml index ef9f3ef..7ca1c9e 100644 --- a/hadoop-common-project/hadoop-registry/pom.xml +++ b/hadoop-common-project/hadoop-registry/pom.xml @@ -163,6 +163,16 @@ </resources> <plugins> <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>findbugs-maven-plugin</artifactId> + <configuration> + <findbugsXmlOutput>true</findbugsXmlOutput> + <xmlOutput>true</xmlOutput> + <excludeFilterFile>${project.basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile> + <effort>Max</effort> + </configuration> + </plugin> + <plugin> <groupId>org.apache.rat</groupId> <artifactId>apache-rat-plugin</artifactId> <configuration> http://git-wip-us.apache.org/repos/asf/hadoop/blob/f747f5b0/hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml ---------------------------------------------------------------------- diff --git a/hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml b/hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml index 216c3bd..dd42129 100644 --- a/hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml +++ b/hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml @@ -639,22 +639,6 @@ <Bug pattern="MS_EXPOSE_REP" /> </Match> - <Match> - <Class name="org.apache.hadoop.registry.server.dns.RegistryDNS" /> - <Method name="addNIOTCP" /> - <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" /> - </Match> - <Match> - <Class name="org.apache.hadoop.registry.server.dns.RegistryDNS" /> - <Method name="addNIOUDP" /> - <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" /> - </Match> - <Match> - <Class name="org.apache.hadoop.registry.server.dns.RegistryDNS" /> - <Method name="serveNIOTCP" /> - <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" /> - </Match> - <!-- EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC --> <Match> <Class name="org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu.AssignedGpuDevice" /> --------------------------------------------------------------------- To unsubscribe, e-mail: common-commits-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-commits-h...@hadoop.apache.org
