[08/50] [abbrv] hadoop git commit: HADOOP-11379. Fix new findbugs warnings in hadoop-auth*. Contributed by Li Lu.

2014-12-15 Thread kasha 
HADOOP-11379. Fix new findbugs warnings in hadoop-auth*. Contributed by Li Lu.


Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/6df457a3
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/6df457a3
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/6df457a3

Branch: refs/heads/YARN-2139
Commit: 6df457a3d7661a890e84fc89567f29d0fe23c970
Parents: 5776a41
Author: Haohui Mai whe...@apache.org
Authored: Tue Dec 9 13:08:51 2014 -0800
Committer: Haohui Mai whe...@apache.org
Committed: Tue Dec 9 13:08:51 2014 -0800

--
 .../hadoop/security/authentication/examples/WhoClient.java  | 5 -
 .../authentication/util/RandomSignerSecretProvider.java | 4 +++-
 .../org/apache/hadoop/security/authentication/util/Signer.java  | 3 ++-
 .../authentication/util/StringSignerSecretProvider.java | 3 ++-
 .../security/authentication/util/ZKSignerSecretProvider.java| 3 ++-
 hadoop-common-project/hadoop-common/CHANGES.txt | 2 ++
 6 files changed, 15 insertions(+), 5 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/hadoop/blob/6df457a3/hadoop-common-project/hadoop-auth-examples/src/main/java/org/apache/hadoop/security/authentication/examples/WhoClient.java
--
diff --git 
a/hadoop-common-project/hadoop-auth-examples/src/main/java/org/apache/hadoop/security/authentication/examples/WhoClient.java
 
b/hadoop-common-project/hadoop-auth-examples/src/main/java/org/apache/hadoop/security/authentication/examples/WhoClient.java
index 2299ae1..f5cff2b 100644
--- 
a/hadoop-common-project/hadoop-auth-examples/src/main/java/org/apache/hadoop/security/authentication/examples/WhoClient.java
+++ 
b/hadoop-common-project/hadoop-auth-examples/src/main/java/org/apache/hadoop/security/authentication/examples/WhoClient.java
@@ -19,6 +19,7 @@ import java.io.BufferedReader;
 import java.io.InputStreamReader;
 import java.net.HttpURLConnection;
 import java.net.URL;
+import java.nio.charset.Charset;
 
 /**
  * Example that uses codeAuthenticatedURL/code.
@@ -39,7 +40,9 @@ public class WhoClient {
   System.out.println(Status code:  + conn.getResponseCode() +   + 
conn.getResponseMessage());
   System.out.println();
   if (conn.getResponseCode() == HttpURLConnection.HTTP_OK) {
-BufferedReader reader = new BufferedReader(new 
InputStreamReader(conn.getInputStream()));
+BufferedReader reader = new BufferedReader(
+new InputStreamReader(
+conn.getInputStream(), Charset.forName(UTF-8)));
 String line = reader.readLine();
 while (line != null) {
   System.out.println(line);

http://git-wip-us.apache.org/repos/asf/hadoop/blob/6df457a3/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/RandomSignerSecretProvider.java
--
diff --git 
a/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/RandomSignerSecretProvider.java
 
b/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/RandomSignerSecretProvider.java
index 29e5661..41059a7 100644
--- 
a/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/RandomSignerSecretProvider.java
+++ 
b/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/RandomSignerSecretProvider.java
@@ -14,6 +14,8 @@
 package org.apache.hadoop.security.authentication.util;
 
 import com.google.common.annotations.VisibleForTesting;
+
+import java.nio.charset.Charset;
 import java.util.Random;
 import org.apache.hadoop.classification.InterfaceAudience;
 import org.apache.hadoop.classification.InterfaceStability;
@@ -46,6 +48,6 @@ public class RandomSignerSecretProvider extends 
RolloverSignerSecretProvider {
 
   @Override
   protected byte[] generateNewSecret() {
-return Long.toString(rand.nextLong()).getBytes();
+return Long.toString(rand.nextLong()).getBytes(Charset.forName(UTF-8));
   }
 }

http://git-wip-us.apache.org/repos/asf/hadoop/blob/6df457a3/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/Signer.java
--
diff --git 
a/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/Signer.java
 
b/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/Signer.java
index f639503..aa63e40 100644
--- 
a/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/Signer.java
+++

hadoop git commit: HADOOP-11379. Fix new findbugs warnings in hadoop-auth*. Contributed by Li Lu.

2014-12-09 Thread wheat9 
Repository: hadoop
Updated Branches:
  refs/heads/branch-2 e8e86e3ec - b68d51e89


HADOOP-11379. Fix new findbugs warnings in hadoop-auth*. Contributed by Li Lu.


Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/b68d51e8
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/b68d51e8
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/b68d51e8

Branch: refs/heads/branch-2
Commit: b68d51e8981450ba61bb2ad6c2782fef738ac00a
Parents: e8e86e3
Author: Haohui Mai whe...@apache.org
Authored: Tue Dec 9 13:08:51 2014 -0800
Committer: Haohui Mai whe...@apache.org
Committed: Tue Dec 9 13:09:01 2014 -0800

--
 .../hadoop/security/authentication/examples/WhoClient.java  | 5 -
 .../authentication/util/RandomSignerSecretProvider.java | 4 +++-
 .../org/apache/hadoop/security/authentication/util/Signer.java  | 3 ++-
 .../authentication/util/StringSignerSecretProvider.java | 3 ++-
 .../security/authentication/util/ZKSignerSecretProvider.java| 3 ++-
 hadoop-common-project/hadoop-common/CHANGES.txt | 2 ++
 6 files changed, 15 insertions(+), 5 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/hadoop/blob/b68d51e8/hadoop-common-project/hadoop-auth-examples/src/main/java/org/apache/hadoop/security/authentication/examples/WhoClient.java
--
diff --git 
a/hadoop-common-project/hadoop-auth-examples/src/main/java/org/apache/hadoop/security/authentication/examples/WhoClient.java
 
b/hadoop-common-project/hadoop-auth-examples/src/main/java/org/apache/hadoop/security/authentication/examples/WhoClient.java
index 2299ae1..f5cff2b 100644
--- 
a/hadoop-common-project/hadoop-auth-examples/src/main/java/org/apache/hadoop/security/authentication/examples/WhoClient.java
+++ 
b/hadoop-common-project/hadoop-auth-examples/src/main/java/org/apache/hadoop/security/authentication/examples/WhoClient.java
@@ -19,6 +19,7 @@ import java.io.BufferedReader;
 import java.io.InputStreamReader;
 import java.net.HttpURLConnection;
 import java.net.URL;
+import java.nio.charset.Charset;
 
 /**
  * Example that uses codeAuthenticatedURL/code.
@@ -39,7 +40,9 @@ public class WhoClient {
   System.out.println(Status code:  + conn.getResponseCode() +   + 
conn.getResponseMessage());
   System.out.println();
   if (conn.getResponseCode() == HttpURLConnection.HTTP_OK) {
-BufferedReader reader = new BufferedReader(new 
InputStreamReader(conn.getInputStream()));
+BufferedReader reader = new BufferedReader(
+new InputStreamReader(
+conn.getInputStream(), Charset.forName(UTF-8)));
 String line = reader.readLine();
 while (line != null) {
   System.out.println(line);

http://git-wip-us.apache.org/repos/asf/hadoop/blob/b68d51e8/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/RandomSignerSecretProvider.java
--
diff --git 
a/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/RandomSignerSecretProvider.java
 
b/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/RandomSignerSecretProvider.java
index 29e5661..41059a7 100644
--- 
a/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/RandomSignerSecretProvider.java
+++ 
b/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/RandomSignerSecretProvider.java
@@ -14,6 +14,8 @@
 package org.apache.hadoop.security.authentication.util;
 
 import com.google.common.annotations.VisibleForTesting;
+
+import java.nio.charset.Charset;
 import java.util.Random;
 import org.apache.hadoop.classification.InterfaceAudience;
 import org.apache.hadoop.classification.InterfaceStability;
@@ -46,6 +48,6 @@ public class RandomSignerSecretProvider extends 
RolloverSignerSecretProvider {
 
   @Override
   protected byte[] generateNewSecret() {
-return Long.toString(rand.nextLong()).getBytes();
+return Long.toString(rand.nextLong()).getBytes(Charset.forName(UTF-8));
   }
 }

http://git-wip-us.apache.org/repos/asf/hadoop/blob/b68d51e8/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/Signer.java
--
diff --git 
a/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/Signer.java
 
b/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/Signer.java
index f639503..aa63e40 100644
---

hadoop git commit: HADOOP-11379. Fix new findbugs warnings in hadoop-auth*. Contributed by Li Lu.

2014-12-09 Thread wheat9 
Repository: hadoop
Updated Branches:
  refs/heads/trunk 5776a41da - 6df457a3d


HADOOP-11379. Fix new findbugs warnings in hadoop-auth*. Contributed by Li Lu.


Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/6df457a3
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/6df457a3
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/6df457a3

Branch: refs/heads/trunk
Commit: 6df457a3d7661a890e84fc89567f29d0fe23c970
Parents: 5776a41
Author: Haohui Mai whe...@apache.org
Authored: Tue Dec 9 13:08:51 2014 -0800
Committer: Haohui Mai whe...@apache.org
Committed: Tue Dec 9 13:08:51 2014 -0800

--
 .../hadoop/security/authentication/examples/WhoClient.java  | 5 -
 .../authentication/util/RandomSignerSecretProvider.java | 4 +++-
 .../org/apache/hadoop/security/authentication/util/Signer.java  | 3 ++-
 .../authentication/util/StringSignerSecretProvider.java | 3 ++-
 .../security/authentication/util/ZKSignerSecretProvider.java| 3 ++-
 hadoop-common-project/hadoop-common/CHANGES.txt | 2 ++
 6 files changed, 15 insertions(+), 5 deletions(-)
--


http://git-wip-us.apache.org/repos/asf/hadoop/blob/6df457a3/hadoop-common-project/hadoop-auth-examples/src/main/java/org/apache/hadoop/security/authentication/examples/WhoClient.java
--
diff --git 
a/hadoop-common-project/hadoop-auth-examples/src/main/java/org/apache/hadoop/security/authentication/examples/WhoClient.java
 
b/hadoop-common-project/hadoop-auth-examples/src/main/java/org/apache/hadoop/security/authentication/examples/WhoClient.java
index 2299ae1..f5cff2b 100644
--- 
a/hadoop-common-project/hadoop-auth-examples/src/main/java/org/apache/hadoop/security/authentication/examples/WhoClient.java
+++ 
b/hadoop-common-project/hadoop-auth-examples/src/main/java/org/apache/hadoop/security/authentication/examples/WhoClient.java
@@ -19,6 +19,7 @@ import java.io.BufferedReader;
 import java.io.InputStreamReader;
 import java.net.HttpURLConnection;
 import java.net.URL;
+import java.nio.charset.Charset;
 
 /**
  * Example that uses codeAuthenticatedURL/code.
@@ -39,7 +40,9 @@ public class WhoClient {
   System.out.println(Status code:  + conn.getResponseCode() +   + 
conn.getResponseMessage());
   System.out.println();
   if (conn.getResponseCode() == HttpURLConnection.HTTP_OK) {
-BufferedReader reader = new BufferedReader(new 
InputStreamReader(conn.getInputStream()));
+BufferedReader reader = new BufferedReader(
+new InputStreamReader(
+conn.getInputStream(), Charset.forName(UTF-8)));
 String line = reader.readLine();
 while (line != null) {
   System.out.println(line);

http://git-wip-us.apache.org/repos/asf/hadoop/blob/6df457a3/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/RandomSignerSecretProvider.java
--
diff --git 
a/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/RandomSignerSecretProvider.java
 
b/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/RandomSignerSecretProvider.java
index 29e5661..41059a7 100644
--- 
a/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/RandomSignerSecretProvider.java
+++ 
b/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/RandomSignerSecretProvider.java
@@ -14,6 +14,8 @@
 package org.apache.hadoop.security.authentication.util;
 
 import com.google.common.annotations.VisibleForTesting;
+
+import java.nio.charset.Charset;
 import java.util.Random;
 import org.apache.hadoop.classification.InterfaceAudience;
 import org.apache.hadoop.classification.InterfaceStability;
@@ -46,6 +48,6 @@ public class RandomSignerSecretProvider extends 
RolloverSignerSecretProvider {
 
   @Override
   protected byte[] generateNewSecret() {
-return Long.toString(rand.nextLong()).getBytes();
+return Long.toString(rand.nextLong()).getBytes(Charset.forName(UTF-8));
   }
 }

http://git-wip-us.apache.org/repos/asf/hadoop/blob/6df457a3/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/Signer.java
--
diff --git 
a/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/Signer.java
 
b/hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/security/authentication/util/Signer.java
index f639503..aa63e40 100644
---