[08/29] hadoop git commit: HDFS-10684. WebHDFS DataNode calls fail without parameter createparent. Contributed by John Zhuge.
HDFS-10684. WebHDFS DataNode calls fail without parameter createparent. Contributed by John Zhuge. Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/fbdbbd57 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/fbdbbd57 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/fbdbbd57 Branch: refs/heads/YARN-5085 Commit: fbdbbd57cdc3d8c778fca9266a7cadf298c8ff6c Parents: e24a923 Author: Andrew WangAuthored: Tue Dec 13 18:01:31 2016 -0800 Committer: Andrew Wang Committed: Tue Dec 13 18:01:31 2016 -0800 -- .../hdfs/web/resources/CreateParentParam.java | 2 +- .../hdfs/web/resources/OverwriteParam.java | 2 +- .../hdfs/web/TestWebHdfsFileSystemContract.java | 40 3 files changed, 42 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/hadoop/blob/fbdbbd57/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java -- diff --git a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java index eaa5e8d..029efa0 100644 --- a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java +++ b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java @@ -39,7 +39,7 @@ public class CreateParentParam extends BooleanParam { * @param str a string representation of the parameter value. */ public CreateParentParam(final String str) { -this(DOMAIN.parse(str)); +this(DOMAIN.parse(str == null ? DEFAULT : str)); } @Override http://git-wip-us.apache.org/repos/asf/hadoop/blob/fbdbbd57/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java -- diff --git a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java index 9610b93..d7f5fb0 100644 --- a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java +++ b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java @@ -39,7 +39,7 @@ public class OverwriteParam extends BooleanParam { * @param str a string representation of the parameter value. */ public OverwriteParam(final String str) { -this(DOMAIN.parse(str)); +super(DOMAIN, DOMAIN.parse(str == null ? DEFAULT : str)); } @Override http://git-wip-us.apache.org/repos/asf/hadoop/blob/fbdbbd57/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java -- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java index a68b1ac..4854471 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java @@ -25,6 +25,7 @@ import java.io.InputStream; import java.io.InputStreamReader; import java.net.HttpURLConnection; import java.net.URL; +import java.text.MessageFormat; import java.util.Arrays; import java.util.Map; import java.util.Random; @@ -48,6 +49,7 @@ import org.apache.hadoop.hdfs.web.resources.NamenodeAddressParam; import org.apache.hadoop.io.IOUtils; import org.apache.hadoop.security.AccessControlException; import org.apache.hadoop.security.UserGroupInformation; +import org.apache.hadoop.test.GenericTestUtils; import org.junit.Assert; import org.junit.Test; @@ -531,6 +533,44 @@ public class TestWebHdfsFileSystemContract extends FileSystemContractBaseTest { } } + public void testDatanodeCreateMissingParameter() throws IOException { +final WebHdfsFileSystem webhdfs = (WebHdfsFileSystem) fs; +final Path testDir = new Path(MessageFormat.format("/test/{0}/{1}", +TestWebHdfsFileSystemContract.class, +GenericTestUtils.getMethodName())); +assertTrue(webhdfs.mkdirs(testDir)); + +for (String dnCreateParam : new String[]{ +CreateFlagParam.NAME, +CreateParentParam.NAME, +
[32/50] [abbrv] hadoop git commit: HDFS-10684. WebHDFS DataNode calls fail without parameter createparent. Contributed by John Zhuge.
HDFS-10684. WebHDFS DataNode calls fail without parameter createparent. Contributed by John Zhuge. Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/fbdbbd57 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/fbdbbd57 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/fbdbbd57 Branch: refs/heads/HDFS-10285 Commit: fbdbbd57cdc3d8c778fca9266a7cadf298c8ff6c Parents: e24a923 Author: Andrew WangAuthored: Tue Dec 13 18:01:31 2016 -0800 Committer: Andrew Wang Committed: Tue Dec 13 18:01:31 2016 -0800 -- .../hdfs/web/resources/CreateParentParam.java | 2 +- .../hdfs/web/resources/OverwriteParam.java | 2 +- .../hdfs/web/TestWebHdfsFileSystemContract.java | 40 3 files changed, 42 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/hadoop/blob/fbdbbd57/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java -- diff --git a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java index eaa5e8d..029efa0 100644 --- a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java +++ b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java @@ -39,7 +39,7 @@ public class CreateParentParam extends BooleanParam { * @param str a string representation of the parameter value. */ public CreateParentParam(final String str) { -this(DOMAIN.parse(str)); +this(DOMAIN.parse(str == null ? DEFAULT : str)); } @Override http://git-wip-us.apache.org/repos/asf/hadoop/blob/fbdbbd57/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java -- diff --git a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java index 9610b93..d7f5fb0 100644 --- a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java +++ b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java @@ -39,7 +39,7 @@ public class OverwriteParam extends BooleanParam { * @param str a string representation of the parameter value. */ public OverwriteParam(final String str) { -this(DOMAIN.parse(str)); +super(DOMAIN, DOMAIN.parse(str == null ? DEFAULT : str)); } @Override http://git-wip-us.apache.org/repos/asf/hadoop/blob/fbdbbd57/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java -- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java index a68b1ac..4854471 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java @@ -25,6 +25,7 @@ import java.io.InputStream; import java.io.InputStreamReader; import java.net.HttpURLConnection; import java.net.URL; +import java.text.MessageFormat; import java.util.Arrays; import java.util.Map; import java.util.Random; @@ -48,6 +49,7 @@ import org.apache.hadoop.hdfs.web.resources.NamenodeAddressParam; import org.apache.hadoop.io.IOUtils; import org.apache.hadoop.security.AccessControlException; import org.apache.hadoop.security.UserGroupInformation; +import org.apache.hadoop.test.GenericTestUtils; import org.junit.Assert; import org.junit.Test; @@ -531,6 +533,44 @@ public class TestWebHdfsFileSystemContract extends FileSystemContractBaseTest { } } + public void testDatanodeCreateMissingParameter() throws IOException { +final WebHdfsFileSystem webhdfs = (WebHdfsFileSystem) fs; +final Path testDir = new Path(MessageFormat.format("/test/{0}/{1}", +TestWebHdfsFileSystemContract.class, +GenericTestUtils.getMethodName())); +assertTrue(webhdfs.mkdirs(testDir)); + +for (String dnCreateParam : new String[]{ +CreateFlagParam.NAME, +CreateParentParam.NAME, +
[3/9] hadoop git commit: HDFS-10684. WebHDFS DataNode calls fail without parameter createparent. Contributed by John Zhuge.
HDFS-10684. WebHDFS DataNode calls fail without parameter createparent. Contributed by John Zhuge. Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/fbdbbd57 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/fbdbbd57 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/fbdbbd57 Branch: refs/heads/YARN-5734 Commit: fbdbbd57cdc3d8c778fca9266a7cadf298c8ff6c Parents: e24a923 Author: Andrew WangAuthored: Tue Dec 13 18:01:31 2016 -0800 Committer: Andrew Wang Committed: Tue Dec 13 18:01:31 2016 -0800 -- .../hdfs/web/resources/CreateParentParam.java | 2 +- .../hdfs/web/resources/OverwriteParam.java | 2 +- .../hdfs/web/TestWebHdfsFileSystemContract.java | 40 3 files changed, 42 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/hadoop/blob/fbdbbd57/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java -- diff --git a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java index eaa5e8d..029efa0 100644 --- a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java +++ b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java @@ -39,7 +39,7 @@ public class CreateParentParam extends BooleanParam { * @param str a string representation of the parameter value. */ public CreateParentParam(final String str) { -this(DOMAIN.parse(str)); +this(DOMAIN.parse(str == null ? DEFAULT : str)); } @Override http://git-wip-us.apache.org/repos/asf/hadoop/blob/fbdbbd57/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java -- diff --git a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java index 9610b93..d7f5fb0 100644 --- a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java +++ b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java @@ -39,7 +39,7 @@ public class OverwriteParam extends BooleanParam { * @param str a string representation of the parameter value. */ public OverwriteParam(final String str) { -this(DOMAIN.parse(str)); +super(DOMAIN, DOMAIN.parse(str == null ? DEFAULT : str)); } @Override http://git-wip-us.apache.org/repos/asf/hadoop/blob/fbdbbd57/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java -- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java index a68b1ac..4854471 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java @@ -25,6 +25,7 @@ import java.io.InputStream; import java.io.InputStreamReader; import java.net.HttpURLConnection; import java.net.URL; +import java.text.MessageFormat; import java.util.Arrays; import java.util.Map; import java.util.Random; @@ -48,6 +49,7 @@ import org.apache.hadoop.hdfs.web.resources.NamenodeAddressParam; import org.apache.hadoop.io.IOUtils; import org.apache.hadoop.security.AccessControlException; import org.apache.hadoop.security.UserGroupInformation; +import org.apache.hadoop.test.GenericTestUtils; import org.junit.Assert; import org.junit.Test; @@ -531,6 +533,44 @@ public class TestWebHdfsFileSystemContract extends FileSystemContractBaseTest { } } + public void testDatanodeCreateMissingParameter() throws IOException { +final WebHdfsFileSystem webhdfs = (WebHdfsFileSystem) fs; +final Path testDir = new Path(MessageFormat.format("/test/{0}/{1}", +TestWebHdfsFileSystemContract.class, +GenericTestUtils.getMethodName())); +assertTrue(webhdfs.mkdirs(testDir)); + +for (String dnCreateParam : new String[]{ +CreateFlagParam.NAME, +CreateParentParam.NAME, +
hadoop git commit: HDFS-10684. WebHDFS DataNode calls fail without parameter createparent. Contributed by John Zhuge.
Repository: hadoop Updated Branches: refs/heads/branch-2 0af67aa20 -> 6b795c34d HDFS-10684. WebHDFS DataNode calls fail without parameter createparent. Contributed by John Zhuge. (cherry picked from commit fbdbbd57cdc3d8c778fca9266a7cadf298c8ff6c) Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/6b795c34 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/6b795c34 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/6b795c34 Branch: refs/heads/branch-2 Commit: 6b795c34d0c534a8d5214c64036ba73708d58fd0 Parents: 0af67aa Author: Andrew WangAuthored: Tue Dec 13 18:01:31 2016 -0800 Committer: Andrew Wang Committed: Tue Dec 13 18:01:35 2016 -0800 -- .../hdfs/web/resources/CreateParentParam.java | 2 +- .../hdfs/web/resources/OverwriteParam.java | 2 +- .../hdfs/web/TestWebHdfsFileSystemContract.java | 40 3 files changed, 42 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/hadoop/blob/6b795c34/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java -- diff --git a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java index eaa5e8d..029efa0 100644 --- a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java +++ b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java @@ -39,7 +39,7 @@ public class CreateParentParam extends BooleanParam { * @param str a string representation of the parameter value. */ public CreateParentParam(final String str) { -this(DOMAIN.parse(str)); +this(DOMAIN.parse(str == null ? DEFAULT : str)); } @Override http://git-wip-us.apache.org/repos/asf/hadoop/blob/6b795c34/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java -- diff --git a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java index 9610b93..d7f5fb0 100644 --- a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java +++ b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java @@ -39,7 +39,7 @@ public class OverwriteParam extends BooleanParam { * @param str a string representation of the parameter value. */ public OverwriteParam(final String str) { -this(DOMAIN.parse(str)); +super(DOMAIN, DOMAIN.parse(str == null ? DEFAULT : str)); } @Override http://git-wip-us.apache.org/repos/asf/hadoop/blob/6b795c34/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java -- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java index 45b363a..925edcf 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java @@ -25,6 +25,7 @@ import java.io.InputStream; import java.io.InputStreamReader; import java.net.HttpURLConnection; import java.net.URL; +import java.text.MessageFormat; import java.util.Arrays; import java.util.Map; import java.util.Random; @@ -49,6 +50,7 @@ import org.apache.hadoop.hdfs.web.resources.NamenodeAddressParam; import org.apache.hadoop.io.IOUtils; import org.apache.hadoop.security.AccessControlException; import org.apache.hadoop.security.UserGroupInformation; +import org.apache.hadoop.test.GenericTestUtils; import org.junit.Assert; import org.junit.Test; @@ -533,6 +535,44 @@ public class TestWebHdfsFileSystemContract extends FileSystemContractBaseTest { } } + public void testDatanodeCreateMissingParameter() throws IOException { +final WebHdfsFileSystem webhdfs = (WebHdfsFileSystem) fs; +final Path testDir = new Path(MessageFormat.format("/test/{0}/{1}", +TestWebHdfsFileSystemContract.class, +GenericTestUtils.getMethodName())); +
hadoop git commit: HDFS-10684. WebHDFS DataNode calls fail without parameter createparent. Contributed by John Zhuge.
Repository: hadoop Updated Branches: refs/heads/branch-2.8 120f3a0ff -> 158292fd7 HDFS-10684. WebHDFS DataNode calls fail without parameter createparent. Contributed by John Zhuge. (cherry picked from commit fbdbbd57cdc3d8c778fca9266a7cadf298c8ff6c) (cherry picked from commit 6b795c34d0c534a8d5214c64036ba73708d58fd0) Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/158292fd Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/158292fd Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/158292fd Branch: refs/heads/branch-2.8 Commit: 158292fd7e6ca1769f8598dd8b4153a9f3b043d9 Parents: 120f3a0 Author: Andrew WangAuthored: Tue Dec 13 18:01:31 2016 -0800 Committer: Andrew Wang Committed: Tue Dec 13 18:01:40 2016 -0800 -- .../hdfs/web/resources/CreateParentParam.java | 2 +- .../hdfs/web/resources/OverwriteParam.java | 2 +- .../hdfs/web/TestWebHdfsFileSystemContract.java | 40 3 files changed, 42 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/hadoop/blob/158292fd/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java -- diff --git a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java index eaa5e8d..029efa0 100644 --- a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java +++ b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java @@ -39,7 +39,7 @@ public class CreateParentParam extends BooleanParam { * @param str a string representation of the parameter value. */ public CreateParentParam(final String str) { -this(DOMAIN.parse(str)); +this(DOMAIN.parse(str == null ? DEFAULT : str)); } @Override http://git-wip-us.apache.org/repos/asf/hadoop/blob/158292fd/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java -- diff --git a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java index 9610b93..d7f5fb0 100644 --- a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java +++ b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java @@ -39,7 +39,7 @@ public class OverwriteParam extends BooleanParam { * @param str a string representation of the parameter value. */ public OverwriteParam(final String str) { -this(DOMAIN.parse(str)); +super(DOMAIN, DOMAIN.parse(str == null ? DEFAULT : str)); } @Override http://git-wip-us.apache.org/repos/asf/hadoop/blob/158292fd/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java -- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java index 45b363a..925edcf 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java @@ -25,6 +25,7 @@ import java.io.InputStream; import java.io.InputStreamReader; import java.net.HttpURLConnection; import java.net.URL; +import java.text.MessageFormat; import java.util.Arrays; import java.util.Map; import java.util.Random; @@ -49,6 +50,7 @@ import org.apache.hadoop.hdfs.web.resources.NamenodeAddressParam; import org.apache.hadoop.io.IOUtils; import org.apache.hadoop.security.AccessControlException; import org.apache.hadoop.security.UserGroupInformation; +import org.apache.hadoop.test.GenericTestUtils; import org.junit.Assert; import org.junit.Test; @@ -533,6 +535,44 @@ public class TestWebHdfsFileSystemContract extends FileSystemContractBaseTest { } } + public void testDatanodeCreateMissingParameter() throws IOException { +final WebHdfsFileSystem webhdfs = (WebHdfsFileSystem) fs; +final Path testDir = new Path(MessageFormat.format("/test/{0}/{1}", +
hadoop git commit: HDFS-10684. WebHDFS DataNode calls fail without parameter createparent. Contributed by John Zhuge.
Repository: hadoop Updated Branches: refs/heads/trunk e24a923db -> fbdbbd57c HDFS-10684. WebHDFS DataNode calls fail without parameter createparent. Contributed by John Zhuge. Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/fbdbbd57 Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/fbdbbd57 Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/fbdbbd57 Branch: refs/heads/trunk Commit: fbdbbd57cdc3d8c778fca9266a7cadf298c8ff6c Parents: e24a923 Author: Andrew WangAuthored: Tue Dec 13 18:01:31 2016 -0800 Committer: Andrew Wang Committed: Tue Dec 13 18:01:31 2016 -0800 -- .../hdfs/web/resources/CreateParentParam.java | 2 +- .../hdfs/web/resources/OverwriteParam.java | 2 +- .../hdfs/web/TestWebHdfsFileSystemContract.java | 40 3 files changed, 42 insertions(+), 2 deletions(-) -- http://git-wip-us.apache.org/repos/asf/hadoop/blob/fbdbbd57/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java -- diff --git a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java index eaa5e8d..029efa0 100644 --- a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java +++ b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/CreateParentParam.java @@ -39,7 +39,7 @@ public class CreateParentParam extends BooleanParam { * @param str a string representation of the parameter value. */ public CreateParentParam(final String str) { -this(DOMAIN.parse(str)); +this(DOMAIN.parse(str == null ? DEFAULT : str)); } @Override http://git-wip-us.apache.org/repos/asf/hadoop/blob/fbdbbd57/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java -- diff --git a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java index 9610b93..d7f5fb0 100644 --- a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java +++ b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/resources/OverwriteParam.java @@ -39,7 +39,7 @@ public class OverwriteParam extends BooleanParam { * @param str a string representation of the parameter value. */ public OverwriteParam(final String str) { -this(DOMAIN.parse(str)); +super(DOMAIN, DOMAIN.parse(str == null ? DEFAULT : str)); } @Override http://git-wip-us.apache.org/repos/asf/hadoop/blob/fbdbbd57/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java -- diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java index a68b1ac..4854471 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHdfsFileSystemContract.java @@ -25,6 +25,7 @@ import java.io.InputStream; import java.io.InputStreamReader; import java.net.HttpURLConnection; import java.net.URL; +import java.text.MessageFormat; import java.util.Arrays; import java.util.Map; import java.util.Random; @@ -48,6 +49,7 @@ import org.apache.hadoop.hdfs.web.resources.NamenodeAddressParam; import org.apache.hadoop.io.IOUtils; import org.apache.hadoop.security.AccessControlException; import org.apache.hadoop.security.UserGroupInformation; +import org.apache.hadoop.test.GenericTestUtils; import org.junit.Assert; import org.junit.Test; @@ -531,6 +533,44 @@ public class TestWebHdfsFileSystemContract extends FileSystemContractBaseTest { } } + public void testDatanodeCreateMissingParameter() throws IOException { +final WebHdfsFileSystem webhdfs = (WebHdfsFileSystem) fs; +final Path testDir = new Path(MessageFormat.format("/test/{0}/{1}", +TestWebHdfsFileSystemContract.class, +GenericTestUtils.getMethodName())); +assertTrue(webhdfs.mkdirs(testDir)); + +for (String dnCreateParam : new