[jira] [Created] (HADOOP-16662) Remove invalid judgment in NetworkTopology#add()
Lisheng Sun created HADOOP-16662:
Summary: Remove invalid judgment in NetworkTopology#add()
Key: HADOOP-16662
URL: https://issues.apache.org/jira/browse/HADOOP-16662
Project: Hadoop Common
Issue Type: Bug
Reporter: Lisheng Sun
Assignee: Lisheng Sun
The method of NetworkTopology#add() as follow:
{code:java}
/** Add a leaf node
* Update node counter rack counter if necessary
* @param node node to be added; can be null
* @exception IllegalArgumentException if add a node to a leave
or node to be added is not a leaf
*/
public void add(Node node) {
if (node==null) return;
int newDepth = NodeBase.locationToDepth(node.getNetworkLocation()) + 1;
netlock.writeLock().lock();
try {
if( node instanceof InnerNode ) {
throw new IllegalArgumentException(
"Not allow to add an inner node: "+NodeBase.getPath(node));
}
if ((depthOfAllLeaves != -1) && (depthOfAllLeaves != newDepth)) {
LOG.error("Error: can't add leaf node {} at depth {} to topology:{}\n",
NodeBase.getPath(node), newDepth, this);
throw new InvalidTopologyException("Failed to add " +
NodeBase.getPath(node) +
": You cannot have a rack and a non-rack node at the same " +
"level of the network topology.");
}
Node rack = getNodeForNetworkLocation(node);
if (rack != null && !(rack instanceof InnerNode)) {
throw new IllegalArgumentException("Unexpected data node "
+ node.toString()
+ " at an illegal network location");
}
if (clusterMap.add(node)) {
LOG.info("Adding a new node: "+NodeBase.getPath(node));
if (rack == null) {
incrementRacks();
}
if (!(node instanceof InnerNode)) {
if (depthOfAllLeaves == -1) {
depthOfAllLeaves = node.getLevel();
}
}
}
LOG.debug("NetworkTopology became:\n{}", this);
} finally {
netlock.writeLock().unlock();
}
}
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org
Apache Hadoop qbt Report: branch2+JDK7 on Linux/x86
For more details, see https://builds.apache.org/job/hadoop-qbt-branch2-java7-linux-x86/479/ No changes -1 overall The following subsystems voted -1: docker Powered by Apache Yetus 0.8.0 http://yetus.apache.org - To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-dev-h...@hadoop.apache.org
Apache Hadoop qbt Report: trunk+JDK8 on Linux/x86
For more details, see https://builds.apache.org/job/hadoop-qbt-trunk-java8-linux-x86/1294/ [Oct 18, 2019 9:19:49 AM] (snemeth) YARN-9841. Capacity scheduler: add support for combined %user + [Oct 18, 2019 3:25:02 PM] (weichiu) HADOOP-16152. Upgrade Eclipse Jetty version to 9.4.x. Contributed by [Oct 18, 2019 8:26:20 PM] (weichiu) HADOOP-16579. Upgrade to Curator 4.2.0 and ZooKeeper 3.5.5 (#1656). [Oct 18, 2019 11:10:32 PM] (eyang) YARN-9884. Make container-executor mount logic modular [Oct 19, 2019 12:30:11 AM] (eyang) YARN-9875. Improve fair scheduler configuration store on HDFS. -1 overall The following subsystems voted -1: docker Powered by Apache Yetus 0.8.0 http://yetus.apache.org - To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-dev-h...@hadoop.apache.org
[jira] [Created] (HADOOP-16661) Test and doc TLS 1.3 support after HADOOP-16152
Wei-Chiu Chuang created HADOOP-16661: Summary: Test and doc TLS 1.3 support after HADOOP-16152 Key: HADOOP-16661 URL: https://issues.apache.org/jira/browse/HADOOP-16661 Project: Hadoop Common Issue Type: Task Reporter: Wei-Chiu Chuang HADOOP-16152 is going to update Jetty from 9.3 to 9.4.20, which should allow us to support TLS 1.3 https://www.eclipse.org/lists/jetty-users/msg08569.html We should test and document the support of TLS 1.3. Assuming its support depends on JDK, then it is likely only supported in JDK11 and above. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-dev-h...@hadoop.apache.org
