Re: InterfaceStability and InterfaceAudience stability
Agreed. Any one interested in reviewing/committing
https://issues.apache.org/jira/browse/HADOOP-11476?
On Thu, Jan 15, 2015 at 11:27 AM, Chris Nauroth
wrote:
> Would it really be backwards-incompatible if we added new levels later?
> That seems counter-intuitive and contrary to this piece of documentation:
>
> http://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html#jls-13.5.7
>
> Quoting:
>
> Annotation types behave exactly like any other interface. Adding or
> removing an element from an annotation type is analogous to adding or
> removing a method. There are important considerations governing other
> changes to annotation types, but these have no effect on the linkage of
> binaries by the Java Virtual Machine. Rather, such changes affect the
> behavior of reflective APIs that manipulate annotations. The documentation
> of these APIs specifies their behavior when various changes are made to the
> underlying annotation types.
>
> Adding or removing annotations has no effect on the correct linkage of the
> binary representations of programs in the Java programming language.
>
> Certainly removing existing levels would be backwards-incompatible.
>
> Chris Nauroth
> Hortonworks
> http://hortonworks.com/
>
>
> On Thu, Jan 15, 2015 at 6:14 AM, Allen Wittenauer
> wrote:
>
> >
> > IIRC, it was marked as evolving because it wasn’t clear at the
> > time whether we would need to add more stability levels. (One of the key
> > inspirations for the stability levels—Sun’s ARC process—had more.)
> >
> > So I think it’s important to remember that if this gets changed
> to
> > stable, that effectively means it new levels can’t really get added...
> >
> > On Jan 13, 2015, at 2:34 PM, Robert Kanter wrote:
> >
> > > +1
> > >
> > > Though it is kinda funny that the InterfaceStability annotation was
> > marked
> > > as Evolving :)
> > > @InterfaceStability.Evolving
> > > public class InterfaceStability {...}
> > >
> > >
> > > On Tue, Jan 13, 2015 at 2:21 PM, Ted Yu wrote:
> > >
> > >> +1
> > >>
> > >> On Tue, Jan 13, 2015 at 1:47 PM, Abraham Elmahrek
> > >> wrote:
> > >>
> > >>> Hey guys,
> > >>>
> > >>> I've noticed the InterfaceStability (
> > >>>
> > >>>
> > >>
> >
> https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceStability.java
> > >>> )
> > >>> and InterfaceAudience (
> > >>>
> > >>>
> > >>
> >
> https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java
> > >>> )
> > >>> classes are marked as "Evolving". These really haven't changed much
> in
> > >> the
> > >>> last few years, so I was wondering if it is reasonable to mark them
> as
> > >>> stable?
> > >>>
> > >>> -Abe
> > >>>
> > >>
> >
> >
>
> --
> CONFIDENTIALITY NOTICE
> NOTICE: This message is intended for the use of the individual or entity to
> which it is addressed and may contain information that is confidential,
> privileged and exempt from disclosure under applicable law. If the reader
> of this message is not the intended recipient, you are hereby notified that
> any printing, copying, dissemination, distribution, disclosure or
> forwarding of this communication is strictly prohibited. If you have
> received this communication in error, please contact the sender immediately
> and delete it from your system. Thank You.
>
Re: InterfaceStability and InterfaceAudience stability
Patch attached. I'm not sure what is necessary for changing the stability
of class. Please review.
On Tue, Jan 13, 2015 at 5:09 PM, Abraham Elmahrek wrote:
> Thanks for your thoughts guys. I've created
> https://issues.apache.org/jira/browse/HADOOP-11476 to follow through on
> this.
>
> On Tue, Jan 13, 2015 at 3:55 PM, Karthik Kambatla
> wrote:
>
>> +1
>>
>> On Wed, Jan 14, 2015 at 4:04 AM, Robert Kanter
>> wrote:
>>
>> > +1
>> >
>> > Though it is kinda funny that the InterfaceStability annotation was
>> marked
>> > as Evolving :)
>> > @InterfaceStability.Evolving
>> > public class InterfaceStability {...}
>> >
>> >
>> > On Tue, Jan 13, 2015 at 2:21 PM, Ted Yu wrote:
>> >
>> > > +1
>> > >
>> > > On Tue, Jan 13, 2015 at 1:47 PM, Abraham Elmahrek
>> > > wrote:
>> > >
>> > > > Hey guys,
>> > > >
>> > > > I've noticed the InterfaceStability (
>> > > >
>> > > >
>> > >
>> >
>> https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceStability.java
>> > > > )
>> > > > and InterfaceAudience (
>> > > >
>> > > >
>> > >
>> >
>> https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java
>> > > > )
>> > > > classes are marked as "Evolving". These really haven't changed much
>> in
>> > > the
>> > > > last few years, so I was wondering if it is reasonable to mark them
>> as
>> > > > stable?
>> > > >
>> > > > -Abe
>> > > >
>> > >
>> >
>>
>>
>>
>> --
>> Karthik Kambatla
>> Software Engineer, Cloudera Inc.
>>
>> http://five.sentenc.es
>>
>
>
Re: InterfaceStability and InterfaceAudience stability
Thanks for your thoughts guys. I've created
https://issues.apache.org/jira/browse/HADOOP-11476 to follow through on
this.
On Tue, Jan 13, 2015 at 3:55 PM, Karthik Kambatla
wrote:
> +1
>
> On Wed, Jan 14, 2015 at 4:04 AM, Robert Kanter
> wrote:
>
> > +1
> >
> > Though it is kinda funny that the InterfaceStability annotation was
> marked
> > as Evolving :)
> > @InterfaceStability.Evolving
> > public class InterfaceStability {...}
> >
> >
> > On Tue, Jan 13, 2015 at 2:21 PM, Ted Yu wrote:
> >
> > > +1
> > >
> > > On Tue, Jan 13, 2015 at 1:47 PM, Abraham Elmahrek
> > > wrote:
> > >
> > > > Hey guys,
> > > >
> > > > I've noticed the InterfaceStability (
> > > >
> > > >
> > >
> >
> https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceStability.java
> > > > )
> > > > and InterfaceAudience (
> > > >
> > > >
> > >
> >
> https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java
> > > > )
> > > > classes are marked as "Evolving". These really haven't changed much
> in
> > > the
> > > > last few years, so I was wondering if it is reasonable to mark them
> as
> > > > stable?
> > > >
> > > > -Abe
> > > >
> > >
> >
>
>
>
> --
> Karthik Kambatla
> Software Engineer, Cloudera Inc.
>
> http://five.sentenc.es
>
[jira] [Created] (HADOOP-11476) Mark InterfaceStability and InterfaceAudience as stable
Abraham Elmahrek created HADOOP-11476: - Summary: Mark InterfaceStability and InterfaceAudience as stable Key: HADOOP-11476 URL: https://issues.apache.org/jira/browse/HADOOP-11476 Project: Hadoop Common Issue Type: Improvement Reporter: Abraham Elmahrek InterfaceStability (https://github.com/apache/hadoop/blob/branch-2.6.0/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceStability.java) and InterfaceAudience (https://github.com/apache/hadoop/blob/branch-2.6.0/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java) are marked as "Evolving", but should not change in reality. Let's mark them as "Stable" so other projects can use them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
InterfaceStability and InterfaceAudience stability
Hey guys, I've noticed the InterfaceStability ( https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceStability.java) and InterfaceAudience ( https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/InterfaceAudience.java) classes are marked as "Evolving". These really haven't changed much in the last few years, so I was wondering if it is reasonable to mark them as stable? -Abe
[jira] [Created] (HADOOP-10875) Sqoop2: Attach a debugger to miniclusters
Abraham Elmahrek created HADOOP-10875:
-
Summary: Sqoop2: Attach a debugger to miniclusters
Key: HADOOP-10875
URL: https://issues.apache.org/jira/browse/HADOOP-10875
Project: Hadoop Common
Issue Type: Bug
Reporter: Abraham Elmahrek
It would be nice to have a way to attach a debugger to the miniclusters:
http://cargo.codehaus.org/Starting+and+stopping+a+container.
For tomcat, I needed to add the following to TomcatSqoopMiniCluster:
{code}
configuration.setProperty(GeneralPropertySet.JVMARGS,
"\"-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005\"");
{code}
There should also be a way to attach a debugger to the Yarn container.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Resolved] (HADOOP-10875) Sqoop2: Attach a debugger to miniclusters
[
https://issues.apache.org/jira/browse/HADOOP-10875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abraham Elmahrek resolved HADOOP-10875.
---
Resolution: Won't Fix
Wrong project!
> Sqoop2: Attach a debugger to miniclusters
> -
>
> Key: HADOOP-10875
> URL: https://issues.apache.org/jira/browse/HADOOP-10875
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Abraham Elmahrek
>
> It would be nice to have a way to attach a debugger to the miniclusters:
> http://cargo.codehaus.org/Starting+and+stopping+a+container.
> For tomcat, I needed to add the following to TomcatSqoopMiniCluster:
> {code}
> configuration.setProperty(GeneralPropertySet.JVMARGS,
> "\"-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005\"");
> {code}
> There should also be a way to attach a debugger to the Yarn container.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (HADOOP-10056) MiniMRClientClusterFactory in Hadoop 1.x forces local mode
Abraham Elmahrek created HADOOP-10056:
-
Summary: MiniMRClientClusterFactory in Hadoop 1.x forces local mode
Key: HADOOP-10056
URL: https://issues.apache.org/jira/browse/HADOOP-10056
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 1.0.4
Reporter: Abraham Elmahrek
Noticed the following in the 1.x branches:
{code}
public class MiniMRClientClusterFactory {
public static MiniMRClientCluster create(Class caller, int noOfNMs,
Configuration conf) throws IOException {
FileSystem fs = FileSystem.getLocal(new Configuration());
MiniMRCluster miniMRCluster = new MiniMRCluster(noOfNMs, fs.getUri()
.toString(), 1);
return new MiniMRClusterAdapter(miniMRCluster);
}
}
{code}
The 2.x branches allow you to set what hadoop configuration to use (and which
DFS cluster to connect to). For instance, in the Sqoop project we are using the
MiniDFSCluster in conjunction with the MiniMRCluster.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
