Re: Is Hadoop's TooRunner thread-safe?

[Steve Loughran]

I'd rather move new code to JCommander; its way, way better at parsing, as it 
uses annotation + introspection for its binding

> On 18 May 2016, at 19:05, Chris Nauroth  wrote:
> 
> Hello,
> 
> Thank you for reporting this.  The root cause is that commons-cli
> OptionBuilder is not thread-safe.
> 
> https://commons.apache.org/proper/commons-cli/apidocs/org/apache/commons/cl
> i/OptionBuilder.html
> 
> 
> According to this issue, commons-cli doesn't plan to change that and
> instead chose to document the lack of thread-safety.
> 
> https://issues.apache.org/jira/browse/CLI-209
> 
> 
> I think we can solve this in Hadoop, probably with a one-line change to
> make GenericOptionsParser#buildGeneralOptions a synchronized method.
> 
> I'm not aware of any existing JIRA that tracks this.  Would you be
> interested in filing a new JIRA, and possibly contributing a patch?
> 
> --Chris Nauroth
> 
> 
> 
> 
> On 5/17/16, 7:10 PM, "hongbin ma"  wrote:
> 
>> Hi experts
>> 
>> I'm running into similar issues like
>> http://stackoverflow.com/questions/22462665/is-hadoops-toorunner-thread-sa
>> fe,
>> the author's observation seem to make sense to me. However when I checked
>> the hadoop github trunk I found the issue still not fixed.
>> 
>> Is there any JIRA tracking this issue? Or it is "Not a Problem"?
>> 
>> thanks
> 
> 
> -
> To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
> For additional commands, e-mail: common-dev-h...@hadoop.apache.org
> 
> 


-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

Re: Is Hadoop's TooRunner thread-safe?

[Chris Nauroth]

Hello,

Thank you for reporting this.  The root cause is that commons-cli
OptionBuilder is not thread-safe.

https://commons.apache.org/proper/commons-cli/apidocs/org/apache/commons/cl
i/OptionBuilder.html


According to this issue, commons-cli doesn't plan to change that and
instead chose to document the lack of thread-safety.

https://issues.apache.org/jira/browse/CLI-209


I think we can solve this in Hadoop, probably with a one-line change to
make GenericOptionsParser#buildGeneralOptions a synchronized method.

I'm not aware of any existing JIRA that tracks this.  Would you be
interested in filing a new JIRA, and possibly contributing a patch?

--Chris Nauroth




On 5/17/16, 7:10 PM, "hongbin ma"  wrote:

>Hi experts
>
>I'm running into similar issues like
>http://stackoverflow.com/questions/22462665/is-hadoops-toorunner-thread-sa
>fe,
>the author's observation seem to make sense to me. However when I checked
>the hadoop github trunk I found the issue still not fixed.
>
>Is there any JIRA tracking this issue? Or it is "Not a Problem"?
>
>thanks


-
To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-dev-h...@hadoop.apache.org

Is Hadoop's TooRunner thread-safe?

[hongbin ma]

Hi experts

I'm running into similar issues like
http://stackoverflow.com/questions/22462665/is-hadoops-toorunner-thread-safe,
the author's observation seem to make sense to me. However when I checked
the hadoop github trunk I found the issue still not fixed.

Is there any JIRA tracking this issue? Or it is "Not a Problem"?

thanks