[jira] [Commented] (HADOOP-13765) Return HomeDirectory if possible in (S)FTPFileSystem
[
https://issues.apache.org/jira/browse/HADOOP-13765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618116#comment-15618116
]
Hadoop QA commented on HADOOP-13765:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
49s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
51s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
6s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
33s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 8m
12s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 41m 6s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Issue | HADOOP-13765 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12835974/HADOOP-13765.002.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 349b70b725b3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / aa3cab1 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/10927/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/10927/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Return HomeDirectory if possible in (S)FTPFileSystem
>
>
> Key: HADOOP-13765
> URL: https://issues.apache.org/jira/browse/HADOOP-13765
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
>Reporter: Yuhao Bi
> Attachments: HADOOP-13765.001.patch, HADOOP-13765.002.patch
>
>
> In SFTPFileSystem#getHomeDirectory(), we disconnect the ChannelSftp
[jira] [Comment Edited] (HADOOP-13449) S3Guard: Implement DynamoDBMetadataStore.
[
https://issues.apache.org/jira/browse/HADOOP-13449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618096#comment-15618096
]
Steve Loughran edited comment on HADOOP-13449 at 10/29/16 1:06 PM:
---
I see this patch bumps up the AWS version. Could that change be self contained
in HADOOP-13050; that way the change is more visible & easier to cherry pick.
This also implies HADOOP-12705.
Also: that dynamo DB dependency MUST be at {{}} scope. We don't want
to force it on people.
was (Author: ste...@apache.org):
I see this patch bumps up the AWS version. Could that change be self contained
in HADOOP-13050; that way the change is more visible & easier to cherry pick.
This also implies HADOOP-12705.
> S3Guard: Implement DynamoDBMetadataStore.
> -
>
> Key: HADOOP-13449
> URL: https://issues.apache.org/jira/browse/HADOOP-13449
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
>Reporter: Chris Nauroth
>Assignee: Mingliang Liu
> Attachments: HADOOP-13449-HADOOP-13345.000.patch,
> HADOOP-13449-HADOOP-13345.001.patch
>
>
> Provide an implementation of the metadata store backed by DynamoDB.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13449) S3Guard: Implement DynamoDBMetadataStore.
[ https://issues.apache.org/jira/browse/HADOOP-13449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15618096#comment-15618096 ] Steve Loughran commented on HADOOP-13449: - I see this patch bumps up the AWS version. Could that change be self contained in HADOOP-13050; that way the change is more visible & easier to cherry pick. This also implies HADOOP-12705. > S3Guard: Implement DynamoDBMetadataStore. > - > > Key: HADOOP-13449 > URL: https://issues.apache.org/jira/browse/HADOOP-13449 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 >Reporter: Chris Nauroth >Assignee: Mingliang Liu > Attachments: HADOOP-13449-HADOOP-13345.000.patch, > HADOOP-13449-HADOOP-13345.001.patch > > > Provide an implementation of the metadata store backed by DynamoDB. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-13765) Return HomeDirectory if possible in (S)FTPFileSystem
[
https://issues.apache.org/jira/browse/HADOOP-13765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuhao Bi updated HADOOP-13765:
--
Status: Patch Available (was: Open)
> Return HomeDirectory if possible in (S)FTPFileSystem
>
>
> Key: HADOOP-13765
> URL: https://issues.apache.org/jira/browse/HADOOP-13765
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
>Reporter: Yuhao Bi
> Attachments: HADOOP-13765.001.patch, HADOOP-13765.002.patch
>
>
> In SFTPFileSystem#getHomeDirectory(), we disconnect the ChannelSftp in
> finally block.
> If we get the homeDir Path successfully but got an IOE in the finally block
> we will return the null result.
> Maybe we can simply ignore this IOE and just return the result we have got.
> Related codes are shown below.
> {code:title=SFTPFileSystem.java|borderStyle=solid}
> public Path getHomeDirectory() {
> ChannelSftp channel = null;
> try {
> channel = connect();
> Path homeDir = new Path(channel.pwd());
> return homeDir;
> } catch (Exception ioe) {
> return null;
> } finally {
> try {
> disconnect(channel);
> } catch (IOException ioe) {
> //Maybe we can just ignore this IOE and do not return null here.
> return null;
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-13765) Return HomeDirectory if possible in (S)FTPFileSystem
[
https://issues.apache.org/jira/browse/HADOOP-13765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuhao Bi updated HADOOP-13765:
--
Attachment: HADOOP-13765.002.patch
> Return HomeDirectory if possible in (S)FTPFileSystem
>
>
> Key: HADOOP-13765
> URL: https://issues.apache.org/jira/browse/HADOOP-13765
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
>Reporter: Yuhao Bi
> Attachments: HADOOP-13765.001.patch, HADOOP-13765.002.patch
>
>
> In SFTPFileSystem#getHomeDirectory(), we disconnect the ChannelSftp in
> finally block.
> If we get the homeDir Path successfully but got an IOE in the finally block
> we will return the null result.
> Maybe we can simply ignore this IOE and just return the result we have got.
> Related codes are shown below.
> {code:title=SFTPFileSystem.java|borderStyle=solid}
> public Path getHomeDirectory() {
> ChannelSftp channel = null;
> try {
> channel = connect();
> Path homeDir = new Path(channel.pwd());
> return homeDir;
> } catch (Exception ioe) {
> return null;
> } finally {
> try {
> disconnect(channel);
> } catch (IOException ioe) {
> //Maybe we can just ignore this IOE and do not return null here.
> return null;
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-13765) Return HomeDirectory if possible in (S)FTPFileSystem
[
https://issues.apache.org/jira/browse/HADOOP-13765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuhao Bi updated HADOOP-13765:
--
Status: Open (was: Patch Available)
> Return HomeDirectory if possible in (S)FTPFileSystem
>
>
> Key: HADOOP-13765
> URL: https://issues.apache.org/jira/browse/HADOOP-13765
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
>Reporter: Yuhao Bi
> Attachments: HADOOP-13765.001.patch
>
>
> In SFTPFileSystem#getHomeDirectory(), we disconnect the ChannelSftp in
> finally block.
> If we get the homeDir Path successfully but got an IOE in the finally block
> we will return the null result.
> Maybe we can simply ignore this IOE and just return the result we have got.
> Related codes are shown below.
> {code:title=SFTPFileSystem.java|borderStyle=solid}
> public Path getHomeDirectory() {
> ChannelSftp channel = null;
> try {
> channel = connect();
> Path homeDir = new Path(channel.pwd());
> return homeDir;
> } catch (Exception ioe) {
> return null;
> } finally {
> try {
> disconnect(channel);
> } catch (IOException ioe) {
> //Maybe we can just ignore this IOE and do not return null here.
> return null;
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-13765) Return HomeDirectory if possible in (S)FTPFileSystem
[
https://issues.apache.org/jira/browse/HADOOP-13765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuhao Bi updated HADOOP-13765:
--
Summary: Return HomeDirectory if possible in (S)FTPFileSystem (was: Return
HomeDirectory if possible in SFTPFileSystem)
> Return HomeDirectory if possible in (S)FTPFileSystem
>
>
> Key: HADOOP-13765
> URL: https://issues.apache.org/jira/browse/HADOOP-13765
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
>Reporter: Yuhao Bi
> Attachments: HADOOP-13765.001.patch
>
>
> In SFTPFileSystem#getHomeDirectory(), we disconnect the ChannelSftp in
> finally block.
> If we get the homeDir Path successfully but got an IOE in the finally block
> we will return the null result.
> Maybe we can simply ignore this IOE and just return the result we have got.
> Related codes are shown below.
> {code:title=SFTPFileSystem.java|borderStyle=solid}
> public Path getHomeDirectory() {
> ChannelSftp channel = null;
> try {
> channel = connect();
> Path homeDir = new Path(channel.pwd());
> return homeDir;
> } catch (Exception ioe) {
> return null;
> } finally {
> try {
> disconnect(channel);
> } catch (IOException ioe) {
> //Maybe we can just ignore this IOE and do not return null here.
> return null;
> }
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13742) Expose "NumOpenConnectionsPerUser" as a metric
[
https://issues.apache.org/jira/browse/HADOOP-13742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15617613#comment-15617613
]
Brahma Reddy Battula commented on HADOOP-13742:
---
[~kihwal] thanks for taking a look into this issue. thinking like following,
let me know your opinion.
{code}
void incrUserConnections(String user) {
AtomicInteger count = userVsConnectionsMap.get(user);
if (count == null) {
count = new AtomicInteger(1);
count = userVsConnectionsMap.putIfAbsent(user, count);
if (count != null) {
count.getAndIncrement();
}
} else {
count.getAndIncrement();
}
}
void decrUserConnections(String user) {
AtomicInteger count = userVsConnectionsMap.get(user);
if (count == null) {
return;
} else {
if (count.decrementAndGet() == 0) {
userVsConnectionsMap.remove(user);
}
}
}
{code}
> Expose "NumOpenConnectionsPerUser" as a metric
> --
>
> Key: HADOOP-13742
> URL: https://issues.apache.org/jira/browse/HADOOP-13742
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Brahma Reddy Battula
>Assignee: Brahma Reddy Battula
> Attachments: HADOOP-13742-002.patch, HADOOP-13742.patch
>
>
> To track user level connections( How many connections for each user) in busy
> cluster where so many connections to server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
