[jira] [Commented] (HADOOP-15742) Log if ipc backoff is enabled in CallQueueManager
[
https://issues.apache.org/jira/browse/HADOOP-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618421#comment-16618421
]
Ryan Wu commented on HADOOP-15742:
--
:D
> Log if ipc backoff is enabled in CallQueueManager
> -
>
> Key: HADOOP-15742
> URL: https://issues.apache.org/jira/browse/HADOOP-15742
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.1.1
>Reporter: Yiqun Lin
>Assignee: Ryan Wu
>Priority: Minor
> Fix For: 3.2.0
>
> Attachments: HADOOP-15742.001.patch, HADOOP-15742.002.patch,
> HADOOP-15742.003.patch
>
>
> Currently we don't log the info of ipc backoff. It will look good to print
> this as well so that makes users know if we enable this.
> {code:java}
> public CallQueueManager(Class> backingClass,
> Class schedulerClass,
> boolean clientBackOffEnabled, int maxQueueSize, String namespace,
> Configuration conf) {
> int priorityLevels = parseNumLevels(namespace, conf);
> this.scheduler = createScheduler(schedulerClass, priorityLevels,
> namespace, conf);
> BlockingQueue bq = createCallQueueInstance(backingClass,
> priorityLevels, maxQueueSize, namespace, conf);
> this.clientBackOffEnabled = clientBackOffEnabled;
> this.putRef = new AtomicReference>(bq);
> this.takeRef = new AtomicReference>(bq);
> LOG.info("Using callQueue: " + backingClass + " queueCapacity: " +
> maxQueueSize + " scheduler: " + schedulerClass);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15742) Log if ipc backoff is enabled in CallQueueManager
[
https://issues.apache.org/jira/browse/HADOOP-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Wu updated HADOOP-15742:
-
Attachment: HADOOP-15742.003.patch
> Log if ipc backoff is enabled in CallQueueManager
> -
>
> Key: HADOOP-15742
> URL: https://issues.apache.org/jira/browse/HADOOP-15742
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.1.1
>Reporter: Yiqun Lin
>Assignee: Ryan Wu
>Priority: Minor
> Attachments: HADOOP-15742.001.patch, HADOOP-15742.002.patch,
> HADOOP-15742.003.patch
>
>
> Currently we don't log the info of ipc backoff. It will look good to print
> this as well so that makes users know if we enable this.
> {code:java}
> public CallQueueManager(Class> backingClass,
> Class schedulerClass,
> boolean clientBackOffEnabled, int maxQueueSize, String namespace,
> Configuration conf) {
> int priorityLevels = parseNumLevels(namespace, conf);
> this.scheduler = createScheduler(schedulerClass, priorityLevels,
> namespace, conf);
> BlockingQueue bq = createCallQueueInstance(backingClass,
> priorityLevels, maxQueueSize, namespace, conf);
> this.clientBackOffEnabled = clientBackOffEnabled;
> this.putRef = new AtomicReference>(bq);
> this.takeRef = new AtomicReference>(bq);
> LOG.info("Using callQueue: " + backingClass + " queueCapacity: " +
> maxQueueSize + " scheduler: " + schedulerClass);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15742) Log if ipc backoff is enabled in CallQueueManager
[
https://issues.apache.org/jira/browse/HADOOP-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613293#comment-16613293
]
Ryan Wu commented on HADOOP-15742:
--
Hi,[~linyiqun], I have used string interpolation way in HADOOP-15742.002.patch.
The following output logs were tested in my local.
{quote}
2018-09-13 18:05:32,077 INFO ipc.CallQueueManager
(CallQueueManager.java:(84)) - Using callQueue: class
org.apache.hadoop.ipc.FairCallQueue, queueCapacity: 8, scheduler: class
org.apache.hadoop.ipc.DecayRpcScheduler, ipcBackoff: false.
{quote}
> Log if ipc backoff is enabled in CallQueueManager
> -
>
> Key: HADOOP-15742
> URL: https://issues.apache.org/jira/browse/HADOOP-15742
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.1.1
>Reporter: Yiqun Lin
>Assignee: Ryan Wu
>Priority: Minor
> Attachments: HADOOP-15742.001.patch, HADOOP-15742.002.patch
>
>
> Currently we don't log the info of ipc backoff. It will look good to print
> this as well so that makes users know if we enable this.
> {code:java}
> public CallQueueManager(Class> backingClass,
> Class schedulerClass,
> boolean clientBackOffEnabled, int maxQueueSize, String namespace,
> Configuration conf) {
> int priorityLevels = parseNumLevels(namespace, conf);
> this.scheduler = createScheduler(schedulerClass, priorityLevels,
> namespace, conf);
> BlockingQueue bq = createCallQueueInstance(backingClass,
> priorityLevels, maxQueueSize, namespace, conf);
> this.clientBackOffEnabled = clientBackOffEnabled;
> this.putRef = new AtomicReference>(bq);
> this.takeRef = new AtomicReference>(bq);
> LOG.info("Using callQueue: " + backingClass + " queueCapacity: " +
> maxQueueSize + " scheduler: " + schedulerClass);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15742) Log if ipc backoff is enabled in CallQueueManager
[
https://issues.apache.org/jira/browse/HADOOP-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Wu updated HADOOP-15742:
-
Attachment: HADOOP-15742.002.patch
> Log if ipc backoff is enabled in CallQueueManager
> -
>
> Key: HADOOP-15742
> URL: https://issues.apache.org/jira/browse/HADOOP-15742
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.1.1
>Reporter: Yiqun Lin
>Assignee: Ryan Wu
>Priority: Minor
> Attachments: HADOOP-15742.001.patch, HADOOP-15742.002.patch
>
>
> Currently we don't log the info of ipc backoff. It will look good to print
> this as well so that makes users know if we enable this.
> {code:java}
> public CallQueueManager(Class> backingClass,
> Class schedulerClass,
> boolean clientBackOffEnabled, int maxQueueSize, String namespace,
> Configuration conf) {
> int priorityLevels = parseNumLevels(namespace, conf);
> this.scheduler = createScheduler(schedulerClass, priorityLevels,
> namespace, conf);
> BlockingQueue bq = createCallQueueInstance(backingClass,
> priorityLevels, maxQueueSize, namespace, conf);
> this.clientBackOffEnabled = clientBackOffEnabled;
> this.putRef = new AtomicReference>(bq);
> this.takeRef = new AtomicReference>(bq);
> LOG.info("Using callQueue: " + backingClass + " queueCapacity: " +
> maxQueueSize + " scheduler: " + schedulerClass);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15742) Log if ipc backoff is enabled in CallQueueManager
[
https://issues.apache.org/jira/browse/HADOOP-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613124#comment-16613124
]
Ryan Wu commented on HADOOP-15742:
--
This patch makes users know that they enabled this feature.
> Log if ipc backoff is enabled in CallQueueManager
> -
>
> Key: HADOOP-15742
> URL: https://issues.apache.org/jira/browse/HADOOP-15742
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.1.1
>Reporter: Yiqun Lin
>Assignee: Ryan Wu
>Priority: Minor
> Attachments: HADOOP-15742.001.patch
>
>
> Currently we don't log the info of ipc backoff. It will look good to print
> this as well so that makes users know if we enable this.
> {code:java}
> public CallQueueManager(Class> backingClass,
> Class schedulerClass,
> boolean clientBackOffEnabled, int maxQueueSize, String namespace,
> Configuration conf) {
> int priorityLevels = parseNumLevels(namespace, conf);
> this.scheduler = createScheduler(schedulerClass, priorityLevels,
> namespace, conf);
> BlockingQueue bq = createCallQueueInstance(backingClass,
> priorityLevels, maxQueueSize, namespace, conf);
> this.clientBackOffEnabled = clientBackOffEnabled;
> this.putRef = new AtomicReference>(bq);
> this.takeRef = new AtomicReference>(bq);
> LOG.info("Using callQueue: " + backingClass + " queueCapacity: " +
> maxQueueSize + " scheduler: " + schedulerClass);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15742) Log if ipc backoff is enabled in CallQueueManager
[
https://issues.apache.org/jira/browse/HADOOP-15742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Wu updated HADOOP-15742:
-
Attachment: HADOOP-15742.001.patch
> Log if ipc backoff is enabled in CallQueueManager
> -
>
> Key: HADOOP-15742
> URL: https://issues.apache.org/jira/browse/HADOOP-15742
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.1.1
>Reporter: Yiqun Lin
>Assignee: Ryan Wu
>Priority: Minor
> Attachments: HADOOP-15742.001.patch
>
>
> Currently we don't log the info of ipc backoff. It will look good to print
> this as well so that makes users know if we enable this.
> {code:java}
> public CallQueueManager(Class> backingClass,
> Class schedulerClass,
> boolean clientBackOffEnabled, int maxQueueSize, String namespace,
> Configuration conf) {
> int priorityLevels = parseNumLevels(namespace, conf);
> this.scheduler = createScheduler(schedulerClass, priorityLevels,
> namespace, conf);
> BlockingQueue bq = createCallQueueInstance(backingClass,
> priorityLevels, maxQueueSize, namespace, conf);
> this.clientBackOffEnabled = clientBackOffEnabled;
> this.putRef = new AtomicReference>(bq);
> this.takeRef = new AtomicReference>(bq);
> LOG.info("Using callQueue: " + backingClass + " queueCapacity: " +
> maxQueueSize + " scheduler: " + schedulerClass);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15611) Improve log in FairCallQueue
[
https://issues.apache.org/jira/browse/HADOOP-15611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16557992#comment-16557992
]
Ryan Wu commented on HADOOP-15611:
--
I can't agree more. HADOOP-15611.004.patch prints the detail decay info for
each user.
{quote}
2018-07-26 14:47:51,186 DEBUG ipc.DecayRpcScheduler
(DecayRpcScheduler.java:decayCurrentCounts(394)) - Start to decay current
counts.
2018-07-26 14:47:51,190 DEBUG ipc.DecayRpcScheduler
(DecayRpcScheduler.java:decayCurrentCounts(414)) - Decaying counts for the
user: A, its decayedCount: 2, rawCount: 4
2018-07-26 14:47:51,190 DEBUG ipc.DecayRpcScheduler
(DecayRpcScheduler.java:decayCurrentCounts(414)) - Decaying counts for the
user: B, its decayedCount: 4, rawCount: 8
2018-07-26 14:47:51,190 DEBUG ipc.DecayRpcScheduler
(DecayRpcScheduler.java:decayCurrentCounts(431)) - After decaying the stored
counts, totalDecayedCount: 6, totalRawCallCount: 12.
{quote}
> Improve log in FairCallQueue
>
>
> Key: HADOOP-15611
> URL: https://issues.apache.org/jira/browse/HADOOP-15611
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.1.0
>Reporter: Ryan Wu
>Priority: Minor
> Attachments: HADOOP-15611.001.patch, HADOOP-15611.002.patch,
> HADOOP-15611.003.patch, HADOOP-15611.004.patch
>
>
> In the usage of the FairCallQueue, we find there missing some Key log. Only a
> few logs are printed, it makes us hard to learn and debug this feature.
> At least, following places can print more logs.
> * DecayRpcScheduler#decayCurrentCounts
> * WeightedRoundRobinMultiplexer#moveToNextQueue
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15611) Improve log in FairCallQueue
[ https://issues.apache.org/jira/browse/HADOOP-15611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Wu updated HADOOP-15611: - Attachment: HADOOP-15611.004.patch > Improve log in FairCallQueue > > > Key: HADOOP-15611 > URL: https://issues.apache.org/jira/browse/HADOOP-15611 > Project: Hadoop Common > Issue Type: Improvement >Affects Versions: 3.1.0 >Reporter: Ryan Wu >Priority: Minor > Attachments: HADOOP-15611.001.patch, HADOOP-15611.002.patch, > HADOOP-15611.003.patch, HADOOP-15611.004.patch > > > In the usage of the FairCallQueue, we find there missing some Key log. Only a > few logs are printed, it makes us hard to learn and debug this feature. > At least, following places can print more logs. > * DecayRpcScheduler#decayCurrentCounts > * WeightedRoundRobinMultiplexer#moveToNextQueue -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15611) Improve log in FairCallQueue
[ https://issues.apache.org/jira/browse/HADOOP-15611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Wu updated HADOOP-15611: - Attachment: (was: HADOOP-15611.004.patch) > Improve log in FairCallQueue > > > Key: HADOOP-15611 > URL: https://issues.apache.org/jira/browse/HADOOP-15611 > Project: Hadoop Common > Issue Type: Improvement >Affects Versions: 3.1.0 >Reporter: Ryan Wu >Priority: Minor > Attachments: HADOOP-15611.001.patch, HADOOP-15611.002.patch, > HADOOP-15611.003.patch > > > In the usage of the FairCallQueue, we find there missing some Key log. Only a > few logs are printed, it makes us hard to learn and debug this feature. > At least, following places can print more logs. > * DecayRpcScheduler#decayCurrentCounts > * WeightedRoundRobinMultiplexer#moveToNextQueue -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15611) Improve log in FairCallQueue
[ https://issues.apache.org/jira/browse/HADOOP-15611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Wu updated HADOOP-15611: - Attachment: HADOOP-15611.004.patch > Improve log in FairCallQueue > > > Key: HADOOP-15611 > URL: https://issues.apache.org/jira/browse/HADOOP-15611 > Project: Hadoop Common > Issue Type: Improvement >Affects Versions: 3.1.0 >Reporter: Ryan Wu >Priority: Minor > Attachments: HADOOP-15611.001.patch, HADOOP-15611.002.patch, > HADOOP-15611.003.patch, HADOOP-15611.004.patch > > > In the usage of the FairCallQueue, we find there missing some Key log. Only a > few logs are printed, it makes us hard to learn and debug this feature. > At least, following places can print more logs. > * DecayRpcScheduler#decayCurrentCounts > * WeightedRoundRobinMultiplexer#moveToNextQueue -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15611) Improve log in FairCallQueue
[
https://issues.apache.org/jira/browse/HADOOP-15611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553882#comment-16553882
]
Ryan Wu commented on HADOOP-15611:
--
Hi [~linyiqun], the following output logs were tested in my local.
{noformat}
2018-07-24 14:24:16,431 DEBUG ipc.DecayRpcScheduler
(DecayRpcScheduler.java:decayCurrentCounts(394)) - Start to decay current
counts.
2018-07-24 14:24:16,431 DEBUG ipc.DecayRpcScheduler
(DecayRpcScheduler.java:decayCurrentCounts(415)) - The decayed count for the
user B is zero and being cleaned.
2018-07-24 14:24:16,431 DEBUG ipc.DecayRpcScheduler
(DecayRpcScheduler.java:decayCurrentCounts(428)) - After decaying the stored
counts, totalDecayedCount: 0, totalRawCallCount: 8.
{noformat}
{noformat}
2018-07-24 14:39:35,214 INFO ipc.WeightedRoundRobinMultiplexer
(WeightedRoundRobinMultiplexer.java:(78)) - WeightedRoundRobinMultiplexer
is being used.
2018-07-24 14:39:35,214 DEBUG ipc.WeightedRoundRobinMultiplexer
(WeightedRoundRobinMultiplexer.java:moveToNextQueue(112)) - Moving to next
queue from queue index 0 to index 1, number of requests left for current queue:
2.
2018-07-24 14:39:35,215 DEBUG ipc.WeightedRoundRobinMultiplexer
(WeightedRoundRobinMultiplexer.java:moveToNextQueue(112)) - Moving to next
queue from queue index 1 to index 2, number of requests left for current queue:
1.
2018-07-24 14:39:35,215 DEBUG ipc.WeightedRoundRobinMultiplexer
(WeightedRoundRobinMultiplexer.java:moveToNextQueue(112)) - Moving to next
queue from queue index 2 to index 0, number of requests left for current queue:
4.
{noformat}
> Improve log in FairCallQueue
>
>
> Key: HADOOP-15611
> URL: https://issues.apache.org/jira/browse/HADOOP-15611
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.1.0
>Reporter: Ryan Wu
>Priority: Minor
> Attachments: HADOOP-15611.001.patch, HADOOP-15611.002.patch,
> HADOOP-15611.003.patch
>
>
> In the usage of the FairCallQueue, we find there missing some Key log. Only a
> few logs are printed, it makes us hard to learn and debug this feature.
> At least, following places can print more logs.
> * DecayRpcScheduler#decayCurrentCounts
> * WeightedRoundRobinMultiplexer#moveToNextQueue
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15611) Improve log in FairCallQueue
[ https://issues.apache.org/jira/browse/HADOOP-15611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Wu updated HADOOP-15611: - Attachment: HADOOP-15611.003.patch > Improve log in FairCallQueue > > > Key: HADOOP-15611 > URL: https://issues.apache.org/jira/browse/HADOOP-15611 > Project: Hadoop Common > Issue Type: Improvement >Affects Versions: 3.1.0 >Reporter: Ryan Wu >Priority: Minor > Attachments: HADOOP-15611.001.patch, HADOOP-15611.002.patch, > HADOOP-15611.003.patch > > > In the usage of the FairCallQueue, we find there missing some Key log. Only a > few logs are printed, it makes us hard to learn and debug this feature. > At least, following places can print more logs. > * DecayRpcScheduler#decayCurrentCounts > * WeightedRoundRobinMultiplexer#moveToNextQueue -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15611) Improve log in FairCallQueue
[ https://issues.apache.org/jira/browse/HADOOP-15611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Wu updated HADOOP-15611: - Attachment: (was: HADOOP-15611.003.patch) > Improve log in FairCallQueue > > > Key: HADOOP-15611 > URL: https://issues.apache.org/jira/browse/HADOOP-15611 > Project: Hadoop Common > Issue Type: Improvement >Affects Versions: 3.1.0 >Reporter: Ryan Wu >Priority: Minor > Attachments: HADOOP-15611.001.patch, HADOOP-15611.002.patch > > > In the usage of the FairCallQueue, we find there missing some Key log. Only a > few logs are printed, it makes us hard to learn and debug this feature. > At least, following places can print more logs. > * DecayRpcScheduler#decayCurrentCounts > * WeightedRoundRobinMultiplexer#moveToNextQueue -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15611) Improve log in FairCallQueue
[ https://issues.apache.org/jira/browse/HADOOP-15611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552503#comment-16552503 ] Ryan Wu commented on HADOOP-15611: -- The HADOOP-15611.003.patch fixed some code style bugs based on HADOOP-15611.002.patch > Improve log in FairCallQueue > > > Key: HADOOP-15611 > URL: https://issues.apache.org/jira/browse/HADOOP-15611 > Project: Hadoop Common > Issue Type: Improvement >Affects Versions: 3.1.0 >Reporter: Ryan Wu >Priority: Minor > Attachments: HADOOP-15611.001.patch, HADOOP-15611.002.patch, > HADOOP-15611.003.patch > > > In the usage of the FairCallQueue, we find there missing some Key log. Only a > few logs are printed, it makes us hard to learn and debug this feature. > At least, following places can print more logs. > * DecayRpcScheduler#decayCurrentCounts > * WeightedRoundRobinMultiplexer#moveToNextQueue -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15611) Improve log in FairCallQueue
[ https://issues.apache.org/jira/browse/HADOOP-15611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Wu updated HADOOP-15611: - Attachment: HADOOP-15611.003.patch > Improve log in FairCallQueue > > > Key: HADOOP-15611 > URL: https://issues.apache.org/jira/browse/HADOOP-15611 > Project: Hadoop Common > Issue Type: Improvement >Affects Versions: 3.1.0 >Reporter: Ryan Wu >Priority: Minor > Attachments: HADOOP-15611.001.patch, HADOOP-15611.002.patch, > HADOOP-15611.003.patch > > > In the usage of the FairCallQueue, we find there missing some Key log. Only a > few logs are printed, it makes us hard to learn and debug this feature. > At least, following places can print more logs. > * DecayRpcScheduler#decayCurrentCounts > * WeightedRoundRobinMultiplexer#moveToNextQueue -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15611) Improve log in FairCallQueue
[ https://issues.apache.org/jira/browse/HADOOP-15611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552497#comment-16552497 ] Ryan Wu commented on HADOOP-15611: -- Thanks [~linyiqun] for gicing me some advice.I have modified the patch to make it more standard. > Improve log in FairCallQueue > > > Key: HADOOP-15611 > URL: https://issues.apache.org/jira/browse/HADOOP-15611 > Project: Hadoop Common > Issue Type: Improvement >Affects Versions: 3.1.0 >Reporter: Ryan Wu >Priority: Minor > Attachments: HADOOP-15611.001.patch, HADOOP-15611.002.patch > > > In the usage of the FairCallQueue, we find there missing some Key log. Only a > few logs are printed, it makes us hard to learn and debug this feature. > At least, following places can print more logs. > * DecayRpcScheduler#decayCurrentCounts > * WeightedRoundRobinMultiplexer#moveToNextQueue -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15611) Improve log in FairCallQueue
[ https://issues.apache.org/jira/browse/HADOOP-15611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Wu updated HADOOP-15611: - Attachment: HADOOP-15611.002.patch > Improve log in FairCallQueue > > > Key: HADOOP-15611 > URL: https://issues.apache.org/jira/browse/HADOOP-15611 > Project: Hadoop Common > Issue Type: Improvement >Affects Versions: 3.1.0 >Reporter: Ryan Wu >Priority: Minor > Attachments: HADOOP-15611.001.patch, HADOOP-15611.002.patch > > > In the usage of the FairCallQueue, we find there missing some Key log. Only a > few logs are printed, it makes us hard to learn and debug this feature. > At least, following places can print more logs. > * DecayRpcScheduler#decayCurrentCounts > * WeightedRoundRobinMultiplexer#moveToNextQueue -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15611) Improve log in FairCallQueue
[ https://issues.apache.org/jira/browse/HADOOP-15611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Wu updated HADOOP-15611: - Attachment: (was: HADOOP-15611.002.patch) > Improve log in FairCallQueue > > > Key: HADOOP-15611 > URL: https://issues.apache.org/jira/browse/HADOOP-15611 > Project: Hadoop Common > Issue Type: Improvement >Affects Versions: 3.1.0 >Reporter: Ryan Wu >Priority: Minor > Attachments: HADOOP-15611.001.patch > > > In the usage of the FairCallQueue, we find there missing some Key log. Only a > few logs are printed, it makes us hard to learn and debug this feature. > At least, following places can print more logs. > * DecayRpcScheduler#decayCurrentCounts > * WeightedRoundRobinMultiplexer#moveToNextQueue -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15611) Improve log in FairCallQueue
[ https://issues.apache.org/jira/browse/HADOOP-15611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Wu updated HADOOP-15611: - Attachment: HADOOP-15611.002.patch > Improve log in FairCallQueue > > > Key: HADOOP-15611 > URL: https://issues.apache.org/jira/browse/HADOOP-15611 > Project: Hadoop Common > Issue Type: Improvement >Affects Versions: 3.1.0 >Reporter: Ryan Wu >Priority: Minor > Attachments: HADOOP-15611.001.patch, HADOOP-15611.002.patch > > > In the usage of the FairCallQueue, we find there missing some Key log. Only a > few logs are printed, it makes us hard to learn and debug this feature. > At least, following places can print more logs. > * DecayRpcScheduler#decayCurrentCounts > * WeightedRoundRobinMultiplexer#moveToNextQueue -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15611) Improve log in FairCallQueue
[ https://issues.apache.org/jira/browse/HADOOP-15611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Wu updated HADOOP-15611: - Attachment: HADOOP-15611.001.patch Status: Patch Available (was: Open) > Improve log in FairCallQueue > > > Key: HADOOP-15611 > URL: https://issues.apache.org/jira/browse/HADOOP-15611 > Project: Hadoop Common > Issue Type: Improvement >Affects Versions: 3.1.0 >Reporter: Ryan Wu >Priority: Minor > Attachments: HADOOP-15611.001.patch > > > In the usage of the FairCallQueue, we find there missing some Key log. Only a > few logs are printed, it makes us hard to learn and debug this feature. > At least, following places can print more logs. > * DecayRpcScheduler#decayCurrentCounts > * WeightedRoundRobinMultiplexer#moveToNextQueue -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Created] (HADOOP-15611) Improve log in FairCallQueue
Ryan Wu created HADOOP-15611: Summary: Improve log in FairCallQueue Key: HADOOP-15611 URL: https://issues.apache.org/jira/browse/HADOOP-15611 Project: Hadoop Common Issue Type: Improvement Affects Versions: 3.1.0 Reporter: Ryan Wu -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
