[jira] [Commented] (HADOOP-14533) Size of args cannot be less than zero in TraceAdmin#run as its linkedlist
[
https://issues.apache.org/jira/browse/HADOOP-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057818#comment-16057818
]
Weisen Han commented on HADOOP-14533:
-
thanks to Wei-Chiu Chuang and Chen Liang for your review. Thanks to Brahma
Reddy Battula for your review and commit.
> Size of args cannot be less than zero in TraceAdmin#run as its linkedlist
> -
>
> Key: HADOOP-14533
> URL: https://issues.apache.org/jira/browse/HADOOP-14533
> Project: Hadoop Common
> Issue Type: Bug
> Components: common, tracing
>Affects Versions: 2.6.0
>Reporter: Weisen Han
>Assignee: Weisen Han
>Priority: Trivial
> Fix For: 2.9.0, 3.0.0-alpha4, 2.8.2
>
> Attachments: HADOOP-14533-001.patch, HADOOP-14533-002.patch
>
>
> {code}
> @Override
> public int run(String argv[]) throws Exception {
> LinkedList args = new LinkedList();
> ……
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> ……
> }
> {code}
> From the code above, the {{args}} is a linklist obejct, so it cannot be less
> than zero.meaning that code below is wrong
> {code}
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14533) TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
[
https://issues.apache.org/jira/browse/HADOOP-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055090#comment-16055090
]
Weisen Han commented on HADOOP-14533:
-
Thanks for your review, [~vagarychen].
submit the patch as you suggested.
> TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
> -
>
> Key: HADOOP-14533
> URL: https://issues.apache.org/jira/browse/HADOOP-14533
> Project: Hadoop Common
> Issue Type: Bug
> Components: common, tracing
>Affects Versions: 3.0.0-alpha3
>Reporter: Weisen Han
>Assignee: Weisen Han
>Priority: Trivial
> Attachments: HADOOP-14533-001.patch, HADOOP-14533-002.patch
>
>
> {code}
> @Override
> public int run(String argv[]) throws Exception {
> LinkedList args = new LinkedList();
> ……
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> ……
> }
> {code}
> From the code above, the {{args}} is a linklist obejct, so it cannot be less
> than zero.meaning that code below is wrong
> {code}
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14533) TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
[
https://issues.apache.org/jira/browse/HADOOP-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weisen Han updated HADOOP-14533:
Attachment: HADOOP-14533-002.patch
> TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
> -
>
> Key: HADOOP-14533
> URL: https://issues.apache.org/jira/browse/HADOOP-14533
> Project: Hadoop Common
> Issue Type: Bug
> Components: common, tracing
>Affects Versions: 3.0.0-alpha3
>Reporter: Weisen Han
>Assignee: Weisen Han
>Priority: Trivial
> Attachments: HADOOP-14533-001.patch, HADOOP-14533-002.patch
>
>
> {code}
> @Override
> public int run(String argv[]) throws Exception {
> LinkedList args = new LinkedList();
> ……
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> ……
> }
> {code}
> From the code above, the {{args}} is a linklist obejct, so it cannot be less
> than zero.meaning that code below is wrong
> {code}
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14533) TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
[
https://issues.apache.org/jira/browse/HADOOP-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052740#comment-16052740
]
Weisen Han commented on HADOOP-14533:
-
None of the findbug warning and junit test failing is related with this patch.
> TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
> -
>
> Key: HADOOP-14533
> URL: https://issues.apache.org/jira/browse/HADOOP-14533
> Project: Hadoop Common
> Issue Type: Bug
> Components: common, tracing
>Affects Versions: 3.0.0-alpha3
>Reporter: Weisen Han
>Assignee: Weisen Han
>Priority: Trivial
> Attachments: HADOOP-14533-001.patch
>
>
> {code}
> @Override
> public int run(String argv[]) throws Exception {
> LinkedList args = new LinkedList();
> ……
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> ……
> }
> {code}
> From the code above, the {{args}} is a linklist obejct, so it cannot be less
> than zero.meaning that code below is wrong
> {code}
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14533) TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
[
https://issues.apache.org/jira/browse/HADOOP-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weisen Han updated HADOOP-14533:
Priority: Trivial (was: Major)
> TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
> -
>
> Key: HADOOP-14533
> URL: https://issues.apache.org/jira/browse/HADOOP-14533
> Project: Hadoop Common
> Issue Type: Bug
> Components: common, tracing
>Affects Versions: 3.0.0-alpha3
>Reporter: Weisen Han
>Assignee: Weisen Han
>Priority: Trivial
> Attachments: HADOOP-14533-001.patch
>
>
> {code}
> @Override
> public int run(String argv[]) throws Exception {
> LinkedList args = new LinkedList();
> ……
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> ……
> }
> {code}
> From the code above, the {{args}} is a linklist obejct, so it cannot be less
> than zero.meaning that code below is wrong
> {code}
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14533) TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
[
https://issues.apache.org/jira/browse/HADOOP-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052081#comment-16052081
]
Weisen Han commented on HADOOP-14533:
-
[~tonywei] submit the patch, could you give me a code review?
> TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
> -
>
> Key: HADOOP-14533
> URL: https://issues.apache.org/jira/browse/HADOOP-14533
> Project: Hadoop Common
> Issue Type: Bug
> Components: common, tracing
>Affects Versions: 3.0.0-alpha3
>Reporter: Weisen Han
>Assignee: Weisen Han
> Attachments: HADOOP-14533-001.patch
>
>
> {code}
> @Override
> public int run(String argv[]) throws Exception {
> LinkedList args = new LinkedList();
> ……
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> ……
> }
> {code}
> From the code above, the {{args}} is a linklist obejct, so it cannot be less
> than zero.meaning that code below is wrong
> {code}
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14533) TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
[
https://issues.apache.org/jira/browse/HADOOP-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weisen Han updated HADOOP-14533:
Attachment: HADOOP-14533-001.patch
> TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
> -
>
> Key: HADOOP-14533
> URL: https://issues.apache.org/jira/browse/HADOOP-14533
> Project: Hadoop Common
> Issue Type: Bug
> Components: common, tracing
>Affects Versions: 3.0.0-alpha3
>Reporter: Weisen Han
>Assignee: Weisen Han
> Attachments: HADOOP-14533-001.patch
>
>
> {code}
> @Override
> public int run(String argv[]) throws Exception {
> LinkedList args = new LinkedList();
> ……
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> ……
> }
> {code}
> From the code above, the {{args}} is a linklist obejct, so it cannot be less
> than zero.meaning that code below is wrong
> {code}
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14533) TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
[
https://issues.apache.org/jira/browse/HADOOP-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weisen Han updated HADOOP-14533:
Status: Patch Available (was: Open)
> TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
> -
>
> Key: HADOOP-14533
> URL: https://issues.apache.org/jira/browse/HADOOP-14533
> Project: Hadoop Common
> Issue Type: Bug
> Components: common, tracing
>Affects Versions: 3.0.0-alpha3
>Reporter: Weisen Han
>Assignee: Weisen Han
> Attachments: HADOOP-14533-001.patch
>
>
> {code}
> @Override
> public int run(String argv[]) throws Exception {
> LinkedList args = new LinkedList();
> ……
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> ……
> }
> {code}
> From the code above, the {{args}} is a linklist obejct, so it cannot be less
> than zero.meaning that code below is wrong
> {code}
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Assigned] (HADOOP-14533) TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
[
https://issues.apache.org/jira/browse/HADOOP-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weisen Han reassigned HADOOP-14533:
---
Assignee: Weisen Han
> TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
> -
>
> Key: HADOOP-14533
> URL: https://issues.apache.org/jira/browse/HADOOP-14533
> Project: Hadoop Common
> Issue Type: Bug
> Components: common, tracing
>Affects Versions: 3.0.0-alpha3
>Reporter: Weisen Han
>Assignee: Weisen Han
>
> {code}
> @Override
> public int run(String argv[]) throws Exception {
> LinkedList args = new LinkedList();
> ……
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> ……
> }
> {code}
> From the code above, the {{args}} is a linklist obejct, so it cannot be less
> than zero.meaning that code below is wrong
> {code}
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14533) TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
[
https://issues.apache.org/jira/browse/HADOOP-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weisen Han updated HADOOP-14533:
Description:
{code}
@Override
public int run(String argv[]) throws Exception {
LinkedList args = new LinkedList();
……
if (args.size() < 0) {
System.err.println("You must specify an operation.");
return 1;
}
……
}
{code}
>From the code above, the {{args}} is a linklist obejct, so it cannot be less
>than zero.meaning that code below is wrong
{code}
if (args.size() < 0) {
System.err.println("You must specify an operation.");
return 1;
}
{code}
was:
{code}
@Override
public int run(String argv[]) throws Exception {
LinkedList args = new LinkedList();
……
if (args.size() < 0) {
System.err.println("You must specify an operation.");
return 1;
}
……
}
{code}
>From the code above, the {{args}} is a linklist obejct, so it cannot be less
>than zero.meaning that code below is redundant
{code}
if (args.size() < 0) {
System.err.println("You must specify an operation.");
return 1;
}
{code}
> TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
> -
>
> Key: HADOOP-14533
> URL: https://issues.apache.org/jira/browse/HADOOP-14533
> Project: Hadoop Common
> Issue Type: Bug
> Components: common, tracing
>Affects Versions: 3.0.0-alpha3
>Reporter: Weisen Han
>
> {code}
> @Override
> public int run(String argv[]) throws Exception {
> LinkedList args = new LinkedList();
> ……
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> ……
> }
> {code}
> From the code above, the {{args}} is a linklist obejct, so it cannot be less
> than zero.meaning that code below is wrong
> {code}
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14533) TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
[
https://issues.apache.org/jira/browse/HADOOP-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052037#comment-16052037
]
Weisen Han commented on HADOOP-14533:
-
[~owen.omalley] can you assign this to me ?
> TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
> -
>
> Key: HADOOP-14533
> URL: https://issues.apache.org/jira/browse/HADOOP-14533
> Project: Hadoop Common
> Issue Type: Bug
> Components: common, tracing
>Affects Versions: 3.0.0-alpha3
>Reporter: Weisen Han
>
> {code}
> @Override
> public int run(String argv[]) throws Exception {
> LinkedList args = new LinkedList();
> ……
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> ……
> }
> {code}
> From the code above, the {{args}} is a linklist obejct, so it cannot be less
> than zero.meaning that code below is redundant
> {code}
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14533) TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
[
https://issues.apache.org/jira/browse/HADOOP-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weisen Han updated HADOOP-14533:
Description:
{code}
@Override
public int run(String argv[]) throws Exception {
LinkedList args = new LinkedList();
……
if (args.size() < 0) {
System.err.println("You must specify an operation.");
return 1;
}
……
}
{code}
>From the code above, the {{args}} is a linklist obejct, so it cannot be less
>than zero.meaning that code below is redundant
{code}
if (args.size() < 0) {
System.err.println("You must specify an operation.");
return 1;
}
{code}
was:
{code}
@Override
public int run(String argv[]) throws Exception {
LinkedList args = new LinkedList();
……
if (args.size() < 0) {
System.err.println("You must specify an operation.");
return 1;
}
……
}
{code}
>From the code above, the {{args}} is a linklist obejct, so it cannot be less
>than zero.meaning that code below is redundant
{code}
if (args.size() < 0) {
System.err.println("You must specify an operation.");
return 1;
}
{code}
> TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
> -
>
> Key: HADOOP-14533
> URL: https://issues.apache.org/jira/browse/HADOOP-14533
> Project: Hadoop Common
> Issue Type: Bug
> Components: common, tracing
>Affects Versions: 3.0.0-alpha3
>Reporter: Weisen Han
>
> {code}
> @Override
> public int run(String argv[]) throws Exception {
> LinkedList args = new LinkedList();
> ……
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> ……
> }
> {code}
> From the code above, the {{args}} is a linklist obejct, so it cannot be less
> than zero.meaning that code below is redundant
> {code}
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Created] (HADOOP-14533) TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
Weisen Han created HADOOP-14533:
---
Summary: TraceAdmin#run, the size of args cannot be less than
zero,which is a linklist
Key: HADOOP-14533
URL: https://issues.apache.org/jira/browse/HADOOP-14533
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 3.0.0-alpha3
Reporter: Weisen Han
{code}
@Override
public int run(String argv[]) throws Exception {
LinkedList args = new LinkedList();
……
if (args.size() < 0) {
System.err.println("You must specify an operation.");
return 1;
}
……
}
{code}
>From the code above, the {{args}} is a linklist obejct, so it cannot be less
>than zero.meaning that code below is redundant
{code}
if (args.size() < 0) {
System.err.println("You must specify an operation.");
return 1;
}
{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14533) TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
[
https://issues.apache.org/jira/browse/HADOOP-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weisen Han updated HADOOP-14533:
Component/s: common
> TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
> -
>
> Key: HADOOP-14533
> URL: https://issues.apache.org/jira/browse/HADOOP-14533
> Project: Hadoop Common
> Issue Type: Bug
> Components: common, tracing
>Affects Versions: 3.0.0-alpha3
>Reporter: Weisen Han
>
> {code}
> @Override
> public int run(String argv[]) throws Exception {
> LinkedList args = new LinkedList();
> ……
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> ……
> }
> {code}
> From the code above, the {{args}} is a linklist obejct, so it cannot be less
> than zero.meaning that code below is redundant
> {code}
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14533) TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
[
https://issues.apache.org/jira/browse/HADOOP-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weisen Han updated HADOOP-14533:
Component/s: tracing
> TraceAdmin#run, the size of args cannot be less than zero,which is a linklist
> -
>
> Key: HADOOP-14533
> URL: https://issues.apache.org/jira/browse/HADOOP-14533
> Project: Hadoop Common
> Issue Type: Bug
> Components: common, tracing
>Affects Versions: 3.0.0-alpha3
>Reporter: Weisen Han
>
> {code}
> @Override
> public int run(String argv[]) throws Exception {
> LinkedList args = new LinkedList();
> ……
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> ……
> }
> {code}
> From the code above, the {{args}} is a linklist obejct, so it cannot be less
> than zero.meaning that code below is redundant
> {code}
> if (args.size() < 0) {
> System.err.println("You must specify an operation.");
> return 1;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
