[jira] [Commented] (HADOOP-14508) TestDFSIO throws NPE when set -sequential argument.
[
https://issues.apache.org/jira/browse/HADOOP-14508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984216#comment-16984216
]
Wenxin He commented on HADOOP-14508:
This issue can be closed.
> TestDFSIO throws NPE when set -sequential argument.
> ---
>
> Key: HADOOP-14508
> URL: https://issues.apache.org/jira/browse/HADOOP-14508
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 3.0.0-alpha4
>Reporter: Wenxin He
>Assignee: Wenxin He
>Priority: Major
> Attachments: HADOOP-14508.002.patch
>
>
> Benchmark tool TestDFSIO throws NPE when set {{-sequential}} due to
> uninitialized {{ioer.stream}} in {{TestDFSIO#sequentialTest}}.
> More descriptions, stack traces see comments.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14508) TestDFSIO throws NPE when set -sequential argument.
[
https://issues.apache.org/jira/browse/HADOOP-14508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wenxin He updated HADOOP-14508:
---
Status: Open (was: Patch Available)
-seq seems trivial, so cancel patch.
> TestDFSIO throws NPE when set -sequential argument.
> ---
>
> Key: HADOOP-14508
> URL: https://issues.apache.org/jira/browse/HADOOP-14508
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 3.0.0-alpha4
>Reporter: Wenxin He
>Assignee: Wenxin He
>Priority: Major
> Attachments: HADOOP-14508.002.patch
>
>
> Benchmark tool TestDFSIO throws NPE when set {{-sequential}} due to
> uninitialized {{ioer.stream}} in {{TestDFSIO#sequentialTest}}.
> More descriptions, stack traces see comments.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14624) Add GenericTestUtils.DelayAnswer that accept slf4j logger API
[ https://issues.apache.org/jira/browse/HADOOP-14624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201805#comment-16201805 ] Wenxin He commented on HADOOP-14624: bq. I'm totally fine with pushing this to the next major release. Wenxin He? Me too. > Add GenericTestUtils.DelayAnswer that accept slf4j logger API > - > > Key: HADOOP-14624 > URL: https://issues.apache.org/jira/browse/HADOOP-14624 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14624.001.patch, HADOOP-14624.002.patch > > > Split from HADOOP-14539. > Now GenericTestUtils.DelayAnswer only accepts commons-logging logger API. Now > we are migrating the APIs to slf4j, slf4j logger API should be accepted as > well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Resolved] (HADOOP-14177) hadoop-build fails to handle non-english UTF-8 characters
[ https://issues.apache.org/jira/browse/HADOOP-14177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He resolved HADOOP-14177. Resolution: Workaround > hadoop-build fails to handle non-english UTF-8 characters > -- > > Key: HADOOP-14177 > URL: https://issues.apache.org/jira/browse/HADOOP-14177 > Project: Hadoop Common > Issue Type: Bug > Components: build >Reporter: Wenxin He >Priority: Minor > Attachments: HADOOP-14177.001.patch > > > as this [link | > http://askubuntu.com/questions/581458/how-to-configure-locales-to-unicode-in-a-docker-ubuntu-14-04-container] > shows, ubuntu:trusty which hadoop-build image build from does not specify > any encoding, eg. UTF-8. so not english characters will show incorrect and > may fail the build. > current: > hewenxin@24a74cc3053b:~/hadoop$ ll zdh-hdfs-autotests/cases/ > total 284 > drwxr-xr-x 2 hewenxin users 4096 Mar 13 05:51 ./ > drwxr-xr-x 7 hewenxin users 4096 Mar 11 08:28 ../ > -rw-r--r-- 1 hewenxin users 3749 Mar 3 09:50 Y01.???.robot > -rw-r--r-- 1 hewenxin users 2060 Feb 27 05:20 Z00..robot > -rw-r--r-- 1 hewenxin users 1102 Feb 27 05:20 Z00..robot.define > -rw-r--r-- 1 hewenxin users 1308 Feb 27 08:46 Z01.??.robot > -rw-r--r-- 1 hewenxin users 1365 Feb 27 05:20 Z02.HttpFS.robot > -rw-r--r-- 1 hewenxin users 1353 Feb 27 05:20 > Z03..robot > -rw-r--r-- 1 hewenxin users 2928 Feb 27 08:46 Z04.???.robot > -rw-r--r-- 1 hewenxin users 1534 Mar 1 05:48 Z05..robot > -rw-r--r-- 1 hewenxin users 1260 Feb 27 05:20 Z06.??.robot > -rw-r--r-- 1 hewenxin users 1322 Feb 27 05:20 Z06.??.robot > -rw-r--r-- 1 hewenxin users 198 Feb 27 05:20 > Z07.balance?.robot > -rw-r--r-- 1 hewenxin users 915 Feb 27 05:20 > Z08.hdfs???.robot > -rw-r--r-- 1 hewenxin users 920 Mar 1 05:48 > Z09.?JMX.robot > -rw-r--r-- 1 hewenxin users 198 Feb 27 05:20 Z10.hdfs??.robot > -rw-r--r-- 1 hewenxin users 198 Feb 27 05:20 Z11.hdfs???.robot > -rw-r--r-- 1 hewenxin users 198 Feb 27 05:20 Z12.???.robot > -rw-r--r-- 1 hewenxin users 198 Feb 27 05:20 Z13.datanode.robot > -rw-r--r-- 1 hewenxin users 198 Feb 27 05:20 Z14.journal.robot > -rw-r--r-- 1 hewenxin users 1246 Mar 1 05:48 > Z15.hdfs???.robot > -rw-r--r-- 1 hewenxin users 169 Feb 27 05:20 > Z16.?.robot > -rw-r--r-- 1 hewenxin users 169 Feb 27 05:20 > Z17.JMX.robot > -rw-r--r-- 1 hewenxin users 169 Feb 27 05:20 > Z18.??krb.robot > -rw-r--r-- 1 hewenxin users 198 Feb 27 05:20 Z99.hdfs???.robot > after modified: > hewenxin@836ade384c62:~/hadoop$ ll zdh-hdfs-autotests/cases/ > total 284 > drwxr-xr-x 2 hewenxin users 4096 Mar 13 05:51 ./ > drwxr-xr-x 7 hewenxin users 4096 Mar 11 08:28 ../ > -rw-r--r-- 1 hewenxin users 3749 Mar 3 09:50 Y01.磁盘热插拔.robot > -rw-r--r-- 1 hewenxin users 2060 Feb 27 05:20 Z00.心跳上报.robot > -rw-r--r-- 1 hewenxin users 1102 Feb 27 05:20 Z00.心跳上报.robot.define > -rw-r--r-- 1 hewenxin users 1308 Feb 27 08:46 Z01.基本功能冒烟.robot > -rw-r--r-- 1 hewenxin users 1365 Feb 27 05:20 Z02.HttpFS功能测试.robot > -rw-r--r-- 1 hewenxin users 1353 Feb 27 05:20 Z03.日志级别动态调整.robot > -rw-r--r-- 1 hewenxin users 2928 Feb 27 08:46 Z04.多线程拷贝.robot > -rw-r--r-- 1 hewenxin users 1534 Mar 1 05:48 Z05.指标上报.robot > -rw-r--r-- 1 hewenxin users 1260 Feb 27 05:20 Z06.容灾功能测试.robot > -rw-r--r-- 1 hewenxin users 1322 Feb 27 05:20 Z06.快照功能测试.robot > -rw-r--r-- 1 hewenxin users 198 Feb 27 05:20 Z07.balance速率可调节优化.robot > -rw-r--r-- 1 hewenxin users 915 Feb 27 05:20 Z08.hdfs智能配置最大坏盘数.robot > -rw-r--r-- 1 hewenxin users 920 Mar 1 05:48 Z09.元数据JMX上报测试.robot > -rw-r--r-- 1 hewenxin users 198 Feb 27 05:20 Z10.hdfs的白名单功能.robot > -rw-r--r-- 1 hewenxin users 198 Feb 27 05:20 Z11.hdfs故障域功能.robot > -rw-r--r-- 1 hewenxin users 198 Feb 27 05:20 Z12.磁盘热插拔.robot > -rw-r--r-- 1 hewenxin users 198 Feb 27 05:20 Z13.datanode的缩扩容.robot > -rw-r--r-- 1 hewenxin users 198 Feb 27 05:20 Z14.journal的缩扩容.robot > -rw-r--r-- 1 hewenxin users 1246 Mar 1 05:48 Z15.hdfs进程内存使用百分比.robot > -rw-r--r-- 1 hewenxin users 169 Feb 27 05:20 Z16.审计日志支持自定义列表.robot > -rw-r--r-- 1 hewenxin users 169 Feb 27 05:20 Z17.JMX上报版本构建时间.robot > -rw-r--r-- 1 hewenxin users 169 Feb 27 05:20 Z18.支持krb下控制台浏览文件.robot > -rw-r--r-- 1 hewenxin users 198 Feb 27 05:20 Z99.hdfs客户端部署.robot -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For
[jira] [Created] (HADOOP-14818) Can not show help message of namenode/datanode/nodemanager when process started.
Wenxin He created HADOOP-14818:
--
Summary: Can not show help message of
namenode/datanode/nodemanager when process started.
Key: HADOOP-14818
URL: https://issues.apache.org/jira/browse/HADOOP-14818
Project: Hadoop Common
Issue Type: Improvement
Components: bin
Affects Versions: 3.0.0-beta1
Reporter: Wenxin He
Priority: Minor
We should always get the help message whenever the process is started or not.
But now,
when datanode starts, we get an error message:
{noformat}
hadoop# bin/hdfs datanode -h
datanode is running as process 1701. Stop it first.
{noformat}
when datanode stops, we get what we want:
{noformat}
hadoop# bin/hdfs --daemon stop datanode
hadoop# bin/hdfs datanode -h
Usage: hdfs datanode [-regular | -rollback | -rollingupgrade rollback ]
-regular : Normal DataNode startup (default).
...
{noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14706) Adding a helper method to determine whether a log is Log4j implement
[ https://issues.apache.org/jira/browse/HADOOP-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113984#comment-16113984 ] Wenxin He commented on HADOOP-14706: Thanks for your review and commit, [~ajisakaa]. The pull request is closed. > Adding a helper method to determine whether a log is Log4j implement > > > Key: HADOOP-14706 > URL: https://issues.apache.org/jira/browse/HADOOP-14706 > Project: Hadoop Common > Issue Type: Improvement > Components: util >Reporter: Wenxin He >Assignee: Wenxin He >Priority: Minor > Fix For: 2.9.0, 3.0.0-beta1 > > Attachments: HADOOP-14706.001.patch, HADOOP-14706-branch-2.001.patch, > HADOOP-14706-branch-2.002.patch > > > Base on the comments in YARN-6873, we'd like to add a helper method to > determine whether a log is Log4j implement. > Using this helper method, we don't have to care about it's > org.apache.commons.logging or org.slf4j.Logger used in our system. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14706) Adding a helper method to determine whether a log is Log4j implement
[ https://issues.apache.org/jira/browse/HADOOP-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14706: --- Status: Open (was: Patch Available) > Adding a helper method to determine whether a log is Log4j implement > > > Key: HADOOP-14706 > URL: https://issues.apache.org/jira/browse/HADOOP-14706 > Project: Hadoop Common > Issue Type: Improvement > Components: util >Reporter: Wenxin He >Assignee: Wenxin He >Priority: Minor > Attachments: HADOOP-14706.001.patch, HADOOP-14706-branch-2.001.patch, > HADOOP-14706-branch-2.002.patch > > > Base on the comments in YARN-6873, we'd like to add a helper method to > determine whether a log is Log4j implement. > Using this helper method, we don't have to care about it's > org.apache.commons.logging or org.slf4j.Logger used in our system. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14706) Adding a helper method to determine whether a log is Log4j implement
[ https://issues.apache.org/jira/browse/HADOOP-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14706: --- Attachment: HADOOP-14706-branch-2.002.patch > Adding a helper method to determine whether a log is Log4j implement > > > Key: HADOOP-14706 > URL: https://issues.apache.org/jira/browse/HADOOP-14706 > Project: Hadoop Common > Issue Type: Improvement > Components: util >Reporter: Wenxin He >Assignee: Wenxin He >Priority: Minor > Attachments: HADOOP-14706.001.patch, HADOOP-14706-branch-2.001.patch, > HADOOP-14706-branch-2.002.patch > > > Base on the comments in YARN-6873, we'd like to add a helper method to > determine whether a log is Log4j implement. > Using this helper method, we don't have to care about it's > org.apache.commons.logging or org.slf4j.Logger used in our system. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14706) Adding a helper method to determine whether a log is Log4j implement
[ https://issues.apache.org/jira/browse/HADOOP-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14706: --- Status: Patch Available (was: Open) > Adding a helper method to determine whether a log is Log4j implement > > > Key: HADOOP-14706 > URL: https://issues.apache.org/jira/browse/HADOOP-14706 > Project: Hadoop Common > Issue Type: Improvement > Components: util >Reporter: Wenxin He >Assignee: Wenxin He >Priority: Minor > Attachments: HADOOP-14706.001.patch, HADOOP-14706-branch-2.001.patch, > HADOOP-14706-branch-2.002.patch > > > Base on the comments in YARN-6873, we'd like to add a helper method to > determine whether a log is Log4j implement. > Using this helper method, we don't have to care about it's > org.apache.commons.logging or org.slf4j.Logger used in our system. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14706) Adding a helper method to determine whether a log is Log4j implement
[ https://issues.apache.org/jira/browse/HADOOP-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14706: --- Status: Patch Available (was: Open) > Adding a helper method to determine whether a log is Log4j implement > > > Key: HADOOP-14706 > URL: https://issues.apache.org/jira/browse/HADOOP-14706 > Project: Hadoop Common > Issue Type: Improvement > Components: util >Reporter: Wenxin He >Assignee: Wenxin He >Priority: Minor > Attachments: HADOOP-14706.001.patch, HADOOP-14706-branch-2.001.patch > > > Base on the comments in YARN-6873, we'd like to add a helper method to > determine whether a log is Log4j implement. > Using this helper method, we don't have to care about it's > org.apache.commons.logging or org.slf4j.Logger used in our system. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14706) Adding a helper method to determine whether a log is Log4j implement
[ https://issues.apache.org/jira/browse/HADOOP-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14706: --- Status: Open (was: Patch Available) > Adding a helper method to determine whether a log is Log4j implement > > > Key: HADOOP-14706 > URL: https://issues.apache.org/jira/browse/HADOOP-14706 > Project: Hadoop Common > Issue Type: Improvement > Components: util >Reporter: Wenxin He >Assignee: Wenxin He >Priority: Minor > Attachments: HADOOP-14706.001.patch, HADOOP-14706-branch-2.001.patch > > > Base on the comments in YARN-6873, we'd like to add a helper method to > determine whether a log is Log4j implement. > Using this helper method, we don't have to care about it's > org.apache.commons.logging or org.slf4j.Logger used in our system. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14706) Adding a helper method to determine whether a log is Log4j implement
[ https://issues.apache.org/jira/browse/HADOOP-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14706: --- Attachment: HADOOP-14706-branch-2.001.patch > Adding a helper method to determine whether a log is Log4j implement > > > Key: HADOOP-14706 > URL: https://issues.apache.org/jira/browse/HADOOP-14706 > Project: Hadoop Common > Issue Type: Improvement > Components: util >Reporter: Wenxin He >Assignee: Wenxin He >Priority: Minor > Attachments: HADOOP-14706.001.patch, HADOOP-14706-branch-2.001.patch > > > Base on the comments in YARN-6873, we'd like to add a helper method to > determine whether a log is Log4j implement. > Using this helper method, we don't have to care about it's > org.apache.commons.logging or org.slf4j.Logger used in our system. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14706) Adding a helper method to determine whether a log is Log4j implement
[ https://issues.apache.org/jira/browse/HADOOP-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110445#comment-16110445 ] Wenxin He commented on HADOOP-14706: It sounds reasonable, [~ajisakaa]. I accept it. Thank you. Now the patch is ready for review. A branch-2 patch will be attached later. > Adding a helper method to determine whether a log is Log4j implement > > > Key: HADOOP-14706 > URL: https://issues.apache.org/jira/browse/HADOOP-14706 > Project: Hadoop Common > Issue Type: Improvement > Components: util >Reporter: Wenxin He >Assignee: Wenxin He >Priority: Minor > Attachments: HADOOP-14706.001.patch > > > Base on the comments in YARN-6873, we'd like to add a helper method to > determine whether a log is Log4j implement. > Using this helper method, we don't have to care about it's > org.apache.commons.logging or org.slf4j.Logger used in our system. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14706) Adding a helper method to determine whether a log is Log4j implement
[
https://issues.apache.org/jira/browse/HADOOP-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wenxin He updated HADOOP-14706:
---
Status: Patch Available (was: Open)
I'm not sure placing this method in {{GenericsUtil}} is suitable or in
{{org.apache.hadoop.util.LogAdapter}} is better?
So I create a GenericsUtil version to see any feedback.
> Adding a helper method to determine whether a log is Log4j implement
>
>
> Key: HADOOP-14706
> URL: https://issues.apache.org/jira/browse/HADOOP-14706
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
>Reporter: Wenxin He
>Assignee: Wenxin He
>Priority: Minor
> Attachments: HADOOP-14706.001.patch
>
>
> Base on the comments in YARN-6873, we'd like to add a helper method to
> determine whether a log is Log4j implement.
> Using this helper method, we don't have to care about it's
> org.apache.commons.logging or org.slf4j.Logger used in our system.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14706) Adding a helper method to determine whether a log is Log4j implement
[ https://issues.apache.org/jira/browse/HADOOP-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14706: --- Attachment: HADOOP-14706.001.patch > Adding a helper method to determine whether a log is Log4j implement > > > Key: HADOOP-14706 > URL: https://issues.apache.org/jira/browse/HADOOP-14706 > Project: Hadoop Common > Issue Type: Improvement > Components: util >Reporter: Wenxin He >Assignee: Wenxin He >Priority: Minor > Attachments: HADOOP-14706.001.patch > > > Base on the comments in YARN-6873, we'd like to add a helper method to > determine whether a log is Log4j implement. > Using this helper method, we don't have to care about it's > org.apache.commons.logging or org.slf4j.Logger used in our system. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Created] (HADOOP-14706) Adding a helper method to determine whether a log is Log4j implement
Wenxin He created HADOOP-14706: -- Summary: Adding a helper method to determine whether a log is Log4j implement Key: HADOOP-14706 URL: https://issues.apache.org/jira/browse/HADOOP-14706 Project: Hadoop Common Issue Type: Improvement Components: util Reporter: Wenxin He Assignee: Wenxin He Priority: Minor Base on the comments in YARN-6873, we'd like to add a helper method to determine whether a log is Log4j implement. Using this helper method, we don't have to care about it's org.apache.commons.logging or org.slf4j.Logger used in our system. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097967#comment-16097967 ] Wenxin He commented on HADOOP-14539: Thanks for your review and commit, [~ajisakaa]. It's my pleasure.:) > Move commons logging APIs over to slf4j in hadoop-common > > > Key: HADOOP-14539 > URL: https://issues.apache.org/jira/browse/HADOOP-14539 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Wenxin He > Fix For: 2.9.0, 3.0.0-beta1 > > Attachments: diff-checkstyle-hadoop-common-project.txt, > HADOOP-14539.001.patch, HADOOP-14539.002.patch, HADOOP-14539.003.patch, > HADOOP-14539-branch-2.001.patch, HADOOP-14539-branch-2.002.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093028#comment-16093028 ] Wenxin He commented on HADOOP-14539: Hi [~ajisakaa], a patch for branch-2 is ready. Please review, thanks. > Move commons logging APIs over to slf4j in hadoop-common > > > Key: HADOOP-14539 > URL: https://issues.apache.org/jira/browse/HADOOP-14539 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Wenxin He > Fix For: 3.0.0-beta1 > > Attachments: diff-checkstyle-hadoop-common-project.txt, > HADOOP-14539.001.patch, HADOOP-14539.002.patch, HADOOP-14539.003.patch, > HADOOP-14539-branch-2.001.patch, HADOOP-14539-branch-2.002.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14539: --- Attachment: HADOOP-14539-branch-2.001.patch HADOOP-14539-branch-2.002.patch > Move commons logging APIs over to slf4j in hadoop-common > > > Key: HADOOP-14539 > URL: https://issues.apache.org/jira/browse/HADOOP-14539 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Wenxin He > Fix For: 3.0.0-beta1 > > Attachments: diff-checkstyle-hadoop-common-project.txt, > HADOOP-14539.001.patch, HADOOP-14539.002.patch, HADOOP-14539.003.patch, > HADOOP-14539-branch-2.001.patch, HADOOP-14539-branch-2.002.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14539: --- Status: Open (was: Patch Available) > Move commons logging APIs over to slf4j in hadoop-common > > > Key: HADOOP-14539 > URL: https://issues.apache.org/jira/browse/HADOOP-14539 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Wenxin He > Fix For: 3.0.0-beta1 > > Attachments: diff-checkstyle-hadoop-common-project.txt, > HADOOP-14539.001.patch, HADOOP-14539.002.patch, HADOOP-14539.003.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14539: --- Status: Patch Available (was: Open) > Move commons logging APIs over to slf4j in hadoop-common > > > Key: HADOOP-14539 > URL: https://issues.apache.org/jira/browse/HADOOP-14539 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Wenxin He > Fix For: 3.0.0-beta1 > > Attachments: diff-checkstyle-hadoop-common-project.txt, > HADOOP-14539.001.patch, HADOOP-14539.002.patch, HADOOP-14539.003.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14539: --- Status: Patch Available (was: Open) patch for branch-2 upload: Move commons logging APIs over to slf4j in hadoop-common in branch-2 and fix some checkstyle warnings. PS: checkstyle report attached to explain why some extra changes are made. [^diff-checkstyle-hadoop-common-project.txt] > Move commons logging APIs over to slf4j in hadoop-common > > > Key: HADOOP-14539 > URL: https://issues.apache.org/jira/browse/HADOOP-14539 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Wenxin He > Fix For: 3.0.0-beta1 > > Attachments: diff-checkstyle-hadoop-common-project.txt, > HADOOP-14539.001.patch, HADOOP-14539.002.patch, HADOOP-14539.003.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14539: --- Attachment: diff-checkstyle-hadoop-common-project.txt > Move commons logging APIs over to slf4j in hadoop-common > > > Key: HADOOP-14539 > URL: https://issues.apache.org/jira/browse/HADOOP-14539 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Wenxin He > Fix For: 3.0.0-beta1 > > Attachments: diff-checkstyle-hadoop-common-project.txt, > HADOOP-14539.001.patch, HADOOP-14539.002.patch, HADOOP-14539.003.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14539: --- Status: Open (was: Patch Available) > Move commons logging APIs over to slf4j in hadoop-common > > > Key: HADOOP-14539 > URL: https://issues.apache.org/jira/browse/HADOOP-14539 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Wenxin He > Fix For: 3.0.0-beta1 > > Attachments: HADOOP-14539.001.patch, HADOOP-14539.002.patch, > HADOOP-14539.003.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092490#comment-16092490 ] Wenxin He commented on HADOOP-14539: Thanks, [~ajisakaa]. bq. would you create a patch for branch-2? OK, I am testing the branch-2 patch and will upload later. > Move commons logging APIs over to slf4j in hadoop-common > > > Key: HADOOP-14539 > URL: https://issues.apache.org/jira/browse/HADOOP-14539 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Wenxin He > Fix For: 3.0.0-beta1 > > Attachments: HADOOP-14539.001.patch, HADOOP-14539.002.patch, > HADOOP-14539.003.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common
[
https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089271#comment-16089271
]
Wenxin He commented on HADOOP-14539:
Thanks for running all tests, [~ajisakaa].
I tried to rerun these failed tests, but did not find the same
NoSuchFieldError.
Also, I checked the code, found {{LOG}} in
LightWeightGSet.computeCapacity(LightWeightGSet.java:395) is OK. It is declared
in org.apache.hadoop.util.GSet.
Did I miss something?
The following is how I ran the tests:
# checkout the latest trunk
{noformat}
commit 02b141ac6059323ec43e472ca36dc570fdca386f
Author: Anu Engineer
Date: Sun Jul 16 10:59:34 2017 -0700
HDFS-11786. Add support to make copyFromLocal multi threaded. Contributed
by Mukul Kumar Singh.
{noformat}
# compile and run the specified tests
{noformat}
mvn clean install -DskipTests -Dmaven.javadoc.skip=true
mvn -f hadoop-hdfs-project/hadoop-hdfs/pom.xml test
-Dtest=TestLazyPersistReplicaRecovery,TestHAAppend,TestFSImage
-Dmaven.test.failure.ignore=true
{noformat}
Three tests failed which maybe caused by my environment:
{noformat}
---
T E S T S
---
---
T E S T S
---
Running
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 20.112 sec - in
org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
Running org.apache.hadoop.hdfs.server.namenode.TestFSImage
Tests run: 14, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 65.195 sec <<<
FAILURE! - in
org.apache.hadoop.hdfs.server.namenode.TestFSImage
testHasNonEcBlockUsingStripedIDForLoadUCFile(org.apache.hadoop.hdfs.server.namenode.TestFSImage)
Time elapsed: 3.34
sec <<< ERROR!
java.lang.IllegalStateException: failed to create a child event loop
at sun.nio.ch.EPollArrayWrapper.epollCreate(Native Method)
at sun.nio.ch.EPollArrayWrapper.(EPollArrayWrapper.java:130)
at sun.nio.ch.EPollSelectorImpl.(EPollSelectorImpl.java:69)
at
sun.nio.ch.EPollSelectorProvider.openSelector(EPollSelectorProvider.java:36)
at io.netty.channel.nio.NioEventLoop.openSelector(NioEventLoop.java:126)
at io.netty.channel.nio.NioEventLoop.(NioEventLoop.java:120)
at
io.netty.channel.nio.NioEventLoopGroup.newChild(NioEventLoopGroup.java:87)
at
io.netty.util.concurrent.MultithreadEventExecutorGroup.(MultithreadEventExecutorGroup.java:64)
at
io.netty.channel.MultithreadEventLoopGroup.(MultithreadEventLoopGroup.java:49)
at
io.netty.channel.nio.NioEventLoopGroup.(NioEventLoopGroup.java:61)
at
io.netty.channel.nio.NioEventLoopGroup.(NioEventLoopGroup.java:52)
at
io.netty.channel.nio.NioEventLoopGroup.(NioEventLoopGroup.java:44)
at
io.netty.channel.nio.NioEventLoopGroup.(NioEventLoopGroup.java:36)
at
org.apache.hadoop.hdfs.server.datanode.web.DatanodeHttpServer.(DatanodeHttpServer.java:131)
at
org.apache.hadoop.hdfs.server.datanode.DataNode.startInfoServer(DataNode.java:954)
at
org.apache.hadoop.hdfs.server.datanode.DataNode.startDataNode(DataNode.java:1402)
at
org.apache.hadoop.hdfs.server.datanode.DataNode.(DataNode.java:497)
at
org.apache.hadoop.hdfs.server.datanode.DataNode.makeInstance(DataNode.java:2752)
at
org.apache.hadoop.hdfs.server.datanode.DataNode.instantiateDataNode(DataNode.java:2655)
at
org.apache.hadoop.hdfs.MiniDFSCluster.startDataNodes(MiniDFSCluster.java:1621)
at
org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:868)
at org.apache.hadoop.hdfs.MiniDFSCluster.(MiniDFSCluster.java:491)
at
org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:450)
at
org.apache.hadoop.hdfs.server.namenode.TestFSImage.testHasNonEcBlockUsingStripedIDForLoadUCFile
(TestFSImage.java:625)
testSupportBlockGroup(org.apache.hadoop.hdfs.server.namenode.TestFSImage) Time
elapsed: 3.677 sec <<< ERROR!
java.lang.IllegalStateException: failed to create a child event loop
at sun.nio.ch.IOUtil.makePipe(Native Method)
at sun.nio.ch.EPollSelectorImpl.(EPollSelectorImpl.java:65)
at
sun.nio.ch.EPollSelectorProvider.openSelector(EPollSelectorProvider.java:36)
at io.netty.channel.nio.NioEventLoop.openSelector(NioEventLoop.java:126)
at io.netty.channel.nio.NioEventLoop.(NioEventLoop.java:120)
at
io.netty.channel.nio.NioEventLoopGroup.newChild(NioEventLoopGroup.java:87)
at
io.netty.util.concurrent.MultithreadEventExecutorGroup.(MultithreadEventExecutorGroup.java:64)
at
[jira] [Commented] (HADOOP-14624) Add GenericTestUtils.DelayAnswer that accept slf4j logger API
[ https://issues.apache.org/jira/browse/HADOOP-14624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085312#comment-16085312 ] Wenxin He commented on HADOOP-14624: Thanks for your review, [~vagarychen]! > Add GenericTestUtils.DelayAnswer that accept slf4j logger API > - > > Key: HADOOP-14624 > URL: https://issues.apache.org/jira/browse/HADOOP-14624 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14624.001.patch, HADOOP-14624.002.patch > > > Split from HADOOP-14539. > Now GenericTestUtils.DelayAnswer only accepts commons-logging logger API. Now > we are migrating the APIs to slf4j, slf4j logger API should be accepted as > well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081987#comment-16081987 ] Wenxin He commented on HADOOP-14539: bq. -1 javac 10m 7s root generated 9 new + 1306 unchanged - 52 fixed = 1315 total (was 1358) 9 new javac warnings are in hadoop-hdfs and caused by deprecated method setLogLevel(Logger,Level) bq. -0 checkstyle 1m 49s hadoop-common-project: The patch generated 7 new + 5116 unchanged - 59 fixed = 5123 total (was 5175) 7 new checkstyle issues leave unchanged intentionally. bq. -1 unit7m 57s hadoop-common in the patch failed. 3 test failures are unrelated. > Move commons logging APIs over to slf4j in hadoop-common > > > Key: HADOOP-14539 > URL: https://issues.apache.org/jira/browse/HADOOP-14539 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Wenxin He > Attachments: HADOOP-14539.001.patch, HADOOP-14539.002.patch, > HADOOP-14539.003.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14539: --- Attachment: HADOOP-14539.003.patch 003.patch: rebase and skip the commit that fixed in HADOOP-14638. > Move commons logging APIs over to slf4j in hadoop-common > > > Key: HADOOP-14539 > URL: https://issues.apache.org/jira/browse/HADOOP-14539 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Wenxin He > Attachments: HADOOP-14539.001.patch, HADOOP-14539.002.patch, > HADOOP-14539.003.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14539: --- Status: Patch Available (was: Open) > Move commons logging APIs over to slf4j in hadoop-common > > > Key: HADOOP-14539 > URL: https://issues.apache.org/jira/browse/HADOOP-14539 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Wenxin He > Attachments: HADOOP-14539.001.patch, HADOOP-14539.002.patch, > HADOOP-14539.003.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14539: --- Status: Open (was: Patch Available) > Move commons logging APIs over to slf4j in hadoop-common > > > Key: HADOOP-14539 > URL: https://issues.apache.org/jira/browse/HADOOP-14539 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Wenxin He > Attachments: HADOOP-14539.001.patch, HADOOP-14539.002.patch, > HADOOP-14539.003.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14539: --- Status: Patch Available (was: Open) > Move commons logging APIs over to slf4j in hadoop-common > > > Key: HADOOP-14539 > URL: https://issues.apache.org/jira/browse/HADOOP-14539 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Wenxin He > Attachments: HADOOP-14539.001.patch, HADOOP-14539.002.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14539: --- Status: Open (was: Patch Available) > Move commons logging APIs over to slf4j in hadoop-common > > > Key: HADOOP-14539 > URL: https://issues.apache.org/jira/browse/HADOOP-14539 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Wenxin He > Attachments: HADOOP-14539.001.patch, HADOOP-14539.002.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14539: --- Attachment: HADOOP-14539.002.patch 002.patch: # revert StreamPumper and related codes that are fixed in separate issue HADOOP-14638. # fix checkstyle issues: Indentation, LineLength. # fix checkstyle issues: StaticVariableName. ## add final modifier to LOG to make them real constant. ## leave LOG in ShellCommandFencer unchanged for it's reassigned in tests. # fix checkstyle issues: MemberName. ## add static modifier to LOG. ## leave LOG in AbstractGangliaSink, GangliaSink30 and GangliaSink31 unchanged for they're real instance member. # fix checkstyle issues: RedundantModifier, ConstantName. > Move commons logging APIs over to slf4j in hadoop-common > > > Key: HADOOP-14539 > URL: https://issues.apache.org/jira/browse/HADOOP-14539 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Wenxin He > Attachments: HADOOP-14539.001.patch, HADOOP-14539.002.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14638) Replace commons-logging APIs with slf4j in StreamPumper
[ https://issues.apache.org/jira/browse/HADOOP-14638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081703#comment-16081703 ] Wenxin He commented on HADOOP-14638: Thanks for your review and commit, [~ajisakaa]. > Replace commons-logging APIs with slf4j in StreamPumper > --- > > Key: HADOOP-14638 > URL: https://issues.apache.org/jira/browse/HADOOP-14638 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Fix For: 2.9.0, 3.0.0-beta1 > > Attachments: HADOOP-14638.001.patch, HADOOP-14638.002.patch > > > HADOOP-14539 is big, so we split a separate issue from HADOOP-14539. > Now StreamPumper only accepts commons-logging logger API, so we should change > StreamPumper api to accept slf4j and change the related code including some > tests in TestShellCommandFencer that failed with slf4j. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14638) Replace commons-logging APIs with slf4j in StreamPumper
[ https://issues.apache.org/jira/browse/HADOOP-14638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14638: --- Status: Patch Available (was: Open) > Replace commons-logging APIs with slf4j in StreamPumper > --- > > Key: HADOOP-14638 > URL: https://issues.apache.org/jira/browse/HADOOP-14638 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14638.001.patch, HADOOP-14638.002.patch > > > HADOOP-14539 is big, so we split a separate issue from HADOOP-14539. > Now StreamPumper only accepts commons-logging logger API, so we should change > StreamPumper api to accept slf4j and change the related code including some > tests in TestShellCommandFencer that failed with slf4j. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14638) Replace commons-logging APIs with slf4j in StreamPumper
[ https://issues.apache.org/jira/browse/HADOOP-14638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14638: --- Status: Open (was: Patch Available) > Replace commons-logging APIs with slf4j in StreamPumper > --- > > Key: HADOOP-14638 > URL: https://issues.apache.org/jira/browse/HADOOP-14638 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14638.001.patch, HADOOP-14638.002.patch > > > HADOOP-14539 is big, so we split a separate issue from HADOOP-14539. > Now StreamPumper only accepts commons-logging logger API, so we should change > StreamPumper api to accept slf4j and change the related code including some > tests in TestShellCommandFencer that failed with slf4j. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14638) Replace commons-logging APIs with slf4j in StreamPumper
[
https://issues.apache.org/jira/browse/HADOOP-14638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wenxin He updated HADOOP-14638:
---
Attachment: HADOOP-14638.002.patch
002.patch:
fix the following checkstyle issue:
{noformat}
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestShellCommandFencer.java:195:
private static final List delegateMethods =
Lists.asList("error",:39: Name 'delegateMethods' must match pattern
'^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]{noformat}
> Replace commons-logging APIs with slf4j in StreamPumper
> ---
>
> Key: HADOOP-14638
> URL: https://issues.apache.org/jira/browse/HADOOP-14638
> Project: Hadoop Common
> Issue Type: Sub-task
>Reporter: Wenxin He
>Assignee: Wenxin He
> Attachments: HADOOP-14638.001.patch, HADOOP-14638.002.patch
>
>
> HADOOP-14539 is big, so we split a separate issue from HADOOP-14539.
> Now StreamPumper only accepts commons-logging logger API, so we should change
> StreamPumper api to accept slf4j and change the related code including some
> tests in TestShellCommandFencer that failed with slf4j.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14638) Replace commons-logging APIs with slf4j in StreamPumper
[ https://issues.apache.org/jira/browse/HADOOP-14638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14638: --- Attachment: HADOOP-14638.001.patch > Replace commons-logging APIs with slf4j in StreamPumper > --- > > Key: HADOOP-14638 > URL: https://issues.apache.org/jira/browse/HADOOP-14638 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14638.001.patch > > > HADOOP-14539 is big, so we split a separate issue from HADOOP-14539. > Now StreamPumper only accepts commons-logging logger API, so we should change > StreamPumper api to accept slf4j and change the related code including some > tests in TestShellCommandFencer that failed with slf4j. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14539: --- Attachment: HADOOP-14539.001.patch > Move commons logging APIs over to slf4j in hadoop-common > > > Key: HADOOP-14539 > URL: https://issues.apache.org/jira/browse/HADOOP-14539 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Wenxin He > Attachments: HADOOP-14539.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079891#comment-16079891 ] Wenxin He commented on HADOOP-14539: bq. I commented one minor nit in the GitHub PR. Thanks, I've fixed it. bq. Let me see the result of the precommit job. I found a test failure caused by this patch and filed a separate issue HADOOP-14638 to fix it. Would you please to review this HADOOP-14638 first? > Move commons logging APIs over to slf4j in hadoop-common > > > Key: HADOOP-14539 > URL: https://issues.apache.org/jira/browse/HADOOP-14539 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Wenxin He > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14638) Replace commons-logging APIs with slf4j in StreamPumper
[ https://issues.apache.org/jira/browse/HADOOP-14638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14638: --- Status: Patch Available (was: Open) > Replace commons-logging APIs with slf4j in StreamPumper > --- > > Key: HADOOP-14638 > URL: https://issues.apache.org/jira/browse/HADOOP-14638 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > > HADOOP-14539 is big, so we split a separate issue from HADOOP-14539. > Now StreamPumper only accepts commons-logging logger API, so we should change > StreamPumper api to accept slf4j and change the related code including some > tests in TestShellCommandFencer that failed with slf4j. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Created] (HADOOP-14638) Replace commons-logging APIs with slf4j in StreamPumper
Wenxin He created HADOOP-14638: -- Summary: Replace commons-logging APIs with slf4j in StreamPumper Key: HADOOP-14638 URL: https://issues.apache.org/jira/browse/HADOOP-14638 Project: Hadoop Common Issue Type: Sub-task Reporter: Wenxin He Assignee: Wenxin He HADOOP-14539 is big, so we split a separate issue from HADOOP-14539. Now StreamPumper only accepts commons-logging logger API, so we should change StreamPumper api to accept slf4j and change the related code including some tests in TestShellCommandFencer that failed with slf4j. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Attachment: HADOOP-14587-branch-2.001.patch This patch [^HADOOP-24587-branch-2.001.patch] has a wrong JIRA issue number. Upload a right one. [^HADOOP-14587-branch-2.001.patch] > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Fix For: 2.9.0, 3.0.0-beta1 > > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch, HADOOP-14587.007.patch, HADOOP-14587.008.patch, > HADOOP-14587-branch-2.001.patch, HADOOP-24587-branch-2.001.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078871#comment-16078871 ] Wenxin He commented on HADOOP-14587: Thanks for your review, [~ajisakaa]. It's my pleasure. > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Fix For: 2.9.0, 3.0.0-beta1 > > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch, HADOOP-14587.007.patch, HADOOP-14587.008.patch, > HADOOP-24587-branch-2.001.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077883#comment-16077883 ] Wenxin He commented on HADOOP-14587: All javac warnings are caused by deprecated method setLogLevel(Log,Level) in GenericTestUtils. > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Fix For: 3.0.0-beta1 > > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch, HADOOP-14587.007.patch, HADOOP-14587.008.patch, > HADOOP-24587-branch-2.001.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common
[
https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077857#comment-16077857
]
Wenxin He commented on HADOOP-14539:
Since the change is big, it's divided into several commit steps:
*Step 1*: (521ac19f9226ea271c239b9b7345d64d82ab35d4)
simply replace all {{org.apache.commons.logging.Log}} to {{org.slf4j.Logger}}
where available.
*Step 2*: (a86f2b25202808f1e4ef2b6ce214f63dfa75e967)
change {{org.apache.commons.logging.LOG.fatal()}} to
{{org.slf4j.LoggerLOG.error()}} for api incompatibility.
*Step 3*: (fa9af169900f3515e65814ef7ca1c98914e90715)
change {{org.apache.commons.logging.Log.debug(Object)}} to
{{org.slf4j.Logger.debug(String)}} for api incompatibility.
*Step 4*: (7af274b3e89da963691272335256004ebf9f1b83)
handle a special case in DelegationTokenRenewer: change
{{LOG.debug(ie.getStackTrace())}} to {{LOG.debug("Exception in
removeRenewAction: ", ie)}}
*Step 5*: (7af274b3e89da963691272335256004ebf9f1b83)
handle a special case in AbstractService: change {{LOG.debug("noteFailure " +
exception, null)}} to {{LOG.debug("noteFailure " + exception, (Throwable)
null)}}
*Step 6*: (4ce2b824e77590407f77f326f16c39175aceccbf)
change {{IOUtils.cleanup}} to {{IOUtils.cleanupWithLogger}}
*Step 7*: (d82797fb88dbea12ffa0db926b894cc9123e444f)
revert {{FileSystem.LOG}} for it's referenced by hadoop-yarn
*Step 8*: (f0ffa503fb135d84e542ecea80cb3d6224983cd3)
change {{SignalLogger.INSTANCE.register(LOG)}} to
{{SignalLogger.INSTANCE.register(LogAdapter.create(LOG))}}
> Move commons logging APIs over to slf4j in hadoop-common
>
>
> Key: HADOOP-14539
> URL: https://issues.apache.org/jira/browse/HADOOP-14539
> Project: Hadoop Common
> Issue Type: Sub-task
>Reporter: Akira Ajisaka
>Assignee: Akira Ajisaka
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077826#comment-16077826 ] Wenxin He commented on HADOOP-14539: Hi, [~ajisakaa], I'm not sure what's the situation of this issue now. I created a pull request, hope It may help. > Move commons logging APIs over to slf4j in hadoop-common > > > Key: HADOOP-14539 > URL: https://issues.apache.org/jira/browse/HADOOP-14539 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Akira Ajisaka > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[
https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1603#comment-1603
]
Wenxin He edited comment on HADOOP-14587 at 7/7/17 8:14 AM:
branch-2.001.patch:
* resolve conflicts from trunk
* replace one more {{org.apache.log4j.Level}} in TestKMS in branch-2
was (Author: vincent he):
branch-2.001.patch:
* apply 008.patch for trunk and resolve conflicts
* replace one more {{org.apache.log4j.Level}} in TestKMS in branch-2
> Use GenericTestUtils.setLogLevel when available in hadoop-common
>
>
> Key: HADOOP-14587
> URL: https://issues.apache.org/jira/browse/HADOOP-14587
> Project: Hadoop Common
> Issue Type: Sub-task
>Reporter: Wenxin He
>Assignee: Wenxin He
> Fix For: 3.0.0-beta1
>
> Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch,
> HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch,
> HADOOP-14587.006.patch, HADOOP-14587.007.patch, HADOOP-14587.008.patch,
> HADOOP-24587-branch-2.001.patch
>
>
> Based on Brahma's comment in HADOOP-14296, it's better to use
> GenericTestUtils.setLogLevel as possible to make the migration easier.
> Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for
> hadoop-common change.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Status: Patch Available (was: Open) > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Fix For: 3.0.0-beta1 > > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch, HADOOP-14587.007.patch, HADOOP-14587.008.patch, > HADOOP-24587-branch-2.001.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[
https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wenxin He updated HADOOP-14587:
---
Attachment: HADOOP-24587-branch-2.001.patch
branch-2.001.patch:
* apply 008.patch for trunk and resolve conflicts
* replace one more {{org.apache.log4j.Level}} in TestKMS in branch-2
> Use GenericTestUtils.setLogLevel when available in hadoop-common
>
>
> Key: HADOOP-14587
> URL: https://issues.apache.org/jira/browse/HADOOP-14587
> Project: Hadoop Common
> Issue Type: Sub-task
>Reporter: Wenxin He
>Assignee: Wenxin He
> Fix For: 3.0.0-beta1
>
> Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch,
> HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch,
> HADOOP-14587.006.patch, HADOOP-14587.007.patch, HADOOP-14587.008.patch,
> HADOOP-24587-branch-2.001.patch
>
>
> Based on Brahma's comment in HADOOP-14296, it's better to use
> GenericTestUtils.setLogLevel as possible to make the migration easier.
> Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for
> hadoop-common change.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Status: Open (was: Patch Available) > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Fix For: 3.0.0-beta1 > > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch, HADOOP-14587.007.patch, HADOOP-14587.008.patch, > HADOOP-24587-branch-2.001.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077661#comment-16077661 ] Wenxin He commented on HADOOP-14587: OK, I’ll upload the patch for branch-2 when resolve all conflicts. > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Fix For: 3.0.0-beta1 > > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch, HADOOP-14587.007.patch, HADOOP-14587.008.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14624) Add GenericTestUtils.DelayAnswer that accept slf4j logger API
[
https://issues.apache.org/jira/browse/HADOOP-14624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075984#comment-16075984
]
Wenxin He commented on HADOOP-14624:
17 new warnings in javac are caused by new deprecated method
{{DelayAnswer(Log)}}.
> Add GenericTestUtils.DelayAnswer that accept slf4j logger API
> -
>
> Key: HADOOP-14624
> URL: https://issues.apache.org/jira/browse/HADOOP-14624
> Project: Hadoop Common
> Issue Type: Sub-task
>Reporter: Wenxin He
>Assignee: Wenxin He
> Attachments: HADOOP-14624.001.patch, HADOOP-14624.002.patch
>
>
> Split from HADOOP-14539.
> Now GenericTestUtils.DelayAnswer only accepts commons-logging logger API. Now
> we are migrating the APIs to slf4j, slf4j logger API should be accepted as
> well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075848#comment-16075848 ] Wenxin He commented on HADOOP-14587: The test failures are unrelated. They are OK in my running. > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch, HADOOP-14587.007.patch, HADOOP-14587.008.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14624) Add GenericTestUtils.DelayAnswer that accept slf4j logger API
[ https://issues.apache.org/jira/browse/HADOOP-14624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14624: --- Status: Patch Available (was: Open) > Add GenericTestUtils.DelayAnswer that accept slf4j logger API > - > > Key: HADOOP-14624 > URL: https://issues.apache.org/jira/browse/HADOOP-14624 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14624.001.patch, HADOOP-14624.002.patch > > > Split from HADOOP-14539. > Now GenericTestUtils.DelayAnswer only accepts commons-logging logger API. Now > we are migrating the APIs to slf4j, slf4j logger API should be accepted as > well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14624) Add GenericTestUtils.DelayAnswer that accept slf4j logger API
[ https://issues.apache.org/jira/browse/HADOOP-14624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14624: --- Attachment: HADOOP-14624.002.patch 002: Fixed checkstyle issue. > Add GenericTestUtils.DelayAnswer that accept slf4j logger API > - > > Key: HADOOP-14624 > URL: https://issues.apache.org/jira/browse/HADOOP-14624 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14624.001.patch, HADOOP-14624.002.patch > > > Split from HADOOP-14539. > Now GenericTestUtils.DelayAnswer only accepts commons-logging logger API. Now > we are migrating the APIs to slf4j, slf4j logger API should be accepted as > well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14624) Add GenericTestUtils.DelayAnswer that accept slf4j logger API
[ https://issues.apache.org/jira/browse/HADOOP-14624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14624: --- Status: Open (was: Patch Available) > Add GenericTestUtils.DelayAnswer that accept slf4j logger API > - > > Key: HADOOP-14624 > URL: https://issues.apache.org/jira/browse/HADOOP-14624 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14624.001.patch, HADOOP-14624.002.patch > > > Split from HADOOP-14539. > Now GenericTestUtils.DelayAnswer only accepts commons-logging logger API. Now > we are migrating the APIs to slf4j, slf4j logger API should be accepted as > well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Status: Open (was: Patch Available) > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch, HADOOP-14587.007.patch, HADOOP-14587.008.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[
https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wenxin He updated HADOOP-14587:
---
Attachment: HADOOP-14587.008.patch
008.patch:
change {{assertTrue(boolean)}} to {{assertEquals(expected, actual)}}.
Thanks, [~ajisakaa].
> Use GenericTestUtils.setLogLevel when available in hadoop-common
>
>
> Key: HADOOP-14587
> URL: https://issues.apache.org/jira/browse/HADOOP-14587
> Project: Hadoop Common
> Issue Type: Sub-task
>Reporter: Wenxin He
>Assignee: Wenxin He
> Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch,
> HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch,
> HADOOP-14587.006.patch, HADOOP-14587.007.patch, HADOOP-14587.008.patch
>
>
> Based on Brahma's comment in HADOOP-14296, it's better to use
> GenericTestUtils.setLogLevel as possible to make the migration easier.
> Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for
> hadoop-common change.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Status: Patch Available (was: Open) > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch, HADOOP-14587.007.patch, HADOOP-14587.008.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075757#comment-16075757 ] Wenxin He commented on HADOOP-14587: Yes, verification errors of assertEquals(expected, actual) are more readable in this situation. A new patch coming soon. > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch, HADOOP-14587.007.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14624) Add GenericTestUtils.DelayAnswer that accept slf4j logger API
[ https://issues.apache.org/jira/browse/HADOOP-14624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14624: --- Status: Patch Available (was: Open) > Add GenericTestUtils.DelayAnswer that accept slf4j logger API > - > > Key: HADOOP-14624 > URL: https://issues.apache.org/jira/browse/HADOOP-14624 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14624.001.patch > > > Split from HADOOP-14539. > Now GenericTestUtils.DelayAnswer only accepts commons-logging logger API. Now > we are migrating the APIs to slf4j, slf4j logger API should be accepted as > well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14624) Add GenericTestUtils.DelayAnswer that accept slf4j logger API
[ https://issues.apache.org/jira/browse/HADOOP-14624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14624: --- Attachment: HADOOP-14624.001.patch > Add GenericTestUtils.DelayAnswer that accept slf4j logger API > - > > Key: HADOOP-14624 > URL: https://issues.apache.org/jira/browse/HADOOP-14624 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14624.001.patch > > > Split from HADOOP-14539. > Now GenericTestUtils.DelayAnswer only accepts commons-logging logger API. Now > we are migrating the APIs to slf4j, slf4j logger API should be accepted as > well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Attachment: HADOOP-14587.007.patch > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch, HADOOP-14587.007.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Status: Open (was: Patch Available) > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch, HADOOP-14587.007.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Attachment: (was: HADOOP-14587.007.patch) > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch, HADOOP-14587.007.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Status: Patch Available (was: Open) > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch, HADOOP-14587.007.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Status: Patch Available (was: Open) https://builds.apache.org/job/PreCommit-HADOOP-Build/ doesn't work, try to kick again. > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch, HADOOP-14587.007.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Status: Open (was: Patch Available) > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch, HADOOP-14587.007.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Created] (HADOOP-14624) Add GenericTestUtils.DelayAnswer that accept slf4j logger API
Wenxin He created HADOOP-14624: -- Summary: Add GenericTestUtils.DelayAnswer that accept slf4j logger API Key: HADOOP-14624 URL: https://issues.apache.org/jira/browse/HADOOP-14624 Project: Hadoop Common Issue Type: Sub-task Reporter: Wenxin He Assignee: Wenxin He Split from HADOOP-14539. Now GenericTestUtils.DelayAnswer only accepts commons-logging logger API. Now we are migrating the APIs to slf4j, slf4j logger API should be accepted as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Status: Patch Available (was: Open) > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch, HADOOP-14587.007.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[
https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wenxin He updated HADOOP-14587:
---
Status: Open (was: Patch Available)
{quote}Processing: HADOOP-14587
HADOOP-14587 patch is being downloaded at Wed Jul 5 02:38:46 UTC 2017 from
https://issues.apache.org/jira/secure/attachment/12875683/HADOOP-14587.007.patch
-> Error (curl returned 56)
https://issues.apache.org/jira/secure/attachment/12875617/HADOOP-14587.006.patch
-> Downloaded{quote}
PreCommit job failed in downloading 007.patch, kick it again.
> Use GenericTestUtils.setLogLevel when available in hadoop-common
>
>
> Key: HADOOP-14587
> URL: https://issues.apache.org/jira/browse/HADOOP-14587
> Project: Hadoop Common
> Issue Type: Sub-task
>Reporter: Wenxin He
>Assignee: Wenxin He
> Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch,
> HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch,
> HADOOP-14587.006.patch, HADOOP-14587.007.patch
>
>
> Based on Brahma's comment in HADOOP-14296, it's better to use
> GenericTestUtils.setLogLevel as possible to make the migration easier.
> Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for
> hadoop-common change.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Attachment: HADOOP-14587.007.patch 007.patch: fix checkstyle. > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch, HADOOP-14587.007.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Status: Patch Available (was: Open) > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch, HADOOP-14587.007.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Status: Open (was: Patch Available) > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch, HADOOP-14587.007.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14615) Add ServiceOperations.stopQuietly that accept slf4j logger API
[ https://issues.apache.org/jira/browse/HADOOP-14615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073484#comment-16073484 ] Wenxin He commented on HADOOP-14615: Thanks, [~ste...@apache.org]! > Add ServiceOperations.stopQuietly that accept slf4j logger API > -- > > Key: HADOOP-14615 > URL: https://issues.apache.org/jira/browse/HADOOP-14615 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Fix For: 2.9.0, 3.0.0-beta1 > > Attachments: HADOOP-14615.001.patch, HADOOP-14615.002.patch, > HADOOP-14615.003.patch > > > Split from HADOOP-14539. > Now ServiceOperations.stopQuietly only accepts commons-logging logger API. > Now we are migrating the APIs to slf4j, slf4j logger API should be accepted > as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Status: Patch Available (was: Open) > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Status: Open (was: Patch Available) > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Attachment: HADOOP-14587.006.patch 006.patch: rebase > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch, > HADOOP-14587.006.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Status: Patch Available (was: Open) > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Status: Open (was: Patch Available) > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[
https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wenxin He updated HADOOP-14587:
---
Attachment: HADOOP-14587.005.patch
Sorry, I forgot to replace all occurrence. Thanks for your catch, [~ajisakaa].
005.patch:
replace all {{GenericTestUtils.setLogLevel(getLogger("org"), Level.DEBUG)}}
with {{GenericTestUtils.setRootLogLevel}} in TestGroupFallback.java.
> Use GenericTestUtils.setLogLevel when available in hadoop-common
>
>
> Key: HADOOP-14587
> URL: https://issues.apache.org/jira/browse/HADOOP-14587
> Project: Hadoop Common
> Issue Type: Sub-task
>Reporter: Wenxin He
>Assignee: Wenxin He
> Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch,
> HADOOP-14587.003.patch, HADOOP-14587.004.patch, HADOOP-14587.005.patch
>
>
> Based on Brahma's comment in HADOOP-14296, it's better to use
> GenericTestUtils.setLogLevel as possible to make the migration easier.
> Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for
> hadoop-common change.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073328#comment-16073328 ] Wenxin He commented on HADOOP-14587: Compiling warnings are all about setLogLevel(Log, Level) in GenericTestUtils. This will be fixed after moving commons logging APIs over to slf4j. > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14571) Deprecate public APIs relate to log4j1
[ https://issues.apache.org/jira/browse/HADOOP-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073324#comment-16073324 ] Wenxin He commented on HADOOP-14571: The test failures are not related. All compiling warnings are caused by deprecated methods. > Deprecate public APIs relate to log4j1 > -- > > Key: HADOOP-14571 > URL: https://issues.apache.org/jira/browse/HADOOP-14571 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Wenxin He > Attachments: HADOOP-14571.001.patch, HADOOP-14571.002.patch > > > When migrating log4j1 to log4j2, log4j1 APIs will be completely removed. > Let's deprecate public APIs relate to log4j1 before removing them. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14617) Add ReflectionUtils.logThreadInfo that accept slf4j logger API
[ https://issues.apache.org/jira/browse/HADOOP-14617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14617: --- Status: Patch Available (was: Open) > Add ReflectionUtils.logThreadInfo that accept slf4j logger API > -- > > Key: HADOOP-14617 > URL: https://issues.apache.org/jira/browse/HADOOP-14617 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14617.001.patch, HADOOP-14617.002.patch > > > Split from HADOOP-14539. > Now ReflectionUtils.logThreadInfo only accepts commons-logging logger API. > Now we are migrating the APIs to slf4j, slf4j logger API should be accepted > as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14617) Add ReflectionUtils.logThreadInfo that accept slf4j logger API
[ https://issues.apache.org/jira/browse/HADOOP-14617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14617: --- Status: Open (was: Patch Available) > Add ReflectionUtils.logThreadInfo that accept slf4j logger API > -- > > Key: HADOOP-14617 > URL: https://issues.apache.org/jira/browse/HADOOP-14617 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14617.001.patch, HADOOP-14617.002.patch > > > Split from HADOOP-14539. > Now ReflectionUtils.logThreadInfo only accepts commons-logging logger API. > Now we are migrating the APIs to slf4j, slf4j logger API should be accepted > as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14617) Add ReflectionUtils.logThreadInfo that accept slf4j logger API
[
https://issues.apache.org/jira/browse/HADOOP-14617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wenxin He updated HADOOP-14617:
---
Attachment: HADOOP-14617.002.patch
002.patch:
Add a test to verify {{logThreadInfo(Logger log, String title, long
minInterval)}}
> Add ReflectionUtils.logThreadInfo that accept slf4j logger API
> --
>
> Key: HADOOP-14617
> URL: https://issues.apache.org/jira/browse/HADOOP-14617
> Project: Hadoop Common
> Issue Type: Sub-task
>Reporter: Wenxin He
>Assignee: Wenxin He
> Attachments: HADOOP-14617.001.patch, HADOOP-14617.002.patch
>
>
> Split from HADOOP-14539.
> Now ReflectionUtils.logThreadInfo only accepts commons-logging logger API.
> Now we are migrating the APIs to slf4j, slf4j logger API should be accepted
> as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14615) Add ServiceOperations.stopQuietly that accept slf4j logger API
[ https://issues.apache.org/jira/browse/HADOOP-14615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14615: --- Attachment: HADOOP-14615.003.patch Thanks, [~ste...@apache.org]. Test added in 003.patch. > Add ServiceOperations.stopQuietly that accept slf4j logger API > -- > > Key: HADOOP-14615 > URL: https://issues.apache.org/jira/browse/HADOOP-14615 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14615.001.patch, HADOOP-14615.002.patch, > HADOOP-14615.003.patch > > > Split from HADOOP-14539. > Now ServiceOperations.stopQuietly only accepts commons-logging logger API. > Now we are migrating the APIs to slf4j, slf4j logger API should be accepted > as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14615) Add ServiceOperations.stopQuietly that accept slf4j logger API
[ https://issues.apache.org/jira/browse/HADOOP-14615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14615: --- Status: Open (was: Patch Available) > Add ServiceOperations.stopQuietly that accept slf4j logger API > -- > > Key: HADOOP-14615 > URL: https://issues.apache.org/jira/browse/HADOOP-14615 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14615.001.patch, HADOOP-14615.002.patch, > HADOOP-14615.003.patch > > > Split from HADOOP-14539. > Now ServiceOperations.stopQuietly only accepts commons-logging logger API. > Now we are migrating the APIs to slf4j, slf4j logger API should be accepted > as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14615) Add ServiceOperations.stopQuietly that accept slf4j logger API
[ https://issues.apache.org/jira/browse/HADOOP-14615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14615: --- Status: Patch Available (was: Open) > Add ServiceOperations.stopQuietly that accept slf4j logger API > -- > > Key: HADOOP-14615 > URL: https://issues.apache.org/jira/browse/HADOOP-14615 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14615.001.patch, HADOOP-14615.002.patch, > HADOOP-14615.003.patch > > > Split from HADOOP-14539. > Now ServiceOperations.stopQuietly only accepts commons-logging logger API. > Now we are migrating the APIs to slf4j, slf4j logger API should be accepted > as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14571) Deprecate public APIs relate to log4j1
[ https://issues.apache.org/jira/browse/HADOOP-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14571: --- Status: Open (was: Patch Available) > Deprecate public APIs relate to log4j1 > -- > > Key: HADOOP-14571 > URL: https://issues.apache.org/jira/browse/HADOOP-14571 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Wenxin He > Attachments: HADOOP-14571.001.patch, HADOOP-14571.002.patch > > > When migrating log4j1 to log4j2, log4j1 APIs will be completely removed. > Let's deprecate public APIs relate to log4j1 before removing them. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14571) Deprecate public APIs relate to log4j1
[ https://issues.apache.org/jira/browse/HADOOP-14571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14571: --- Attachment: HADOOP-14571.002.patch 002.patch: document javadoc for the deprecated methods to suggest alternatives Thanks, [~ajisakaa]. > Deprecate public APIs relate to log4j1 > -- > > Key: HADOOP-14571 > URL: https://issues.apache.org/jira/browse/HADOOP-14571 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Wenxin He > Attachments: HADOOP-14571.001.patch, HADOOP-14571.002.patch > > > When migrating log4j1 to log4j2, log4j1 APIs will be completely removed. > Let's deprecate public APIs relate to log4j1 before removing them. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Status: Patch Available (was: Open) > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Status: Open (was: Patch Available) > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Attachment: HADOOP-14587.004.patch 004.patch: fix checkstyle, remove unused import > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch, HADOOP-14587.004.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Status: Open (was: Patch Available) > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[
https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wenxin He updated HADOOP-14587:
---
Attachment: HADOOP-14587.003.patch
Yes, more simple and clear. Thanks.
003.patch attached:
change to {{setLogLevel(LogManager.getRootLogger(),
Level.toLevel(level.toString()));}}
> Use GenericTestUtils.setLogLevel when available in hadoop-common
>
>
> Key: HADOOP-14587
> URL: https://issues.apache.org/jira/browse/HADOOP-14587
> Project: Hadoop Common
> Issue Type: Sub-task
>Reporter: Wenxin He
>Assignee: Wenxin He
> Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch,
> HADOOP-14587.003.patch
>
>
> Based on Brahma's comment in HADOOP-14296, it's better to use
> GenericTestUtils.setLogLevel as possible to make the migration easier.
> Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for
> hadoop-common change.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Status: Patch Available (was: Open) > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, > HADOOP-14587.003.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
[ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenxin He updated HADOOP-14587: --- Status: Open (was: Patch Available) > Use GenericTestUtils.setLogLevel when available in hadoop-common > > > Key: HADOOP-14587 > URL: https://issues.apache.org/jira/browse/HADOOP-14587 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Wenxin He >Assignee: Wenxin He > Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch > > > Based on Brahma's comment in HADOOP-14296, it's better to use > GenericTestUtils.setLogLevel as possible to make the migration easier. > Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for > hadoop-common change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
