[jira] [Issue Comment Deleted] (HADOOP-14549) Use GenericTestUtils.setLogLevel when available
[
https://issues.apache.org/jira/browse/HADOOP-14549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hewenxin updated HADOOP-14549:
--
Comment: was deleted
(was: PS: I leave {{org.apache.log4j.Logger.setLevel}} in
{{org.apache.hadoop.tools.rumen.datatypes.util.MapReduceJobPropertiesParser}}
unchanged for it's not test code and should not dependent on
{{GenericTestUtils}}.
I searched in the whole project, only found this one not in test code.
So in this situation should I leave it unchanged or do something that makes
migration easier?)
> Use GenericTestUtils.setLogLevel when available
> ---
>
> Key: HADOOP-14549
> URL: https://issues.apache.org/jira/browse/HADOOP-14549
> Project: Hadoop Common
> Issue Type: Sub-task
>Reporter: Akira Ajisaka
>Assignee: wenxin he
> Attachments: HADOOP-14549.hadoop-tools.example.patch
>
>
> Based on Brahma's
> [comment|https://issues.apache.org/jira/browse/HADOOP-14296?focusedCommentId=16054390&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16054390]
> in HADOOP-14296, it's better to use GenericTestUtils.setLogLevel as possible
> to make the migration easier.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14549) Use GenericTestUtils.setLogLevel when available
[
https://issues.apache.org/jira/browse/HADOOP-14549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058748#comment-16058748
]
hewenxin commented on HADOOP-14549:
---
PS: I leave {{org.apache.log4j.Logger.setLevel}} in
{{org.apache.hadoop.tools.rumen.datatypes.util.MapReduceJobPropertiesParser}}
unchanged for it's not test code and should not dependent on
{{GenericTestUtils}}.
I searched in the whole project, only found this one not in test code.
So in this situation should I leave it unchanged or do something that makes
migration easier?
> Use GenericTestUtils.setLogLevel when available
> ---
>
> Key: HADOOP-14549
> URL: https://issues.apache.org/jira/browse/HADOOP-14549
> Project: Hadoop Common
> Issue Type: Sub-task
>Reporter: Akira Ajisaka
>Assignee: wenxin he
> Attachments: HADOOP-14549.hadoop-tools.example.patch
>
>
> Based on Brahma's
> [comment|https://issues.apache.org/jira/browse/HADOOP-14296?focusedCommentId=16054390&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16054390]
> in HADOOP-14296, it's better to use GenericTestUtils.setLogLevel as possible
> to make the migration easier.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
