[GitHub] [hadoop] PrabhuJoseph commented on pull request #4436: YARN-9971.YARN Native Service HttpProbe logs THIS_HOST in error messages

2022-06-21 Thread GitBox 


PrabhuJoseph commented on PR #4436:
URL: https://github.com/apache/hadoop/pull/4436#issuecomment-1162614271

   Patch Looks good. +1. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] PrabhuJoseph commented on pull request #4436: YARN-9971.YARN Native Service HttpProbe logs THIS_HOST in error messages

2022-06-19 Thread GitBox 


PrabhuJoseph commented on PR #4436:
URL: https://github.com/apache/hadoop/pull/4436#issuecomment-1159975425

   @ashutoshcipher Shall we assign it to some variable in try and use it from 
both try and catch clause.
   
   ```
   String hostString = urlString.replace(HOST_TOKEN, ip);
   try {
 URL url = new URL(hostString);
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org