[GitHub] [hadoop] adoroszlai commented on a change in pull request #1218: HDDS-1891. Ozone fs shell command should work with default port when port number is not specified

2019-08-09 Thread GitBox 
adoroszlai commented on a change in pull request #1218: HDDS-1891. Ozone fs 
shell command should work with default port when port number is not specified
URL: https://github.com/apache/hadoop/pull/1218#discussion_r312386384
 
 

 ##
 File path: 
hadoop-ozone/ozonefs/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystemWithMocks.java
 ##
 @@ -78,6 +79,42 @@ public void testFSUriWithHostPortOverrides() throws 
Exception {
 OzoneClientFactory.getRpcClient("local.host", 5899, conf);
   }
 
+  @Test
+  public void testFSUriWithHostPortUnspecified() throws Exception {
+Configuration conf = new OzoneConfiguration();
+final int OM_PORT_DEFAULT = OmUtils.getOmRpcPort(conf);
 
 Review comment:
   Also from checkstyle: `Name 'OM_PORT_DEFAULT' must match pattern 
'^[a-z][a-zA-Z0-9]*$'`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[GitHub] [hadoop] adoroszlai commented on a change in pull request #1218: HDDS-1891. Ozone fs shell command should work with default port when port number is not specified

2019-08-09 Thread GitBox 
adoroszlai commented on a change in pull request #1218: HDDS-1891. Ozone fs 
shell command should work with default port when port number is not specified
URL: https://github.com/apache/hadoop/pull/1218#discussion_r312382889
 
 

 ##
 File path: 
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java
 ##
 @@ -54,6 +55,8 @@
 import static org.apache.hadoop.fs.ozone.Constants.OZONE_USER_DIR;
 import static org.apache.hadoop.ozone.OzoneConsts.OZONE_URI_DELIMITER;
 import static org.apache.hadoop.ozone.OzoneConsts.OZONE_URI_SCHEME;
+import static org.apache.hadoop.ozone.om.OMConfigKeys.OZONE_OM_PORT_DEFAULT;
 
 Review comment:
   Unused import, checkstyle will complain.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org