[GitHub] [hadoop] adoroszlai commented on a change in pull request #1501: HDDS-2067. Create generic service facade with tracing/metrics/logging support
adoroszlai commented on a change in pull request #1501: HDDS-2067. Create
generic service facade with tracing/metrics/logging support
URL: https://github.com/apache/hadoop/pull/1501#discussion_r327141010
##
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/OzoneProtocolMessageDispatcher.java
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hdds.server;
+
+import org.apache.hadoop.hdds.function.FunctionWithServiceException;
+import org.apache.hadoop.hdds.tracing.TracingUtil;
+import org.apache.hadoop.ozone.protocolPB.ProtocolMessageMetrics;
+
+import com.google.protobuf.ProtocolMessageEnum;
+import com.google.protobuf.RpcController;
+import com.google.protobuf.ServiceException;
+import io.opentracing.Scope;
+import org.slf4j.Logger;
+
+/**
+ * Dispatch message after tracing and message logging for insight.
+ *
+ * This is a generic utility to dispatch message in ServierSide translators.
+ *
+ * It logs the message type/content on DEBUG/TRACING log for insight and create
+ * a new span based on the tracing information.
+ */
+public class OzoneProtocolMessageDispatcher {
+
+ private String serviceName;
+
+ private final ProtocolMessageMetrics protocolMessageMetrics;
+
+ private Logger logger;
+
+ public OzoneProtocolMessageDispatcher(String serviceName,
+ ProtocolMessageMetrics protocolMessageMetrics, Logger logger) {
+this.serviceName = serviceName;
+this.protocolMessageMetrics = protocolMessageMetrics;
+this.logger = logger;
+ }
+
+ public RESPONSE processRequest(
+ RpcController controller,
+ REQUEST request,
+ FunctionWithServiceException methodCall,
+ ProtocolMessageEnum type,
+ String traceId) throws ServiceException {
+Scope scope = TracingUtil
+.importAndCreateScope(type.toString(), traceId);
+try {
+ if (logger.isTraceEnabled()) {
+logger.trace(
+"{} {} request is received: {}",
+serviceName,
+type.toString(),
+request.toString().replaceAll("\n", "n"));
+ } else if (logger.isDebugEnabled()) {
+logger.debug("{}} {} request is received",
Review comment:
```suggestion
logger.debug("{} {} request is received",
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] adoroszlai commented on a change in pull request #1501: HDDS-2067. Create generic service facade with tracing/metrics/logging support
adoroszlai commented on a change in pull request #1501: HDDS-2067. Create generic service facade with tracing/metrics/logging support URL: https://github.com/apache/hadoop/pull/1501#discussion_r327155616 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/function/package-info.java ## @@ -0,0 +1,25 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +/** + * This package contains HDDS protocol related classes. + */ +package org.apache.hadoop.hdds.function; +/** + * Functional interfaces for ozone, similar to java.util.function. Review comment: Seems to be misplaced (should go above documented `package`). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] adoroszlai commented on a change in pull request #1501: HDDS-2067. Create generic service facade with tracing/metrics/logging support
adoroszlai commented on a change in pull request #1501: HDDS-2067. Create
generic service facade with tracing/metrics/logging support
URL: https://github.com/apache/hadoop/pull/1501#discussion_r327154998
##
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/function/FunctionWithIOException.java
##
@@ -0,0 +1,37 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hdds.function;
+
+import java.io.IOException;
+
+/**
+ * Functional interface like java.util.function.Function but with
+ * checked exception.
+ */
+@FunctionalInterface
+public interface FunctionWithIOException {
Review comment:
Unused.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] adoroszlai commented on a change in pull request #1501: HDDS-2067. Create generic service facade with tracing/metrics/logging support
adoroszlai commented on a change in pull request #1501: HDDS-2067. Create generic service facade with tracing/metrics/logging support URL: https://github.com/apache/hadoop/pull/1501#discussion_r327141110 ## File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/OzoneProtocolMessageDispatcher.java ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hdds.server; + +import org.apache.hadoop.hdds.function.FunctionWithServiceException; +import org.apache.hadoop.hdds.tracing.TracingUtil; +import org.apache.hadoop.ozone.protocolPB.ProtocolMessageMetrics; + +import com.google.protobuf.ProtocolMessageEnum; +import com.google.protobuf.RpcController; +import com.google.protobuf.ServiceException; +import io.opentracing.Scope; +import org.slf4j.Logger; + +/** + * Dispatch message after tracing and message logging for insight. + * + * This is a generic utility to dispatch message in ServierSide translators. Review comment: ```suggestion * This is a generic utility to dispatch message in ServerSide translators. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] adoroszlai commented on a change in pull request #1501: HDDS-2067. Create generic service facade with tracing/metrics/logging support
adoroszlai commented on a change in pull request #1501: HDDS-2067. Create
generic service facade with tracing/metrics/logging support
URL: https://github.com/apache/hadoop/pull/1501#discussion_r327140870
##
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/OzoneProtocolMessageDispatcher.java
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hdds.server;
+
+import org.apache.hadoop.hdds.function.FunctionWithServiceException;
+import org.apache.hadoop.hdds.tracing.TracingUtil;
+import org.apache.hadoop.ozone.protocolPB.ProtocolMessageMetrics;
+
+import com.google.protobuf.ProtocolMessageEnum;
+import com.google.protobuf.RpcController;
+import com.google.protobuf.ServiceException;
+import io.opentracing.Scope;
+import org.slf4j.Logger;
+
+/**
+ * Dispatch message after tracing and message logging for insight.
+ *
+ * This is a generic utility to dispatch message in ServierSide translators.
+ *
+ * It logs the message type/content on DEBUG/TRACING log for insight and create
+ * a new span based on the tracing information.
+ */
+public class OzoneProtocolMessageDispatcher {
+
+ private String serviceName;
+
+ private final ProtocolMessageMetrics protocolMessageMetrics;
+
+ private Logger logger;
+
+ public OzoneProtocolMessageDispatcher(String serviceName,
+ ProtocolMessageMetrics protocolMessageMetrics, Logger logger) {
+this.serviceName = serviceName;
+this.protocolMessageMetrics = protocolMessageMetrics;
+this.logger = logger;
+ }
+
+ public RESPONSE processRequest(
+ RpcController controller,
Review comment:
Unused.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] adoroszlai commented on a change in pull request #1501: HDDS-2067. Create generic service facade with tracing/metrics/logging support
adoroszlai commented on a change in pull request #1501: HDDS-2067. Create
generic service facade with tracing/metrics/logging support
URL: https://github.com/apache/hadoop/pull/1501#discussion_r327157203
##
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/function/FunctionWithServiceException.java
##
@@ -0,0 +1,36 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hdds.function;
+
+import com.google.protobuf.ServiceException;
+
+/**
+ * Functional interface like java.util.function.Function but with
+ * checked exception.
+ */
+@FunctionalInterface
+public interface FunctionWithServiceException {
Review comment:
Can `CheckedFunction` from Ratis be used instead, or is that not an option?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
