[GitHub] [hadoop] ayushtkn commented on pull request #4461: HADOOP-18303. Remove shading exclusion of javax.ws.rs-api from hadoop-client-runtime
ayushtkn commented on PR #4461: URL: https://github.com/apache/hadoop/pull/4461#issuecomment-1315808049 Try with 3.3.4, we fixed it there If I remember correctly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on pull request #4461: HADOOP-18303. Remove shading exclusion of javax.ws.rs-api from hadoop-client-runtime
ayushtkn commented on PR #4461: URL: https://github.com/apache/hadoop/pull/4461#issuecomment-116433 Yeps, if people let us do that, that jira is already in a released version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on pull request #4461: HADOOP-18303. Remove shading exclusion of javax.ws.rs-api from hadoop-client-runtime
ayushtkn commented on PR #4461: URL: https://github.com/apache/hadoop/pull/4461#issuecomment-1164781602 Both shading and the issue that I am talking about are due to HADOOP-18033 Jackson upgrade added a rs-api jar which is not shaded and which all cause conflicts in Tez jsr311 jar already present -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on pull request #4461: HADOOP-18303. Remove shading exclusion of javax.ws.rs-api from hadoop-client-runtime
ayushtkn commented on PR #4461: URL: https://github.com/apache/hadoop/pull/4461#issuecomment-1162743798 @sunchao It doesn't, that is what I was saying, even if we sort the shading issue, the Tez issue is gonna stay because it doesn't use the shaded Jar and gets both these jars in classpath and things mess up. Can check the exception in the end here: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-213/4/testReport/org.apache.tez.history/TestHistoryParser/testParserWithFailedJob/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on pull request #4461: HADOOP-18303. Remove shading exclusion of javax.ws.rs-api from hadoop-client-runtime
ayushtkn commented on PR #4461: URL: https://github.com/apache/hadoop/pull/4461#issuecomment-1162099605 @pan3793 might be good to answer the kyuubi & spark issue is flagged by him here: https://github.com/apache/hadoop/pull/3764#issuecomment-1158641569 and some details here: https://issues.apache.org/jira/browse/HADOOP-18033?focusedCommentId=17555953=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17555953 @pan3793 can you please share some more details on that... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on pull request #4461: HADOOP-18303. Remove shading exclusion of javax.ws.rs-api from hadoop-client-runtime
ayushtkn commented on PR #4461: URL: https://github.com/apache/hadoop/pull/4461#issuecomment-1161637780 >I'm getting really confused now. Before this PR, conflicting imports were both being shaded. Now they are being merged in unshaded and the issue is which ones not to shade? I am also confused No, one was shaded one wasn't, the one not shaded is getting added here because kirby & spark are crying due to missing classes. The question is yes which one to shade and which one not to, In Ideal situation only one these jars should be there because they provide similar classes and to be used by different version. In our case Jackson use the new Jar, and Jersey uses the old Jar, so we need both Jar in hadoop. If we upgrade Jersey also, both Jackson & Jersey will need the new jar and we can remove one jar and this conflict. Let us assume we did something with the shading, but Projects like Tez, when they add Hadoop as dependency they get both Jars and both have similar classes, so that creates a mess, something similar error message like here: https://stackoverflow.com/questions/23277429/java-lang-abstractmethoderror-javax-ws-rs-core-uribuilder-uri/26767488#26767488 Regarding Solution: I don't have a perfect solution, and definitely need pointers, Not sure what we can do with shading, if we figure out may be spark/kriby may be happy. But if we exclude the old jar who will be unhappy god knows Shading won't solve Hive/Tez issue Jersey upgrade: Not sure we can do for a maintenance release, people have objections for protobuf as well, and post that also I guess downstream also have to upgrade Jersey, that won't be easy either. That is all what I know or can think of, Not sure what all is Right/Wrong. Hope I didn't contribute more to the confusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
