[GitHub] [hadoop] bharatviswa504 commented on issue #1588: HDDS-1986. Fix listkeys API.

2019-10-10 Thread GitBox
bharatviswa504 commented on issue #1588: HDDS-1986. Fix listkeys API.
URL: https://github.com/apache/hadoop/pull/1588#issuecomment-540843683
 
 
   Thank You all for the review.
   I have committed this to the trunk.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] bharatviswa504 commented on issue #1588: HDDS-1986. Fix listkeys API.

2019-10-10 Thread GitBox
bharatviswa504 commented on issue #1588: HDDS-1986. Fix listkeys API.
URL: https://github.com/apache/hadoop/pull/1588#issuecomment-540673876
 
 
   Thank You @arp7 and @anuengineer for the review.
   I will try to run the benchmark and update it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] bharatviswa504 commented on issue #1588: HDDS-1986. Fix listkeys API.

2019-10-09 Thread GitBox
bharatviswa504 commented on issue #1588: HDDS-1986. Fix listkeys API.
URL: https://github.com/apache/hadoop/pull/1588#issuecomment-540330495
 
 
   > +1
   > 
   > I am okay to get this committed with a minor comment below, assuming there 
are no unaddressed comments from @anuengineer.
   > 
   > We should benchmark list operations later in case any further optimization 
is needed.
   
   I will run the benchmarks once after the list Operations is fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] bharatviswa504 commented on issue #1588: HDDS-1986. Fix listkeys API.

2019-10-09 Thread GitBox
bharatviswa504 commented on issue #1588: HDDS-1986. Fix listkeys API.
URL: https://github.com/apache/hadoop/pull/1588#issuecomment-540330162
 
 
   Addressed the review comment.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org