[GitHub] [hadoop] hadoop-yetus commented on pull request #4151: HADOOP-18088. Replace log4j 1.x with reload4j.

2022-04-11 Thread GitBox


hadoop-yetus commented on PR #4151:
URL: https://github.com/apache/hadoop/pull/4151#issuecomment-1094927966

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 40s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
    _ branch-2.10 Compile Tests _ |
   | +0 :ok: |  mvndep  |   3m 55s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  14m 30s |  |  branch-2.10 passed  |
   | +1 :green_heart: |  compile  |  13m 57s |  |  branch-2.10 passed with JDK 
Azul Systems, Inc.-1.7.0_262-b10  |
   | +1 :green_heart: |  compile  |  11m 46s |  |  branch-2.10 passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07  |
   | +1 :green_heart: |  checkstyle  |   2m 15s |  |  branch-2.10 passed  |
   | +1 :green_heart: |  mvnsite  |  12m 35s |  |  branch-2.10 passed  |
   | -1 :x: |  javadoc  |   0m 47s | 
[/branch-javadoc-root-jdkAzulSystems,Inc.-1.7.0_262-b10.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4151/2/artifact/out/branch-javadoc-root-jdkAzulSystems,Inc.-1.7.0_262-b10.txt)
 |  root in branch-2.10 failed with JDK Azul Systems, Inc.-1.7.0_262-b10.  |
   | +1 :green_heart: |  javadoc  |   5m 49s |  |  branch-2.10 passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07  |
   | +0 :ok: |  spotbugs  |   0m 39s |  |  branch/hadoop-project no spotbugs 
output file (spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 18s |  |  branch/hadoop-assemblies no spotbugs 
output file (spotbugsXml.xml)  |
   | -1 :x: |  spotbugs  |  27m 28s | 
[/branch-spotbugs-root-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4151/2/artifact/out/branch-spotbugs-root-warnings.html)
 |  root in branch-2.10 has 4 extant spotbugs warnings.  |
   | -1 :x: |  spotbugs  |   1m 58s | 
[/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4151/2/artifact/out/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html)
 |  hadoop-common-project/hadoop-common in branch-2.10 has 2 extant spotbugs 
warnings.  |
   | -1 :x: |  spotbugs  |   2m 20s | 
[/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4151/2/artifact/out/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html)
 |  hadoop-hdfs-project/hadoop-hdfs in branch-2.10 has 1 extant spotbugs 
warnings.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 30s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  21m  3s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  13m  5s |  |  the patch passed with JDK 
Azul Systems, Inc.-1.7.0_262-b10  |
   | +1 :green_heart: |  javac  |  13m  5s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  10m 59s |  |  the patch passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07  |
   | +1 :green_heart: |  javac  |  10m 59s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   2m  5s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |  10m 54s |  |  the patch passed  |
   | +1 :green_heart: |  xml  |   0m 32s |  |  The patch has no ill-formed XML 
file.  |
   | -1 :x: |  javadoc  |   0m 26s | 
[/patch-javadoc-root-jdkAzulSystems,Inc.-1.7.0_262-b10.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4151/2/artifact/out/patch-javadoc-root-jdkAzulSystems,Inc.-1.7.0_262-b10.txt)
 |  root in the patch failed with JDK Azul Systems, Inc.-1.7.0_262-b10.  |
   | +1 :green_heart: |  javadoc  |   5m 24s |  |  the patch passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07  |
   | +0 :ok: |  spotbugs  |   0m 14s |  |  hadoop-project has no data from 
spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 14s |  |  hadoop-assemblies has no data from 
spotbugs  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 435m 36s | 
[/patch-unit-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4151/2/artifact/out/patch-unit-root.txt)
 |  root in the patch passed.  |
   | -1 :x: |  asflicense  |   1m 20s | 
[/results-asflicense.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4151/2/artifact/out/results-asflicense.txt)
 |  The patch generated 2 ASF License warnings.  |
   |  |   | 671m 20s |  |  |
   
   
   | Reason | Tests |
   |---:|:--|
   | 

[GitHub] [hadoop] hadoop-yetus commented on pull request #4151: HADOOP-18088. Replace log4j 1.x with reload4j.

2022-04-08 Thread GitBox


hadoop-yetus commented on PR #4151:
URL: https://github.com/apache/hadoop/pull/4151#issuecomment-1093419281

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   8m 17s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
    _ branch-2.10 Compile Tests _ |
   | +0 :ok: |  mvndep  |   3m 52s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  13m 48s |  |  branch-2.10 passed  |
   | +1 :green_heart: |  compile  |  13m 18s |  |  branch-2.10 passed with JDK 
Azul Systems, Inc.-1.7.0_262-b10  |
   | +1 :green_heart: |  compile  |  10m 45s |  |  branch-2.10 passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07  |
   | +1 :green_heart: |  checkstyle  |   2m  6s |  |  branch-2.10 passed  |
   | +1 :green_heart: |  mvnsite  |  10m 46s |  |  branch-2.10 passed  |
   | -1 :x: |  javadoc  |   0m 45s | 
[/branch-javadoc-root-jdkAzulSystems,Inc.-1.7.0_262-b10.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4151/1/artifact/out/branch-javadoc-root-jdkAzulSystems,Inc.-1.7.0_262-b10.txt)
 |  root in branch-2.10 failed with JDK Azul Systems, Inc.-1.7.0_262-b10.  |
   | +1 :green_heart: |  javadoc  |   5m 12s |  |  branch-2.10 passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07  |
   | +0 :ok: |  spotbugs  |   0m 39s |  |  branch/hadoop-project no spotbugs 
output file (spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 18s |  |  branch/hadoop-assemblies no spotbugs 
output file (spotbugsXml.xml)  |
   | -1 :x: |  spotbugs  |  22m 32s | 
[/branch-spotbugs-root-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4151/1/artifact/out/branch-spotbugs-root-warnings.html)
 |  root in branch-2.10 has 4 extant spotbugs warnings.  |
   | -1 :x: |  spotbugs  |   1m 38s | 
[/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4151/1/artifact/out/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html)
 |  hadoop-common-project/hadoop-common in branch-2.10 has 2 extant spotbugs 
warnings.  |
   | -1 :x: |  spotbugs  |   2m  4s | 
[/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4151/1/artifact/out/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html)
 |  hadoop-hdfs-project/hadoop-hdfs in branch-2.10 has 1 extant spotbugs 
warnings.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 29s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  23m  4s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  13m 19s |  |  the patch passed with JDK 
Azul Systems, Inc.-1.7.0_262-b10  |
   | +1 :green_heart: |  javac  |  13m 19s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  11m  0s |  |  the patch passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07  |
   | +1 :green_heart: |  javac  |  11m  0s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   2m  2s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |  10m 54s |  |  the patch passed  |
   | +1 :green_heart: |  xml  |   0m 31s |  |  The patch has no ill-formed XML 
file.  |
   | -1 :x: |  javadoc  |   0m 26s | 
[/patch-javadoc-root-jdkAzulSystems,Inc.-1.7.0_262-b10.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4151/1/artifact/out/patch-javadoc-root-jdkAzulSystems,Inc.-1.7.0_262-b10.txt)
 |  root in the patch failed with JDK Azul Systems, Inc.-1.7.0_262-b10.  |
   | +1 :green_heart: |  javadoc  |   5m 17s |  |  the patch passed with JDK 
Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07  |
   | +0 :ok: |  spotbugs  |   0m 16s |  |  hadoop-project has no data from 
spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 17s |  |  hadoop-assemblies has no data from 
spotbugs  |
    _ Other Tests _ |
   | -1 :x: |  unit  | 432m 56s | 
[/patch-unit-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4151/1/artifact/out/patch-unit-root.txt)
 |  root in the patch passed.  |
   | -1 :x: |  asflicense  |   1m 20s | 
[/results-asflicense.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4151/1/artifact/out/results-asflicense.txt)
 |  The patch