[GitHub] [hadoop] jojochuang commented on a change in pull request #3302: HDFS-16173.Improve CopyCommands#Put#executor queue configurability.
jojochuang commented on a change in pull request #3302: URL: https://github.com/apache/hadoop/pull/3302#discussion_r690871929 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/CopyCommands.java ## @@ -256,6 +258,8 @@ protected void processOptions(LinkedList args) " -p : Preserves timestamps, ownership and the mode.\n" + " -f : Overwrites the destination if it already exists.\n" + " -t : Number of threads to be used, default is 1.\n" + +" -q : Number of threadPool queue size to be used, " + Review comment: Just a nit: remove "Number of" ## File path: hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md ## @@ -542,6 +542,8 @@ Options: * `-l` : Allow DataNode to lazily persist the file to disk, Forces a replication factor of 1. This flag will result in reduced durability. Use with care. * `-d` : Skip creation of temporary file with the suffix `._COPYING_`. +* `-q ` : Number of threadPool queue size to be used, Review comment: here, too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] jojochuang commented on a change in pull request #3302: HDFS-16173.Improve CopyCommands#Put#executor queue configurability.
jojochuang commented on a change in pull request #3302: URL: https://github.com/apache/hadoop/pull/3302#discussion_r690872102 ## File path: hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md ## @@ -542,6 +542,8 @@ Options: * `-l` : Allow DataNode to lazily persist the file to disk, Forces a replication factor of 1. This flag will result in reduced durability. Use with care. * `-d` : Skip creation of temporary file with the suffix `._COPYING_`. +* `-q ` : Number of threadPool queue size to be used, Review comment: here, too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] jojochuang commented on a change in pull request #3302: HDFS-16173.Improve CopyCommands#Put#executor queue configurability.
jojochuang commented on a change in pull request #3302: URL: https://github.com/apache/hadoop/pull/3302#discussion_r690871929 ## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/CopyCommands.java ## @@ -256,6 +258,8 @@ protected void processOptions(LinkedList args) " -p : Preserves timestamps, ownership and the mode.\n" + " -f : Overwrites the destination if it already exists.\n" + " -t : Number of threads to be used, default is 1.\n" + +" -q : Number of threadPool queue size to be used, " + Review comment: Just a nit: remove "Number of" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
