jojochuang commented on code in PR #4406:
URL: https://github.com/apache/hadoop/pull/4406#discussion_r931673249
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/web/TestDatanodeHttpXFrame.java:
##########
@@ -69,7 +68,7 @@ public void testNameNodeXFrameOptionsDisabled() throws
Exception {
cluster = createCluster(xFrameEnabled, null);
HttpURLConnection conn = getConn(cluster);
String xfoHeader = conn.getHeaderField("X-FRAME-OPTIONS");
- Assert.assertTrue("unexpected X-FRAME-OPTION in header", xfoHeader ==
null);
+ Assert.assertNull(xfoHeader);
Review Comment:
```suggestion
Assert.assertNull("unexpected X-FRAME-OPTION in header", xfoHeader);
```
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/web/webhdfs/TestDataNodeUGIProvider.java:
##########
@@ -246,9 +246,9 @@ private WebHdfsFileSystem
getWebHdfsFileSystem(UserGroupInformation ugi,
DelegationTokenSecretManager dtSecretManager = new
DelegationTokenSecretManager(
86400000, 86400000, 86400000, 86400000, namesystem);
dtSecretManager.startThreads();
- Token<DelegationTokenIdentifier> token1 = new
Token<DelegationTokenIdentifier>(
+ Token<DelegationTokenIdentifier> token1 = new Token<>(
Review Comment:
Unrelated change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
