[GitHub] [hadoop] omalley commented on a diff in pull request #4511: HADOOP-18315. Fix 3.3 build problems caused by backport of HADOOP-11867.
omalley commented on code in PR #4511: URL: https://github.com/apache/hadoop/pull/4511#discussion_r918217672 ## hadoop-project/pom.xml: ## @@ -1723,17 +1723,6 @@ - -org.apache.hbase -hbase-server -${hbase.version} - - -log4j -log4j - - - Review Comment: Ok, that was caused by HADOOP-18088 in 160b6d106. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] omalley commented on a diff in pull request #4511: HADOOP-18315. Fix 3.3 build problems caused by backport of HADOOP-11867.
omalley commented on code in PR #4511: URL: https://github.com/apache/hadoop/pull/4511#discussion_r918216569 ## hadoop-tools/hadoop-benchmark/pom.xml: ## @@ -22,11 +22,11 @@ org.apache.hadoop hadoop-project -3.4.0-SNAPSHOT +3.3.9-SNAPSHOT ../../hadoop-project/pom.xml hadoop-benchmark - 3.4.0-SNAPSHOT + 3.3.9-SNAPSHOT Review Comment: It should track the current branch, so 3.3.9 is correct. This was fixed by HADOOP-18322 in 7eb1c908a0 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org