[GitHub] [hadoop] slfan1989 commented on pull request #4632: YARN-5871. [RESERVATION] Add support for reservation-based routing.
slfan1989 commented on PR #4632: URL: https://github.com/apache/hadoop/pull/4632#issuecomment-1197527754 > @slfan1989 this is a lot to review. Can we split it? Probably cleanup of the existing code and then one or two for the federation part. @goiri Thank you very much for your help reviewing the code, I will split it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on pull request #4632: YARN-5871. [RESERVATION] Add support for reservation-based routing.
slfan1989 commented on PR #4632: URL: https://github.com/apache/hadoop/pull/4632#issuecomment-1196845974 @goiri I have integrated the code of YARN-5871, tested it locally, and it runs normally. There are 3 proto compilation prompts in javac, which I personally think can be ignored. I am sorting out the design documents, and it is expected to be available in 1-2 days. Please help to review code, thank you very much! I don't plan to split into multiple prs, because a lot of code is related to proto, I will explain this part in the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on pull request #4632: YARN-5871. [RESERVATION] Add support for reservation-based routing.
slfan1989 commented on PR #4632: URL: https://github.com/apache/hadoop/pull/4632#issuecomment-1196044391 @goiri Can you help review the code? Do I need to split this PR? Thank you very much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
