[GitHub] [hadoop] slfan1989 commented on pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.
slfan1989 commented on PR #4846: URL: https://github.com/apache/hadoop/pull/4846#issuecomment-1260032750 @goiri Thank you very much for your help reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.
slfan1989 commented on PR #4846: URL: https://github.com/apache/hadoop/pull/4846#issuecomment-1259987263 @goiri Can you help merge this pr into trunk branch? Thank you very much! after this pr is completed, I will submit a new pr to clean up the completed application in the router's StateStore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.
slfan1989 commented on PR #4846: URL: https://github.com/apache/hadoop/pull/4846#issuecomment-1248591269 @goiri Please help to review the code again, thank you very much! Error in TestLogAggregationService in unit test, I have submitted pr separately to fix. (https://github.com/apache/hadoop/pull/4893) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.
slfan1989 commented on PR #4846: URL: https://github.com/apache/hadoop/pull/4846#issuecomment-1245869268 @goiri Please help to review the code again, thank you very much! I have provided a test report, we can refer to the following link https://issues.apache.org/jira/secure/attachment/13049175/Improve%20Query%20Condition%20of%20FederationStateStore%23getApplicationsHomeSubCluster%20Test%20Report.pdf MySQL We need 5.7 and above - [ ] MySQL 5.7 - [ ] MySQL 8.0 SQLServer - [ ] SQL Server 2008 R2 Enterprise - [ ] SQL Server 2012 Enterprise - [ ] SQL Server 2016 Enterprise - [ ] SQL Server 2017 Enterprise - [ ] SQL Server 2019 Enterprise -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.
slfan1989 commented on PR #4846: URL: https://github.com/apache/hadoop/pull/4846#issuecomment-1238308788 @goiri Please help to review the code again, thank you very much! This PR changes the execution script of the stored procedure, I will check the script against the major version of the database. **SQLServer** The change script of the stored procedure has been verified on SQL Server 2012 Enterprise And SQL Server 2008 R2 Enterprise, I will verify it on the following version as soon as possible - [ ] SQL Server 2008 R2 Enterprise - [ ] SQL Server 2012 Enterprise SQL Server 2016 Enterprise SQL Server 2017 Enterprise SQL Server 2019 Enterprise **MySQL** MySQL 5.7 and above must be required, MySQL 5.5 and MySQL 5.6 cannot be supported. MySQL-5.5 and MySQL-5.6 Can't Create Table membership and policies, for the following reasons: 1.The primary key of the membership table is subClusterId varchar(256) , Mysql will prompt the following error: Specified key was too long; max key length is 767 bytes. 2.The primary key of the policies table is subClusterId varchar(256) , Mysql will prompt the following error: Specified key was too long; max key length is 767 bytes. - [ ] MySQL 5.7 - [ ] MySQL 8.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.
slfan1989 commented on PR #4846: URL: https://github.com/apache/hadoop/pull/4846#issuecomment-1237189620 @goiri Please help to review the code again, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on pull request #4846: YARN-11290. Improve Query Condition of FederationStateStore#getApplicationsHomeSubCluster.
slfan1989 commented on PR #4846: URL: https://github.com/apache/hadoop/pull/4846#issuecomment-1236511195 This PR changes the execution script of the stored procedure, I will check the script against the major version of the database. SQL Server The change script of the stored procedure has been verified on SQL Server 2012 Enterprise, I will verify it on the following version as soon as possible - SQL Server 2008 R2 Enterprise - SQL Server 2016 Enterprise - SQL Server 2017 Enterprise - SQL Server 2019 Enterprise MySQL - MySQL 5.5 - MySQL 5.6 - MySQL 5.7 - MySQL 8.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
