[GitHub] [hadoop] snvijaya commented on a change in pull request #3335: HADOOP-17864. ABFS: Make provision for adding additional connections type

2021-09-03 Thread GitBox


snvijaya commented on a change in pull request #3335:
URL: https://github.com/apache/hadoop/pull/3335#discussion_r701923387



##
File path: 
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpConnection.java
##
@@ -0,0 +1,367 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.azurebfs.services;
+
+import java.io.DataInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.net.HttpURLConnection;
+import java.net.URL;
+import java.util.List;
+import java.util.Map;
+
+import javax.net.ssl.HttpsURLConnection;
+import javax.net.ssl.SSLSocketFactory;
+
+import org.codehaus.jackson.JsonFactory;
+import org.codehaus.jackson.JsonParser;
+import org.codehaus.jackson.JsonToken;
+import org.codehaus.jackson.map.ObjectMapper;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.security.ssl.DelegatingSSLSocketFactory;
+import org.apache.hadoop.fs.azurebfs.constants.AbfsHttpConstants;
+import org.apache.hadoop.fs.azurebfs.constants.HttpHeaderConfigurations;
+import org.apache.hadoop.fs.azurebfs.contracts.services.ListResultSchema;
+
+public class AbfsHttpConnection extends AbfsHttpOperation {
+  private static final Logger LOG = 
LoggerFactory.getLogger(AbfsHttpOperation.class);
+  private HttpURLConnection connection;
+  private ListResultSchema listResultSchema = null;
+
+  public AbfsHttpConnection(final URL url,
+  final String method,
+  List requestHeaders) throws IOException {
+super(url, method);
+init(method, requestHeaders);
+  }
+
+  /**
+   * Initializes a new HTTP request and opens the connection.
+   *
+   * @param method The HTTP method (PUT, PATCH, POST, GET, HEAD, or DELETE).
+   * @param requestHeaders The HTTP request headers.READ_TIMEOUT
+   *
+   * @throws IOException if an error occurs.
+   */
+  public void init(final String method, List requestHeaders)
+  throws IOException {
+this.connection = openConnection();
+if (this.connection instanceof HttpsURLConnection) {
+  HttpsURLConnection secureConn = (HttpsURLConnection) this.connection;
+  SSLSocketFactory sslSocketFactory = 
DelegatingSSLSocketFactory.getDefaultFactory();
+  if (sslSocketFactory != null) {
+secureConn.setSSLSocketFactory(sslSocketFactory);
+  }
+}
+
+this.connection.setConnectTimeout(getConnectTimeout());
+this.connection.setReadTimeout(getReadTimeout());
+
+this.connection.setRequestMethod(method);
+
+for (AbfsHttpHeader header : requestHeaders) {
+  this.connection.setRequestProperty(header.getName(), header.getValue());
+}
+  }
+
+  public HttpURLConnection getConnection() {
+return connection;
+  }
+
+  public ListResultSchema getListResultSchema() {
+return listResultSchema;
+  }
+
+  public String getResponseHeader(String httpHeader) {
+return connection.getHeaderField(httpHeader);
+  }
+
+  public void setHeader(String header, String value) {
+this.getConnection().setRequestProperty(header, value);
+  }
+
+  public Map> getRequestHeaders() {
+return getConnection().getRequestProperties();
+  }
+
+  public String getRequestHeader(String header) {
+return getConnection().getRequestProperty(header);
+  }
+
+  public String getClientRequestId() {
+return this.connection
+.getRequestProperty(HttpHeaderConfigurations.X_MS_CLIENT_REQUEST_ID);
+  }
+  /**
+   * Sends the HTTP request.  Note that HttpUrlConnection requires that an
+   * empty buffer be sent in order to set the "Content-Length: 0" header, which
+   * is required by our endpoint.
+   *
+   * @param buffer the request entity body.
+   * @param offset an offset into the buffer where the data beings.
+   * @param length the length of the data in the buffer.
+   *
+   * @throws IOException if an error occurs.
+   */
+  public void sendRequest(byte[] buffer, int offset, int length) throws 
IOException {
+this.connection.setDoOutput(true);
+this.connection.setFixedLengthStreamingMode(length);
+if (buffer == null) {
+  // An empty buffer is sent to set the "Content-Length: 0" header, which
+  // is 

[GitHub] [hadoop] snvijaya commented on a change in pull request #3335: HADOOP-17864. ABFS: Make provision for adding additional connections type

2021-09-03 Thread GitBox


snvijaya commented on a change in pull request #3335:
URL: https://github.com/apache/hadoop/pull/3335#discussion_r701921089



##
File path: 
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpConnection.java
##
@@ -0,0 +1,367 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.azurebfs.services;
+
+import java.io.DataInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.net.HttpURLConnection;
+import java.net.URL;
+import java.util.List;
+import java.util.Map;
+
+import javax.net.ssl.HttpsURLConnection;
+import javax.net.ssl.SSLSocketFactory;
+
+import org.codehaus.jackson.JsonFactory;
+import org.codehaus.jackson.JsonParser;
+import org.codehaus.jackson.JsonToken;
+import org.codehaus.jackson.map.ObjectMapper;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.security.ssl.DelegatingSSLSocketFactory;
+import org.apache.hadoop.fs.azurebfs.constants.AbfsHttpConstants;
+import org.apache.hadoop.fs.azurebfs.constants.HttpHeaderConfigurations;
+import org.apache.hadoop.fs.azurebfs.contracts.services.ListResultSchema;
+
+public class AbfsHttpConnection extends AbfsHttpOperation {
+  private static final Logger LOG = 
LoggerFactory.getLogger(AbfsHttpOperation.class);
+  private HttpURLConnection connection;
+  private ListResultSchema listResultSchema = null;
+
+  public AbfsHttpConnection(final URL url,
+  final String method,
+  List requestHeaders) throws IOException {
+super(url, method);
+init(method, requestHeaders);
+  }
+
+  /**
+   * Initializes a new HTTP request and opens the connection.
+   *
+   * @param method The HTTP method (PUT, PATCH, POST, GET, HEAD, or DELETE).
+   * @param requestHeaders The HTTP request headers.READ_TIMEOUT
+   *
+   * @throws IOException if an error occurs.
+   */
+  public void init(final String method, List requestHeaders)
+  throws IOException {
+this.connection = openConnection();
+if (this.connection instanceof HttpsURLConnection) {
+  HttpsURLConnection secureConn = (HttpsURLConnection) this.connection;
+  SSLSocketFactory sslSocketFactory = 
DelegatingSSLSocketFactory.getDefaultFactory();
+  if (sslSocketFactory != null) {
+secureConn.setSSLSocketFactory(sslSocketFactory);
+  }
+}
+
+this.connection.setConnectTimeout(getConnectTimeout());
+this.connection.setReadTimeout(getReadTimeout());
+
+this.connection.setRequestMethod(method);
+
+for (AbfsHttpHeader header : requestHeaders) {
+  this.connection.setRequestProperty(header.getName(), header.getValue());
+}
+  }
+
+  public HttpURLConnection getConnection() {
+return connection;
+  }
+
+  public ListResultSchema getListResultSchema() {
+return listResultSchema;
+  }
+
+  public String getResponseHeader(String httpHeader) {
+return connection.getHeaderField(httpHeader);
+  }
+
+  public void setHeader(String header, String value) {
+this.getConnection().setRequestProperty(header, value);
+  }
+
+  public Map> getRequestHeaders() {
+return getConnection().getRequestProperties();
+  }
+
+  public String getRequestHeader(String header) {
+return getConnection().getRequestProperty(header);
+  }
+
+  public String getClientRequestId() {
+return this.connection
+.getRequestProperty(HttpHeaderConfigurations.X_MS_CLIENT_REQUEST_ID);
+  }
+  /**
+   * Sends the HTTP request.  Note that HttpUrlConnection requires that an
+   * empty buffer be sent in order to set the "Content-Length: 0" header, which
+   * is required by our endpoint.
+   *
+   * @param buffer the request entity body.
+   * @param offset an offset into the buffer where the data beings.
+   * @param length the length of the data in the buffer.
+   *
+   * @throws IOException if an error occurs.
+   */
+  public void sendRequest(byte[] buffer, int offset, int length) throws 
IOException {
+this.connection.setDoOutput(true);
+this.connection.setFixedLengthStreamingMode(length);
+if (buffer == null) {
+  // An empty buffer is sent to set the "Content-Length: 0" header, which
+  // is 

[GitHub] [hadoop] snvijaya commented on a change in pull request #3335: HADOOP-17864. ABFS: Make provision for adding additional connections type

2021-09-03 Thread GitBox


snvijaya commented on a change in pull request #3335:
URL: https://github.com/apache/hadoop/pull/3335#discussion_r701920531



##
File path: 
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpConnection.java
##
@@ -0,0 +1,367 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.azurebfs.services;
+
+import java.io.DataInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.net.HttpURLConnection;
+import java.net.URL;
+import java.util.List;
+import java.util.Map;
+
+import javax.net.ssl.HttpsURLConnection;
+import javax.net.ssl.SSLSocketFactory;
+
+import org.codehaus.jackson.JsonFactory;
+import org.codehaus.jackson.JsonParser;
+import org.codehaus.jackson.JsonToken;
+import org.codehaus.jackson.map.ObjectMapper;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.security.ssl.DelegatingSSLSocketFactory;
+import org.apache.hadoop.fs.azurebfs.constants.AbfsHttpConstants;
+import org.apache.hadoop.fs.azurebfs.constants.HttpHeaderConfigurations;
+import org.apache.hadoop.fs.azurebfs.contracts.services.ListResultSchema;
+
+public class AbfsHttpConnection extends AbfsHttpOperation {
+  private static final Logger LOG = 
LoggerFactory.getLogger(AbfsHttpOperation.class);
+  private HttpURLConnection connection;
+  private ListResultSchema listResultSchema = null;
+
+  public AbfsHttpConnection(final URL url,
+  final String method,
+  List requestHeaders) throws IOException {
+super(url, method);
+init(method, requestHeaders);
+  }
+
+  /**
+   * Initializes a new HTTP request and opens the connection.
+   *
+   * @param method The HTTP method (PUT, PATCH, POST, GET, HEAD, or DELETE).
+   * @param requestHeaders The HTTP request headers.READ_TIMEOUT
+   *
+   * @throws IOException if an error occurs.
+   */
+  public void init(final String method, List requestHeaders)
+  throws IOException {
+this.connection = openConnection();
+if (this.connection instanceof HttpsURLConnection) {
+  HttpsURLConnection secureConn = (HttpsURLConnection) this.connection;
+  SSLSocketFactory sslSocketFactory = 
DelegatingSSLSocketFactory.getDefaultFactory();
+  if (sslSocketFactory != null) {
+secureConn.setSSLSocketFactory(sslSocketFactory);
+  }
+}
+
+this.connection.setConnectTimeout(getConnectTimeout());
+this.connection.setReadTimeout(getReadTimeout());
+
+this.connection.setRequestMethod(method);
+
+for (AbfsHttpHeader header : requestHeaders) {
+  this.connection.setRequestProperty(header.getName(), header.getValue());
+}
+  }
+
+  public HttpURLConnection getConnection() {
+return connection;
+  }
+
+  public ListResultSchema getListResultSchema() {
+return listResultSchema;
+  }
+
+  public String getResponseHeader(String httpHeader) {
+return connection.getHeaderField(httpHeader);
+  }
+
+  public void setHeader(String header, String value) {
+this.getConnection().setRequestProperty(header, value);
+  }
+
+  public Map> getRequestHeaders() {
+return getConnection().getRequestProperties();
+  }
+
+  public String getRequestHeader(String header) {
+return getConnection().getRequestProperty(header);
+  }
+
+  public String getClientRequestId() {
+return this.connection
+.getRequestProperty(HttpHeaderConfigurations.X_MS_CLIENT_REQUEST_ID);
+  }
+  /**
+   * Sends the HTTP request.  Note that HttpUrlConnection requires that an
+   * empty buffer be sent in order to set the "Content-Length: 0" header, which
+   * is required by our endpoint.
+   *
+   * @param buffer the request entity body.
+   * @param offset an offset into the buffer where the data beings.
+   * @param length the length of the data in the buffer.
+   *
+   * @throws IOException if an error occurs.
+   */
+  public void sendRequest(byte[] buffer, int offset, int length) throws 
IOException {
+this.connection.setDoOutput(true);
+this.connection.setFixedLengthStreamingMode(length);
+if (buffer == null) {
+  // An empty buffer is sent to set the "Content-Length: 0" header, which
+  // is 

[GitHub] [hadoop] snvijaya commented on a change in pull request #3335: HADOOP-17864. ABFS: Make provision for adding additional connections type

2021-09-03 Thread GitBox


snvijaya commented on a change in pull request #3335:
URL: https://github.com/apache/hadoop/pull/3335#discussion_r701917138



##
File path: 
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpConnection.java
##
@@ -0,0 +1,367 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.azurebfs.services;
+
+import java.io.DataInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.net.HttpURLConnection;
+import java.net.URL;
+import java.util.List;
+import java.util.Map;
+
+import javax.net.ssl.HttpsURLConnection;
+import javax.net.ssl.SSLSocketFactory;
+
+import org.codehaus.jackson.JsonFactory;
+import org.codehaus.jackson.JsonParser;
+import org.codehaus.jackson.JsonToken;
+import org.codehaus.jackson.map.ObjectMapper;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.security.ssl.DelegatingSSLSocketFactory;
+import org.apache.hadoop.fs.azurebfs.constants.AbfsHttpConstants;
+import org.apache.hadoop.fs.azurebfs.constants.HttpHeaderConfigurations;
+import org.apache.hadoop.fs.azurebfs.contracts.services.ListResultSchema;
+
+public class AbfsHttpConnection extends AbfsHttpOperation {
+  private static final Logger LOG = 
LoggerFactory.getLogger(AbfsHttpOperation.class);
+  private HttpURLConnection connection;
+  private ListResultSchema listResultSchema = null;
+
+  public AbfsHttpConnection(final URL url,
+  final String method,
+  List requestHeaders) throws IOException {
+super(url, method);
+init(method, requestHeaders);
+  }
+
+  /**
+   * Initializes a new HTTP request and opens the connection.
+   *
+   * @param method The HTTP method (PUT, PATCH, POST, GET, HEAD, or DELETE).
+   * @param requestHeaders The HTTP request headers.READ_TIMEOUT
+   *
+   * @throws IOException if an error occurs.
+   */
+  public void init(final String method, List requestHeaders)
+  throws IOException {
+this.connection = openConnection();
+if (this.connection instanceof HttpsURLConnection) {
+  HttpsURLConnection secureConn = (HttpsURLConnection) this.connection;
+  SSLSocketFactory sslSocketFactory = 
DelegatingSSLSocketFactory.getDefaultFactory();
+  if (sslSocketFactory != null) {
+secureConn.setSSLSocketFactory(sslSocketFactory);
+  }
+}
+
+this.connection.setConnectTimeout(getConnectTimeout());
+this.connection.setReadTimeout(getReadTimeout());
+
+this.connection.setRequestMethod(method);
+
+for (AbfsHttpHeader header : requestHeaders) {
+  this.connection.setRequestProperty(header.getName(), header.getValue());
+}
+  }
+
+  public HttpURLConnection getConnection() {
+return connection;
+  }
+
+  public ListResultSchema getListResultSchema() {
+return listResultSchema;
+  }
+
+  public String getResponseHeader(String httpHeader) {
+return connection.getHeaderField(httpHeader);
+  }
+
+  public void setHeader(String header, String value) {
+this.getConnection().setRequestProperty(header, value);
+  }
+
+  public Map> getRequestHeaders() {
+return getConnection().getRequestProperties();
+  }
+
+  public String getRequestHeader(String header) {
+return getConnection().getRequestProperty(header);
+  }
+
+  public String getClientRequestId() {
+return this.connection
+.getRequestProperty(HttpHeaderConfigurations.X_MS_CLIENT_REQUEST_ID);
+  }
+  /**
+   * Sends the HTTP request.  Note that HttpUrlConnection requires that an
+   * empty buffer be sent in order to set the "Content-Length: 0" header, which
+   * is required by our endpoint.
+   *
+   * @param buffer the request entity body.
+   * @param offset an offset into the buffer where the data beings.
+   * @param length the length of the data in the buffer.
+   *
+   * @throws IOException if an error occurs.
+   */
+  public void sendRequest(byte[] buffer, int offset, int length) throws 
IOException {
+this.connection.setDoOutput(true);
+this.connection.setFixedLengthStreamingMode(length);
+if (buffer == null) {
+  // An empty buffer is sent to set the "Content-Length: 0" header, which
+  // is 

[GitHub] [hadoop] snvijaya commented on a change in pull request #3335: HADOOP-17864. ABFS: Make provision for adding additional connections type

2021-09-03 Thread GitBox


snvijaya commented on a change in pull request #3335:
URL: https://github.com/apache/hadoop/pull/3335#discussion_r701916259



##
File path: 
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpConnection.java
##
@@ -0,0 +1,367 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.azurebfs.services;
+
+import java.io.DataInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.net.HttpURLConnection;
+import java.net.URL;
+import java.util.List;
+import java.util.Map;
+
+import javax.net.ssl.HttpsURLConnection;
+import javax.net.ssl.SSLSocketFactory;
+
+import org.codehaus.jackson.JsonFactory;
+import org.codehaus.jackson.JsonParser;
+import org.codehaus.jackson.JsonToken;
+import org.codehaus.jackson.map.ObjectMapper;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.security.ssl.DelegatingSSLSocketFactory;
+import org.apache.hadoop.fs.azurebfs.constants.AbfsHttpConstants;
+import org.apache.hadoop.fs.azurebfs.constants.HttpHeaderConfigurations;
+import org.apache.hadoop.fs.azurebfs.contracts.services.ListResultSchema;
+
+public class AbfsHttpConnection extends AbfsHttpOperation {
+  private static final Logger LOG = 
LoggerFactory.getLogger(AbfsHttpOperation.class);
+  private HttpURLConnection connection;
+  private ListResultSchema listResultSchema = null;
+
+  public AbfsHttpConnection(final URL url,
+  final String method,
+  List requestHeaders) throws IOException {
+super(url, method);
+init(method, requestHeaders);
+  }
+
+  /**
+   * Initializes a new HTTP request and opens the connection.
+   *
+   * @param method The HTTP method (PUT, PATCH, POST, GET, HEAD, or DELETE).
+   * @param requestHeaders The HTTP request headers.READ_TIMEOUT
+   *
+   * @throws IOException if an error occurs.
+   */
+  public void init(final String method, List requestHeaders)
+  throws IOException {
+this.connection = openConnection();

Review comment:
   Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[GitHub] [hadoop] snvijaya commented on a change in pull request #3335: HADOOP-17864. ABFS: Make provision for adding additional connections type

2021-09-03 Thread GitBox


snvijaya commented on a change in pull request #3335:
URL: https://github.com/apache/hadoop/pull/3335#discussion_r701913006



##
File path: 
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpConnection.java
##
@@ -0,0 +1,367 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.azurebfs.services;
+
+import java.io.DataInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.net.HttpURLConnection;
+import java.net.URL;
+import java.util.List;
+import java.util.Map;
+
+import javax.net.ssl.HttpsURLConnection;
+import javax.net.ssl.SSLSocketFactory;
+
+import org.codehaus.jackson.JsonFactory;

Review comment:
   ABFS Driver dependency on com.fasterxml.jackson.core was replaced with 
org.codehaus.jackson in 
[HADOOP-15659](https://issues.apache.org/jira/browse/HADOOP-15659). @DadanielZ 
, Could you please help with the reason for this ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org