steveloughran commented on a change in pull request #1956:
URL: https://github.com/apache/hadoop/pull/1956#discussion_r411477050
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java
##########
@@ -61,21 +61,19 @@
private boolean closed = false;
public AbfsInputStream(
- final AbfsClient client,
- final Statistics statistics,
- final String path,
- final long contentLength,
- final int bufferSize,
- final int readAheadQueueDepth,
- final boolean tolerateOobAppends,
- final String eTag) {
+ final AbfsClient client,
+ final Statistics statistics,
+ final String path,
+ final long contentLength,
+ AbfsInputStreamContext abfsInputStreamContext,
Review comment:
for consistency, mark as `final`. I know, it's not that significant in a
constructor, but it just keeps things the same.
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsOutputStreamContext.java
##########
@@ -0,0 +1,68 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.azurebfs.services;
+
+/**
+ * Class to hold extra output stream configs.
+ */
+public class AbfsOutputStreamContext extends AbfsStreamContext {
+
+ private int writeBufferSize;
+
+ private boolean enableFlush;
+
+ private boolean disableOutputStreamFlush;
+
+ public AbfsOutputStreamContext() {
+ }
+
+ public AbfsOutputStreamContext withWriteBufferSize(
+ final int writeBufferSize) {
+ this.writeBufferSize = writeBufferSize;
+ return this;
+ }
+
+ public AbfsOutputStreamContext enableFlush(final boolean enableFlush) {
+ this.enableFlush = enableFlush;
+ return this;
+ }
+
+ public AbfsOutputStreamContext disableOutputStreamFlush(
+ final boolean disableOutputStreamFlush) {
+ this.disableOutputStreamFlush = disableOutputStreamFlush;
+ return this;
+ }
+
+ public AbfsOutputStreamContext build() {
+ // Validation of parameters to be done here.
+ return this;
Review comment:
do we need any validators here yet, or is there enough in the code as it
is?
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStreamContext.java
##########
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.azurebfs.services;
+
+/**
+ * Class to hold extra input stream configs.
+ */
+public class AbfsInputStreamContext extends AbfsStreamContext {
+
+ private int readBufferSize;
+
+ private int readAheadQueueDepth;
+
+ private boolean tolerateOobAppends;
+
+ public AbfsInputStreamContext() {
+ }
+
+ public AbfsInputStreamContext withReadBufferSize(final int readBufferSize) {
+ this.readBufferSize = readBufferSize;
+ return this;
+ }
+
+ public AbfsInputStreamContext withReadAheadQueueDepth(
+ final int readAheadQueueDepth) {
+ this.readAheadQueueDepth = (readAheadQueueDepth >= 0)
+ ? readAheadQueueDepth
+ : Runtime.getRuntime().availableProcessors();;
Review comment:
trailing ;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
