[GitHub] [hadoop] steveloughran commented on issue #1587: HADOOP-16626. S3A ITestRestrictedReadAccess fails
steveloughran commented on issue #1587: HADOOP-16626. S3A ITestRestrictedReadAccess fails URL: https://github.com/apache/hadoop/pull/1587#issuecomment-538643344 merged. And I have learned some facts about Configuration that I didn't want to. Someone should update the javadocs there...or we add the notion of tombstone markers in the config :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1587: HADOOP-16626. S3A ITestRestrictedReadAccess fails
steveloughran commented on issue #1587: HADOOP-16626. S3A ITestRestrictedReadAccess fails URL: https://github.com/apache/hadoop/pull/1587#issuecomment-538643059 thx. will merge; then rebase #1601 on top and use the same explicit disabling of the metastore to ensure test runs always validate the unguarded path there too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1587: HADOOP-16626. S3A ITestRestrictedReadAccess fails
steveloughran commented on issue #1587: HADOOP-16626. S3A ITestRestrictedReadAccess fails URL: https://github.com/apache/hadoop/pull/1587#issuecomment-538521306 latest patch skips all the s3guard test runs if the store is local; you must be running with DDB enabled for it to work. That is runs without anything or with only -Ds3guard will only run one of the tests; the other two should be reported as skipped. To get all three -run with -dynamo Made sure there were no DDB bindings in my auth keys files to verify that things are good This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1587: HADOOP-16626. S3A ITestRestrictedReadAccess fails
steveloughran commented on issue #1587: HADOOP-16626. S3A ITestRestrictedReadAccess fails URL: https://github.com/apache/hadoop/pull/1587#issuecomment-538315035 oh, and it does work for me: -Dit.test=ITestRestrictedReadAccess -Ds3guard I am going to go to only running the guarded tests if -Ds3guard -Ddynamo is set This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1587: HADOOP-16626. S3A ITestRestrictedReadAccess fails
steveloughran commented on issue #1587: HADOOP-16626. S3A ITestRestrictedReadAccess fails URL: https://github.com/apache/hadoop/pull/1587#issuecomment-538314567 * we are unsetting any bucket-specific choices of s3guard, so that even when people (me) have it enabled you explicitly * the problem I've tried to fix was the discovery that Filesyste.get() triggered the load of things like HdfsConfiguration, it's adding of hdfs-default.xml , which then reinstated the unset options * If any XML resource is added to any config created with default resources, all options from core-default, core-site which had been unset are reinstated* Which of course is entirely unexpected. Having a look at why things are failing for you, -Ds3guard -Dlocal had been fine for me. I had problems with this when changing the test because you need to share the same local store instance across the real fs and the restricted one -otherwise the restricted one's cache is empty, so it falls back to s3 checks. I may just change the test so that it requires s3guard + ddb set on the maven command line to run those guarded tests, and not worry about the local one at all. It's just complicating things too much and *especially given the local store cannot be used in production* This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1587: HADOOP-16626. S3A ITestRestrictedReadAccess fails
steveloughran commented on issue #1587: HADOOP-16626. S3A ITestRestrictedReadAccess fails URL: https://github.com/apache/hadoop/pull/1587#issuecomment-538112086 Testing s3a ireland -a full run of everything (kicking off another) with s3guard and ddb -this test suite with s3guard off, on and local. Verifying that without s3guard, the guarded versions of the tests are not executed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
