[GitHub] [hadoop] sunchao commented on pull request #2080: HDFS-15417. RBF: Get the datanode report from cache for federation WebHDFS operations
sunchao commented on pull request #2080: URL: https://github.com/apache/hadoop/pull/2080#issuecomment-654509964 Merged. Thanks @NickyYe for the contribution and @Hexiaoqiao for helping review! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] sunchao commented on pull request #2080: HDFS-15417. RBF: Get the datanode report from cache for federation WebHDFS operations
sunchao commented on pull request #2080: URL: https://github.com/apache/hadoop/pull/2080#issuecomment-652780154 Any update @NickyYe ? we are pretty close to get this in with the UT. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] sunchao commented on pull request #2080: HDFS-15417. RBF: Get the datanode report from cache for federation WebHDFS operations
sunchao commented on pull request #2080: URL: https://github.com/apache/hadoop/pull/2080#issuecomment-648979719 Thanks @Hexiaoqiao . Similarly, in our case we also disabled this for router metrics but need webhdfs on router. Relying on `getDatanodeReport` is not the ideal approach but this PR is a step-up on the existing approach. @NickyYe thanks for addressing the checkstyle issue. Could you also add a unit test as well? I think we need one for `getCachedDatanodeReport`. You can add it in `TestRouterRpc` and verify the cache refresh logic. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
