[GitHub] [hadoop] symious commented on pull request #3638: HDFS-16313. Add metrics for each subcluster
symious commented on pull request #3638: URL: https://github.com/apache/hadoop/pull/3638#issuecomment-967221346 @goiri @ferhui Updated to use NameserviceRPCMetrics, please help to check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] symious commented on pull request #3638: HDFS-16313. Add metrics for each subcluster
symious commented on pull request #3638: URL: https://github.com/apache/hadoop/pull/3638#issuecomment-965729191 @goiri I got the idea to use "subcluster" because of https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-hdfs-rbf/HDFSRouterFederation.html. I chose subcluster earlier because I thought compared to "FederationRPCMetrics", it might be easier for users to know that we are talking about the metrics of the underlayer of RBF to use "SubclusterRPCMetrics" than "NameserviceRPCMetrics". Both names would be fine to me, I'll make the change after there is an alignment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] symious commented on pull request #3638: HDFS-16313. Add metrics for each subcluster
symious commented on pull request #3638: URL: https://github.com/apache/hadoop/pull/3638#issuecomment-965041151 @goiri @ferhui Thanks for the review. Have aligned the terminology to use "subclusterName", please have a check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] symious commented on pull request #3638: HDFS-16313. Add metrics for each subcluster
symious commented on pull request #3638: URL: https://github.com/apache/hadoop/pull/3638#issuecomment-964274235 @goiri @ferhui Could you help to review the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
