[GitHub] [hadoop] viirya edited a comment on pull request #2297: HADOOP-17125. Using snappy-java in SnappyCodec
viirya edited a comment on pull request #2297: URL: https://github.com/apache/hadoop/pull/2297#issuecomment-704433770 Ok, got it. I will update release notes once it is back. Seems I cannot update Hadoop JIRA. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] viirya edited a comment on pull request #2297: HADOOP-17125. Using snappy-java in SnappyCodec
viirya edited a comment on pull request #2297: URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691712861 Checked the cc warnings and the related code. They are committed long time ago, e.g., 2014, and not touched here. Many of the cc warnings are `warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]`. I guess it is either due to that we didn't check such warnings when the code was committed, or compilation tools upgrade? I think it is not caused by this change. Because we removed some .c and .h files, so the CI build triggered related building. So I am not sure which one is good, fixing these compilation warnings, or ignoring them? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] viirya edited a comment on pull request #2297: HADOOP-17125. Using snappy-java in SnappyCodec
viirya edited a comment on pull request #2297: URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691330003 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] viirya edited a comment on pull request #2297: HADOOP-17125. Using snappy-java in SnappyCodec
viirya edited a comment on pull request #2297: URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691330003 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] viirya edited a comment on pull request #2297: HADOOP-17125. Using snappy-java in SnappyCodec
viirya edited a comment on pull request #2297: URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691330003 And I think for checkstyle, it is just a -0? For two cc links, I don't see any errors: cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/4/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt -- | -- cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/4/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt There are some warnings, but not related to the change here. Are they known issues? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] viirya edited a comment on pull request #2297: HADOOP-17125. Using snappy-java in SnappyCodec
viirya edited a comment on pull request #2297: URL: https://github.com/apache/hadoop/pull/2297#issuecomment-691330003 And I think for checkstyle, it is just a -0? For two cc links, I don't see any errors: cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/4/artifact/out/diff-compile-cc-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt -- | -- cc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2297/4/artifact/out/diff-compile-cc-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt There are some warnings, but not related to the change here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
