[GitHub] [hadoop] virajjasani commented on pull request #3362: HDFS-16199. Resolve log placeholders in NamenodeBeanMetrics
virajjasani commented on pull request #3362: URL: https://github.com/apache/hadoop/pull/3362#issuecomment-912527131 > It is debug log, Can we not just pass e as whole, rather than just printing the message, The trace might be more helpful while debugging? Nothing wrong with that, the only reason why I kept it `e.getMessage()` is because it was already in place, but yes since the error message is not getting printed anyways, let's keep entire stacktrace, sounds good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] virajjasani commented on pull request #3362: HDFS-16199. Resolve log placeholders in NamenodeBeanMetrics
virajjasani commented on pull request #3362: URL: https://github.com/apache/hadoop/pull/3362#issuecomment-912323906 FYI @aajisaka, Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] virajjasani commented on pull request #3362: HDFS-16199. Resolve log placeholders in NamenodeBeanMetrics
virajjasani commented on pull request #3362: URL: https://github.com/apache/hadoop/pull/3362#issuecomment-911492004 Thanks for the reviews @goiri @tomscut ! Could you please help merge the PR @goiri? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
