[jira] [Comment Edited] (HADOOP-14729) Upgrade JUnit 3 TestCase to JUnit 4

2017-08-23 Thread Ajay Kumar (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-14729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138904#comment-16138904
 ] 

Ajay Kumar edited comment on HADOOP-14729 at 8/23/17 7:17 PM:
--

[~ste...@apache.org], Revereted back changes for azure and s3 test class. Jira 
to track upgrade for TestS3NInMemoryFileSystem. [HADOOP-14803]


was (Author: ajayydv):
[~ste...@apache.org], Revereted back changes for azure and s3 test class. Jira 
to track upgrade for TestS3NInMemoryFileSystem. [#HADOOP-14803]

> Upgrade JUnit 3 TestCase to JUnit 4
> ---
>
> Key: HADOOP-14729
> URL: https://issues.apache.org/jira/browse/HADOOP-14729
> Project: Hadoop Common
>  Issue Type: Test
>Reporter: Akira Ajisaka
>Assignee: Ajay Kumar
>  Labels: newbie
> Attachments: HADOOP-14729.001.patch, HADOOP-14729.002.patch, 
> HADOOP-14729.003.patch, HADOOP-14729.004.patch, HADOOP-14729.005.patch, 
> HADOOP-14729.006.patch, HADOOP-14729.007.patch, HADOOP-14729.008.patch, 
> HADOOP-14729.009.patch, HADOOP-14729.010.patch, HADOOP-14729.011.patch
>
>
> There are still test classes that extend from junit.framework.TestCase in 
> hadoop-common. Upgrade them to JUnit4.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Comment Edited] (HADOOP-14729) Upgrade JUnit 3 TestCase to JUnit 4

2017-08-09 Thread Andras Bokor (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-14729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121086#comment-16121086
 ] 

Andras Bokor edited comment on HADOOP-14729 at 8/10/17 5:40 AM:


[~ajayydv],

It will not compile because {{TestMapFileOutputFormat}} (and some other 
classes) miss(es) the import of After annotation.
In addition, in your 2nd patch please use two spaces for indentation instead of 
tab.


was (Author: boky01):
[~ajayydv],

It will not compile because {{TestMapFileOutputFormat}} misses an import.
In your 2nd patch please use two spaces for indentation instead of tab.

> Upgrade JUnit 3 TestCase to JUnit 4
> ---
>
> Key: HADOOP-14729
> URL: https://issues.apache.org/jira/browse/HADOOP-14729
> Project: Hadoop Common
>  Issue Type: Test
>Reporter: Akira Ajisaka
>Assignee: Ajay Yadav
>  Labels: newbie
> Attachments: HADOOP-14729.001.patch
>
>
> There are still test classes that extend from junit.framework.TestCase in 
> hadoop-common. Upgrade them to JUnit4.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org