[jira] [Commented] (HADOOP-10044) Improve the javadoc of rpc code
[ https://issues.apache.org/jira/browse/HADOOP-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353482#comment-14353482 ] Yongjun Zhang commented on HADOOP-10044: Hi [~sanjay.radia], Thanks for your earlier work on this. I found that the commit of this jira is missing from branch-2. May I know if there is any concern of putting this to branch-2? Thanks. > Improve the javadoc of rpc code > --- > > Key: HADOOP-10044 > URL: https://issues.apache.org/jira/browse/HADOOP-10044 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Sanjay Radia >Assignee: Sanjay Radia >Priority: Minor > Attachments: HADOOP-10044.20131014.patch, hadoop-10044.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-10044) Improve the javadoc of rpc code
[ https://issues.apache.org/jira/browse/HADOOP-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847547#comment-13847547 ] Hudson commented on HADOOP-10044: - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1637 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1637/]) HADOOP-10044 Improve the javadoc of rpc code (sanjay Radia) (sradia: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1550486) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcConstants.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java > Improve the javadoc of rpc code > --- > > Key: HADOOP-10044 > URL: https://issues.apache.org/jira/browse/HADOOP-10044 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Sanjay Radia >Assignee: Sanjay Radia >Priority: Minor > Attachments: HADOOP-10044.20131014.patch, hadoop-10044.patch > > -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HADOOP-10044) Improve the javadoc of rpc code
[ https://issues.apache.org/jira/browse/HADOOP-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847487#comment-13847487 ] Hudson commented on HADOOP-10044: - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1611 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1611/]) HADOOP-10044 Improve the javadoc of rpc code (sanjay Radia) (sradia: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1550486) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcConstants.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java > Improve the javadoc of rpc code > --- > > Key: HADOOP-10044 > URL: https://issues.apache.org/jira/browse/HADOOP-10044 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Sanjay Radia >Assignee: Sanjay Radia >Priority: Minor > Attachments: HADOOP-10044.20131014.patch, hadoop-10044.patch > > -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HADOOP-10044) Improve the javadoc of rpc code
[ https://issues.apache.org/jira/browse/HADOOP-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847401#comment-13847401 ] Hudson commented on HADOOP-10044: - FAILURE: Integrated in Hadoop-Yarn-trunk #420 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/420/]) HADOOP-10044 Improve the javadoc of rpc code (sanjay Radia) (sradia: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1550486) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcConstants.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java > Improve the javadoc of rpc code > --- > > Key: HADOOP-10044 > URL: https://issues.apache.org/jira/browse/HADOOP-10044 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Sanjay Radia >Assignee: Sanjay Radia >Priority: Minor > Attachments: HADOOP-10044.20131014.patch, hadoop-10044.patch > > -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HADOOP-10044) Improve the javadoc of rpc code
[ https://issues.apache.org/jira/browse/HADOOP-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846602#comment-13846602 ] Hudson commented on HADOOP-10044: - SUCCESS: Integrated in Hadoop-trunk-Commit #4874 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4874/]) HADOOP-10044 Improve the javadoc of rpc code (sanjay Radia) (sradia: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1550486) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcConstants.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java > Improve the javadoc of rpc code > --- > > Key: HADOOP-10044 > URL: https://issues.apache.org/jira/browse/HADOOP-10044 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Sanjay Radia >Assignee: Sanjay Radia >Priority: Minor > Attachments: HADOOP-10044.20131014.patch, hadoop-10044.patch > > -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HADOOP-10044) Improve the javadoc of rpc code
[
https://issues.apache.org/jira/browse/HADOOP-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845752#comment-13845752
]
Hadoop QA commented on HADOOP-10044:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12608377/HADOOP-10044.20131014.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The following test timeouts occurred in
hadoop-common-project/hadoop-common:
org.apache.hadoop.http.TestHttpServer
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3356//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3356//console
This message is automatically generated.
> Improve the javadoc of rpc code
> ---
>
> Key: HADOOP-10044
> URL: https://issues.apache.org/jira/browse/HADOOP-10044
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Sanjay Radia
>Assignee: Sanjay Radia
>Priority: Minor
> Attachments: HADOOP-10044.20131014.patch, hadoop-10044.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HADOOP-10044) Improve the javadoc of rpc code
[
https://issues.apache.org/jira/browse/HADOOP-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13795002#comment-13795002
]
Steve Loughran commented on HADOOP-10044:
-
If the new javadocs have preformatted code, it should be wrapped with
{{}} tags, so that the generated javadocs look OK too
> Improve the javadoc of rpc code
> ---
>
> Key: HADOOP-10044
> URL: https://issues.apache.org/jira/browse/HADOOP-10044
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Sanjay Radia
>Assignee: Sanjay Radia
>Priority: Minor
> Attachments: HADOOP-10044.20131014.patch, hadoop-10044.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HADOOP-10044) Improve the javadoc of rpc code
[
https://issues.apache.org/jira/browse/HADOOP-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794682#comment-13794682
]
Hadoop QA commented on HADOOP-10044:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12608377/HADOOP-10044.20131014.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3214//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3214//console
This message is automatically generated.
> Improve the javadoc of rpc code
> ---
>
> Key: HADOOP-10044
> URL: https://issues.apache.org/jira/browse/HADOOP-10044
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Sanjay Radia
>Assignee: Sanjay Radia
>Priority: Minor
> Attachments: HADOOP-10044.20131014.patch, hadoop-10044.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HADOOP-10044) Improve the javadoc of rpc code
[ https://issues.apache.org/jira/browse/HADOOP-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793409#comment-13793409 ] Steve Loughran commented on HADOOP-10044: - +1 to a javadoc patch, but as someone who has recently done some RPC work, I think we need something that gives an overall view of how to implement RPC services. Particular troublespots for me * basics of registering a service, client proxy * why turning Simple auth on is a good feature during dev * moving to protobuf as a payload (why, how) * moving to protbuf RPC with the various relay proxies. Here the why really has to come before the how, as having done this once I think you really need a good reason to invest the effort. * security, delegation tokens, auth: basic services, then under YARN * failure modes, testing YARN is going to enable many more people to write distributed apps, which means more people trying to understand the RPC mechanism > Improve the javadoc of rpc code > --- > > Key: HADOOP-10044 > URL: https://issues.apache.org/jira/browse/HADOOP-10044 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Sanjay Radia >Assignee: Sanjay Radia >Priority: Minor > Attachments: hadoop-10044.patch > > -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-10044) Improve the javadoc of rpc code
[
https://issues.apache.org/jira/browse/HADOOP-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793199#comment-13793199
]
Hadoop QA commented on HADOOP-10044:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12608119/hadoop-10044.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3209//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3209//console
This message is automatically generated.
> Improve the javadoc of rpc code
> ---
>
> Key: HADOOP-10044
> URL: https://issues.apache.org/jira/browse/HADOOP-10044
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Sanjay Radia
>Assignee: Sanjay Radia
>Priority: Minor
> Attachments: hadoop-10044.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HADOOP-10044) Improve the javadoc of rpc code
[ https://issues.apache.org/jira/browse/HADOOP-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793139#comment-13793139 ] Sanjay Radia commented on HADOOP-10044: --- The hadoop rpc code especially the code in Server.java is fairly complicated and poorly documented. Everytime I make changes there or try and debug an issue, I have relearn parts of the code. The javadoc needs to be improved. > Improve the javadoc of rpc code > --- > > Key: HADOOP-10044 > URL: https://issues.apache.org/jira/browse/HADOOP-10044 > Project: Hadoop Common > Issue Type: Improvement >Reporter: Sanjay Radia >Assignee: Sanjay Radia >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.1#6144)
