[jira] [Commented] (HADOOP-10106) Incorrect thread name in RPC log messages
[ https://issues.apache.org/jira/browse/HADOOP-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870059#comment-13870059 ] Suresh Srinivas commented on HADOOP-10106: -- [~mingma], I have added you as a contributor and assigned the jira to you. > Incorrect thread name in RPC log messages > - > > Key: HADOOP-10106 > URL: https://issues.apache.org/jira/browse/HADOOP-10106 > Project: Hadoop Common > Issue Type: Bug >Reporter: Ming Ma >Assignee: Ming Ma >Priority: Minor > Fix For: 2.4.0 > > Attachments: hadoop_10106_trunk.patch, hadoop_10106_trunk_2.patch > > > INFO org.apache.hadoop.ipc.Server: IPC Server listener on 8020: > readAndProcess from client 10.115.201.46 threw exception > org.apache.hadoop.ipc.RpcServerException: Unknown out of band call > #-2147483647 > This is thrown by a reader thread, so the message should be like > INFO org.apache.hadoop.ipc.Server: Socket Reader #1 for port 8020: > readAndProcess from client 10.115.201.46 threw exception > org.apache.hadoop.ipc.RpcServerException: Unknown out of band call > #-2147483647 > Another example is Responder.processResponse, which can also be called by > handler thread. When that happend, the thread name should be the handler > thread, not the responder thread. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HADOOP-10106) Incorrect thread name in RPC log messages
[ https://issues.apache.org/jira/browse/HADOOP-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850532#comment-13850532 ] Hudson commented on HADOOP-10106: - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1641 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1641/]) HADOOP-10106. Incorrect thread name in RPC log messages. Contributed by Ming Ma. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551369) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java > Incorrect thread name in RPC log messages > - > > Key: HADOOP-10106 > URL: https://issues.apache.org/jira/browse/HADOOP-10106 > Project: Hadoop Common > Issue Type: Bug >Reporter: Ming Ma >Priority: Minor > Fix For: 2.4.0 > > Attachments: hadoop_10106_trunk.patch, hadoop_10106_trunk_2.patch > > > INFO org.apache.hadoop.ipc.Server: IPC Server listener on 8020: > readAndProcess from client 10.115.201.46 threw exception > org.apache.hadoop.ipc.RpcServerException: Unknown out of band call > #-2147483647 > This is thrown by a reader thread, so the message should be like > INFO org.apache.hadoop.ipc.Server: Socket Reader #1 for port 8020: > readAndProcess from client 10.115.201.46 threw exception > org.apache.hadoop.ipc.RpcServerException: Unknown out of band call > #-2147483647 > Another example is Responder.processResponse, which can also be called by > handler thread. When that happend, the thread name should be the handler > thread, not the responder thread. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HADOOP-10106) Incorrect thread name in RPC log messages
[ https://issues.apache.org/jira/browse/HADOOP-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850444#comment-13850444 ] Hudson commented on HADOOP-10106: - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1615 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1615/]) HADOOP-10106. Incorrect thread name in RPC log messages. Contributed by Ming Ma. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551369) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java > Incorrect thread name in RPC log messages > - > > Key: HADOOP-10106 > URL: https://issues.apache.org/jira/browse/HADOOP-10106 > Project: Hadoop Common > Issue Type: Bug >Reporter: Ming Ma >Priority: Minor > Fix For: 2.4.0 > > Attachments: hadoop_10106_trunk.patch, hadoop_10106_trunk_2.patch > > > INFO org.apache.hadoop.ipc.Server: IPC Server listener on 8020: > readAndProcess from client 10.115.201.46 threw exception > org.apache.hadoop.ipc.RpcServerException: Unknown out of band call > #-2147483647 > This is thrown by a reader thread, so the message should be like > INFO org.apache.hadoop.ipc.Server: Socket Reader #1 for port 8020: > readAndProcess from client 10.115.201.46 threw exception > org.apache.hadoop.ipc.RpcServerException: Unknown out of band call > #-2147483647 > Another example is Responder.processResponse, which can also be called by > handler thread. When that happend, the thread name should be the handler > thread, not the responder thread. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HADOOP-10106) Incorrect thread name in RPC log messages
[ https://issues.apache.org/jira/browse/HADOOP-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850348#comment-13850348 ] Hudson commented on HADOOP-10106: - FAILURE: Integrated in Hadoop-Yarn-trunk #424 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/424/]) HADOOP-10106. Incorrect thread name in RPC log messages. Contributed by Ming Ma. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551369) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java > Incorrect thread name in RPC log messages > - > > Key: HADOOP-10106 > URL: https://issues.apache.org/jira/browse/HADOOP-10106 > Project: Hadoop Common > Issue Type: Bug >Reporter: Ming Ma >Priority: Minor > Fix For: 2.4.0 > > Attachments: hadoop_10106_trunk.patch, hadoop_10106_trunk_2.patch > > > INFO org.apache.hadoop.ipc.Server: IPC Server listener on 8020: > readAndProcess from client 10.115.201.46 threw exception > org.apache.hadoop.ipc.RpcServerException: Unknown out of band call > #-2147483647 > This is thrown by a reader thread, so the message should be like > INFO org.apache.hadoop.ipc.Server: Socket Reader #1 for port 8020: > readAndProcess from client 10.115.201.46 threw exception > org.apache.hadoop.ipc.RpcServerException: Unknown out of band call > #-2147483647 > Another example is Responder.processResponse, which can also be called by > handler thread. When that happend, the thread name should be the handler > thread, not the responder thread. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HADOOP-10106) Incorrect thread name in RPC log messages
[ https://issues.apache.org/jira/browse/HADOOP-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13849784#comment-13849784 ] Hudson commented on HADOOP-10106: - SUCCESS: Integrated in Hadoop-trunk-Commit #4893 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4893/]) HADOOP-10106. Incorrect thread name in RPC log messages. Contributed by Ming Ma. (jing9: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551369) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java > Incorrect thread name in RPC log messages > - > > Key: HADOOP-10106 > URL: https://issues.apache.org/jira/browse/HADOOP-10106 > Project: Hadoop Common > Issue Type: Bug >Reporter: Ming Ma >Priority: Minor > Attachments: hadoop_10106_trunk.patch, hadoop_10106_trunk_2.patch > > > INFO org.apache.hadoop.ipc.Server: IPC Server listener on 8020: > readAndProcess from client 10.115.201.46 threw exception > org.apache.hadoop.ipc.RpcServerException: Unknown out of band call > #-2147483647 > This is thrown by a reader thread, so the message should be like > INFO org.apache.hadoop.ipc.Server: Socket Reader #1 for port 8020: > readAndProcess from client 10.115.201.46 threw exception > org.apache.hadoop.ipc.RpcServerException: Unknown out of band call > #-2147483647 > Another example is Responder.processResponse, which can also be called by > handler thread. When that happend, the thread name should be the handler > thread, not the responder thread. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HADOOP-10106) Incorrect thread name in RPC log messages
[ https://issues.apache.org/jira/browse/HADOOP-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13848037#comment-13848037 ] Sanjay Radia commented on HADOOP-10106: --- +1 > Incorrect thread name in RPC log messages > - > > Key: HADOOP-10106 > URL: https://issues.apache.org/jira/browse/HADOOP-10106 > Project: Hadoop Common > Issue Type: Bug >Reporter: Ming Ma >Priority: Minor > Attachments: hadoop_10106_trunk.patch, hadoop_10106_trunk_2.patch > > > INFO org.apache.hadoop.ipc.Server: IPC Server listener on 8020: > readAndProcess from client 10.115.201.46 threw exception > org.apache.hadoop.ipc.RpcServerException: Unknown out of band call > #-2147483647 > This is thrown by a reader thread, so the message should be like > INFO org.apache.hadoop.ipc.Server: Socket Reader #1 for port 8020: > readAndProcess from client 10.115.201.46 threw exception > org.apache.hadoop.ipc.RpcServerException: Unknown out of band call > #-2147483647 > Another example is Responder.processResponse, which can also be called by > handler thread. When that happend, the thread name should be the handler > thread, not the responder thread. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HADOOP-10106) Incorrect thread name in RPC log messages
[
https://issues.apache.org/jira/browse/HADOOP-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844346#comment-13844346
]
Hadoop QA commented on HADOOP-10106:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12618045/hadoop_10106_trunk_2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3352//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3352//console
This message is automatically generated.
> Incorrect thread name in RPC log messages
> -
>
> Key: HADOOP-10106
> URL: https://issues.apache.org/jira/browse/HADOOP-10106
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Ming Ma
>Priority: Minor
> Attachments: hadoop_10106_trunk.patch, hadoop_10106_trunk_2.patch
>
>
> INFO org.apache.hadoop.ipc.Server: IPC Server listener on 8020:
> readAndProcess from client 10.115.201.46 threw exception
> org.apache.hadoop.ipc.RpcServerException: Unknown out of band call
> #-2147483647
> This is thrown by a reader thread, so the message should be like
> INFO org.apache.hadoop.ipc.Server: Socket Reader #1 for port 8020:
> readAndProcess from client 10.115.201.46 threw exception
> org.apache.hadoop.ipc.RpcServerException: Unknown out of band call
> #-2147483647
> Another example is Responder.processResponse, which can also be called by
> handler thread. When that happend, the thread name should be the handler
> thread, not the responder thread.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HADOOP-10106) Incorrect thread name in RPC log messages
[ https://issues.apache.org/jira/browse/HADOOP-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843477#comment-13843477 ] Sanjay Radia commented on HADOOP-10106: --- Refactoring of code generally need to be done in separate Jira. Isn't the fixing of the thread name possible with the old structure? If so, I suggest that you do the refactoring in a separate jira. > Incorrect thread name in RPC log messages > - > > Key: HADOOP-10106 > URL: https://issues.apache.org/jira/browse/HADOOP-10106 > Project: Hadoop Common > Issue Type: Bug >Reporter: Ming Ma >Priority: Minor > Attachments: hadoop_10106_trunk.patch > > > INFO org.apache.hadoop.ipc.Server: IPC Server listener on 8020: > readAndProcess from client 10.115.201.46 threw exception > org.apache.hadoop.ipc.RpcServerException: Unknown out of band call > #-2147483647 > This is thrown by a reader thread, so the message should be like > INFO org.apache.hadoop.ipc.Server: Socket Reader #1 for port 8020: > readAndProcess from client 10.115.201.46 threw exception > org.apache.hadoop.ipc.RpcServerException: Unknown out of band call > #-2147483647 > Another example is Responder.processResponse, which can also be called by > handler thread. When that happend, the thread name should be the handler > thread, not the responder thread. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (HADOOP-10106) Incorrect thread name in RPC log messages
[ https://issues.apache.org/jira/browse/HADOOP-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841989#comment-13841989 ] Ming Ma commented on HADOOP-10106: -- Thanks, Sanjay. Moving doRead from Listener class to Reader class is another way to fix the specific issue found. When I was about to revert doRead, I feel like semantically wise it is better to have doRead be a member of Reader. So I includes it as part of the fix. What is the reason to keep doRead method under Listener class? > Incorrect thread name in RPC log messages > - > > Key: HADOOP-10106 > URL: https://issues.apache.org/jira/browse/HADOOP-10106 > Project: Hadoop Common > Issue Type: Bug >Reporter: Ming Ma >Priority: Minor > Attachments: hadoop_10106_trunk.patch > > > INFO org.apache.hadoop.ipc.Server: IPC Server listener on 8020: > readAndProcess from client 10.115.201.46 threw exception > org.apache.hadoop.ipc.RpcServerException: Unknown out of band call > #-2147483647 > This is thrown by a reader thread, so the message should be like > INFO org.apache.hadoop.ipc.Server: Socket Reader #1 for port 8020: > readAndProcess from client 10.115.201.46 threw exception > org.apache.hadoop.ipc.RpcServerException: Unknown out of band call > #-2147483647 > Another example is Responder.processResponse, which can also be called by > handler thread. When that happend, the thread name should be the handler > thread, not the responder thread. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-10106) Incorrect thread name in RPC log messages
[ https://issues.apache.org/jira/browse/HADOOP-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841665#comment-13841665 ] Sanjay Radia commented on HADOOP-10106: --- You seemed to have unnecessarily moved the doRead() function's location in the server.java file. Can you please leave it in its original place in the file and please resubmit the patch. > Incorrect thread name in RPC log messages > - > > Key: HADOOP-10106 > URL: https://issues.apache.org/jira/browse/HADOOP-10106 > Project: Hadoop Common > Issue Type: Bug >Reporter: Ming Ma >Priority: Minor > Attachments: hadoop_10106_trunk.patch > > > INFO org.apache.hadoop.ipc.Server: IPC Server listener on 8020: > readAndProcess from client 10.115.201.46 threw exception > org.apache.hadoop.ipc.RpcServerException: Unknown out of band call > #-2147483647 > This is thrown by a reader thread, so the message should be like > INFO org.apache.hadoop.ipc.Server: Socket Reader #1 for port 8020: > readAndProcess from client 10.115.201.46 threw exception > org.apache.hadoop.ipc.RpcServerException: Unknown out of band call > #-2147483647 > Another example is Responder.processResponse, which can also be called by > handler thread. When that happend, the thread name should be the handler > thread, not the responder thread. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-10106) Incorrect thread name in RPC log messages
[
https://issues.apache.org/jira/browse/HADOOP-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826961#comment-13826961
]
Hadoop QA commented on HADOOP-10106:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12614181/hadoop_10106_trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3299//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3299//console
This message is automatically generated.
> Incorrect thread name in RPC log messages
> -
>
> Key: HADOOP-10106
> URL: https://issues.apache.org/jira/browse/HADOOP-10106
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Ming Ma
>Priority: Minor
> Attachments: hadoop_10106_trunk.patch
>
>
> INFO org.apache.hadoop.ipc.Server: IPC Server listener on 8020:
> readAndProcess from client 10.115.201.46 threw exception
> org.apache.hadoop.ipc.RpcServerException: Unknown out of band call
> #-2147483647
> This is thrown by a reader thread, so the message should be like
> INFO org.apache.hadoop.ipc.Server: Socket Reader #1 for port 8020:
> readAndProcess from client 10.115.201.46 threw exception
> org.apache.hadoop.ipc.RpcServerException: Unknown out of band call
> #-2147483647
> Another example is Responder.processResponse, which can also be called by
> handler thread. When that happend, the thread name should be the handler
> thread, not the responder thread.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HADOOP-10106) Incorrect thread name in RPC log messages
[
https://issues.apache.org/jira/browse/HADOOP-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825811#comment-13825811
]
Hadoop QA commented on HADOOP-10106:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12614181/hadoop_10106_trunk.patch
against trunk revision .
{color:red}-1 patch{color}. Trunk compilation may be broken.
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3291//console
This message is automatically generated.
> Incorrect thread name in RPC log messages
> -
>
> Key: HADOOP-10106
> URL: https://issues.apache.org/jira/browse/HADOOP-10106
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.2.0
>Reporter: Ming Ma
>Priority: Minor
> Fix For: 3.0.0, 2.2.1
>
> Attachments: hadoop_10106_trunk.patch
>
>
> INFO org.apache.hadoop.ipc.Server: IPC Server listener on 8020:
> readAndProcess from client 10.115.201.46 threw exception
> org.apache.hadoop.ipc.RpcServerException: Unknown out of band call
> #-2147483647
> This is thrown by a reader thread, so the message should be like
> INFO org.apache.hadoop.ipc.Server: Socket Reader #1 for port 8020:
> readAndProcess from client 10.115.201.46 threw exception
> org.apache.hadoop.ipc.RpcServerException: Unknown out of band call
> #-2147483647
> Another example is Responder.processResponse, which can also be called by
> handler thread. When that happend, the thread name should be the handler
> thread, not the responder thread.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
