[jira] [Commented] (HADOOP-10250) VersionUtil returns wrong value when comparing two versions
[ https://issues.apache.org/jira/browse/HADOOP-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13947108#comment-13947108 ] Tsz Wo Nicholas Sze commented on HADOOP-10250: -- Hi [~yzhangal], why copying ComparableVersion but not importing it? VersionUtil returns wrong value when comparing two versions --- Key: HADOOP-10250 URL: https://issues.apache.org/jira/browse/HADOOP-10250 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.3.0 Reporter: Yongjun Zhang Assignee: Yongjun Zhang Fix For: 2.3.0 Attachments: HADOOP-10250.001.patch, HADOOP-10250.002.patch, HADOOP-10250.003.patch, HADOOP-10250.004.patch, HADOOP-10250.004.patch VersionUtil.compareVersions(1.0.0-beta-1, 1.0.0) returns 7 instead of negative number, which is wrong, because 1.0.0-beta-1 older than 1.0.0. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10250) VersionUtil returns wrong value when comparing two versions
[ https://issues.apache.org/jira/browse/HADOOP-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13947209#comment-13947209 ] Yongjun Zhang commented on HADOOP-10250: HI [~szetszwo], That's a very good question. I actually did try importing it in my earlier attempt, it turned out to be not clean, basically we need to import the whole package org.apache.maven.artifact.versioning though we just need this single file. Plus it would create hadoop dependency on maven (they have different version too). At that point, it was decided that to make a copy of this file is a cleaner and easier solution. I'm open for suggestions. Thanks. VersionUtil returns wrong value when comparing two versions --- Key: HADOOP-10250 URL: https://issues.apache.org/jira/browse/HADOOP-10250 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.3.0 Reporter: Yongjun Zhang Assignee: Yongjun Zhang Fix For: 2.3.0 Attachments: HADOOP-10250.001.patch, HADOOP-10250.002.patch, HADOOP-10250.003.patch, HADOOP-10250.004.patch, HADOOP-10250.004.patch VersionUtil.compareVersions(1.0.0-beta-1, 1.0.0) returns 7 instead of negative number, which is wrong, because 1.0.0-beta-1 older than 1.0.0. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10250) VersionUtil returns wrong value when comparing two versions
[ https://issues.apache.org/jira/browse/HADOOP-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885940#comment-13885940 ] Andrew Wang commented on HADOOP-10250: -- I merged this back to branch-2.3 post swizzle as well. VersionUtil returns wrong value when comparing two versions --- Key: HADOOP-10250 URL: https://issues.apache.org/jira/browse/HADOOP-10250 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.3.0 Reporter: Yongjun Zhang Assignee: Yongjun Zhang Fix For: 2.3.0 Attachments: HADOOP-10250.001.patch, HADOOP-10250.002.patch, HADOOP-10250.003.patch, HADOOP-10250.004.patch, HADOOP-10250.004.patch VersionUtil.compareVersions(1.0.0-beta-1, 1.0.0) returns 7 instead of negative number, which is wrong, because 1.0.0-beta-1 older than 1.0.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HADOOP-10250) VersionUtil returns wrong value when comparing two versions
[ https://issues.apache.org/jira/browse/HADOOP-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886009#comment-13886009 ] Yongjun Zhang commented on HADOOP-10250: Thanks Andrew. VersionUtil returns wrong value when comparing two versions --- Key: HADOOP-10250 URL: https://issues.apache.org/jira/browse/HADOOP-10250 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.3.0 Reporter: Yongjun Zhang Assignee: Yongjun Zhang Fix For: 2.3.0 Attachments: HADOOP-10250.001.patch, HADOOP-10250.002.patch, HADOOP-10250.003.patch, HADOOP-10250.004.patch, HADOOP-10250.004.patch VersionUtil.compareVersions(1.0.0-beta-1, 1.0.0) returns 7 instead of negative number, which is wrong, because 1.0.0-beta-1 older than 1.0.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HADOOP-10250) VersionUtil returns wrong value when comparing two versions
[ https://issues.apache.org/jira/browse/HADOOP-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13884019#comment-13884019 ] Hudson commented on HADOOP-10250: - FAILURE: Integrated in Hadoop-Yarn-trunk #464 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/464/]) HADOOP-10250. VersionUtil returns wrong value when comparing two versions. Contributed by Yongjun Zhang. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1561860) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ComparableVersion.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionUtil.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestVersionUtil.java VersionUtil returns wrong value when comparing two versions --- Key: HADOOP-10250 URL: https://issues.apache.org/jira/browse/HADOOP-10250 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.3.0 Reporter: Yongjun Zhang Assignee: Yongjun Zhang Fix For: 2.4.0 Attachments: HADOOP-10250.001.patch, HADOOP-10250.002.patch, HADOOP-10250.003.patch, HADOOP-10250.004.patch, HADOOP-10250.004.patch VersionUtil.compareVersions(1.0.0-beta-1, 1.0.0) returns 7 instead of negative number, which is wrong, because 1.0.0-beta-1 older than 1.0.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HADOOP-10250) VersionUtil returns wrong value when comparing two versions
[ https://issues.apache.org/jira/browse/HADOOP-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13884125#comment-13884125 ] Hudson commented on HADOOP-10250: - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1681 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1681/]) HADOOP-10250. VersionUtil returns wrong value when comparing two versions. Contributed by Yongjun Zhang. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1561860) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ComparableVersion.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionUtil.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestVersionUtil.java VersionUtil returns wrong value when comparing two versions --- Key: HADOOP-10250 URL: https://issues.apache.org/jira/browse/HADOOP-10250 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.3.0 Reporter: Yongjun Zhang Assignee: Yongjun Zhang Fix For: 2.4.0 Attachments: HADOOP-10250.001.patch, HADOOP-10250.002.patch, HADOOP-10250.003.patch, HADOOP-10250.004.patch, HADOOP-10250.004.patch VersionUtil.compareVersions(1.0.0-beta-1, 1.0.0) returns 7 instead of negative number, which is wrong, because 1.0.0-beta-1 older than 1.0.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HADOOP-10250) VersionUtil returns wrong value when comparing two versions
[ https://issues.apache.org/jira/browse/HADOOP-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13884142#comment-13884142 ] Hudson commented on HADOOP-10250: - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1656 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1656/]) HADOOP-10250. VersionUtil returns wrong value when comparing two versions. Contributed by Yongjun Zhang. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1561860) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ComparableVersion.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionUtil.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestVersionUtil.java VersionUtil returns wrong value when comparing two versions --- Key: HADOOP-10250 URL: https://issues.apache.org/jira/browse/HADOOP-10250 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.3.0 Reporter: Yongjun Zhang Assignee: Yongjun Zhang Fix For: 2.4.0 Attachments: HADOOP-10250.001.patch, HADOOP-10250.002.patch, HADOOP-10250.003.patch, HADOOP-10250.004.patch, HADOOP-10250.004.patch VersionUtil.compareVersions(1.0.0-beta-1, 1.0.0) returns 7 instead of negative number, which is wrong, because 1.0.0-beta-1 older than 1.0.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HADOOP-10250) VersionUtil returns wrong value when comparing two versions
[ https://issues.apache.org/jira/browse/HADOOP-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13883355#comment-13883355 ] Aaron T. Myers commented on HADOOP-10250: - +1, the latest patch looks good to me. I'm going to commit this momentarily. VersionUtil returns wrong value when comparing two versions --- Key: HADOOP-10250 URL: https://issues.apache.org/jira/browse/HADOOP-10250 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.3.0 Reporter: Yongjun Zhang Assignee: Yongjun Zhang Attachments: HADOOP-10250.001.patch, HADOOP-10250.002.patch, HADOOP-10250.003.patch, HADOOP-10250.004.patch, HADOOP-10250.004.patch VersionUtil.compareVersions(1.0.0-beta-1, 1.0.0) returns 7 instead of negative number, which is wrong, because 1.0.0-beta-1 older than 1.0.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HADOOP-10250) VersionUtil returns wrong value when comparing two versions
[ https://issues.apache.org/jira/browse/HADOOP-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13883398#comment-13883398 ] Hudson commented on HADOOP-10250: - SUCCESS: Integrated in Hadoop-trunk-Commit #5047 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5047/]) HADOOP-10250. VersionUtil returns wrong value when comparing two versions. Contributed by Yongjun Zhang. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1561860) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ComparableVersion.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionUtil.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestVersionUtil.java VersionUtil returns wrong value when comparing two versions --- Key: HADOOP-10250 URL: https://issues.apache.org/jira/browse/HADOOP-10250 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.3.0 Reporter: Yongjun Zhang Assignee: Yongjun Zhang Fix For: 2.4.0 Attachments: HADOOP-10250.001.patch, HADOOP-10250.002.patch, HADOOP-10250.003.patch, HADOOP-10250.004.patch, HADOOP-10250.004.patch VersionUtil.compareVersions(1.0.0-beta-1, 1.0.0) returns 7 instead of negative number, which is wrong, because 1.0.0-beta-1 older than 1.0.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HADOOP-10250) VersionUtil returns wrong value when comparing two versions
[ https://issues.apache.org/jira/browse/HADOOP-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13883449#comment-13883449 ] Yongjun Zhang commented on HADOOP-10250: Many thanks Aaron! VersionUtil returns wrong value when comparing two versions --- Key: HADOOP-10250 URL: https://issues.apache.org/jira/browse/HADOOP-10250 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.3.0 Reporter: Yongjun Zhang Assignee: Yongjun Zhang Fix For: 2.4.0 Attachments: HADOOP-10250.001.patch, HADOOP-10250.002.patch, HADOOP-10250.003.patch, HADOOP-10250.004.patch, HADOOP-10250.004.patch VersionUtil.compareVersions(1.0.0-beta-1, 1.0.0) returns 7 instead of negative number, which is wrong, because 1.0.0-beta-1 older than 1.0.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HADOOP-10250) VersionUtil returns wrong value when comparing two versions
[
https://issues.apache.org/jira/browse/HADOOP-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881940#comment-13881940
]
Hadoop QA commented on HADOOP-10250:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12625192/HADOOP-10250.004.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3471//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3471//console
This message is automatically generated.
VersionUtil returns wrong value when comparing two versions
---
Key: HADOOP-10250
URL: https://issues.apache.org/jira/browse/HADOOP-10250
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 2.3.0
Reporter: Yongjun Zhang
Assignee: Yongjun Zhang
Attachments: HADOOP-10250.001.patch, HADOOP-10250.002.patch,
HADOOP-10250.003.patch, HADOOP-10250.004.patch, HADOOP-10250.004.patch
VersionUtil.compareVersions(1.0.0-beta-1, 1.0.0) returns 7 instead of
negative number, which is wrong, because 1.0.0-beta-1 older than 1.0.0.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HADOOP-10250) VersionUtil returns wrong value when comparing two versions
[
https://issues.apache.org/jira/browse/HADOOP-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878817#comment-13878817
]
Hadoop QA commented on HADOOP-10250:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12624364/HADOOP-10250.002.patch
against trunk revision .
{color:red}-1 @author{color}. The patch appears to contain 1 @author tags
which the Hadoop community has agreed to not allow in code contributions.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3458//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3458//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3458//console
This message is automatically generated.
VersionUtil returns wrong value when comparing two versions
---
Key: HADOOP-10250
URL: https://issues.apache.org/jira/browse/HADOOP-10250
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 2.3.0
Reporter: Yongjun Zhang
Assignee: Yongjun Zhang
Attachments: HADOOP-10250.001.patch, HADOOP-10250.002.patch
VersionUtil.compareVersions(1.0.0-beta-1, 1.0.0) returns 7 instead of
negative number, which is wrong, because 1.0.0-beta-1 older than 1.0.0.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HADOOP-10250) VersionUtil returns wrong value when comparing two versions
[ https://issues.apache.org/jira/browse/HADOOP-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879262#comment-13879262 ] Yongjun Zhang commented on HADOOP-10250: Updated new version to address the @author tag and findbugs issues reported by jenkins test. VersionUtil returns wrong value when comparing two versions --- Key: HADOOP-10250 URL: https://issues.apache.org/jira/browse/HADOOP-10250 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.3.0 Reporter: Yongjun Zhang Assignee: Yongjun Zhang Attachments: HADOOP-10250.001.patch, HADOOP-10250.002.patch, HADOOP-10250.003.patch VersionUtil.compareVersions(1.0.0-beta-1, 1.0.0) returns 7 instead of negative number, which is wrong, because 1.0.0-beta-1 older than 1.0.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HADOOP-10250) VersionUtil returns wrong value when comparing two versions
[
https://issues.apache.org/jira/browse/HADOOP-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879304#comment-13879304
]
Hadoop QA commented on HADOOP-10250:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12624417/HADOOP-10250.003.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3462//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3462//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3462//console
This message is automatically generated.
VersionUtil returns wrong value when comparing two versions
---
Key: HADOOP-10250
URL: https://issues.apache.org/jira/browse/HADOOP-10250
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 2.3.0
Reporter: Yongjun Zhang
Assignee: Yongjun Zhang
Attachments: HADOOP-10250.001.patch, HADOOP-10250.002.patch,
HADOOP-10250.003.patch
VersionUtil.compareVersions(1.0.0-beta-1, 1.0.0) returns 7 instead of
negative number, which is wrong, because 1.0.0-beta-1 older than 1.0.0.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HADOOP-10250) VersionUtil returns wrong value when comparing two versions
[ https://issues.apache.org/jira/browse/HADOOP-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13879370#comment-13879370 ] Yongjun Zhang commented on HADOOP-10250: uploaded a new version for the findbugs issue. VersionUtil returns wrong value when comparing two versions --- Key: HADOOP-10250 URL: https://issues.apache.org/jira/browse/HADOOP-10250 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.3.0 Reporter: Yongjun Zhang Assignee: Yongjun Zhang Attachments: HADOOP-10250.001.patch, HADOOP-10250.002.patch, HADOOP-10250.003.patch, HADOOP-10250.004.patch VersionUtil.compareVersions(1.0.0-beta-1, 1.0.0) returns 7 instead of negative number, which is wrong, because 1.0.0-beta-1 older than 1.0.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HADOOP-10250) VersionUtil returns wrong value when comparing two versions
[ https://issues.apache.org/jira/browse/HADOOP-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878197#comment-13878197 ] Yongjun Zhang commented on HADOOP-10250: I submitted a patch by reusing maven's version comparison class ComparableVersion.java. Thanks for reviewing. VersionUtil returns wrong value when comparing two versions --- Key: HADOOP-10250 URL: https://issues.apache.org/jira/browse/HADOOP-10250 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.3.0 Reporter: Yongjun Zhang Assignee: Yongjun Zhang Attachments: HADOOP-10250.001.patch VersionUtil.compareVersions(1.0.0-beta-1, 1.0.0) returns 7 instead of negative number, which is wrong, because 1.0.0-beta-1 older than 1.0.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HADOOP-10250) VersionUtil returns wrong value when comparing two versions
[
https://issues.apache.org/jira/browse/HADOOP-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878227#comment-13878227
]
Hadoop QA commented on HADOOP-10250:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12624262/HADOOP-10250.001.patch
against trunk revision .
{color:red}-1 @author{color}. The patch appears to contain 2 @author tags
which the Hadoop community has agreed to not allow in code contributions.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3452//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3452//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3452//console
This message is automatically generated.
VersionUtil returns wrong value when comparing two versions
---
Key: HADOOP-10250
URL: https://issues.apache.org/jira/browse/HADOOP-10250
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 2.3.0
Reporter: Yongjun Zhang
Assignee: Yongjun Zhang
Attachments: HADOOP-10250.001.patch
VersionUtil.compareVersions(1.0.0-beta-1, 1.0.0) returns 7 instead of
negative number, which is wrong, because 1.0.0-beta-1 older than 1.0.0.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
