[jira] [Commented] (HADOOP-10626) Limit Returning Attributes for LDAP search

2015-01-28 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295180#comment-14295180
 ] 

Hudson commented on HADOOP-10626:
-

FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #84 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/84/])
HADOOP-10626. Limit Returning Attributes for LDAP search. Contributed by Jason 
Hubbard. (atm: rev 8bf6f0b70396e8f2d3b37e6da194b19f357e846a)
* hadoop-common-project/hadoop-common/CHANGES.txt
* 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java


 Limit Returning Attributes for LDAP search
 --

 Key: HADOOP-10626
 URL: https://issues.apache.org/jira/browse/HADOOP-10626
 Project: Hadoop Common
  Issue Type: Improvement
  Components: security
Affects Versions: 2.3.0
Reporter: Jason Hubbard
Assignee: Jason Hubbard
  Labels: easyfix, newbie, performance
 Fix For: 2.7.0

 Attachments: HADOOP-10626.patch, HADOOP-10626.patch


 When using Hadoop Ldap Group mappings in an enterprise environment, searching 
 groups and returning all members can take a long time causing a timeout.  
 This causes not all groups to be returned for a user.  Because the first 
 search only searches for the user dn and the second search retrieves the 
 group member attribute, we only need to return the group member attribute on 
 the search speeding up the search.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-10626) Limit Returning Attributes for LDAP search

2015-01-28 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295193#comment-14295193
 ] 

Hudson commented on HADOOP-10626:
-

FAILURE: Integrated in Hadoop-Hdfs-trunk #2019 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2019/])
HADOOP-10626. Limit Returning Attributes for LDAP search. Contributed by Jason 
Hubbard. (atm: rev 8bf6f0b70396e8f2d3b37e6da194b19f357e846a)
* hadoop-common-project/hadoop-common/CHANGES.txt
* 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java


 Limit Returning Attributes for LDAP search
 --

 Key: HADOOP-10626
 URL: https://issues.apache.org/jira/browse/HADOOP-10626
 Project: Hadoop Common
  Issue Type: Improvement
  Components: security
Affects Versions: 2.3.0
Reporter: Jason Hubbard
Assignee: Jason Hubbard
  Labels: easyfix, newbie, performance
 Fix For: 2.7.0

 Attachments: HADOOP-10626.patch, HADOOP-10626.patch


 When using Hadoop Ldap Group mappings in an enterprise environment, searching 
 groups and returning all members can take a long time causing a timeout.  
 This causes not all groups to be returned for a user.  Because the first 
 search only searches for the user dn and the second search retrieves the 
 group member attribute, we only need to return the group member attribute on 
 the search speeding up the search.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-10626) Limit Returning Attributes for LDAP search

2015-01-28 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295041#comment-14295041
 ] 

Hudson commented on HADOOP-10626:
-

FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #87 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/87/])
HADOOP-10626. Limit Returning Attributes for LDAP search. Contributed by Jason 
Hubbard. (atm: rev 8bf6f0b70396e8f2d3b37e6da194b19f357e846a)
* 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java
* hadoop-common-project/hadoop-common/CHANGES.txt


 Limit Returning Attributes for LDAP search
 --

 Key: HADOOP-10626
 URL: https://issues.apache.org/jira/browse/HADOOP-10626
 Project: Hadoop Common
  Issue Type: Improvement
  Components: security
Affects Versions: 2.3.0
Reporter: Jason Hubbard
Assignee: Jason Hubbard
  Labels: easyfix, newbie, performance
 Fix For: 2.7.0

 Attachments: HADOOP-10626.patch, HADOOP-10626.patch


 When using Hadoop Ldap Group mappings in an enterprise environment, searching 
 groups and returning all members can take a long time causing a timeout.  
 This causes not all groups to be returned for a user.  Because the first 
 search only searches for the user dn and the second search retrieves the 
 group member attribute, we only need to return the group member attribute on 
 the search speeding up the search.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-10626) Limit Returning Attributes for LDAP search

2015-01-28 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295059#comment-14295059
 ] 

Hudson commented on HADOOP-10626:
-

FAILURE: Integrated in Hadoop-Yarn-trunk #821 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/821/])
HADOOP-10626. Limit Returning Attributes for LDAP search. Contributed by Jason 
Hubbard. (atm: rev 8bf6f0b70396e8f2d3b37e6da194b19f357e846a)
* 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java
* hadoop-common-project/hadoop-common/CHANGES.txt


 Limit Returning Attributes for LDAP search
 --

 Key: HADOOP-10626
 URL: https://issues.apache.org/jira/browse/HADOOP-10626
 Project: Hadoop Common
  Issue Type: Improvement
  Components: security
Affects Versions: 2.3.0
Reporter: Jason Hubbard
Assignee: Jason Hubbard
  Labels: easyfix, newbie, performance
 Fix For: 2.7.0

 Attachments: HADOOP-10626.patch, HADOOP-10626.patch


 When using Hadoop Ldap Group mappings in an enterprise environment, searching 
 groups and returning all members can take a long time causing a timeout.  
 This causes not all groups to be returned for a user.  Because the first 
 search only searches for the user dn and the second search retrieves the 
 group member attribute, we only need to return the group member attribute on 
 the search speeding up the search.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-10626) Limit Returning Attributes for LDAP search

2015-01-28 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295249#comment-14295249
 ] 

Hudson commented on HADOOP-10626:
-

FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #88 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/88/])
HADOOP-10626. Limit Returning Attributes for LDAP search. Contributed by Jason 
Hubbard. (atm: rev 8bf6f0b70396e8f2d3b37e6da194b19f357e846a)
* 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java
* hadoop-common-project/hadoop-common/CHANGES.txt


 Limit Returning Attributes for LDAP search
 --

 Key: HADOOP-10626
 URL: https://issues.apache.org/jira/browse/HADOOP-10626
 Project: Hadoop Common
  Issue Type: Improvement
  Components: security
Affects Versions: 2.3.0
Reporter: Jason Hubbard
Assignee: Jason Hubbard
  Labels: easyfix, newbie, performance
 Fix For: 2.7.0

 Attachments: HADOOP-10626.patch, HADOOP-10626.patch


 When using Hadoop Ldap Group mappings in an enterprise environment, searching 
 groups and returning all members can take a long time causing a timeout.  
 This causes not all groups to be returned for a user.  Because the first 
 search only searches for the user dn and the second search retrieves the 
 group member attribute, we only need to return the group member attribute on 
 the search speeding up the search.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-10626) Limit Returning Attributes for LDAP search

2015-01-28 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295279#comment-14295279
 ] 

Hudson commented on HADOOP-10626:
-

FAILURE: Integrated in Hadoop-Mapreduce-trunk #2038 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2038/])
HADOOP-10626. Limit Returning Attributes for LDAP search. Contributed by Jason 
Hubbard. (atm: rev 8bf6f0b70396e8f2d3b37e6da194b19f357e846a)
* 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java
* hadoop-common-project/hadoop-common/CHANGES.txt


 Limit Returning Attributes for LDAP search
 --

 Key: HADOOP-10626
 URL: https://issues.apache.org/jira/browse/HADOOP-10626
 Project: Hadoop Common
  Issue Type: Improvement
  Components: security
Affects Versions: 2.3.0
Reporter: Jason Hubbard
Assignee: Jason Hubbard
  Labels: easyfix, newbie, performance
 Fix For: 2.7.0

 Attachments: HADOOP-10626.patch, HADOOP-10626.patch


 When using Hadoop Ldap Group mappings in an enterprise environment, searching 
 groups and returning all members can take a long time causing a timeout.  
 This causes not all groups to be returned for a user.  Because the first 
 search only searches for the user dn and the second search retrieves the 
 group member attribute, we only need to return the group member attribute on 
 the search speeding up the search.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-10626) Limit Returning Attributes for LDAP search

2015-01-27 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294271#comment-14294271
 ] 

Hudson commented on HADOOP-10626:
-

FAILURE: Integrated in Hadoop-trunk-Commit #6942 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/6942/])
HADOOP-10626. Limit Returning Attributes for LDAP search. Contributed by Jason 
Hubbard. (atm: rev 8bf6f0b70396e8f2d3b37e6da194b19f357e846a)
* 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/LdapGroupsMapping.java
* hadoop-common-project/hadoop-common/CHANGES.txt


 Limit Returning Attributes for LDAP search
 --

 Key: HADOOP-10626
 URL: https://issues.apache.org/jira/browse/HADOOP-10626
 Project: Hadoop Common
  Issue Type: Improvement
  Components: security
Affects Versions: 2.3.0
Reporter: Jason Hubbard
Assignee: Jason Hubbard
  Labels: easyfix, newbie, performance
 Fix For: 2.7.0

 Attachments: HADOOP-10626.patch, HADOOP-10626.patch


 When using Hadoop Ldap Group mappings in an enterprise environment, searching 
 groups and returning all members can take a long time causing a timeout.  
 This causes not all groups to be returned for a user.  Because the first 
 search only searches for the user dn and the second search retrieves the 
 group member attribute, we only need to return the group member attribute on 
 the search speeding up the search.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-10626) Limit Returning Attributes for LDAP search

2015-01-26 Thread Aaron T. Myers (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14292336#comment-14292336
 ] 

Aaron T. Myers commented on HADOOP-10626:
-

Latest patch looks good to me. +1 pending Jenkins.

 Limit Returning Attributes for LDAP search
 --

 Key: HADOOP-10626
 URL: https://issues.apache.org/jira/browse/HADOOP-10626
 Project: Hadoop Common
  Issue Type: Improvement
  Components: security
Affects Versions: 2.3.0
Reporter: Jason Hubbard
Assignee: Jason Hubbard
  Labels: easyfix, newbie, performance
 Attachments: HADOOP-10626.patch, HADOOP-10626.patch


 When using Hadoop Ldap Group mappings in an enterprise environment, searching 
 groups and returning all members can take a long time causing a timeout.  
 This causes not all groups to be returned for a user.  Because the first 
 search only searches for the user dn and the second search retrieves the 
 group member attribute, we only need to return the group member attribute on 
 the search speeding up the search.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-10626) Limit Returning Attributes for LDAP search

2015-01-26 Thread Jason Hubbard (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14292339#comment-14292339
 ] 

Jason Hubbard commented on HADOOP-10626:


Hi Aaron.  Yes, that's exactly it, this will limit what is returned instead of 
returning everything which helps performance since only the groupNameAttr is 
used in the search.  I've rebased to trunk and included the comments you 
suggested with the new patch.  Thanks for the help.

 Limit Returning Attributes for LDAP search
 --

 Key: HADOOP-10626
 URL: https://issues.apache.org/jira/browse/HADOOP-10626
 Project: Hadoop Common
  Issue Type: Improvement
  Components: security
Affects Versions: 2.3.0
Reporter: Jason Hubbard
Assignee: Jason Hubbard
  Labels: easyfix, newbie, performance
 Attachments: HADOOP-10626.patch, HADOOP-10626.patch


 When using Hadoop Ldap Group mappings in an enterprise environment, searching 
 groups and returning all members can take a long time causing a timeout.  
 This causes not all groups to be returned for a user.  Because the first 
 search only searches for the user dn and the second search retrieves the 
 group member attribute, we only need to return the group member attribute on 
 the search speeding up the search.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-10626) Limit Returning Attributes for LDAP search

2015-01-26 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14292421#comment-14292421
 ] 

Hadoop QA commented on HADOOP-10626:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12694602/HADOOP-10626.patch
  against trunk revision 21d5599.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/5483//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/5483//console

This message is automatically generated.

 Limit Returning Attributes for LDAP search
 --

 Key: HADOOP-10626
 URL: https://issues.apache.org/jira/browse/HADOOP-10626
 Project: Hadoop Common
  Issue Type: Improvement
  Components: security
Affects Versions: 2.3.0
Reporter: Jason Hubbard
Assignee: Jason Hubbard
  Labels: easyfix, newbie, performance
 Attachments: HADOOP-10626.patch, HADOOP-10626.patch


 When using Hadoop Ldap Group mappings in an enterprise environment, searching 
 groups and returning all members can take a long time causing a timeout.  
 This causes not all groups to be returned for a user.  Because the first 
 search only searches for the user dn and the second search retrieves the 
 group member attribute, we only need to return the group member attribute on 
 the search speeding up the search.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-10626) Limit Returning Attributes for LDAP search

2015-01-22 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14287932#comment-14287932
 ] 

Hadoop QA commented on HADOOP-10626:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12646690/HADOOP-10626.patch
  against trunk revision 825923f.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/5456//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/5456//console

This message is automatically generated.

 Limit Returning Attributes for LDAP search
 --

 Key: HADOOP-10626
 URL: https://issues.apache.org/jira/browse/HADOOP-10626
 Project: Hadoop Common
  Issue Type: Improvement
  Components: security
Affects Versions: 2.3.0
Reporter: Jason Hubbard
Assignee: Jason Hubbard
  Labels: easyfix, newbie, performance
 Attachments: HADOOP-10626.patch


 When using Hadoop Ldap Group mappings in an enterprise environment, searching 
 groups and returning all members can take a long time causing a timeout.  
 This causes not all groups to be returned for a user.  Because the first 
 search only searches for the user dn and the second search retrieves the 
 group member attribute, we only need to return the group member attribute on 
 the search speeding up the search.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-10626) Limit Returning Attributes for LDAP search

2015-01-22 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14287940#comment-14287940
 ] 

Hadoop QA commented on HADOOP-10626:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12646690/HADOOP-10626.patch
  against trunk revision 825923f.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/5457//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/5457//console

This message is automatically generated.

 Limit Returning Attributes for LDAP search
 --

 Key: HADOOP-10626
 URL: https://issues.apache.org/jira/browse/HADOOP-10626
 Project: Hadoop Common
  Issue Type: Improvement
  Components: security
Affects Versions: 2.3.0
Reporter: Jason Hubbard
Assignee: Jason Hubbard
  Labels: easyfix, newbie, performance
 Attachments: HADOOP-10626.patch


 When using Hadoop Ldap Group mappings in an enterprise environment, searching 
 groups and returning all members can take a long time causing a timeout.  
 This causes not all groups to be returned for a user.  Because the first 
 search only searches for the user dn and the second search retrieves the 
 group member attribute, we only need to return the group member attribute on 
 the search speeding up the search.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-10626) Limit Returning Attributes for LDAP search

2015-01-22 Thread Aaron T. Myers (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14287827#comment-14287827
 ] 

Aaron T. Myers commented on HADOOP-10626:
-

Hi Jason, the patch looks pretty good to me in the abstract, thanks for 
providing it and for doing that testing.

One question for you - the javadocs for the {{SearchControls}} class seem to 
indicate that by default all attributes will be returned by a search. 
Specifically, I'm looking at this bit of text in the description of the no args 
constructor (emphasis mine):

{quote}
The defaults are:

* search one level
* no maximum return limit for search results
* no time limit for search
* *return all attributes associated with objects that satisfy the search 
filter.*
* do not return named object (return only name and class)
* do not dereference links during search
{quote}

Given this, why is it necessary to explicitly add the group name attribute to 
the search results? Are the javadocs incorrect? Or am I just misunderstanding 
something?

 Limit Returning Attributes for LDAP search
 --

 Key: HADOOP-10626
 URL: https://issues.apache.org/jira/browse/HADOOP-10626
 Project: Hadoop Common
  Issue Type: Improvement
  Components: security
Affects Versions: 2.3.0
Reporter: Jason Hubbard
Assignee: Jason Hubbard
  Labels: easyfix, newbie, performance
 Attachments: HADOOP-10626.patch


 When using Hadoop Ldap Group mappings in an enterprise environment, searching 
 groups and returning all members can take a long time causing a timeout.  
 This causes not all groups to be returned for a user.  Because the first 
 search only searches for the user dn and the second search retrieves the 
 group member attribute, we only need to return the group member attribute on 
 the search speeding up the search.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-10626) Limit Returning Attributes for LDAP search

2015-01-22 Thread Aaron T. Myers (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14287849#comment-14287849
 ] 

Aaron T. Myers commented on HADOOP-10626:
-

Ah, never mind my question - I think I understand now. The whole point of this 
change is to expressly limit the search results to only those attributes which 
the groups plugin will actually be looking at, and in doing so speed up the 
search. Makes sense.

Given that, the patch looks pretty good to me. My only suggestion is to add a 
one-line comment above the {{setReturningAttributes}} call explaining why we're 
reducing the results returned by the search, something along the lines of // 
Limit the attributes returned to only those required to speed up the search. 
See HADOOP-10626 for more details.

I'll be +1 once this is addressed.

 Limit Returning Attributes for LDAP search
 --

 Key: HADOOP-10626
 URL: https://issues.apache.org/jira/browse/HADOOP-10626
 Project: Hadoop Common
  Issue Type: Improvement
  Components: security
Affects Versions: 2.3.0
Reporter: Jason Hubbard
Assignee: Jason Hubbard
  Labels: easyfix, newbie, performance
 Attachments: HADOOP-10626.patch


 When using Hadoop Ldap Group mappings in an enterprise environment, searching 
 groups and returning all members can take a long time causing a timeout.  
 This causes not all groups to be returned for a user.  Because the first 
 search only searches for the user dn and the second search retrieves the 
 group member attribute, we only need to return the group member attribute on 
 the search speeding up the search.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-10626) Limit Returning Attributes for LDAP search

2014-05-27 Thread Jason Hubbard (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14009668#comment-14009668
 ] 

Jason Hubbard commented on HADOOP-10626:


The only useful test I could think to add was an integration test, but there is 
no current support for ldap integration that I am aware.  The integration test 
would test to make sure group name attribute was returned as well as user full 
dn.  I have tested this manually and all groups for users were successfully 
returned.

 Limit Returning Attributes for LDAP search
 --

 Key: HADOOP-10626
 URL: https://issues.apache.org/jira/browse/HADOOP-10626
 Project: Hadoop Common
  Issue Type: Improvement
  Components: security
Affects Versions: 2.3.0
Reporter: Jason Hubbard
  Labels: easyfix, newbie, performance
 Attachments: HADOOP-10626.patch


 When using Hadoop Ldap Group mappings in an enterprise environment, searching 
 groups and returning all members can take a long time causing a timeout.  
 This causes not all groups to be returned for a user.  Because the first 
 search only searches for the user dn and the second search retrieves the 
 group member attribute, we only need to return the group member attribute on 
 the search speeding up the search.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HADOOP-10626) Limit Returning Attributes for LDAP search

2014-05-25 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008420#comment-14008420
 ] 

Hadoop QA commented on HADOOP-10626:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12646690/HADOOP-10626.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/3967//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/3967//console

This message is automatically generated.

 Limit Returning Attributes for LDAP search
 --

 Key: HADOOP-10626
 URL: https://issues.apache.org/jira/browse/HADOOP-10626
 Project: Hadoop Common
  Issue Type: Improvement
  Components: security
Affects Versions: 2.3.0
Reporter: Jason Hubbard
  Labels: easyfix, newbie, performance
 Attachments: HADOOP-10626.patch


 When using Hadoop Ldap Group mappings in an enterprise environment, searching 
 groups and returning all members can take a long time causing a timeout.  
 This causes not all groups to be returned for a user.  Because the first 
 search only searches for the user dn and the second search retrieves the 
 group member attribute, we only need to return the group member attribute on 
 the search speeding up the search.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HADOOP-10626) Limit Returning Attributes for LDAP search

2014-05-25 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008434#comment-14008434
 ] 

Hadoop QA commented on HADOOP-10626:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12646690/HADOOP-10626.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/3969//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/3969//console

This message is automatically generated.

 Limit Returning Attributes for LDAP search
 --

 Key: HADOOP-10626
 URL: https://issues.apache.org/jira/browse/HADOOP-10626
 Project: Hadoop Common
  Issue Type: Improvement
  Components: security
Affects Versions: 2.3.0
Reporter: Jason Hubbard
  Labels: easyfix, newbie, performance
 Attachments: HADOOP-10626.patch


 When using Hadoop Ldap Group mappings in an enterprise environment, searching 
 groups and returning all members can take a long time causing a timeout.  
 This causes not all groups to be returned for a user.  Because the first 
 search only searches for the user dn and the second search retrieves the 
 group member attribute, we only need to return the group member attribute on 
 the search speeding up the search.



--
This message was sent by Atlassian JIRA
(v6.2#6252)