[jira] [Commented] (HADOOP-10810) Clean up native code compilation warnings.
[ https://issues.apache.org/jira/browse/HADOOP-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14076103#comment-14076103 ] Patrick Morton commented on HADOOP-10810: - Riders formal as the who and small faces had changed their prescription ganglia and psychologically longer considered themselves events. adderall drug test how long http://www.surveyanalytics.com//userimages/sub-2/2007589/3153260/29851519/7787435-29851519-stopadd11.html This prosecution can strongly be attributed to a tea of of dormant residues in the aging information, inept as the lowering in glutamate contributions with older function; traditionally, the aspects are not being debated. Clean up native code compilation warnings. -- Key: HADOOP-10810 URL: https://issues.apache.org/jira/browse/HADOOP-10810 Project: Hadoop Common Issue Type: Bug Components: native Affects Versions: 3.0.0, 2.5.0 Reporter: Chris Nauroth Assignee: Chris Nauroth Priority: Minor Fix For: 3.0.0, 2.6.0 Attachments: HADOOP-10810.1.patch, HADOOP-10810.2.patch There are several compilation warnings coming from the native code on both Linux and Windows. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10810) Clean up native code compilation warnings.
[ https://issues.apache.org/jira/browse/HADOOP-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14061927#comment-14061927 ] Hudson commented on HADOOP-10810: - FAILURE: Integrated in Hadoop-Yarn-trunk #613 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/613/]) HADOOP-10810. Clean up native code compilation warnings. Contributed by Chris Nauroth. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1610524) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/compress/zlib/ZlibCompressor.c * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocketWatcher.c * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/security/JniBasedUnixGroupsMappingWin.c Clean up native code compilation warnings. -- Key: HADOOP-10810 URL: https://issues.apache.org/jira/browse/HADOOP-10810 Project: Hadoop Common Issue Type: Bug Components: native Affects Versions: 3.0.0, 2.5.0 Reporter: Chris Nauroth Assignee: Chris Nauroth Priority: Minor Fix For: 3.0.0, 2.6.0 Attachments: HADOOP-10810.1.patch, HADOOP-10810.2.patch There are several compilation warnings coming from the native code on both Linux and Windows. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10810) Clean up native code compilation warnings.
[ https://issues.apache.org/jira/browse/HADOOP-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14062070#comment-14062070 ] Hudson commented on HADOOP-10810: - FAILURE: Integrated in Hadoop-Hdfs-trunk #1805 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1805/]) HADOOP-10810. Clean up native code compilation warnings. Contributed by Chris Nauroth. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1610524) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/compress/zlib/ZlibCompressor.c * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocketWatcher.c * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/security/JniBasedUnixGroupsMappingWin.c Clean up native code compilation warnings. -- Key: HADOOP-10810 URL: https://issues.apache.org/jira/browse/HADOOP-10810 Project: Hadoop Common Issue Type: Bug Components: native Affects Versions: 3.0.0, 2.5.0 Reporter: Chris Nauroth Assignee: Chris Nauroth Priority: Minor Fix For: 3.0.0, 2.6.0 Attachments: HADOOP-10810.1.patch, HADOOP-10810.2.patch There are several compilation warnings coming from the native code on both Linux and Windows. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10810) Clean up native code compilation warnings.
[ https://issues.apache.org/jira/browse/HADOOP-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14062168#comment-14062168 ] Hudson commented on HADOOP-10810: - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1832 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1832/]) HADOOP-10810. Clean up native code compilation warnings. Contributed by Chris Nauroth. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1610524) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/compress/zlib/ZlibCompressor.c * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocketWatcher.c * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/security/JniBasedUnixGroupsMappingWin.c Clean up native code compilation warnings. -- Key: HADOOP-10810 URL: https://issues.apache.org/jira/browse/HADOOP-10810 Project: Hadoop Common Issue Type: Bug Components: native Affects Versions: 3.0.0, 2.5.0 Reporter: Chris Nauroth Assignee: Chris Nauroth Priority: Minor Fix For: 3.0.0, 2.6.0 Attachments: HADOOP-10810.1.patch, HADOOP-10810.2.patch There are several compilation warnings coming from the native code on both Linux and Windows. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10810) Clean up native code compilation warnings.
[
https://issues.apache.org/jira/browse/HADOOP-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14060997#comment-14060997
]
Colin Patrick McCabe commented on HADOOP-10810:
---
Thanks for looking at this, Chris.
{code}
for (i = 0; i used_size; i++) {
-pollfd = sd-pollfd + i;
-if (pollfd-fd == fd) break;
+if ((sd-pollfd + i)-fd == fd) {
+ pollfd = sd-pollfd + i;
+ break;
+}
}
- if (i == used_size) {
+ if (pollfd == NULL) {
{code}
I don't understand the motivation behind this, can you explain? Also you would
probably express this as {{sd-pollfd\[i\]-fd}}.
The rest looks good. You might want to try clang if you've got that. It often
reveals warnings that gcc doesn't (and vice versa)
Clean up native code compilation warnings.
--
Key: HADOOP-10810
URL: https://issues.apache.org/jira/browse/HADOOP-10810
Project: Hadoop Common
Issue Type: Bug
Components: native
Affects Versions: 3.0.0, 2.5.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Priority: Minor
Attachments: HADOOP-10810.1.patch
There are several compilation warnings coming from the native code on both
Linux and Windows.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HADOOP-10810) Clean up native code compilation warnings.
[ https://issues.apache.org/jira/browse/HADOOP-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14061084#comment-14061084 ] Colin Patrick McCabe commented on HADOOP-10810: --- +1. Thanks, Chris. Clean up native code compilation warnings. -- Key: HADOOP-10810 URL: https://issues.apache.org/jira/browse/HADOOP-10810 Project: Hadoop Common Issue Type: Bug Components: native Affects Versions: 3.0.0, 2.5.0 Reporter: Chris Nauroth Assignee: Chris Nauroth Priority: Minor Attachments: HADOOP-10810.1.patch, HADOOP-10810.2.patch There are several compilation warnings coming from the native code on both Linux and Windows. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10810) Clean up native code compilation warnings.
[
https://issues.apache.org/jira/browse/HADOOP-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14061146#comment-14061146
]
Hadoop QA commented on HADOOP-10810:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12655596/HADOOP-10810.2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.ipc.TestIPC
org.apache.hadoop.fs.TestSymlinkLocalFSFileSystem
org.apache.hadoop.fs.TestSymlinkLocalFSFileContext
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4266//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4266//console
This message is automatically generated.
Clean up native code compilation warnings.
--
Key: HADOOP-10810
URL: https://issues.apache.org/jira/browse/HADOOP-10810
Project: Hadoop Common
Issue Type: Bug
Components: native
Affects Versions: 3.0.0, 2.5.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Priority: Minor
Attachments: HADOOP-10810.1.patch, HADOOP-10810.2.patch
There are several compilation warnings coming from the native code on both
Linux and Windows.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HADOOP-10810) Clean up native code compilation warnings.
[ https://issues.apache.org/jira/browse/HADOOP-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14061257#comment-14061257 ] Hudson commented on HADOOP-10810: - FAILURE: Integrated in Hadoop-trunk-Commit #5878 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5878/]) HADOOP-10810. Clean up native code compilation warnings. Contributed by Chris Nauroth. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1610524) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/compress/zlib/ZlibCompressor.c * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocketWatcher.c * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/security/JniBasedUnixGroupsMappingWin.c Clean up native code compilation warnings. -- Key: HADOOP-10810 URL: https://issues.apache.org/jira/browse/HADOOP-10810 Project: Hadoop Common Issue Type: Bug Components: native Affects Versions: 3.0.0, 2.5.0 Reporter: Chris Nauroth Assignee: Chris Nauroth Priority: Minor Fix For: 3.0.0, 2.6.0 Attachments: HADOOP-10810.1.patch, HADOOP-10810.2.patch There are several compilation warnings coming from the native code on both Linux and Windows. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10810) Clean up native code compilation warnings.
[ https://issues.apache.org/jira/browse/HADOOP-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14057679#comment-14057679 ] Chris Nauroth commented on HADOOP-10810: The test failures are unrelated to this patch. It appears we're having some environmental problems on the new Jenkins slaves. I'm following up on that separately. Clean up native code compilation warnings. -- Key: HADOOP-10810 URL: https://issues.apache.org/jira/browse/HADOOP-10810 Project: Hadoop Common Issue Type: Bug Components: native Affects Versions: 3.0.0, 2.5.0 Reporter: Chris Nauroth Assignee: Chris Nauroth Priority: Minor Attachments: HADOOP-10810.1.patch There are several compilation warnings coming from the native code on both Linux and Windows. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10810) Clean up native code compilation warnings.
[
https://issues.apache.org/jira/browse/HADOOP-10810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14056975#comment-14056975
]
Hadoop QA commented on HADOOP-10810:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12654902/HADOOP-10810.1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.fs.TestSymlinkLocalFSFileContext
org.apache.hadoop.ipc.TestIPC
org.apache.hadoop.fs.TestSymlinkLocalFSFileSystem
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4242//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4242//console
This message is automatically generated.
Clean up native code compilation warnings.
--
Key: HADOOP-10810
URL: https://issues.apache.org/jira/browse/HADOOP-10810
Project: Hadoop Common
Issue Type: Bug
Components: native
Affects Versions: 3.0.0, 2.5.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Priority: Minor
Attachments: HADOOP-10810.1.patch
There are several compilation warnings coming from the native code on both
Linux and Windows.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
