[
https://issues.apache.org/jira/browse/HADOOP-10998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106876#comment-14106876
]
Jim Hester commented on HADOOP-10998:
-
I did not see [HADOOP-6310|https://issues.apache.org/jira/browse/HADOOP-6310]
when I searched, just the original ticket
[HADOOP-3714|https://issues.apache.org/jira/browse/HADOOP-3714]. The final
patch on [HADOOP-6310|https://issues.apache.org/jira/browse/HADOOP-6310] is a
much more extensive change from what is in trunk, and has at least two bugs I
noticed while looking it over (dfs paths with spaces in them will be parsed
incorrectly and stderr is incorrectly included in file completion results). It
also combines local and remote file system completions together, which seems
like a less than optimal solution.
I would prefer to have either commit this patch or the first patch on
[HADOOP-6310|https://issues.apache.org/jira/browse/HADOOP-6310] committed
(which does basically the same things as this one) before tacking the larger
changes in the second patch on
[HADOOP-6310|https://issues.apache.org/jira/browse/HADOOP-6310].
As it is the current code does not work at all (and hasn't since at least
2009), so committing any of the submitted patches would be an improvement.
Bash tab completion support for newer versions of hadoop
Key: HADOOP-10998
URL: https://issues.apache.org/jira/browse/HADOOP-10998
Project: Hadoop Common
Issue Type: Improvement
Components: scripts
Environment: Hadoop 2.0.0-cdh4.2.1
Reporter: Jim Hester
Priority: Trivial
Attachments: HADOOP-10998.patch
The included version of bash completion has not been updated in almost two
years and does not work correctly with more recent versions of Hadoop.
The command substitutions in the script were using backticks, which were
interpolating variables before they were executed and breaking the script.
In particular the awk commands were breaking due to this interpolation.
The attached patch changes the backticks to {{$(command)}} style for command
substitution and updates the script to work properly with newer versions of
hadoop.
I tested the script using {{zsh 5.0.5}}, {{zsh 4.3.10]}, {{bash-4.1.2}} and
{{bash-3.2}}. Hadoop versions tested were cloudera version
{{2.0.0-cdh4.2.1}} and briefly Apache {{2.5.0}}.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
