[jira] [Commented] (HADOOP-11776) jdiff is broken in Hadoop 2
[ https://issues.apache.org/jira/browse/HADOOP-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486303#comment-14486303 ] Haohui Mai commented on HADOOP-11776: - I believe it creates a lot of noises on the HDFS side. It does not differentiate between public and private APIs. jdiff is broken in Hadoop 2 --- Key: HADOOP-11776 URL: https://issues.apache.org/jira/browse/HADOOP-11776 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.6.0 Reporter: Li Lu Assignee: Li Lu Priority: Blocker Fix For: 2.7.0 Attachments: HADOOP-11776-040115.patch Seems like we haven't touch the API files from jdiff under dev-support for a while. For now we're missing the jdiff API files for hadoop 2. We're also missing YARN when generating the jdiff API files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11776) jdiff is broken in Hadoop 2
[ https://issues.apache.org/jira/browse/HADOOP-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14481438#comment-14481438 ] Li Lu commented on HADOOP-11776: Thanks [~vinodkv] for the review and commit. Yes we do have more things to do for tools to check API compatibility. Given the current status our long term goal may be replacing it with some other tool. jdiff is broken in Hadoop 2 --- Key: HADOOP-11776 URL: https://issues.apache.org/jira/browse/HADOOP-11776 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.6.0 Reporter: Li Lu Assignee: Li Lu Priority: Blocker Fix For: 2.7.0 Attachments: HADOOP-11776-040115.patch Seems like we haven't touch the API files from jdiff under dev-support for a while. For now we're missing the jdiff API files for hadoop 2. We're also missing YARN when generating the jdiff API files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11776) jdiff is broken in Hadoop 2
[ https://issues.apache.org/jira/browse/HADOOP-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14396235#comment-14396235 ] Hudson commented on HADOOP-11776: - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2104 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2104/]) HADOOP-11776. Fixed the broken JDiff support in Hadoop 2. Contributed by Li Lu. (vinodkv: rev 4b3948ea365db07df7a9369a271009fafd1ba8f5) * hadoop-hdfs-project/hadoop-hdfs/dev-support/jdiff/Apache_Hadoop_HDFS_2.6.0.xml * hadoop-common-project/hadoop-common/dev-support/jdiff/Apache_Hadoop_Common_2.6.0.xml * hadoop-project/pom.xml * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-project-dist/pom.xml jdiff is broken in Hadoop 2 --- Key: HADOOP-11776 URL: https://issues.apache.org/jira/browse/HADOOP-11776 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.6.0 Reporter: Li Lu Assignee: Li Lu Priority: Blocker Fix For: 2.7.0 Attachments: HADOOP-11776-040115.patch Seems like we haven't touch the API files from jdiff under dev-support for a while. For now we're missing the jdiff API files for hadoop 2. We're also missing YARN when generating the jdiff API files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11776) jdiff is broken in Hadoop 2
[ https://issues.apache.org/jira/browse/HADOOP-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14396199#comment-14396199 ] Hudson commented on HADOOP-11776: - FAILURE: Integrated in Hadoop-Yarn-trunk #888 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/888/]) HADOOP-11776. Fixed the broken JDiff support in Hadoop 2. Contributed by Li Lu. (vinodkv: rev 4b3948ea365db07df7a9369a271009fafd1ba8f5) * hadoop-project-dist/pom.xml * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/dev-support/jdiff/Apache_Hadoop_HDFS_2.6.0.xml * hadoop-project/pom.xml * hadoop-common-project/hadoop-common/dev-support/jdiff/Apache_Hadoop_Common_2.6.0.xml jdiff is broken in Hadoop 2 --- Key: HADOOP-11776 URL: https://issues.apache.org/jira/browse/HADOOP-11776 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.6.0 Reporter: Li Lu Assignee: Li Lu Priority: Blocker Fix For: 2.7.0 Attachments: HADOOP-11776-040115.patch Seems like we haven't touch the API files from jdiff under dev-support for a while. For now we're missing the jdiff API files for hadoop 2. We're also missing YARN when generating the jdiff API files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11776) jdiff is broken in Hadoop 2
[ https://issues.apache.org/jira/browse/HADOOP-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14396250#comment-14396250 ] Hudson commented on HADOOP-11776: - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #145 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/145/]) HADOOP-11776. Fixed the broken JDiff support in Hadoop 2. Contributed by Li Lu. (vinodkv: rev 4b3948ea365db07df7a9369a271009fafd1ba8f5) * hadoop-common-project/hadoop-common/dev-support/jdiff/Apache_Hadoop_Common_2.6.0.xml * hadoop-project/pom.xml * hadoop-hdfs-project/hadoop-hdfs/dev-support/jdiff/Apache_Hadoop_HDFS_2.6.0.xml * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-project-dist/pom.xml jdiff is broken in Hadoop 2 --- Key: HADOOP-11776 URL: https://issues.apache.org/jira/browse/HADOOP-11776 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.6.0 Reporter: Li Lu Assignee: Li Lu Priority: Blocker Fix For: 2.7.0 Attachments: HADOOP-11776-040115.patch Seems like we haven't touch the API files from jdiff under dev-support for a while. For now we're missing the jdiff API files for hadoop 2. We're also missing YARN when generating the jdiff API files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11776) jdiff is broken in Hadoop 2
[ https://issues.apache.org/jira/browse/HADOOP-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14396258#comment-14396258 ] Hudson commented on HADOOP-11776: - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2086 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2086/]) HADOOP-11776. Fixed the broken JDiff support in Hadoop 2. Contributed by Li Lu. (vinodkv: rev 4b3948ea365db07df7a9369a271009fafd1ba8f5) * hadoop-common-project/hadoop-common/dev-support/jdiff/Apache_Hadoop_Common_2.6.0.xml * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-project/pom.xml * hadoop-project-dist/pom.xml * hadoop-hdfs-project/hadoop-hdfs/dev-support/jdiff/Apache_Hadoop_HDFS_2.6.0.xml jdiff is broken in Hadoop 2 --- Key: HADOOP-11776 URL: https://issues.apache.org/jira/browse/HADOOP-11776 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.6.0 Reporter: Li Lu Assignee: Li Lu Priority: Blocker Fix For: 2.7.0 Attachments: HADOOP-11776-040115.patch Seems like we haven't touch the API files from jdiff under dev-support for a while. For now we're missing the jdiff API files for hadoop 2. We're also missing YARN when generating the jdiff API files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11776) jdiff is broken in Hadoop 2
[ https://issues.apache.org/jira/browse/HADOOP-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14396189#comment-14396189 ] Hudson commented on HADOOP-11776: - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #154 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/154/]) HADOOP-11776. Fixed the broken JDiff support in Hadoop 2. Contributed by Li Lu. (vinodkv: rev 4b3948ea365db07df7a9369a271009fafd1ba8f5) * hadoop-common-project/hadoop-common/dev-support/jdiff/Apache_Hadoop_Common_2.6.0.xml * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-project-dist/pom.xml * hadoop-hdfs-project/hadoop-hdfs/dev-support/jdiff/Apache_Hadoop_HDFS_2.6.0.xml * hadoop-project/pom.xml jdiff is broken in Hadoop 2 --- Key: HADOOP-11776 URL: https://issues.apache.org/jira/browse/HADOOP-11776 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.6.0 Reporter: Li Lu Assignee: Li Lu Priority: Blocker Fix For: 2.7.0 Attachments: HADOOP-11776-040115.patch Seems like we haven't touch the API files from jdiff under dev-support for a while. For now we're missing the jdiff API files for hadoop 2. We're also missing YARN when generating the jdiff API files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11776) jdiff is broken in Hadoop 2
[ https://issues.apache.org/jira/browse/HADOOP-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14396349#comment-14396349 ] Hudson commented on HADOOP-11776: - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #155 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/155/]) HADOOP-11776. Fixed the broken JDiff support in Hadoop 2. Contributed by Li Lu. (vinodkv: rev 4b3948ea365db07df7a9369a271009fafd1ba8f5) * hadoop-project-dist/pom.xml * hadoop-project/pom.xml * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/dev-support/jdiff/Apache_Hadoop_HDFS_2.6.0.xml * hadoop-common-project/hadoop-common/dev-support/jdiff/Apache_Hadoop_Common_2.6.0.xml jdiff is broken in Hadoop 2 --- Key: HADOOP-11776 URL: https://issues.apache.org/jira/browse/HADOOP-11776 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.6.0 Reporter: Li Lu Assignee: Li Lu Priority: Blocker Fix For: 2.7.0 Attachments: HADOOP-11776-040115.patch Seems like we haven't touch the API files from jdiff under dev-support for a while. For now we're missing the jdiff API files for hadoop 2. We're also missing YARN when generating the jdiff API files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11776) jdiff is broken in Hadoop 2
[ https://issues.apache.org/jira/browse/HADOOP-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14395947#comment-14395947 ] Hudson commented on HADOOP-11776: - FAILURE: Integrated in Hadoop-trunk-Commit #7512 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7512/]) HADOOP-11776. Fixed the broken JDiff support in Hadoop 2. Contributed by Li Lu. (vinodkv: rev 4b3948ea365db07df7a9369a271009fafd1ba8f5) * hadoop-common-project/hadoop-common/dev-support/jdiff/Apache_Hadoop_Common_2.6.0.xml * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-project/pom.xml * hadoop-hdfs-project/hadoop-hdfs/dev-support/jdiff/Apache_Hadoop_HDFS_2.6.0.xml * hadoop-project-dist/pom.xml jdiff is broken in Hadoop 2 --- Key: HADOOP-11776 URL: https://issues.apache.org/jira/browse/HADOOP-11776 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.6.0 Reporter: Li Lu Assignee: Li Lu Priority: Blocker Fix For: 2.7.0 Attachments: HADOOP-11776-040115.patch Seems like we haven't touch the API files from jdiff under dev-support for a while. For now we're missing the jdiff API files for hadoop 2. We're also missing YARN when generating the jdiff API files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11776) jdiff is broken in Hadoop 2
[ https://issues.apache.org/jira/browse/HADOOP-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14395928#comment-14395928 ] Vinod Kumar Vavilapalli commented on HADOOP-11776: -- This looks good to me. +1. There is more work to be done, but the current patch should unblock the basic reporting. Checking this in. jdiff is broken in Hadoop 2 --- Key: HADOOP-11776 URL: https://issues.apache.org/jira/browse/HADOOP-11776 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.6.0 Reporter: Li Lu Assignee: Li Lu Priority: Blocker Attachments: HADOOP-11776-040115.patch Seems like we haven't touch the API files from jdiff under dev-support for a while. For now we're missing the jdiff API files for hadoop 2. We're also missing YARN when generating the jdiff API files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11776) jdiff is broken in Hadoop 2
[ https://issues.apache.org/jira/browse/HADOOP-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14393077#comment-14393077 ] Li Lu commented on HADOOP-11776: Tested the 3 failed tests locally, could reproduce none of them. The failed UTs appears to be irrelevant to the changes here. jdiff is broken in Hadoop 2 --- Key: HADOOP-11776 URL: https://issues.apache.org/jira/browse/HADOOP-11776 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.6.0 Reporter: Li Lu Assignee: Li Lu Priority: Blocker Attachments: HADOOP-11776-040115.patch Seems like we haven't touch the API files from jdiff under dev-support for a while. For now we're missing the jdiff API files for hadoop 2. We're also missing YARN when generating the jdiff API files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11776) jdiff is broken in Hadoop 2
[
https://issues.apache.org/jira/browse/HADOOP-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392198#comment-14392198
]
Hadoop QA commented on HADOOP-11776:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12708869/HADOOP-11776-040115.patch
against trunk revision f383fd9.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager
org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
org.apache.hadoop.hdfs.server.namenode.TestStartup
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/6048//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/6048//console
This message is automatically generated.
jdiff is broken in Hadoop 2
---
Key: HADOOP-11776
URL: https://issues.apache.org/jira/browse/HADOOP-11776
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 2.6.0
Reporter: Li Lu
Assignee: Li Lu
Priority: Blocker
Attachments: HADOOP-11776-040115.patch
Seems like we haven't touch the API files from jdiff under dev-support for a
while. For now we're missing the jdiff API files for hadoop 2. We're also
missing YARN when generating the jdiff API files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11776) jdiff is broken in Hadoop 2
[ https://issues.apache.org/jira/browse/HADOOP-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14387571#comment-14387571 ] Li Lu commented on HADOOP-11776: Hi [~busbey], thanks for the pointer! Will definitely look into that. jdiff is broken in Hadoop 2 --- Key: HADOOP-11776 URL: https://issues.apache.org/jira/browse/HADOOP-11776 Project: Hadoop Common Issue Type: Bug Reporter: Li Lu Assignee: Li Lu Priority: Blocker Seems like we haven't touch the API files from jdiff under dev-support for a while. For now we're missing the jdiff API files for hadoop 2. We're also missing YARN when generating the jdiff API files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11776) jdiff is broken in Hadoop 2
[ https://issues.apache.org/jira/browse/HADOOP-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14387565#comment-14387565 ] Sean Busbey commented on HADOOP-11776: -- Rather than working ot update the jdiff interfaces, you could switch to using the Java API Compliance Checker. That's what HBase uses, and they were kind enough to add support for API definitions via class annotations. So now we check compatibility via InterfaceAudience definitions directly. (see [our test script|https://github.com/apache/hbase/blob/master/dev-support/check_compatibility.sh] for info or HBASE-12808) jdiff is broken in Hadoop 2 --- Key: HADOOP-11776 URL: https://issues.apache.org/jira/browse/HADOOP-11776 Project: Hadoop Common Issue Type: Bug Reporter: Li Lu Assignee: Li Lu Priority: Blocker Seems like we haven't touch the API files from jdiff under dev-support for a while. For now we're missing the jdiff API files for hadoop 2. We're also missing YARN when generating the jdiff API files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
