[jira] [Commented] (HADOOP-11778) Update checkstyle
[ https://issues.apache.org/jira/browse/HADOOP-11778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519703#comment-14519703 ] Chris Nauroth commented on HADOOP-11778: [~jira.shegalov] has posted some other checkstyle configuration improvements on HADOOP-11889. He has agreed to fold the version upgrade into his patch, so I'm resolving this as a duplicate. Update checkstyle - Key: HADOOP-11778 URL: https://issues.apache.org/jira/browse/HADOOP-11778 Project: Hadoop Common Issue Type: Improvement Components: build, test Affects Versions: 3.0.0 Reporter: Allen Wittenauer Attachments: HADOOP-11778.000.patch We should update checkstyle so that mvn checkstyle:checkstyle-aggregate doesn't NPE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11778) Update checkstyle
[
https://issues.apache.org/jira/browse/HADOOP-11778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14515118#comment-14515118
]
Chris Nauroth commented on HADOOP-11778:
Thank you for the patch, Allen.
# Following Steve's suggestion, I found that it works to remove the definition
of the {{maven-checkstyle-plugin.version}} property from
hadoop-project/pom.xml, move it to the root pom.xml, and then have both
hadoop-project/pom.xml and pom.xml refer to the version using that property.
It does require a full {{mvn install}} from the root of the source tree after
the change to make it work when running checkstyle from within sub-modules, but
that's true no matter how we do this change.
# After the change, I could not run {{mvn checkstyle:checkstyle}} in the
hadoop-hdfs sub-module. After some digging, I found out that the
RedundantThrows checkstyle module was removed from the newer version. We need
to remove it from hadoop-hdfs/dev-support/checkstyle.xml. After I did that, it
worked. More details on that Checkstyle change are here:
https://github.com/checkstyle/checkstyle/issues/473
I can't find a clear statement of whether or not there is a different module
that replaces it. Maybe these rules are just folded into default configuration
now?
Update checkstyle
-
Key: HADOOP-11778
URL: https://issues.apache.org/jira/browse/HADOOP-11778
Project: Hadoop Common
Issue Type: Improvement
Components: build, test
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Attachments: HADOOP-11778.000.patch
We should update checkstyle so that mvn checkstyle:checkstyle-aggregate
doesn't NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11778) Update checkstyle
[
https://issues.apache.org/jira/browse/HADOOP-11778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388394#comment-14388394
]
Steve Loughran commented on HADOOP-11778:
-
could reference the version ${maven-checkstyle-plugin.version} in the root pom?
or is the dependency chain complex enough that it doesn't work that way?
Update checkstyle
-
Key: HADOOP-11778
URL: https://issues.apache.org/jira/browse/HADOOP-11778
Project: Hadoop Common
Issue Type: Improvement
Components: build, test
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Attachments: HADOOP-11778.000.patch
We should update checkstyle so that mvn checkstyle:checkstyle-aggregate
doesn't NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11778) Update checkstyle
[ https://issues.apache.org/jira/browse/HADOOP-11778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388620#comment-14388620 ] Allen Wittenauer commented on HADOOP-11778: --- My attempts at making it work all failed. :( Update checkstyle - Key: HADOOP-11778 URL: https://issues.apache.org/jira/browse/HADOOP-11778 Project: Hadoop Common Issue Type: Improvement Components: build, test Affects Versions: 3.0.0 Reporter: Allen Wittenauer Attachments: HADOOP-11778.000.patch We should update checkstyle so that mvn checkstyle:checkstyle-aggregate doesn't NPE. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11778) Update checkstyle
[
https://issues.apache.org/jira/browse/HADOOP-11778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14387965#comment-14387965
]
Hadoop QA commented on HADOOP-11778:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12708308/HADOOP-11778.000.patch
against trunk revision cce66ba.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/6029//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/6029//console
This message is automatically generated.
Update checkstyle
-
Key: HADOOP-11778
URL: https://issues.apache.org/jira/browse/HADOOP-11778
Project: Hadoop Common
Issue Type: Improvement
Components: build, test
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Attachments: HADOOP-11778.000.patch
We should update checkstyle so that mvn checkstyle:checkstyle-aggregate
doesn't NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
