[jira] [Commented] (HADOOP-12031) test-patch.sh should have an xml plugin
[
https://issues.apache.org/jira/browse/HADOOP-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565520#comment-14565520
]
Hadoop QA commented on HADOOP-12031:
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec | 0m 0s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch | 0m 0s | Pre-patch trunk compilation is
healthy. |
| {color:blue}0{color} | @author | 0m 0s | Skipping @author checks as
test-patch has been patched. |
| {color:green}+1{color} | release audit | 0m 15s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | shellcheck | 0m 5s | There were no new shellcheck
(v0.3.3) issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| | | 0m 23s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12736247/HADOOP-12031.005.patch
|
| Optional Tests | shellcheck |
| git revision | trunk / 7673d4f |
| Java | 1.7.0_55 |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6871/console |
This message was automatically generated.
test-patch.sh should have an xml plugin
---
Key: HADOOP-12031
URL: https://issues.apache.org/jira/browse/HADOOP-12031
Project: Hadoop Common
Issue Type: Test
Components: build
Reporter: Allen Wittenauer
Assignee: Kengo Seki
Labels: newbie, test-patch
Attachments: HADOOP-12031.001.patch, HADOOP-12031.002.patch,
HADOOP-12031.003.patch, HADOOP-12031.004.patch, HADOOP-12031.005.patch
HADOOP-11178 demonstrates why there is a need to verify xml files on a patch
change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12031) test-patch.sh should have an xml plugin
[ https://issues.apache.org/jira/browse/HADOOP-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565517#comment-14565517 ] Hadoop QA commented on HADOOP-12031: (!) A patch to test-patch or smart-apply-patch has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6871/console in case of problems. test-patch.sh should have an xml plugin --- Key: HADOOP-12031 URL: https://issues.apache.org/jira/browse/HADOOP-12031 Project: Hadoop Common Issue Type: Test Components: build Reporter: Allen Wittenauer Assignee: Kengo Seki Labels: newbie, test-patch Attachments: HADOOP-12031.001.patch, HADOOP-12031.002.patch, HADOOP-12031.003.patch, HADOOP-12031.004.patch, HADOOP-12031.005.patch HADOOP-11178 demonstrates why there is a need to verify xml files on a patch change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12031) test-patch.sh should have an xml plugin
[
https://issues.apache.org/jira/browse/HADOOP-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564026#comment-14564026
]
Hadoop QA commented on HADOOP-12031:
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec | 0m 0s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch | 0m 0s | Pre-patch trunk compilation is
healthy. |
| {color:blue}0{color} | @author | 0m 0s | Skipping @author checks as
test-patch has been patched. |
| {color:green}+1{color} | release audit | 0m 14s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | shellcheck | 0m 5s | There were no new shellcheck
(v0.3.3) issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| | | 0m 22s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12736003/HADOOP-12031.004.patch
|
| Optional Tests | shellcheck |
| git revision | trunk / 788bfa0 |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6862/console |
This message was automatically generated.
test-patch.sh should have an xml plugin
---
Key: HADOOP-12031
URL: https://issues.apache.org/jira/browse/HADOOP-12031
Project: Hadoop Common
Issue Type: Test
Components: build
Reporter: Allen Wittenauer
Assignee: Kengo Seki
Labels: newbie, test-patch
Attachments: HADOOP-12031.001.patch, HADOOP-12031.002.patch,
HADOOP-12031.003.patch, HADOOP-12031.004.patch
HADOOP-11178 demonstrates why there is a need to verify xml files on a patch
change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12031) test-patch.sh should have an xml plugin
[ https://issues.apache.org/jira/browse/HADOOP-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564024#comment-14564024 ] Hadoop QA commented on HADOOP-12031: (!) A patch to test-patch or smart-apply-patch has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6862/console in case of problems. test-patch.sh should have an xml plugin --- Key: HADOOP-12031 URL: https://issues.apache.org/jira/browse/HADOOP-12031 Project: Hadoop Common Issue Type: Test Components: build Reporter: Allen Wittenauer Assignee: Kengo Seki Labels: newbie, test-patch Attachments: HADOOP-12031.001.patch, HADOOP-12031.002.patch, HADOOP-12031.003.patch, HADOOP-12031.004.patch HADOOP-11178 demonstrates why there is a need to verify xml files on a patch change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12031) test-patch.sh should have an xml plugin
[
https://issues.apache.org/jira/browse/HADOOP-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562491#comment-14562491
]
Kengo Seki commented on HADOOP-12031:
-
Thank you very much, [~aw] [~busbey]. Thanks to your comments, I realize we can
use Java's scripting feature to make the plugin more simple and platform
independent. I tried this idea on OpenJDK 1.6 and 1.7, and it seems to work
fine.
{code}
# cat a.xml
configuration/
# cat b.xml
configuration
# /usr/lib/jvm/java-1.6.0-openjdk-1.6.0.35.x86_64/bin/jrunscript -e
'XMLDocument(arguments[0])' a.xml
# echo $?
0
# /usr/lib/jvm/java-1.6.0-openjdk-1.6.0.35.x86_64/bin/jrunscript -e
'XMLDocument(arguments[0])' b.xml
[Fatal Error] b.xml:2:1: XML document structures must start and end within the
same entity.
script error: sun.org.mozilla.javascript.WrappedException: Wrapped
org.xml.sax.SAXParseException; systemId: file:///tmp/b.xml; lineNumber: 2;
columnNumber: 1; XML document structures must start and end within the same
entity. (system-init#714) in system-init at line number 714
# echo $?
10
# /usr/lib/jvm/java-1.7.0-openjdk-1.7.0.79.x86_64/bin/jrunscript -e
'XMLDocument(arguments[0])' a.xml
# echo $?
0
# /usr/lib/jvm/java-1.7.0-openjdk-1.7.0.79.x86_64/bin/jrunscript -e
'XMLDocument(arguments[0])' b.xml
[Fatal Error] b.xml:2:1: XML document structures must start and end within the
same entity.
script error: sun.org.mozilla.javascript.WrappedException: Wrapped
org.xml.sax.SAXParseException; systemId: file:///tmp/b.xml; lineNumber: 2;
columnNumber: 1; XML document structures must start and end within the same
entity. (system-init#714) in system-init at line number 714
# echo $?
10
{code}
Since Java 8 replaced jrunscript with jjs, I must do some work such as version
detection, but it is not difficult.
Other comments also make sense to me. I'll fix them.
test-patch.sh should have an xml plugin
---
Key: HADOOP-12031
URL: https://issues.apache.org/jira/browse/HADOOP-12031
Project: Hadoop Common
Issue Type: Test
Components: build
Reporter: Allen Wittenauer
Assignee: Kengo Seki
Labels: newbie, test-patch
Attachments: HADOOP-12031.001.patch, HADOOP-12031.002.patch,
HADOOP-12031.003.patch
HADOOP-11178 demonstrates why there is a need to verify xml files on a patch
change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12031) test-patch.sh should have an xml plugin
[ https://issues.apache.org/jira/browse/HADOOP-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560521#comment-14560521 ] Kengo Seki commented on HADOOP-12031: - Thanks [~busbey]. As you pointed out, I realized that 002.patch does not work on Python 2.6-, because except ... as ... statement is supported from 2.6.1. So I'm planning: * If xmllint is available, use it * If not, try to validate using Python. In that case, use sys.exc_info() instead of except ... as ... statement. It makes the plugin to work on Python at least 2.1+ (including 3.x). test-patch.sh should have an xml plugin --- Key: HADOOP-12031 URL: https://issues.apache.org/jira/browse/HADOOP-12031 Project: Hadoop Common Issue Type: Test Components: build Reporter: Allen Wittenauer Assignee: Kengo Seki Labels: newbie, test-patch Attachments: HADOOP-12031.001.patch, HADOOP-12031.002.patch HADOOP-11178 demonstrates why there is a need to verify xml files on a patch change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12031) test-patch.sh should have an xml plugin
[ https://issues.apache.org/jira/browse/HADOOP-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562117#comment-14562117 ] Allen Wittenauer commented on HADOOP-12031: --- I guess there's nothing we can leverage that ships with the JVM is there? test-patch.sh should have an xml plugin --- Key: HADOOP-12031 URL: https://issues.apache.org/jira/browse/HADOOP-12031 Project: Hadoop Common Issue Type: Test Components: build Reporter: Allen Wittenauer Assignee: Kengo Seki Labels: newbie, test-patch Attachments: HADOOP-12031.001.patch, HADOOP-12031.002.patch, HADOOP-12031.003.patch HADOOP-11178 demonstrates why there is a need to verify xml files on a patch change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12031) test-patch.sh should have an xml plugin
[ https://issues.apache.org/jira/browse/HADOOP-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562243#comment-14562243 ] Allen Wittenauer commented on HADOOP-12031: --- OK, definitely a bug here. It looks like xmlwellformed_postapply isn't checking to see if it actually needs to execute via verify_needed_test. test-patch.sh should have an xml plugin --- Key: HADOOP-12031 URL: https://issues.apache.org/jira/browse/HADOOP-12031 Project: Hadoop Common Issue Type: Test Components: build Reporter: Allen Wittenauer Assignee: Kengo Seki Labels: newbie, test-patch Attachments: HADOOP-12031.001.patch, HADOOP-12031.002.patch, HADOOP-12031.003.patch HADOOP-11178 demonstrates why there is a need to verify xml files on a patch change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12031) test-patch.sh should have an xml plugin
[ https://issues.apache.org/jira/browse/HADOOP-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562249#comment-14562249 ] Allen Wittenauer commented on HADOOP-12031: --- Also: XML well-formedness is *really* long, especially in the JIRA table. Can we abbreviate that and the test name to be just xml? test-patch.sh should have an xml plugin --- Key: HADOOP-12031 URL: https://issues.apache.org/jira/browse/HADOOP-12031 Project: Hadoop Common Issue Type: Test Components: build Reporter: Allen Wittenauer Assignee: Kengo Seki Labels: newbie, test-patch Attachments: HADOOP-12031.001.patch, HADOOP-12031.002.patch, HADOOP-12031.003.patch HADOOP-11178 demonstrates why there is a need to verify xml files on a patch change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12031) test-patch.sh should have an xml plugin
[
https://issues.apache.org/jira/browse/HADOOP-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562285#comment-14562285
]
Sean Busbey commented on HADOOP-12031:
--
{quote}
I guess there's nothing we can leverage that ships with the JVM is there?
{quote}
interesting suggestion. there isn't any cli tool that comes out of the box
AFAICT.
However, we could write a simple utility to do this using
[DocumentBuilder|http://docs.oracle.com/javase/7/docs/api/javax/xml/parsers/DocumentBuilder.html]
for well-formedness and when a Schema is specified [the validation
package|http://docs.oracle.com/javase/7/docs/api/javax/xml/validation/package-summary.html]
for more specifics. Looking at the docs, I think we could make it work for
Java 5+.
test-patch.sh should have an xml plugin
---
Key: HADOOP-12031
URL: https://issues.apache.org/jira/browse/HADOOP-12031
Project: Hadoop Common
Issue Type: Test
Components: build
Reporter: Allen Wittenauer
Assignee: Kengo Seki
Labels: newbie, test-patch
Attachments: HADOOP-12031.001.patch, HADOOP-12031.002.patch,
HADOOP-12031.003.patch
HADOOP-11178 demonstrates why there is a need to verify xml files on a patch
change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12031) test-patch.sh should have an xml plugin
[
https://issues.apache.org/jira/browse/HADOOP-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562130#comment-14562130
]
Hadoop QA commented on HADOOP-12031:
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec | 0m 0s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch | 0m 0s | Pre-patch trunk compilation is
healthy. |
| {color:blue}0{color} | @author | 0m 0s | Skipping @author checks as
test-patch has been patched. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | shellcheck | 0m 5s | There were no new shellcheck
(v0.3.3) issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | XML well-formedness | 0m 0s | The patch has no
ill-formed XML file. |
| | | 0m 30s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12735733/HADOOP-12031.003.patch
|
| Optional Tests | shellcheck |
| git revision | trunk / 5450413 |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6849/console |
This message was automatically generated.
test-patch.sh should have an xml plugin
---
Key: HADOOP-12031
URL: https://issues.apache.org/jira/browse/HADOOP-12031
Project: Hadoop Common
Issue Type: Test
Components: build
Reporter: Allen Wittenauer
Assignee: Kengo Seki
Labels: newbie, test-patch
Attachments: HADOOP-12031.001.patch, HADOOP-12031.002.patch,
HADOOP-12031.003.patch
HADOOP-11178 demonstrates why there is a need to verify xml files on a patch
change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12031) test-patch.sh should have an xml plugin
[ https://issues.apache.org/jira/browse/HADOOP-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562128#comment-14562128 ] Hadoop QA commented on HADOOP-12031: (!) A patch to test-patch or smart-apply-patch has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6849/console in case of problems. test-patch.sh should have an xml plugin --- Key: HADOOP-12031 URL: https://issues.apache.org/jira/browse/HADOOP-12031 Project: Hadoop Common Issue Type: Test Components: build Reporter: Allen Wittenauer Assignee: Kengo Seki Labels: newbie, test-patch Attachments: HADOOP-12031.001.patch, HADOOP-12031.002.patch, HADOOP-12031.003.patch HADOOP-11178 demonstrates why there is a need to verify xml files on a patch change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12031) test-patch.sh should have an xml plugin
[ https://issues.apache.org/jira/browse/HADOOP-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560229#comment-14560229 ] Kengo Seki commented on HADOOP-12031: - whitespace plugin seems not to be able to detect the trailing whitespace in the first patch at line 33. But I don't know why for now. test-patch.sh should have an xml plugin --- Key: HADOOP-12031 URL: https://issues.apache.org/jira/browse/HADOOP-12031 Project: Hadoop Common Issue Type: Test Components: build Reporter: Allen Wittenauer Assignee: Kengo Seki Labels: newbie, test-patch Attachments: HADOOP-12031.001.patch, HADOOP-12031.002.patch HADOOP-11178 demonstrates why there is a need to verify xml files on a patch change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12031) test-patch.sh should have an xml plugin
[
https://issues.apache.org/jira/browse/HADOOP-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560447#comment-14560447
]
Sean Busbey commented on HADOOP-12031:
--
{quote}
One concern is, this plugin depends on Python currently. I assume we can use
Python in most build environment, but please advise if there is a more portable
and not-so-hard way to validate XML.
{quote}
Relying on python is problematic. If you stick with it, you'll need to detect
and gracefully degrade when the version you need isn't present.
If we're just checking well-formed-ness, how about using xmllint?
test-patch.sh should have an xml plugin
---
Key: HADOOP-12031
URL: https://issues.apache.org/jira/browse/HADOOP-12031
Project: Hadoop Common
Issue Type: Test
Components: build
Reporter: Allen Wittenauer
Assignee: Kengo Seki
Labels: newbie, test-patch
Attachments: HADOOP-12031.001.patch, HADOOP-12031.002.patch
HADOOP-11178 demonstrates why there is a need to verify xml files on a patch
change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12031) test-patch.sh should have an xml plugin
[ https://issues.apache.org/jira/browse/HADOOP-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560094#comment-14560094 ] Hadoop QA commented on HADOOP-12031: (!) A patch to test-patch or smart-apply-patch has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6832/console in case of problems. test-patch.sh should have an xml plugin --- Key: HADOOP-12031 URL: https://issues.apache.org/jira/browse/HADOOP-12031 Project: Hadoop Common Issue Type: Test Components: build Reporter: Allen Wittenauer Assignee: Kengo Seki Labels: newbie, test-patch Attachments: HADOOP-12031.001.patch HADOOP-11178 demonstrates why there is a need to verify xml files on a patch change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12031) test-patch.sh should have an xml plugin
[
https://issues.apache.org/jira/browse/HADOOP-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560096#comment-14560096
]
Hadoop QA commented on HADOOP-12031:
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec | 0m 0s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch | 0m 0s | Pre-patch trunk compilation is
healthy. |
| {color:blue}0{color} | @author | 0m 0s | Skipping @author checks as
test-patch has been patched. |
| {color:green}+1{color} | release audit | 0m 15s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | shellcheck | 0m 4s | There were no new shellcheck
(v0.3.3) issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no ill-formed
XML file. |
| | | 0m 23s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12735441/HADOOP-12031.001.patch
|
| Optional Tests | shellcheck |
| git revision | trunk / cdbd66b |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6832/console |
This message was automatically generated.
test-patch.sh should have an xml plugin
---
Key: HADOOP-12031
URL: https://issues.apache.org/jira/browse/HADOOP-12031
Project: Hadoop Common
Issue Type: Test
Components: build
Reporter: Allen Wittenauer
Assignee: Kengo Seki
Labels: newbie, test-patch
Attachments: HADOOP-12031.001.patch
HADOOP-11178 demonstrates why there is a need to verify xml files on a patch
change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12031) test-patch.sh should have an xml plugin
[ https://issues.apache.org/jira/browse/HADOOP-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560128#comment-14560128 ] Hadoop QA commented on HADOOP-12031: (!) A patch to test-patch or smart-apply-patch has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6833/console in case of problems. test-patch.sh should have an xml plugin --- Key: HADOOP-12031 URL: https://issues.apache.org/jira/browse/HADOOP-12031 Project: Hadoop Common Issue Type: Test Components: build Reporter: Allen Wittenauer Assignee: Kengo Seki Labels: newbie, test-patch Attachments: HADOOP-12031.001.patch, HADOOP-12031.002.patch HADOOP-11178 demonstrates why there is a need to verify xml files on a patch change. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12031) test-patch.sh should have an xml plugin
[
https://issues.apache.org/jira/browse/HADOOP-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560131#comment-14560131
]
Hadoop QA commented on HADOOP-12031:
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec | 0m 0s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch | 0m 0s | Pre-patch trunk compilation is
healthy. |
| {color:blue}0{color} | @author | 0m 0s | Skipping @author checks as
test-patch has been patched. |
| {color:green}+1{color} | release audit | 0m 15s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | shellcheck | 0m 4s | There were no new shellcheck
(v0.3.3) issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | XML well-formedness | 0m 0s | The patch has no
ill-formed XML file. |
| | | 0m 23s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12735458/HADOOP-12031.002.patch
|
| Optional Tests | shellcheck |
| git revision | trunk / cdbd66b |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6833/console |
This message was automatically generated.
test-patch.sh should have an xml plugin
---
Key: HADOOP-12031
URL: https://issues.apache.org/jira/browse/HADOOP-12031
Project: Hadoop Common
Issue Type: Test
Components: build
Reporter: Allen Wittenauer
Assignee: Kengo Seki
Labels: newbie, test-patch
Attachments: HADOOP-12031.001.patch, HADOOP-12031.002.patch
HADOOP-11178 demonstrates why there is a need to verify xml files on a patch
change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
