[jira] [Commented] (HADOOP-12172) FsShell mkdir -p makes an unnecessary check for the existence of the parent.
[
https://issues.apache.org/jira/browse/HADOOP-12172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613943#comment-14613943
]
Hudson commented on HADOOP-12172:
-
FAILURE: Integrated in Hadoop-Mapreduce-trunk #2192 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2192/])
HADOOP-12172. FsShell mkdir -p makes an unnecessary check for the existence of
the parent. Contributed by Chris Nauroth. (cnauroth: rev
f3796224bfdfd88e2428cc8a9915bdfdc62b48f3)
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Mkdir.java
> FsShell mkdir -p makes an unnecessary check for the existence of the parent.
>
>
> Key: HADOOP-12172
> URL: https://issues.apache.org/jira/browse/HADOOP-12172
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HADOOP-12172.001.patch
>
>
> The {{mkdir}} command in {{FsShell}} checks for the existence of the parent
> of the directory and returns an error if it doesn't exist. The {{-p}} option
> suppresses the error and allows the directory creation to continue,
> implicitly creating all missing intermediate directories. However, the
> existence check still runs even with {{-p}} specified, and its result is
> ignored. Depending on the file system, this is a wasteful RPC call (HDFS) or
> HTTP request (WebHDFS/S3/Azure) imposing extra latency for the client and
> extra load for the server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12172) FsShell mkdir -p makes an unnecessary check for the existence of the parent.
[
https://issues.apache.org/jira/browse/HADOOP-12172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613898#comment-14613898
]
Hudson commented on HADOOP-12172:
-
SUCCESS: Integrated in Hadoop-Hdfs-trunk #2173 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2173/])
HADOOP-12172. FsShell mkdir -p makes an unnecessary check for the existence of
the parent. Contributed by Chris Nauroth. (cnauroth: rev
f3796224bfdfd88e2428cc8a9915bdfdc62b48f3)
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Mkdir.java
> FsShell mkdir -p makes an unnecessary check for the existence of the parent.
>
>
> Key: HADOOP-12172
> URL: https://issues.apache.org/jira/browse/HADOOP-12172
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HADOOP-12172.001.patch
>
>
> The {{mkdir}} command in {{FsShell}} checks for the existence of the parent
> of the directory and returns an error if it doesn't exist. The {{-p}} option
> suppresses the error and allows the directory creation to continue,
> implicitly creating all missing intermediate directories. However, the
> existence check still runs even with {{-p}} specified, and its result is
> ignored. Depending on the file system, this is a wasteful RPC call (HDFS) or
> HTTP request (WebHDFS/S3/Azure) imposing extra latency for the client and
> extra load for the server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12172) FsShell mkdir -p makes an unnecessary check for the existence of the parent.
[
https://issues.apache.org/jira/browse/HADOOP-12172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613882#comment-14613882
]
Hudson commented on HADOOP-12172:
-
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #234 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/234/])
HADOOP-12172. FsShell mkdir -p makes an unnecessary check for the existence of
the parent. Contributed by Chris Nauroth. (cnauroth: rev
f3796224bfdfd88e2428cc8a9915bdfdc62b48f3)
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Mkdir.java
* hadoop-common-project/hadoop-common/CHANGES.txt
> FsShell mkdir -p makes an unnecessary check for the existence of the parent.
>
>
> Key: HADOOP-12172
> URL: https://issues.apache.org/jira/browse/HADOOP-12172
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HADOOP-12172.001.patch
>
>
> The {{mkdir}} command in {{FsShell}} checks for the existence of the parent
> of the directory and returns an error if it doesn't exist. The {{-p}} option
> suppresses the error and allows the directory creation to continue,
> implicitly creating all missing intermediate directories. However, the
> existence check still runs even with {{-p}} specified, and its result is
> ignored. Depending on the file system, this is a wasteful RPC call (HDFS) or
> HTTP request (WebHDFS/S3/Azure) imposing extra latency for the client and
> extra load for the server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12172) FsShell mkdir -p makes an unnecessary check for the existence of the parent.
[
https://issues.apache.org/jira/browse/HADOOP-12172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613866#comment-14613866
]
Hudson commented on HADOOP-12172:
-
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #244 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/244/])
HADOOP-12172. FsShell mkdir -p makes an unnecessary check for the existence of
the parent. Contributed by Chris Nauroth. (cnauroth: rev
f3796224bfdfd88e2428cc8a9915bdfdc62b48f3)
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Mkdir.java
> FsShell mkdir -p makes an unnecessary check for the existence of the parent.
>
>
> Key: HADOOP-12172
> URL: https://issues.apache.org/jira/browse/HADOOP-12172
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HADOOP-12172.001.patch
>
>
> The {{mkdir}} command in {{FsShell}} checks for the existence of the parent
> of the directory and returns an error if it doesn't exist. The {{-p}} option
> suppresses the error and allows the directory creation to continue,
> implicitly creating all missing intermediate directories. However, the
> existence check still runs even with {{-p}} specified, and its result is
> ignored. Depending on the file system, this is a wasteful RPC call (HDFS) or
> HTTP request (WebHDFS/S3/Azure) imposing extra latency for the client and
> extra load for the server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12172) FsShell mkdir -p makes an unnecessary check for the existence of the parent.
[
https://issues.apache.org/jira/browse/HADOOP-12172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613827#comment-14613827
]
Hudson commented on HADOOP-12172:
-
SUCCESS: Integrated in Hadoop-Yarn-trunk #976 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/976/])
HADOOP-12172. FsShell mkdir -p makes an unnecessary check for the existence of
the parent. Contributed by Chris Nauroth. (cnauroth: rev
f3796224bfdfd88e2428cc8a9915bdfdc62b48f3)
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Mkdir.java
> FsShell mkdir -p makes an unnecessary check for the existence of the parent.
>
>
> Key: HADOOP-12172
> URL: https://issues.apache.org/jira/browse/HADOOP-12172
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HADOOP-12172.001.patch
>
>
> The {{mkdir}} command in {{FsShell}} checks for the existence of the parent
> of the directory and returns an error if it doesn't exist. The {{-p}} option
> suppresses the error and allows the directory creation to continue,
> implicitly creating all missing intermediate directories. However, the
> existence check still runs even with {{-p}} specified, and its result is
> ignored. Depending on the file system, this is a wasteful RPC call (HDFS) or
> HTTP request (WebHDFS/S3/Azure) imposing extra latency for the client and
> extra load for the server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12172) FsShell mkdir -p makes an unnecessary check for the existence of the parent.
[
https://issues.apache.org/jira/browse/HADOOP-12172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613810#comment-14613810
]
Hudson commented on HADOOP-12172:
-
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #246 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/246/])
HADOOP-12172. FsShell mkdir -p makes an unnecessary check for the existence of
the parent. Contributed by Chris Nauroth. (cnauroth: rev
f3796224bfdfd88e2428cc8a9915bdfdc62b48f3)
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Mkdir.java
* hadoop-common-project/hadoop-common/CHANGES.txt
> FsShell mkdir -p makes an unnecessary check for the existence of the parent.
>
>
> Key: HADOOP-12172
> URL: https://issues.apache.org/jira/browse/HADOOP-12172
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HADOOP-12172.001.patch
>
>
> The {{mkdir}} command in {{FsShell}} checks for the existence of the parent
> of the directory and returns an error if it doesn't exist. The {{-p}} option
> suppresses the error and allows the directory creation to continue,
> implicitly creating all missing intermediate directories. However, the
> existence check still runs even with {{-p}} specified, and its result is
> ignored. Depending on the file system, this is a wasteful RPC call (HDFS) or
> HTTP request (WebHDFS/S3/Azure) imposing extra latency for the client and
> extra load for the server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12172) FsShell mkdir -p makes an unnecessary check for the existence of the parent.
[
https://issues.apache.org/jira/browse/HADOOP-12172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611406#comment-14611406
]
Hudson commented on HADOOP-12172:
-
FAILURE: Integrated in Hadoop-trunk-Commit #8110 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/8110/])
HADOOP-12172. FsShell mkdir -p makes an unnecessary check for the existence of
the parent. Contributed by Chris Nauroth. (cnauroth: rev
f3796224bfdfd88e2428cc8a9915bdfdc62b48f3)
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Mkdir.java
> FsShell mkdir -p makes an unnecessary check for the existence of the parent.
>
>
> Key: HADOOP-12172
> URL: https://issues.apache.org/jira/browse/HADOOP-12172
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HADOOP-12172.001.patch
>
>
> The {{mkdir}} command in {{FsShell}} checks for the existence of the parent
> of the directory and returns an error if it doesn't exist. The {{-p}} option
> suppresses the error and allows the directory creation to continue,
> implicitly creating all missing intermediate directories. However, the
> existence check still runs even with {{-p}} specified, and its result is
> ignored. Depending on the file system, this is a wasteful RPC call (HDFS) or
> HTTP request (WebHDFS/S3/Azure) imposing extra latency for the client and
> extra load for the server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12172) FsShell mkdir -p makes an unnecessary check for the existence of the parent.
[
https://issues.apache.org/jira/browse/HADOOP-12172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611352#comment-14611352
]
Brahma Reddy Battula commented on HADOOP-12172:
---
Nice Catch [~cnauroth],,+1 (non-binding).
> FsShell mkdir -p makes an unnecessary check for the existence of the parent.
>
>
> Key: HADOOP-12172
> URL: https://issues.apache.org/jira/browse/HADOOP-12172
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
>Priority: Minor
> Attachments: HADOOP-12172.001.patch
>
>
> The {{mkdir}} command in {{FsShell}} checks for the existence of the parent
> of the directory and returns an error if it doesn't exist. The {{-p}} option
> suppresses the error and allows the directory creation to continue,
> implicitly creating all missing intermediate directories. However, the
> existence check still runs even with {{-p}} specified, and its result is
> ignored. Depending on the file system, this is a wasteful RPC call (HDFS) or
> HTTP request (WebHDFS/S3/Azure) imposing extra latency for the client and
> extra load for the server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12172) FsShell mkdir -p makes an unnecessary check for the existence of the parent.
[
https://issues.apache.org/jira/browse/HADOOP-12172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611318#comment-14611318
]
Hadoop QA commented on HADOOP-12172:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 16m 30s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 34s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 38s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 24s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 1m 2s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 50s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests | 22m 9s | Tests passed in
hadoop-common. |
| | | 61m 18s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12743169/HADOOP-12172.001.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 0e4b066 |
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7131/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7131/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7131/console |
This message was automatically generated.
> FsShell mkdir -p makes an unnecessary check for the existence of the parent.
>
>
> Key: HADOOP-12172
> URL: https://issues.apache.org/jira/browse/HADOOP-12172
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
>Priority: Minor
> Attachments: HADOOP-12172.001.patch
>
>
> The {{mkdir}} command in {{FsShell}} checks for the existence of the parent
> of the directory and returns an error if it doesn't exist. The {{-p}} option
> suppresses the error and allows the directory creation to continue,
> implicitly creating all missing intermediate directories. However, the
> existence check still runs even with {{-p}} specified, and its result is
> ignored. Depending on the file system, this is a wasteful RPC call (HDFS) or
> HTTP request (WebHDFS/S3/Azure) imposing extra latency for the client and
> extra load for the server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12172) FsShell mkdir -p makes an unnecessary check for the existence of the parent.
[
https://issues.apache.org/jira/browse/HADOOP-12172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611287#comment-14611287
]
Yi Liu commented on HADOOP-12172:
-
+1, thanks Chris
> FsShell mkdir -p makes an unnecessary check for the existence of the parent.
>
>
> Key: HADOOP-12172
> URL: https://issues.apache.org/jira/browse/HADOOP-12172
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
>Priority: Minor
> Attachments: HADOOP-12172.001.patch
>
>
> The {{mkdir}} command in {{FsShell}} checks for the existence of the parent
> of the directory and returns an error if it doesn't exist. The {{-p}} option
> suppresses the error and allows the directory creation to continue,
> implicitly creating all missing intermediate directories. However, the
> existence check still runs even with {{-p}} specified, and its result is
> ignored. Depending on the file system, this is a wasteful RPC call (HDFS) or
> HTTP request (WebHDFS/S3/Azure) imposing extra latency for the client and
> extra load for the server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
