[jira] [Commented] (HADOOP-12463) TestShell.testGetSignalKillCommand failing on windows
[ https://issues.apache.org/jira/browse/HADOOP-12463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501936#comment-16501936 ] Steve Loughran commented on HADOOP-12463: - As discussed, this is probably a DONE or CANNOT REPRODUCE; it just needs people to play with to be sure that's the case > TestShell.testGetSignalKillCommand failing on windows > - > > Key: HADOOP-12463 > URL: https://issues.apache.org/jira/browse/HADOOP-12463 > Project: Hadoop Common > Issue Type: Sub-task > Components: test >Affects Versions: 2.8.0, 3.0.0-alpha1 > Environment: windows >Reporter: Steve Loughran >Priority: Critical > Attachments: HADOOP-12463-001.patch, HADOOP-12463.1.branch-2.patch > > > TestShell.testGetSignalKillCommand is failing on windows; the command to > query a process isn't that which the test expects. > Maybe we need to have some policy that nothing goes into Shell without being > tested on Windows first: its where things meet. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-12463) TestShell.testGetSignalKillCommand failing on windows
[ https://issues.apache.org/jira/browse/HADOOP-12463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112505#comment-16112505 ] Steve Loughran commented on HADOOP-12463: - HADOOP-14724 will tell us if this has gone away. If so, yes, let's close as a dupe > TestShell.testGetSignalKillCommand failing on windows > - > > Key: HADOOP-12463 > URL: https://issues.apache.org/jira/browse/HADOOP-12463 > Project: Hadoop Common > Issue Type: Bug > Components: test >Affects Versions: 2.8.0, 3.0.0-alpha1 >Reporter: Steve Loughran >Priority: Critical > Attachments: HADOOP-12463-001.patch, HADOOP-12463.1.branch-2.patch > > > TestShell.testGetSignalKillCommand is failing on windows; the command to > query a process isn't that which the test expects. > Maybe we need to have some policy that nothing goes into Shell without being > tested on Windows first: its where things meet. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-12463) TestShell.testGetSignalKillCommand failing on windows
[ https://issues.apache.org/jira/browse/HADOOP-12463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823403#comment-15823403 ] Brahma Reddy Battula commented on HADOOP-12463: --- HADOOP-10775 is fixed this issue.. if you all agree, will close as dupe of HADOOP-10775.. > TestShell.testGetSignalKillCommand failing on windows > - > > Key: HADOOP-12463 > URL: https://issues.apache.org/jira/browse/HADOOP-12463 > Project: Hadoop Common > Issue Type: Bug > Components: test >Affects Versions: 2.8.0, 3.0.0-alpha1 >Reporter: Steve Loughran >Priority: Critical > Attachments: HADOOP-12463-001.patch, HADOOP-12463.1.branch-2.patch > > > TestShell.testGetSignalKillCommand is failing on windows; the command to > query a process isn't that which the test expects. > Maybe we need to have some policy that nothing goes into Shell without being > tested on Windows first: its where things meet. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-12463) TestShell.testGetSignalKillCommand failing on windows
[ https://issues.apache.org/jira/browse/HADOOP-12463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14950092#comment-14950092 ] Steve Loughran commented on HADOOP-12463: - If we can get my HADOOP-12463 in to branch-2 then we don't need this patch. I've already had to deal with the merge/diff pain from the HADOOP-12441 patch -I really don't want to have to deal with the same pain for a patch which essentially my own work > TestShell.testGetSignalKillCommand failing on windows > - > > Key: HADOOP-12463 > URL: https://issues.apache.org/jira/browse/HADOOP-12463 > Project: Hadoop Common > Issue Type: Bug > Components: test >Affects Versions: 2.8.0, 3.0.0 >Reporter: Steve Loughran >Priority: Critical > Attachments: HADOOP-12463-001.patch, HADOOP-12463.1.branch-2.patch > > > TestShell.testGetSignalKillCommand is failing on windows; the command to > query a process isn't that which the test expects. > Maybe we need to have some policy that nothing goes into Shell without being > tested on Windows first: its where things meet. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12463) TestShell.testGetSignalKillCommand failing on windows
[ https://issues.apache.org/jira/browse/HADOOP-12463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949515#comment-14949515 ] Chris Nauroth commented on HADOOP-12463: [~leftnoteasy], thanks for the branch-2 patch. I just ran it on Windows, and the test passed, so +1 for the patch pending a Jenkins run. > TestShell.testGetSignalKillCommand failing on windows > - > > Key: HADOOP-12463 > URL: https://issues.apache.org/jira/browse/HADOOP-12463 > Project: Hadoop Common > Issue Type: Bug > Components: test >Affects Versions: 2.8.0, 3.0.0 >Reporter: Steve Loughran >Priority: Critical > Attachments: HADOOP-12463-001.patch, HADOOP-12463.1.branch-2.patch > > > TestShell.testGetSignalKillCommand is failing on windows; the command to > query a process isn't that which the test expects. > Maybe we need to have some policy that nothing goes into Shell without being > tested on Windows first: its where things meet. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12463) TestShell.testGetSignalKillCommand failing on windows
[ https://issues.apache.org/jira/browse/HADOOP-12463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949479#comment-14949479 ] Wangda Tan commented on HADOOP-12463: - Thanks [~steve_l]! I have also attached fix for branch-2. > TestShell.testGetSignalKillCommand failing on windows > - > > Key: HADOOP-12463 > URL: https://issues.apache.org/jira/browse/HADOOP-12463 > Project: Hadoop Common > Issue Type: Bug > Components: test >Affects Versions: 2.8.0, 3.0.0 >Reporter: Steve Loughran >Priority: Critical > Attachments: HADOOP-12463-001.patch, HADOOP-12463.1.branch-2.patch > > > TestShell.testGetSignalKillCommand is failing on windows; the command to > query a process isn't that which the test expects. > Maybe we need to have some policy that nothing goes into Shell without being > tested on Windows first: its where things meet. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12463) TestShell.testGetSignalKillCommand failing on windows
[
https://issues.apache.org/jira/browse/HADOOP-12463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945673#comment-14945673
]
Steve Loughran commented on HADOOP-12463:
-
{code}
Running org.apache.hadoop.util.TestShell
Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.266 sec <<<
FAILURE! - in org.apache.hadoop.util.TestShell
testGetSignalKillCommand(org.apache.hadoop.util.TestShell) Time elapsed: 0.016
sec <<< FAILURE!
org.junit.internal.ArrayComparisonFailure: arrays first differed at element
[2]; expected:<[isAlive]> but was:<[kill]>
at
org.junit.internal.ComparisonCriteria.arrayEquals(ComparisonCriteria.java:50)
at org.junit.Assert.internalArrayEquals(Assert.java:473)
at org.junit.Assert.assertArrayEquals(Assert.java:265)
at org.junit.Assert.assertArrayEquals(Assert.java:280)
at
org.apache.hadoop.util.TestShell.testGetSignalKillCommand(TestShell.java:189)
{code}
> TestShell.testGetSignalKillCommand failing on windows
> -
>
> Key: HADOOP-12463
> URL: https://issues.apache.org/jira/browse/HADOOP-12463
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0
>Reporter: Steve Loughran
>Priority: Critical
>
> TestShell.testGetSignalKillCommand is failing on windows; the command to
> query a process isn't that which the test expects.
> Maybe we need to have some policy that nothing goes into Shell without being
> tested on Windows first: its where things meet.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
