[jira] [Commented] (HADOOP-12647) Allowing to use -Drequire.isal but without -Disal.prefix and -Disal.lib to build ISA-L support
[
https://issues.apache.org/jira/browse/HADOOP-12647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063814#comment-15063814
]
Hadoop QA commented on HADOOP-12647:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
33s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m 13s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m 30s
{color} | {color:green} trunk passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 7s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 58s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 6s
{color} | {color:green} trunk passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
43s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 42s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 8m 42s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 8m 42s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m 20s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 9m 20s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 9m 20s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 5s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 0s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 58s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 5s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 8m 28s
{color} | {color:green} hadoop-common in the patch passed with JDK v1.8.0_66.
{color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 17m 18s {color}
| {color:red} hadoop-common in the patch failed with JDK v1.7.0_91. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 80m 51s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.7.0_91 Failed junit tests | hadoop.metrics2.impl.TestGangliaMetrics |
| JDK v1.7.0_91 Timed out junit tests |
org.apache.hadoop.http.TestHttpServerLifecycle |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:0ca8df7 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12777952/HADOOP-12647-v1.patch
|
| JIRA Issue | HADOOP-12647 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit xml cc |
| uname | Linux 64969a002c56 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Commented] (HADOOP-12647) Allowing to use -Drequire.isal but without -Disal.prefix and -Disal.lib to build ISA-L support
[ https://issues.apache.org/jira/browse/HADOOP-12647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064153#comment-15064153 ] Colin Patrick McCabe commented on HADOOP-12647: --- +1. Thanks, Kai. > Allowing to use -Drequire.isal but without -Disal.prefix and -Disal.lib to > build ISA-L support > -- > > Key: HADOOP-12647 > URL: https://issues.apache.org/jira/browse/HADOOP-12647 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Kai Zheng >Assignee: Kai Zheng > Attachments: HADOOP-12647-v1.patch > > > It was found the building will fail when use -Drequire.isal only (without > -Disal.prefix and -Disal.lib options) to build ISA-L in order to use the > default library installation. The cause is the mvn executor doesn't know > where to find the dynamic so file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12647) Allowing to use -Drequire.isal but without -Disal.prefix and -Disal.lib to build ISA-L support
[
https://issues.apache.org/jira/browse/HADOOP-12647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15059720#comment-15059720
]
Kai Zheng commented on HADOOP-12647:
Tested the changes as follows:
* Case 1. Build with default ISA-L installation
** Installing ISA-L to /usr/lib the default folder the library uses
** mvn build hadoop using -Drequire.isal option only, run {{mvn -Pnative
package -Drequire.isal -DskipTests -Pdist}} passed
* Case 2. Build with customized ISA-L installation
** Installing ISA-L to a custom folder like /tmp/isal
** mvn build hadoop using the installation, run {{mvn -Pnative package
-Drequire.isal -Disal.prefix=/tmp/isal -DskipTests -Pdist}} passed
* Case 3. Build tar dist package with customized ISA-L installaton
** Installing ISA-L to a custom folder like /tmp/isal
** mvn build hadoop using the installation, run {{mvn -Pnative package
-Drequire.isal -Disal.lib=/tmp/isal -Dbundle.isal -DskipTests -Pdist -Dtar}}
passed
** Checked the result tar package is valid and contains ISA-L library files
In all cases, run {{hadoop checknative}} passed.
Also tested negative cases.
> Allowing to use -Drequire.isal but without -Disal.prefix and -Disal.lib to
> build ISA-L support
> --
>
> Key: HADOOP-12647
> URL: https://issues.apache.org/jira/browse/HADOOP-12647
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Kai Zheng
>Assignee: Kai Zheng
> Attachments: HADOOP-12647-v1.patch
>
>
> It was found the building will fail when use -Drequire.isal only (without
> -Disal.prefix and -Disal.lib options) to build ISA-L in order to use the
> default library installation. The cause is the mvn executor doesn't know
> where to find the dynamic so file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
