[jira] [Commented] (HADOOP-13154) S3AFileSystem printAmazonServiceException/printAmazonClientException appear copy & paste of AWS examples
[
https://issues.apache.org/jira/browse/HADOOP-13154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292699#comment-15292699
]
Chris Nauroth commented on HADOOP-13154:
Before committing this, I had a successful full test run against my S3 buckets
in US-west-2.
> S3AFileSystem printAmazonServiceException/printAmazonClientException appear
> copy & paste of AWS examples
>
>
> Key: HADOOP-13154
> URL: https://issues.apache.org/jira/browse/HADOOP-13154
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
>Affects Versions: 2.7.2
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Blocker
> Fix For: 2.7.3
>
> Attachments: HADOOP-13154-branch-2.7-001.patch
>
>
> The logging code in {{S3AFileSystem.printAmazonServiceException()}} and
> {{printAmazonClientException}} appear to be paste + edits of the example code
> in the amazon SDK, such as
> [http://docs.aws.amazon.com/AmazonS3/latest/dev/ListingObjectKeysUsingJava.html]]
> Either we review the license to validate it, and add credits to the code if
> compatible, or we rework. HADOOP-13130 would be the place to do that, as it
> is changing exception handling anyway.
> tagging as blocker as it is license related
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13154) S3AFileSystem printAmazonServiceException/printAmazonClientException appear copy & paste of AWS examples
[
https://issues.apache.org/jira/browse/HADOOP-13154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291588#comment-15291588
]
Chris Nauroth commented on HADOOP-13154:
The patch looks good. I'll take it through a test run on branch-2.7 later
today.
> S3AFileSystem printAmazonServiceException/printAmazonClientException appear
> copy & paste of AWS examples
>
>
> Key: HADOOP-13154
> URL: https://issues.apache.org/jira/browse/HADOOP-13154
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
>Affects Versions: 2.7.2
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Blocker
> Attachments: HADOOP-13154-branch-2.7-001.patch
>
>
> The logging code in {{S3AFileSystem.printAmazonServiceException()}} and
> {{printAmazonClientException}} appear to be paste + edits of the example code
> in the amazon SDK, such as
> [http://docs.aws.amazon.com/AmazonS3/latest/dev/ListingObjectKeysUsingJava.html]]
> Either we review the license to validate it, and add credits to the code if
> compatible, or we rework. HADOOP-13130 would be the place to do that, as it
> is changing exception handling anyway.
> tagging as blocker as it is license related
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13154) S3AFileSystem printAmazonServiceException/printAmazonClientException appear copy & paste of AWS examples
[
https://issues.apache.org/jira/browse/HADOOP-13154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291571#comment-15291571
]
Hadoop QA commented on HADOOP-13154:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
46s {color} | {color:green} branch-2.7 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 10s
{color} | {color:green} branch-2.7 passed with JDK v1.8.0_91 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 12s
{color} | {color:green} branch-2.7 passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s {color} | {color:green} branch-2.7 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 21s
{color} | {color:green} branch-2.7 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
40s {color} | {color:green} branch-2.7 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
41s {color} | {color:green} branch-2.7 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 14s
{color} | {color:green} branch-2.7 passed with JDK v1.8.0_91 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 14s
{color} | {color:green} branch-2.7 passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
14s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 12s
{color} | {color:green} the patch passed with JDK v1.8.0_91 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 12s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 10s
{color} | {color:green} the patch passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 10s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s {color} | {color:green} hadoop-tools/hadoop-aws: The patch generated 0 new
+ 205 unchanged - 8 fixed = 205 total (was 213) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 16s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 1102 line(s) that end in whitespace. Use
git apply --whitespace=fix. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 26s
{color} | {color:red} The patch 70 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
43s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 12s
{color} | {color:green} the patch passed with JDK v1.8.0_91 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 13s
{color} | {color:green} the patch passed with JDK v1.7.0_101 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 11s
{color} | {color:green} hadoop-aws in the patch passed with JDK v1.8.0_91.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 11s
{color} | {color:green} hadoop-aws in the patch passed with JDK v1.7.0_101.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 16m 50s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:c420dfe |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12804918/HADOOP-13154-branch-2.7-001.patch
|
| JIRA Issue | HADOOP-13154 |
|
[jira] [Commented] (HADOOP-13154) S3AFileSystem printAmazonServiceException/printAmazonClientException appear copy & paste of AWS examples
[
https://issues.apache.org/jira/browse/HADOOP-13154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290976#comment-15290976
]
Steve Loughran commented on HADOOP-13154:
-
BTW, that commit you found with git blame isn't in branch-2.7; the code came in
HADOOP-10400, the original S3A donation.
> S3AFileSystem printAmazonServiceException/printAmazonClientException appear
> copy & paste of AWS examples
>
>
> Key: HADOOP-13154
> URL: https://issues.apache.org/jira/browse/HADOOP-13154
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
>Affects Versions: 2.7.2
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Blocker
> Attachments: HADOOP-13154-branch-2.7-001.patch
>
>
> The logging code in {{S3AFileSystem.printAmazonServiceException()}} and
> {{printAmazonClientException}} appear to be paste + edits of the example code
> in the amazon SDK, such as
> [http://docs.aws.amazon.com/AmazonS3/latest/dev/ListingObjectKeysUsingJava.html]]
> Either we review the license to validate it, and add credits to the code if
> compatible, or we rework. HADOOP-13130 would be the place to do that, as it
> is changing exception handling anyway.
> tagging as blocker as it is license related
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13154) S3AFileSystem printAmazonServiceException/printAmazonClientException appear copy & paste of AWS examples
[
https://issues.apache.org/jira/browse/HADOOP-13154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286272#comment-15286272
]
Steve Loughran commented on HADOOP-13154:
-
Oh, it's been along for a while, I was the one who put in the contributed code.
I only realised yesterday that this is the case.
in HADOOP-13130 I pull the methods out, but that is part of a bigger diff.
I think for 2.7 we can/should just add a comment in the credits of the file
(and other license file) saying "from Amazon"
> S3AFileSystem printAmazonServiceException/printAmazonClientException appear
> copy & paste of AWS examples
>
>
> Key: HADOOP-13154
> URL: https://issues.apache.org/jira/browse/HADOOP-13154
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
>Affects Versions: 2.7.2
>Reporter: Steve Loughran
>Priority: Blocker
>
> The logging code in {{S3AFileSystem.printAmazonServiceException()}} and
> {{printAmazonClientException}} appear to be paste + edits of the example code
> in the amazon SDK, such as
> [http://docs.aws.amazon.com/AmazonS3/latest/dev/ListingObjectKeysUsingJava.html]]
> Either we review the license to validate it, and add credits to the code if
> compatible, or we rework. HADOOP-13130 would be the place to do that, as it
> is changing exception handling anyway.
> tagging as blocker as it is license related
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13154) S3AFileSystem printAmazonServiceException/printAmazonClientException appear copy & paste of AWS examples
[
https://issues.apache.org/jira/browse/HADOOP-13154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15285746#comment-15285746
]
Vinod Kumar Vavilapalli commented on HADOOP-13154:
--
[~steve_l], looks like they've been around for a while. git blame on both these
methods point to the following commit, back to you
{code}
commit 27c4e90efce04e1b1302f668b5eb22412e00d033
Author: Steve Loughran
Date: Thu May 12 19:24:20 2016 +0100
HADOOP-13028 add low level counter metrics for S3A; use in read performance
tests. contributed by: stevel
patch includes
HADOOP-12844 Recover when S3A fails on IOException in read()
HADOOP-13058 S3A FS fails during init against a read-only FS if multipart
purge
HADOOP-13047 S3a Forward seek in stream length to be configurable
{code}
> S3AFileSystem printAmazonServiceException/printAmazonClientException appear
> copy & paste of AWS examples
>
>
> Key: HADOOP-13154
> URL: https://issues.apache.org/jira/browse/HADOOP-13154
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
>Affects Versions: 2.7.2
>Reporter: Steve Loughran
>Priority: Blocker
>
> The logging code in {{S3AFileSystem.printAmazonServiceException()}} and
> {{printAmazonClientException}} appear to be paste + edits of the example code
> in the amazon SDK, such as
> [http://docs.aws.amazon.com/AmazonS3/latest/dev/ListingObjectKeysUsingJava.html]]
> Either we review the license to validate it, and add credits to the code if
> compatible, or we rework. HADOOP-13130 would be the place to do that, as it
> is changing exception handling anyway.
> tagging as blocker as it is license related
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
