[jira] [Commented] (HADOOP-13201) Print the directory paths when ViewFs denies the rename operation on internal dirs

2016-10-27 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612105#comment-15612105
 ] 

Hudson commented on HADOOP-13201:
-

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10706 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/10706/])
HADOOP-13201. Print the directory paths when ViewFs denies the rename (brahma: 
rev 0c837db8a874079dd5db83a7eef9c4d2b9d0e9ff)
* (edit) 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java


> Print the directory paths when ViewFs denies the rename operation on internal 
> dirs
> --
>
> Key: HADOOP-13201
> URL: https://issues.apache.org/jira/browse/HADOOP-13201
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: viewfs
>Affects Versions: 2.7.2
>Reporter: Tianyin Xu
>Assignee: Rakesh R
> Fix For: 2.8.0, 2.7.4, 3.0.0-alpha2
>
> Attachments: HADOOP-13201-001.patch, HADOOP-13201.000.patch
>
>
> With ViewFs, the delete and rename operations on internal dirs are denied by 
> throwing {{AccessControlException}}. 
> Unlike the {{delete()}} which notify the internal dir path, rename does not. 
> The attached patch appends the directory path on the logged exception.
> {code:title=ViewFs.java|borderStyle=solid}
>  InodeTree.ResolveResult resSrc = 
>fsState.resolve(getUriPath(src), false); 
>  if (resSrc.isInternalDir()) {
>throw new AccessControlException(
> -  "Cannot Rename within internal dirs of mount table: it is 
> readOnly");
> +  "Cannot Rename within internal dirs of mount table: it is readOnly"
> +  + src);
>  }
>
>  InodeTree.ResolveResult resDst = 
>  fsState.resolve(getUriPath(dst), false);
>  if (resDst.isInternalDir()) {
>throw new AccessControlException(
> -  "Cannot Rename within internal dirs of mount table: it is 
> readOnly");
> +  "Cannot Rename within internal dirs of mount table: it is readOnly"
> +  + dst);
>  }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-13201) Print the directory paths when ViewFs denies the rename operation on internal dirs

2016-10-27 Thread Rakesh R (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15611805#comment-15611805
 ] 

Rakesh R commented on HADOOP-13201:
---

Thank you [~brahmareddy]

> Print the directory paths when ViewFs denies the rename operation on internal 
> dirs
> --
>
> Key: HADOOP-13201
> URL: https://issues.apache.org/jira/browse/HADOOP-13201
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: viewfs
>Affects Versions: 2.7.2
>Reporter: Tianyin Xu
>Assignee: Rakesh R
> Attachments: HADOOP-13201-001.patch, HADOOP-13201.000.patch
>
>
> With ViewFs, the delete and rename operations on internal dirs are denied by 
> throwing {{AccessControlException}}. 
> Unlike the {{delete()}} which notify the internal dir path, rename does not. 
> The attached patch appends the directory path on the logged exception.
> {code:title=ViewFs.java|borderStyle=solid}
>  InodeTree.ResolveResult resSrc = 
>fsState.resolve(getUriPath(src), false); 
>  if (resSrc.isInternalDir()) {
>throw new AccessControlException(
> -  "Cannot Rename within internal dirs of mount table: it is 
> readOnly");
> +  "Cannot Rename within internal dirs of mount table: it is readOnly"
> +  + src);
>  }
>
>  InodeTree.ResolveResult resDst = 
>  fsState.resolve(getUriPath(dst), false);
>  if (resDst.isInternalDir()) {
>throw new AccessControlException(
> -  "Cannot Rename within internal dirs of mount table: it is 
> readOnly");
> +  "Cannot Rename within internal dirs of mount table: it is readOnly"
> +  + dst);
>  }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-13201) Print the directory paths when ViewFs denies the rename operation on internal dirs

2016-10-27 Thread Brahma Reddy Battula (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15611777#comment-15611777
 ] 

Brahma Reddy Battula commented on HADOOP-13201:
---

[~rakeshr] thanks for rebasing the patch.. +1, will commit soon.

> Print the directory paths when ViewFs denies the rename operation on internal 
> dirs
> --
>
> Key: HADOOP-13201
> URL: https://issues.apache.org/jira/browse/HADOOP-13201
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: viewfs
>Affects Versions: 2.7.2
>Reporter: Tianyin Xu
>Assignee: Rakesh R
> Attachments: HADOOP-13201-001.patch, HADOOP-13201.000.patch
>
>
> With ViewFs, the delete and rename operations on internal dirs are denied by 
> throwing {{AccessControlException}}. 
> Unlike the {{delete()}} which notify the internal dir path, rename does not. 
> The attached patch appends the directory path on the logged exception.
> {code:title=ViewFs.java|borderStyle=solid}
>  InodeTree.ResolveResult resSrc = 
>fsState.resolve(getUriPath(src), false); 
>  if (resSrc.isInternalDir()) {
>throw new AccessControlException(
> -  "Cannot Rename within internal dirs of mount table: it is 
> readOnly");
> +  "Cannot Rename within internal dirs of mount table: it is readOnly"
> +  + src);
>  }
>
>  InodeTree.ResolveResult resDst = 
>  fsState.resolve(getUriPath(dst), false);
>  if (resDst.isInternalDir()) {
>throw new AccessControlException(
> -  "Cannot Rename within internal dirs of mount table: it is 
> readOnly");
> +  "Cannot Rename within internal dirs of mount table: it is readOnly"
> +  + dst);
>  }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-13201) Print the directory paths when ViewFs denies the rename operation on internal dirs

2016-10-27 Thread Rakesh R (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15611568#comment-15611568
 ] 

Rakesh R commented on HADOOP-13201:
---

cc/[~vinayrpet]

> Print the directory paths when ViewFs denies the rename operation on internal 
> dirs
> --
>
> Key: HADOOP-13201
> URL: https://issues.apache.org/jira/browse/HADOOP-13201
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: viewfs
>Affects Versions: 2.7.2
>Reporter: Tianyin Xu
>Assignee: Rakesh R
> Attachments: HADOOP-13201-001.patch, HADOOP-13201.000.patch
>
>
> With ViewFs, the delete and rename operations on internal dirs are denied by 
> throwing {{AccessControlException}}. 
> Unlike the {{delete()}} which notify the internal dir path, rename does not. 
> The attached patch appends the directory path on the logged exception.
> {code:title=ViewFs.java|borderStyle=solid}
>  InodeTree.ResolveResult resSrc = 
>fsState.resolve(getUriPath(src), false); 
>  if (resSrc.isInternalDir()) {
>throw new AccessControlException(
> -  "Cannot Rename within internal dirs of mount table: it is 
> readOnly");
> +  "Cannot Rename within internal dirs of mount table: it is readOnly"
> +  + src);
>  }
>
>  InodeTree.ResolveResult resDst = 
>  fsState.resolve(getUriPath(dst), false);
>  if (resDst.isInternalDir()) {
>throw new AccessControlException(
> -  "Cannot Rename within internal dirs of mount table: it is 
> readOnly");
> +  "Cannot Rename within internal dirs of mount table: it is readOnly"
> +  + dst);
>  }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-13201) Print the directory paths when ViewFs denies the rename operation on internal dirs

2016-10-27 Thread Rakesh R (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15611496#comment-15611496
 ] 

Rakesh R commented on HADOOP-13201:
---

Kindly review the patch. Thanks!

> Print the directory paths when ViewFs denies the rename operation on internal 
> dirs
> --
>
> Key: HADOOP-13201
> URL: https://issues.apache.org/jira/browse/HADOOP-13201
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: viewfs
>Affects Versions: 2.7.2
>Reporter: Tianyin Xu
>Assignee: Rakesh R
> Attachments: HADOOP-13201-001.patch, HADOOP-13201.000.patch
>
>
> With ViewFs, the delete and rename operations on internal dirs are denied by 
> throwing {{AccessControlException}}. 
> Unlike the {{delete()}} which notify the internal dir path, rename does not. 
> The attached patch appends the directory path on the logged exception.
> {code:title=ViewFs.java|borderStyle=solid}
>  InodeTree.ResolveResult resSrc = 
>fsState.resolve(getUriPath(src), false); 
>  if (resSrc.isInternalDir()) {
>throw new AccessControlException(
> -  "Cannot Rename within internal dirs of mount table: it is 
> readOnly");
> +  "Cannot Rename within internal dirs of mount table: it is readOnly"
> +  + src);
>  }
>
>  InodeTree.ResolveResult resDst = 
>  fsState.resolve(getUriPath(dst), false);
>  if (resDst.isInternalDir()) {
>throw new AccessControlException(
> -  "Cannot Rename within internal dirs of mount table: it is 
> readOnly");
> +  "Cannot Rename within internal dirs of mount table: it is readOnly"
> +  + dst);
>  }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-13201) Print the directory paths when ViewFs denies the rename operation on internal dirs

2016-10-27 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15611275#comment-15611275
 ] 

Hadoop QA commented on HADOOP-13201:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
16s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
41s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  6m 
59s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
24s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m  
0s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
28s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
41s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  6m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  6m 
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  8m 
48s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
21s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 39m 22s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:9560f25 |
| JIRA Issue | HADOOP-13201 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12835517/HADOOP-13201-001.patch
 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux 42664ce607db 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed 
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | trunk / 6cc7c43 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10907/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U: 
hadoop-common-project/hadoop-common |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/10907/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Print the directory paths when ViewFs denies the rename operation on internal 
> dirs
> --
>
> Key: HADOOP-13201
> URL: https://issues.apache.org/jira/browse/HADOOP-13201
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: viewfs
>Affects Versions: 2.7.2
>Reporter: Tianyin Xu
> Attachments: HADOOP-13201-001.patch,

[jira] [Commented] (HADOOP-13201) Print the directory paths when ViewFs denies the rename operation on internal dirs

2016-10-27 Thread Rakesh R (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15611154#comment-15611154
 ] 

Rakesh R commented on HADOOP-13201:
---

Thanks [~tianyin] for reporting this. I've modified the exception message and 
placed {{src}} and {{dest}} properly, please review this.

> Print the directory paths when ViewFs denies the rename operation on internal 
> dirs
> --
>
> Key: HADOOP-13201
> URL: https://issues.apache.org/jira/browse/HADOOP-13201
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: viewfs
>Affects Versions: 2.7.2
>Reporter: Tianyin Xu
> Attachments: HADOOP-13201-001.patch, HADOOP-13201.000.patch
>
>
> With ViewFs, the delete and rename operations on internal dirs are denied by 
> throwing {{AccessControlException}}. 
> Unlike the {{delete()}} which notify the internal dir path, rename does not. 
> The attached patch appends the directory path on the logged exception.
> {code:title=ViewFs.java|borderStyle=solid}
>  InodeTree.ResolveResult resSrc = 
>fsState.resolve(getUriPath(src), false); 
>  if (resSrc.isInternalDir()) {
>throw new AccessControlException(
> -  "Cannot Rename within internal dirs of mount table: it is 
> readOnly");
> +  "Cannot Rename within internal dirs of mount table: it is readOnly"
> +  + src);
>  }
>
>  InodeTree.ResolveResult resDst = 
>  fsState.resolve(getUriPath(dst), false);
>  if (resDst.isInternalDir()) {
>throw new AccessControlException(
> -  "Cannot Rename within internal dirs of mount table: it is 
> readOnly");
> +  "Cannot Rename within internal dirs of mount table: it is readOnly"
> +  + dst);
>  }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-13201) Print the directory paths when ViewFs denies the rename operation on internal dirs

2016-05-24 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-13201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299156#comment-15299156
 ] 

Hadoop QA commented on HADOOP-13201:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s 
{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 
30s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 29s 
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 
28s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 7s 
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
13s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 
29s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 1s 
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 
42s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 31s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 31s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 
22s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 56s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 
11s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 
32s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m 50s 
{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
20s {color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 39m 29s {color} 
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:2c91fd8 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12806009/HADOOP-13201.000.patch
 |
| JIRA Issue | HADOOP-13201 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux 8a6c6112300d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed 
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | trunk / edd716e |
| Default Java | 1.8.0_91 |
| findbugs | v3.0.0 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/9572/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U: 
hadoop-common-project/hadoop-common |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/9572/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Print the directory paths when ViewFs denies the rename operation on internal 
> dirs
> --
>
> Key: HADOOP-13201
> URL: https://issues.apache.org/jira/browse/HADOOP-13201
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: viewfs
>Affects Versions: 2.7.2
>Reporter: Tianyin Xu
> Attachments: HADOOP-13201.000.patch
>
>
>