[jira] [Commented] (HADOOP-13512) ReloadingX509TrustManager should keep reloading in case of exception
[
https://issues.apache.org/jira/browse/HADOOP-13512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427207#comment-15427207
]
Hudson commented on HADOOP-13512:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10302 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/10302/])
HADOOP-13512. ReloadingX509TrustManager should keep reloading in case of
(liuml07: rev 0f51eae0c085ded38216824377acf8122638c3a5)
* (edit)
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/ReloadingX509TrustManager.java
> ReloadingX509TrustManager should keep reloading in case of exception
>
>
> Key: HADOOP-13512
> URL: https://issues.apache.org/jira/browse/HADOOP-13512
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
>Reporter: Mingliang Liu
>Assignee: Mingliang Liu
>Priority: Critical
> Fix For: 2.7.4
>
> Attachments: HADOOP-13512.000.patch
>
>
> {{org.apache.hadoop.security.ssl.TestReloadingX509TrustManager}} checks the
> key store file's last modified time to decide whether to reload. This is to
> avoid unnecessary reload if the key store file is not changed. To do this, it
> maintains an internal state {{lastLoaded}} whenever it tries to reload a
> file. It also updates the {{lastLoaded}} variable in case of exception so
> failing reload will not be retried until the key store file's last modified
> time changes again.
> Chances are that the reload happens when the key store file is being written.
> The reload fails (probably with EOFException) and won't load until key store
> files's last modified time changes. After a short period, the key store file
> is closed after update. However, the last modified time may not be updated as
> if it's in the same precision period (e.g. 1 second). In this case, the
> updated key store file is never reloaded.
> A simple fix is to update the {{lastLoaded}} only when the reload succeeds.
> {{ReloadingX509TrustManager}} will keep reloading in case of exception.
> Thoughts?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13512) ReloadingX509TrustManager should keep reloading in case of exception
[
https://issues.apache.org/jira/browse/HADOOP-13512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427090#comment-15427090
]
Jitendra Nath Pandey commented on HADOOP-13512:
---
Its a good catch.
+1
> ReloadingX509TrustManager should keep reloading in case of exception
>
>
> Key: HADOOP-13512
> URL: https://issues.apache.org/jira/browse/HADOOP-13512
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
>Reporter: Mingliang Liu
>Assignee: Mingliang Liu
> Attachments: HADOOP-13512.000.patch
>
>
> {{org.apache.hadoop.security.ssl.TestReloadingX509TrustManager}} checks the
> key store file's last modified time to decide whether to reload. This is to
> avoid unnecessary reload if the key store file is not changed. To do this, it
> maintains an internal state {{lastLoaded}} whenever it tries to reload a
> file. It also updates the {{lastLoaded}} variable in case of exception so
> failing reload will not be retried until the key store file's last modified
> time changes again.
> Chances are that the reload happens when the key store file is being written.
> The reload fails (probably with EOFException) and won't load until key store
> files's last modified time changes. After a short period, the key store file
> is closed after update. However, the last modified time may not be updated as
> if it's in the same precision period (e.g. 1 second). In this case, the
> updated key store file is never reloaded.
> A simple fix is to update the {{lastLoaded}} only when the reload succeeds.
> {{ReloadingX509TrustManager}} will keep reloading in case of exception.
> Thoughts?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13512) ReloadingX509TrustManager should keep reloading in case of exception
[
https://issues.apache.org/jira/browse/HADOOP-13512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426051#comment-15426051
]
Hadoop QA commented on HADOOP-13512:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
55s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
53s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
53s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
12s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
21s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m
48s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 38m 20s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12824295/HADOOP-13512.000.patch
|
| JIRA Issue | HADOOP-13512 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 1e17ccb62fd5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 913a895 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/10294/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/10294/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> ReloadingX509TrustManager should keep reloading in case of exception
>
>
> Key: HADOOP-13512
> URL: https://issues.apache.org/jira/browse/HADOOP-13512
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
>Reporter: Mingliang Liu
>Assignee: Mingliang Liu
> Attachments: HADOOP-13512.000.patch
>
>
>
[jira] [Commented] (HADOOP-13512) ReloadingX509TrustManager should keep reloading in case of exception
[
https://issues.apache.org/jira/browse/HADOOP-13512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426001#comment-15426001
]
Mingliang Liu commented on HADOOP-13512:
https://builds.apache.org/job/PreCommit-HADOOP-Build/10251/testReport/org.apache.hadoop.security.ssl/TestReloadingX509TrustManager/testReload/
is a potential UT failure because of this.
> ReloadingX509TrustManager should keep reloading in case of exception
>
>
> Key: HADOOP-13512
> URL: https://issues.apache.org/jira/browse/HADOOP-13512
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
>Affects Versions: 2.8.0
>Reporter: Mingliang Liu
>Assignee: Mingliang Liu
>
> {{org.apache.hadoop.security.ssl.TestReloadingX509TrustManager}} checks the
> key store file's last modified time to decide whether to reload. This is to
> avoid unnecessary reload if the key store file is not changed. To do this, it
> maintains an internal state {{lastLoaded}} whenever it tries to reload a
> file. It also updates the {{lastLoaded}} variable in case of exception so
> failing reload will not be retried until the key store file's last modified
> time changes again.
> Chances are that the reload happens when the key store file is being written.
> The reload fails (probably with EOFException) and won't load until key store
> files's last modified time changes. After a short period, the key store file
> is closed after update. However, the last modified time may not be updated as
> if it's in the same precision period (e.g. 1 second). In this case, the
> updated key store file is never reloaded.
> A simple fix is to update the {{lastLoaded}} only when the reload succeeds.
> {{ReloadingX509TrustManager}} will keep reloading in case of exception.
> Thoughts?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
