[jira] [Commented] (HADOOP-13688) Stop bundling HTML source code in javadoc JARs
[
https://issues.apache.org/jira/browse/HADOOP-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959673#comment-15959673
]
Junping Du commented on HADOOP-13688:
-
I have merged the patch to branch-2 and branch-2.8.
> Stop bundling HTML source code in javadoc JARs
> --
>
> Key: HADOOP-13688
> URL: https://issues.apache.org/jira/browse/HADOOP-13688
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
>Affects Versions: 2.6.4
>Reporter: Andrew Wang
>Assignee: Andrew Wang
> Fix For: 3.0.0-alpha2, 2.8.1
>
> Attachments: HADOOP-13688.001.patch
>
>
> We generate source code with line numbers for inclusion in the javadoc JARs.
> Given that there's github and other online viewers, this doesn't seem so
> useful these days.
> Disabling the "linkSource" option saves us 40MB for the hadoop-common javadoc
> jar:
> {noformat}
> -rw-r--r-- 1 andrew andrew 98M Oct 5 14:44
> hadoop-common-3.0.0-alpha2-SNAPSHOT-javadoc.jar
> -rw-r--r-- 1 andrew andrew 58M Oct 5 15:00
> ./hadoop-common-project/hadoop-common/target/hadoop-common-3.0.0-alpha2-SNAPSHOT-javadoc.jar
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13688) Stop bundling HTML source code in javadoc JARs
[
https://issues.apache.org/jira/browse/HADOOP-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957960#comment-15957960
]
Junping Du commented on HADOOP-13688:
-
I think there are related because our tar ball include these javadoc jars (with
new create release script), so remove the link source will significantly reduce
the tar ball in branch-2 releases. I verified that the size of tar ball is
reduced from 410 M to 242M for the same branch-2.8.
I plan to merge the patch to branch-2/branch-2.8 if no one objects.
> Stop bundling HTML source code in javadoc JARs
> --
>
> Key: HADOOP-13688
> URL: https://issues.apache.org/jira/browse/HADOOP-13688
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
>Affects Versions: 2.6.4
>Reporter: Andrew Wang
>Assignee: Andrew Wang
> Fix For: 3.0.0-alpha2
>
> Attachments: HADOOP-13688.001.patch
>
>
> We generate source code with line numbers for inclusion in the javadoc JARs.
> Given that there's github and other online viewers, this doesn't seem so
> useful these days.
> Disabling the "linkSource" option saves us 40MB for the hadoop-common javadoc
> jar:
> {noformat}
> -rw-r--r-- 1 andrew andrew 98M Oct 5 14:44
> hadoop-common-3.0.0-alpha2-SNAPSHOT-javadoc.jar
> -rw-r--r-- 1 andrew andrew 58M Oct 5 15:00
> ./hadoop-common-project/hadoop-common/target/hadoop-common-3.0.0-alpha2-SNAPSHOT-javadoc.jar
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13688) Stop bundling HTML source code in javadoc JARs
[
https://issues.apache.org/jira/browse/HADOOP-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940879#comment-15940879
]
Andrew Wang commented on HADOOP-13688:
--
I think the 2.8.0 release vote issue might be a bit different, since this
removes the content from the javadoc jars, and the 2.8.0 tarball had these in
expanded form. Also, 2.7.2 seemed to be okay and didn't have this change, so
it's unclear why 2.8.0 blew up.
> Stop bundling HTML source code in javadoc JARs
> --
>
> Key: HADOOP-13688
> URL: https://issues.apache.org/jira/browse/HADOOP-13688
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
>Affects Versions: 2.6.4
>Reporter: Andrew Wang
>Assignee: Andrew Wang
> Fix For: 3.0.0-alpha2
>
> Attachments: HADOOP-13688.001.patch
>
>
> We generate source code with line numbers for inclusion in the javadoc JARs.
> Given that there's github and other online viewers, this doesn't seem so
> useful these days.
> Disabling the "linkSource" option saves us 40MB for the hadoop-common javadoc
> jar:
> {noformat}
> -rw-r--r-- 1 andrew andrew 98M Oct 5 14:44
> hadoop-common-3.0.0-alpha2-SNAPSHOT-javadoc.jar
> -rw-r--r-- 1 andrew andrew 58M Oct 5 15:00
> ./hadoop-common-project/hadoop-common/target/hadoop-common-3.0.0-alpha2-SNAPSHOT-javadoc.jar
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13688) Stop bundling HTML source code in javadoc JARs
[
https://issues.apache.org/jira/browse/HADOOP-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940109#comment-15940109
]
Elek, Marton commented on HADOOP-13688:
---
Same problem has been questioned during the 2.8.0 release vote.
I suggest to cherry-pick the patch to the branch-2/branch-2.8/branch-2.7.
Hopefully we will get releases from those lines. I wouldn't call it
incompatible change.
> Stop bundling HTML source code in javadoc JARs
> --
>
> Key: HADOOP-13688
> URL: https://issues.apache.org/jira/browse/HADOOP-13688
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
>Affects Versions: 2.6.4
>Reporter: Andrew Wang
>Assignee: Andrew Wang
> Fix For: 3.0.0-alpha2
>
> Attachments: HADOOP-13688.001.patch
>
>
> We generate source code with line numbers for inclusion in the javadoc JARs.
> Given that there's github and other online viewers, this doesn't seem so
> useful these days.
> Disabling the "linkSource" option saves us 40MB for the hadoop-common javadoc
> jar:
> {noformat}
> -rw-r--r-- 1 andrew andrew 98M Oct 5 14:44
> hadoop-common-3.0.0-alpha2-SNAPSHOT-javadoc.jar
> -rw-r--r-- 1 andrew andrew 58M Oct 5 15:00
> ./hadoop-common-project/hadoop-common/target/hadoop-common-3.0.0-alpha2-SNAPSHOT-javadoc.jar
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13688) Stop bundling HTML source code in javadoc JARs
[
https://issues.apache.org/jira/browse/HADOOP-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552779#comment-15552779
]
Hudson commented on HADOOP-13688:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10559 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/10559/])
HADOOP-13688. Stop bundling HTML source code in javadoc JARs. (wang: rev
72a2ae6452e615c66d10829da38737896814e02b)
* (edit) hadoop-project-dist/pom.xml
* (edit) pom.xml
* (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml
> Stop bundling HTML source code in javadoc JARs
> --
>
> Key: HADOOP-13688
> URL: https://issues.apache.org/jira/browse/HADOOP-13688
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
>Affects Versions: 2.6.4
>Reporter: Andrew Wang
>Assignee: Andrew Wang
> Fix For: 3.0.0-alpha2
>
> Attachments: HADOOP-13688.001.patch
>
>
> We generate source code with line numbers for inclusion in the javadoc JARs.
> Given that there's github and other online viewers, this doesn't seem so
> useful these days.
> Disabling the "linkSource" option saves us 40MB for the hadoop-common javadoc
> jar:
> {noformat}
> -rw-r--r-- 1 andrew andrew 98M Oct 5 14:44
> hadoop-common-3.0.0-alpha2-SNAPSHOT-javadoc.jar
> -rw-r--r-- 1 andrew andrew 58M Oct 5 15:00
> ./hadoop-common-project/hadoop-common/target/hadoop-common-3.0.0-alpha2-SNAPSHOT-javadoc.jar
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13688) Stop bundling HTML source code in javadoc JARs
[
https://issues.apache.org/jira/browse/HADOOP-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551795#comment-15551795
]
Akira Ajisaka commented on HADOOP-13688:
+1
> Stop bundling HTML source code in javadoc JARs
> --
>
> Key: HADOOP-13688
> URL: https://issues.apache.org/jira/browse/HADOOP-13688
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
>Affects Versions: 2.6.4
>Reporter: Andrew Wang
>Assignee: Andrew Wang
> Attachments: HADOOP-13688.001.patch
>
>
> We generate source code with line numbers for inclusion in the javadoc JARs.
> Given that there's github and other online viewers, this doesn't seem so
> useful these days.
> Disabling the "linkSource" option saves us 40MB for the hadoop-common javadoc
> jar:
> {noformat}
> -rw-r--r-- 1 andrew andrew 98M Oct 5 14:44
> hadoop-common-3.0.0-alpha2-SNAPSHOT-javadoc.jar
> -rw-r--r-- 1 andrew andrew 58M Oct 5 15:00
> ./hadoop-common-project/hadoop-common/target/hadoop-common-3.0.0-alpha2-SNAPSHOT-javadoc.jar
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13688) Stop bundling HTML source code in javadoc JARs
[
https://issues.apache.org/jira/browse/HADOOP-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551658#comment-15551658
]
Steve Loughran commented on HADOOP-13688:
-
+1
> Stop bundling HTML source code in javadoc JARs
> --
>
> Key: HADOOP-13688
> URL: https://issues.apache.org/jira/browse/HADOOP-13688
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
>Affects Versions: 2.6.4
>Reporter: Andrew Wang
>Assignee: Andrew Wang
> Attachments: HADOOP-13688.001.patch
>
>
> We generate source code with line numbers for inclusion in the javadoc JARs.
> Given that there's github and other online viewers, this doesn't seem so
> useful these days.
> Disabling the "linkSource" option saves us 40MB for the hadoop-common javadoc
> jar:
> {noformat}
> -rw-r--r-- 1 andrew andrew 98M Oct 5 14:44
> hadoop-common-3.0.0-alpha2-SNAPSHOT-javadoc.jar
> -rw-r--r-- 1 andrew andrew 58M Oct 5 15:00
> ./hadoop-common-project/hadoop-common/target/hadoop-common-3.0.0-alpha2-SNAPSHOT-javadoc.jar
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13688) Stop bundling HTML source code in javadoc JARs
[
https://issues.apache.org/jira/browse/HADOOP-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15550870#comment-15550870
]
Andrew Wang commented on HADOOP-13688:
--
test-patch issues look unrelated.
> Stop bundling HTML source code in javadoc JARs
> --
>
> Key: HADOOP-13688
> URL: https://issues.apache.org/jira/browse/HADOOP-13688
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
>Affects Versions: 2.6.4
>Reporter: Andrew Wang
>Assignee: Andrew Wang
> Attachments: HADOOP-13688.001.patch
>
>
> We generate source code with line numbers for inclusion in the javadoc JARs.
> Given that there's github and other online viewers, this doesn't seem so
> useful these days.
> Disabling the "linkSource" option saves us 40MB for the hadoop-common javadoc
> jar:
> {noformat}
> -rw-r--r-- 1 andrew andrew 98M Oct 5 14:44
> hadoop-common-3.0.0-alpha2-SNAPSHOT-javadoc.jar
> -rw-r--r-- 1 andrew andrew 58M Oct 5 15:00
> ./hadoop-common-project/hadoop-common/target/hadoop-common-3.0.0-alpha2-SNAPSHOT-javadoc.jar
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13688) Stop bundling HTML source code in javadoc JARs
[
https://issues.apache.org/jira/browse/HADOOP-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15550272#comment-15550272
]
Hadoop QA commented on HADOOP-13688:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
1s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
54s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 9m
18s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
59s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
37s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 10m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
4s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m
0s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 3m 47s{color}
| {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
22s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 66m 5s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.security.authentication.util.TestZKSignerSecretProvider |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Issue | HADOOP-13688 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12831823/HADOOP-13688.001.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit xml |
| uname | Linux 4b43ffcdda22 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18
21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / e68c7b9 |
| Default Java | 1.8.0_101 |
| unit |
https://builds.apache.org/job/PreCommit-HADOOP-Build/10681/artifact/patchprocess/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/10681/testReport/ |
| asflicense |
https://builds.apache.org/job/PreCommit-HADOOP-Build/10681/artifact/patchprocess/patch-asflicense-problems.txt
|
| modules | C: hadoop-project-dist hadoop-hdfs-project/hadoop-hdfs-httpfs . U:
. |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/10681/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Stop bundling HTML source code in javadoc JARs
> --
>
> Key: HADOOP-13688
> URL: https://issues.apache.org/jira/browse/HADOOP-13688
> Project: Hadoop Common
> Issue Type: Improvement
> Components:
[jira] [Commented] (HADOOP-13688) Stop bundling HTML source code in javadoc JARs
[
https://issues.apache.org/jira/browse/HADOOP-13688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15550134#comment-15550134
]
Andrew Wang commented on HADOOP-13688:
--
The other issue I noticed is that there seems to be tons of extra content in
the javadoc jars, like other jars and classfiles. It looks like it's sucking
down the entire target directory:
After unzipping the hadoop-common javadoc jar:
{noformat}
-> % ls
allclasses-frame.htmlfindbugsXml.xml
hadoop-maven-plugins-protoc-checksums.json META-INF src-html
allclasses-noframe.html generated-sources
help-doc.html org
stylesheet.css
antrun generated-test-sources
index-all.html overview-frame.htmltest
archive-tmp hadoop-annotations.jar
index.html overview-summary.html test-classes
classes hadoop-common-3.0.0-alpha2-SNAPSHOT
javadoc-bundle-options overview-tree.html test-dir
constant-values.html hadoop-common-3.0.0-alpha2-SNAPSHOT.jar
jdiff.jar package-list xerces.jar
deprecated-list.html hadoop-common-3.0.0-alpha2-SNAPSHOT-sources.jar
log script.js
docs-src hadoop-common-3.0.0-alpha2-SNAPSHOT-tests.jar
maven-archiver serialized-form.html
findbugsExcludeFile.xml hadoop-common-3.0.0-alpha2-SNAPSHOT-test-sources.jar
maven-shared-archive-resources site
andrew@zanarkand [03:21:07 PM] [/tmp/javadoc]
-> % find . -name "*.class" | wc -l
3455
andrew@zanarkand [03:21:11 PM] [/tmp/javadoc]
-> % find . -name "*.jar" | wc -l
85
-> % find . -name "*.jar" -exec wc -c {} \; | awk -e '{SUM+=$1} END {print
SUM}'
41692556
{noformat}
Since the jarfiles by themselves are another 41MB, there's the potential to
really streamline the javadoc jars.
> Stop bundling HTML source code in javadoc JARs
> --
>
> Key: HADOOP-13688
> URL: https://issues.apache.org/jira/browse/HADOOP-13688
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
>Affects Versions: 2.6.4
>Reporter: Andrew Wang
>Assignee: Andrew Wang
> Attachments: HADOOP-13688.001.patch
>
>
> We generate source code with line numbers for inclusion in the javadoc JARs.
> Given that there's github and other online viewers, this doesn't seem so
> useful these days.
> Disabling the "linkSource" option saves us 40MB for the hadoop-common javadoc
> jar:
> {noformat}
> -rw-r--r-- 1 andrew andrew 98M Oct 5 14:44
> hadoop-common-3.0.0-alpha2-SNAPSHOT-javadoc.jar
> -rw-r--r-- 1 andrew andrew 58M Oct 5 15:00
> ./hadoop-common-project/hadoop-common/target/hadoop-common-3.0.0-alpha2-SNAPSHOT-javadoc.jar
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
