[jira] [Commented] (HADOOP-13860) ZKFailoverController.ElectorCallbacks should have a non-trivial implementation for enterNeutralMode
[ https://issues.apache.org/jira/browse/HADOOP-13860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730408#comment-15730408 ] Karthik Kambatla commented on HADOOP-13860: --- IMO, we should implement it similar to YARN-5677. That said, I would defer the judgment to HDFS devs. [~atm] - do you have an opinion here? > ZKFailoverController.ElectorCallbacks should have a non-trivial > implementation for enterNeutralMode > --- > > Key: HADOOP-13860 > URL: https://issues.apache.org/jira/browse/HADOOP-13860 > Project: Hadoop Common > Issue Type: Bug >Reporter: Karthik Kambatla > > ZKFailoverController.ElectorCallbacks implements enterNeutralMode trivially. > This can lead to a master staying active for longer than necessary, unless > the fencing scheme ensures the first active is transitioned to standby before > transitioning another master to active (e.g. ssh fencing). > YARN-5677 does this for YARN in EmbeddedElectorService. If we choose not to > implement, we should at least document this so any user of > ZKFailoverController in the future is aware. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13860) ZKFailoverController.ElectorCallbacks should have a non-trivial implementation for enterNeutralMode
[ https://issues.apache.org/jira/browse/HADOOP-13860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726511#comment-15726511 ] Andres Perez commented on HADOOP-13860: --- Hi [~kasha], I would like to take care of this issue if possible. Are we more inclined to leave it as it is and document it or create the implementation? In case of the latter, should we follow a similar approach as YARN-5677 did? > ZKFailoverController.ElectorCallbacks should have a non-trivial > implementation for enterNeutralMode > --- > > Key: HADOOP-13860 > URL: https://issues.apache.org/jira/browse/HADOOP-13860 > Project: Hadoop Common > Issue Type: Bug >Reporter: Karthik Kambatla > > ZKFailoverController.ElectorCallbacks implements enterNeutralMode trivially. > This can lead to a master staying active for longer than necessary, unless > the fencing scheme ensures the first active is transitioned to standby before > transitioning another master to active (e.g. ssh fencing). > YARN-5677 does this for YARN in EmbeddedElectorService. If we choose not to > implement, we should at least document this so any user of > ZKFailoverController in the future is aware. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
