[jira] [Commented] (HADOOP-14339) Fix warnings from Spotbugs in hadoop-mapreduce
[ https://issues.apache.org/jira/browse/HADOOP-14339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980733#comment-15980733 ] Weiwei Yang commented on HADOOP-14339: -- Thanks [~ajisakaa], that's a good catch, I think we should init localizedFiles with an empty HashSet to avoid null checks. I just fixed this in v4 patch, it also replaced add(..) by Collections.addAll(...). Thanks a lot. > Fix warnings from Spotbugs in hadoop-mapreduce > -- > > Key: HADOOP-14339 > URL: https://issues.apache.org/jira/browse/HADOOP-14339 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Weiwei Yang >Assignee: Weiwei Yang > Attachments: HADOOP-14339.001.patch, HADOOP-14339.002.patch, > HADOOP-14339.003.patch, HADOOP-14339.004.patch > > > Fix warnings from Spotbugs in hadoop-mapreduce since switched from findbugs > to spotbugs. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14339) Fix warnings from Spotbugs in hadoop-mapreduce
[ https://issues.apache.org/jira/browse/HADOOP-14339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980695#comment-15980695 ] Akira Ajisaka commented on HADOOP-14339: Thank [~cheersyang] for providing the patches. {code} if (curLocalFiles != null) { HashSet lf = new HashSet(curLocalFiles.length); for (int j = 0; j < curLocalFiles.length; ++j) { lf.add(curLocalFiles[j]); } localizedFiles = Collections.unmodifiableSet(lf); } {code} If curLocalFiles is null, localizedFiles is not initialized, and then, {{relocalize()}} method calls {{!localizedFiles.contains(curLocalFiles\[j\])}} and it causes NPE. What do you think? {code} for (int j = 0; j < curLocalFiles.length; ++j) { lf.add(curLocalFiles[j]); } {code} {{Collections.addAll(lf, curLocalFiles)}} can be used instead. > Fix warnings from Spotbugs in hadoop-mapreduce > -- > > Key: HADOOP-14339 > URL: https://issues.apache.org/jira/browse/HADOOP-14339 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Weiwei Yang >Assignee: Weiwei Yang > Attachments: HADOOP-14339.001.patch, HADOOP-14339.002.patch, > HADOOP-14339.003.patch > > > Fix warnings from Spotbugs in hadoop-mapreduce since switched from findbugs > to spotbugs. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14339) Fix warnings from Spotbugs in hadoop-mapreduce
[ https://issues.apache.org/jira/browse/HADOOP-14339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980013#comment-15980013 ] Weiwei Yang commented on HADOOP-14339: -- Looks like all issues are fixed. > Fix warnings from Spotbugs in hadoop-mapreduce > -- > > Key: HADOOP-14339 > URL: https://issues.apache.org/jira/browse/HADOOP-14339 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Weiwei Yang >Assignee: Weiwei Yang > Attachments: HADOOP-14339.001.patch, HADOOP-14339.002.patch, > HADOOP-14339.003.patch > > > Fix warnings from Spotbugs in hadoop-mapreduce since switched from findbugs > to spotbugs. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14339) Fix warnings from Spotbugs in hadoop-mapreduce
[ https://issues.apache.org/jira/browse/HADOOP-14339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979868#comment-15979868 ] Hadoop QA commented on HADOOP-14339: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 25s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 52s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m 12s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 8s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 36s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 54s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 15s{color} | {color:green} trunk passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 54s{color} | {color:red} hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 3 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 36s{color} | {color:red} hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app in trunk has 3 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 29s{color} | {color:red} hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs in trunk has 1 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 30s{color} | {color:red} hadoop-mapreduce-project/hadoop-mapreduce-examples in trunk has 1 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 8s{color} | {color:green} trunk passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 30s{color} | {color:green} hadoop-mapreduce-project: The patch generated 0 new + 142 unchanged - 4 fixed = 142 total (was 146) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 2s{color} | {color:green} hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3) {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 50s{color} | {color:green} hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3) {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 42s{color} | {color:green} hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 41s{color} | {color:green} hadoop-mapreduce-project/hadoop-mapreduce-examples generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s{color} |
[jira] [Commented] (HADOOP-14339) Fix warnings from Spotbugs in hadoop-mapreduce
[ https://issues.apache.org/jira/browse/HADOOP-14339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979446#comment-15979446 ] Hadoop QA commented on HADOOP-14339: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m 16s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 11s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 37s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 58s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 21s{color} | {color:green} trunk passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 56s{color} | {color:red} hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 3 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 42s{color} | {color:red} hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app in trunk has 3 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 37s{color} | {color:red} hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs in trunk has 1 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 35s{color} | {color:red} hadoop-mapreduce-project/hadoop-mapreduce-examples in trunk has 1 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 19s{color} | {color:green} trunk passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 8s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 8s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 38s{color} | {color:orange} hadoop-mapreduce-project: The patch generated 2 new + 142 unchanged - 4 fixed = 144 total (was 146) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 44s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 53s{color} | {color:green} hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3) {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 42s{color} | {color:green} hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3) {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 36s{color} | {color:green} hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 35s{color} | {color:green} hadoop-mapreduce-project/hadoop-mapreduce-examples generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 0s{color} |
[jira] [Commented] (HADOOP-14339) Fix warnings from Spotbugs in hadoop-mapreduce
[ https://issues.apache.org/jira/browse/HADOOP-14339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979343#comment-15979343 ] Weiwei Yang commented on HADOOP-14339: -- Hi [~aw] Would you please take a look at this.. I am a bit confused by the jenkins result.. I thought I have fixed those warnings as I see following {noformat} hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) hadoop-mapreduce-project/hadoop-mapreduce-examples generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) {noformat} but it still complains at first few lines, looks like the old result. What does this mean? Thank you > Fix warnings from Spotbugs in hadoop-mapreduce > -- > > Key: HADOOP-14339 > URL: https://issues.apache.org/jira/browse/HADOOP-14339 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Weiwei Yang >Assignee: Weiwei Yang > Attachments: HADOOP-14339.001.patch, HADOOP-14339.002.patch > > > Fix warnings from Spotbugs in hadoop-mapreduce since switched from findbugs > to spotbugs. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14339) Fix warnings from Spotbugs in hadoop-mapreduce
[ https://issues.apache.org/jira/browse/HADOOP-14339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979256#comment-15979256 ] Hadoop QA commented on HADOOP-14339: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 21s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 44s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m 33s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 7s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 30s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 28s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 58s{color} | {color:green} trunk passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 49s{color} | {color:red} hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 3 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 35s{color} | {color:red} hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app in trunk has 3 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 29s{color} | {color:red} hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs in trunk has 1 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 26s{color} | {color:red} hadoop-mapreduce-project/hadoop-mapreduce-examples in trunk has 1 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 57s{color} | {color:green} trunk passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 7s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 15s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 36s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 28s{color} | {color:orange} hadoop-mapreduce-project: The patch generated 2 new + 142 unchanged - 4 fixed = 144 total (was 146) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 51s{color} | {color:green} hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3) {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 41s{color} | {color:green} hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3) {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 33s{color} | {color:green} hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 34s{color} | {color:green} hadoop-mapreduce-project/hadoop-mapreduce-examples generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s{color} |
[jira] [Commented] (HADOOP-14339) Fix warnings from Spotbugs in hadoop-mapreduce
[ https://issues.apache.org/jira/browse/HADOOP-14339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979191#comment-15979191 ] Weiwei Yang commented on HADOOP-14339: -- Got 8 warnings by running {code} dev-support/bin/qbt --plugins=findbugs --console-report-file=/tmp/myrpt.txt --dirty-workspace {code} they are in following packages {noformat} hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in trunk has 3 extant Findbugs warnings. hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app in trunk has 3 extant Findbugs warnings. hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs in trunk has 1 extant Findbugs warnings. hadoop-mapreduce-project/hadoop-mapreduce-examples in trunk has 1 extant Findbugs warnings. {noformat} submit v1 patch to fix. > Fix warnings from Spotbugs in hadoop-mapreduce > -- > > Key: HADOOP-14339 > URL: https://issues.apache.org/jira/browse/HADOOP-14339 > Project: Hadoop Common > Issue Type: Sub-task >Reporter: Weiwei Yang >Assignee: Weiwei Yang > Attachments: HADOOP-14339.001.patch > > > Fix warnings from Spotbugs in hadoop-mapreduce since switched from findbugs > to spotbugs. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org