[jira] [Commented] (HADOOP-14481) Print stack trace when native bzip2 library does not load
[
https://issues.apache.org/jira/browse/HADOOP-14481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083267#comment-16083267
]
Wei-Chiu Chuang commented on HADOOP-14481:
--
Hi Steve, sounds like a good idea.
Will post a patch later to do that.
Thanks
> Print stack trace when native bzip2 library does not load
> -
>
> Key: HADOOP-14481
> URL: https://issues.apache.org/jira/browse/HADOOP-14481
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Minor
> Attachments: HADOOP-14481.001.patch
>
>
> When I ran hadoop checknative on my machine, it was not able to load system
> bzip2 library and printed the following message.
> 17/06/02 09:25:42 WARN bzip2.Bzip2Factory: Failed to load/initialize
> native-bzip2 library system-native, will use pure-Java version
> Reviewing the relevant code, it fails because of an exception. However, that
> exception is not logged. We should print the stacktrace, at least at debug
> log level.
> {code:title=Bzip2Factory#isNativeBzip2Loaded()}
> try {
> // Initialize the native library.
> Bzip2Compressor.initSymbols(libname);
> Bzip2Decompressor.initSymbols(libname);
> nativeBzip2Loaded = true;
> LOG.info("Successfully loaded & initialized native-bzip2 library " +
>libname);
> } catch (Throwable t) {
> LOG.warn("Failed to load/initialize native-bzip2 library " +
>libname + ", will use pure-Java version");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14481) Print stack trace when native bzip2 library does not load
[
https://issues.apache.org/jira/browse/HADOOP-14481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037076#comment-16037076
]
Steve Loughran commented on HADOOP-14481:
-
I'm not sure that warn is necessary, given that a lot of time it's OK to use
the native lib, and printing more stack traces only creates more panic and
confusion. That's especially true in client apps which don't have the native
libs on their path (i.e. third party code)
I'd propose
# log stack at debug
# warn message to include a cwiki link to a (new) page explaning the issue and
the consequence "things *may* be slower"
> Print stack trace when native bzip2 library does not load
> -
>
> Key: HADOOP-14481
> URL: https://issues.apache.org/jira/browse/HADOOP-14481
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Minor
> Attachments: HADOOP-14481.001.patch
>
>
> When I ran hadoop checknative on my machine, it was not able to load system
> bzip2 library and printed the following message.
> 17/06/02 09:25:42 WARN bzip2.Bzip2Factory: Failed to load/initialize
> native-bzip2 library system-native, will use pure-Java version
> Reviewing the relevant code, it fails because of an exception. However, that
> exception is not logged. We should print the stacktrace, at least at debug
> log level.
> {code:title=Bzip2Factory#isNativeBzip2Loaded()}
> try {
> // Initialize the native library.
> Bzip2Compressor.initSymbols(libname);
> Bzip2Decompressor.initSymbols(libname);
> nativeBzip2Loaded = true;
> LOG.info("Successfully loaded & initialized native-bzip2 library " +
>libname);
> } catch (Throwable t) {
> LOG.warn("Failed to load/initialize native-bzip2 library " +
>libname + ", will use pure-Java version");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14481) Print stack trace when native bzip2 library does not load
[
https://issues.apache.org/jira/browse/HADOOP-14481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035586#comment-16035586
]
Chen Liang commented on HADOOP-14481:
-
Thanks [~jojochuang] for the catch! v001 patch LGTM.
> Print stack trace when native bzip2 library does not load
> -
>
> Key: HADOOP-14481
> URL: https://issues.apache.org/jira/browse/HADOOP-14481
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Minor
> Attachments: HADOOP-14481.001.patch
>
>
> When I ran hadoop checknative on my machine, it was not able to load system
> bzip2 library and printed the following message.
> 17/06/02 09:25:42 WARN bzip2.Bzip2Factory: Failed to load/initialize
> native-bzip2 library system-native, will use pure-Java version
> Reviewing the relevant code, it fails because of an exception. However, that
> exception is not logged. We should print the stacktrace, at least at debug
> log level.
> {code:title=Bzip2Factory#isNativeBzip2Loaded()}
> try {
> // Initialize the native library.
> Bzip2Compressor.initSymbols(libname);
> Bzip2Decompressor.initSymbols(libname);
> nativeBzip2Loaded = true;
> LOG.info("Successfully loaded & initialized native-bzip2 library " +
>libname);
> } catch (Throwable t) {
> LOG.warn("Failed to load/initialize native-bzip2 library " +
>libname + ", will use pure-Java version");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14481) Print stack trace when native bzip2 library does not load
[
https://issues.apache.org/jira/browse/HADOOP-14481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035330#comment-16035330
]
Hadoop QA commented on HADOOP-14481:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 19m
35s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m
8s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 13m
8s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
33s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
1s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
25s{color} | {color:red} hadoop-common-project/hadoop-common in trunk has 19
extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 12m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 12m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m
27s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
29s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 76m 51s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HADOOP-14481 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12871017/HADOOP-14481.001.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 39cb0683d304 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 73ecb19 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC1 |
| findbugs |
https://builds.apache.org/job/PreCommit-HADOOP-Build/12435/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/12435/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/12435/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Print stack trace when native bzip2 library does not load
> -
>
> Key: HADOOP-14481
> URL: https://issues.apache.org/jira/browse/HADOOP-14481
> Project: Hadoop Common
>
