[jira] [Commented] (HADOOP-14543) ZKFC should use getAversion() while setting the zkacl

2017-06-23 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-14543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061674#comment-16061674
 ] 

Hudson commented on HADOOP-14543:
-

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11919 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/11919/])
HADOOP-14543. ZKFC should use getAversion() while setting the zkacl. (arp: rev 
0111711d8b2355a12a3e5f4da7f5a91e89355c1b)
* (edit) 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
* (edit) 
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestActiveStandbyElectorRealZK.java


> ZKFC should use getAversion() while setting the zkacl
> -
>
> Key: HADOOP-14543
> URL: https://issues.apache.org/jira/browse/HADOOP-14543
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Brahma Reddy Battula
>Assignee: Brahma Reddy Battula
> Fix For: 2.9.0, 3.0.0-alpha4
>
> Attachments: HADOOP-14543-002.patch, HADOOP-14543-003.patch, 
> HADOOP-14543.patch
>
>
> while setting the zkacl we used {{getVersion()}} which is dataVersion,Ideally 
> we should use {{getAversion()}}. If there is any acl changes( i.e relam 
> change/..) ,we set the ACL with dataversion which will cause BADVersion and 
> *process will not start*. See 
> [here|https://issues.apache.org/jira/browse/HDFS-11403?focusedCommentId=16051804=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16051804]
> {{zkClient.setACL(path, zkAcl, stat.getVersion());}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-14543) ZKFC should use getAversion() while setting the zkacl

2017-06-23 Thread Brahma Reddy Battula (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-14543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061666#comment-16061666
 ] 

Brahma Reddy Battula commented on HADOOP-14543:
---

[~arpitagarwal] thanks for review and commit.and thanks again to [~rakeshr] for 
review.

> ZKFC should use getAversion() while setting the zkacl
> -
>
> Key: HADOOP-14543
> URL: https://issues.apache.org/jira/browse/HADOOP-14543
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Brahma Reddy Battula
>Assignee: Brahma Reddy Battula
> Fix For: 2.9.0, 3.0.0-alpha4
>
> Attachments: HADOOP-14543-002.patch, HADOOP-14543-003.patch, 
> HADOOP-14543.patch
>
>
> while setting the zkacl we used {{getVersion()}} which is dataVersion,Ideally 
> we should use {{getAversion()}}. If there is any acl changes( i.e relam 
> change/..) ,we set the ACL with dataversion which will cause BADVersion and 
> *process will not start*. See 
> [here|https://issues.apache.org/jira/browse/HDFS-11403?focusedCommentId=16051804=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16051804]
> {{zkClient.setACL(path, zkAcl, stat.getVersion());}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-14543) ZKFC should use getAversion() while setting the zkacl

2017-06-23 Thread Arpit Agarwal (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-14543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061653#comment-16061653
 ] 

Arpit Agarwal commented on HADOOP-14543:


I've committed this.

> ZKFC should use getAversion() while setting the zkacl
> -
>
> Key: HADOOP-14543
> URL: https://issues.apache.org/jira/browse/HADOOP-14543
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Brahma Reddy Battula
>Assignee: Brahma Reddy Battula
> Fix For: 2.9.0, 3.0.0-alpha4
>
> Attachments: HADOOP-14543-002.patch, HADOOP-14543-003.patch, 
> HADOOP-14543.patch
>
>
> while setting the zkacl we used {{getVersion()}} which is dataVersion,Ideally 
> we should use {{getAversion()}}. If there is any acl changes( i.e relam 
> change/..) ,we set the ACL with dataversion which will cause BADVersion and 
> *process will not start*. See 
> [here|https://issues.apache.org/jira/browse/HDFS-11403?focusedCommentId=16051804=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16051804]
> {{zkClient.setACL(path, zkAcl, stat.getVersion());}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org